1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372
|
# -*- coding: utf-8 -*-
require 'rails/version'
def using_rails_api?
ENV["TEST_RAILS_API"] == true
end
def pool_db_config?
Gem::Version.new(ActiveRecord::VERSION::STRING) >= Gem::Version.new('6.1')
end
require "minitest/autorun"
require "mocha/minitest"
require 'logger'
require 'pp'
require 'active_record'
require 'action_controller'
require 'active_job'
require 'sidekiq'
require 'sidekiq/testing'
require 'action_dispatch/middleware/request_id'
if using_rails_api?
require 'rails-api/action_controller/api'
end
# Shim for compatibility with older versions of MiniTest
MiniTest::Test = MiniTest::Unit::TestCase unless defined?(MiniTest::Test)
# From version 4.1, ActiveRecord expects `Rails.env` to be
# defined if `Rails` is defined
if defined?(Rails) && !defined?(Rails.env)
module Rails
def self.env
end
end
end
require 'marginalia'
RAILS_ROOT = File.expand_path(File.dirname(__FILE__))
ActiveRecord::Base.establish_connection({
:adapter => ENV["DRIVER"] || "mysql",
:host => ENV["DB_HOST"] || "localhost",
:username => ENV["DB_USERNAME"] || "root",
:database => "marginalia_test"
})
class Post < ActiveRecord::Base
end
class PostsController < ActionController::Base
def driver_only
ActiveRecord::Base.connection.execute "select id from posts"
if Gem::Version.new(Rails::VERSION::STRING) >= Gem::Version.new('5')
render body: nil
else
render nothing: true
end
end
end
module API
module V1
class PostsController < ::PostsController
end
end
end
class PostsJob < ActiveJob::Base
def perform
Post.first
end
end
class PostsSidekiqJob
include Sidekiq::Worker
def perform
Post.first
end
end
if using_rails_api?
class PostsApiController < ActionController::API
def driver_only
ActiveRecord::Base.connection.execute "select id from posts"
head :no_content
end
end
end
unless Post.table_exists?
ActiveRecord::Schema.define do
create_table "posts", :force => true do |t|
end
end
end
Marginalia::Railtie.insert
class MarginaliaTest < MiniTest::Test
def setup
# Touch the model to avoid spurious schema queries
Post.first
@queries = []
ActiveSupport::Notifications.subscribe "sql.active_record" do |*args|
@queries << args.last[:sql]
end
@env = Rack::MockRequest.env_for('/')
ActiveJob::Base.queue_adapter = :inline
end
def test_double_annotate
ActiveRecord::Base.connection.expects(:annotate_sql).returns("select id from posts").once
ActiveRecord::Base.connection.send(:select, "select id from posts")
ensure
ActiveRecord::Base.connection.unstub(:annotate_sql)
end
def test_exists
Post.exists?
assert_match %r{/\*application:rails\*/$}, @queries.last
end
def test_query_commenting_on_mysql_driver_with_no_action
ActiveRecord::Base.connection.execute "select id from posts"
assert_match %r{select id from posts /\*application:rails\*/$}, @queries.first
end
if ENV["DRIVER"] =~ /^mysql/
def test_query_commenting_on_mysql_driver_with_binary_chars
ActiveRecord::Base.connection.execute "select id from posts /* \x81\x80\u0010\ */"
assert_equal "select id from posts /* \x81\x80\u0010 */ /*application:rails*/", @queries.first
end
end
if ENV["DRIVER"] =~ /^postgres/
def test_query_commenting_on_postgres_update
ActiveRecord::Base.connection.expects(:annotate_sql).returns("update posts set id = 1").once
ActiveRecord::Base.connection.send(:exec_update, "update posts set id = 1")
ensure
ActiveRecord::Base.connection.unstub(:annotate_sql)
end
def test_query_commenting_on_postgres_delete
ActiveRecord::Base.connection.expects(:annotate_sql).returns("delete from posts where id = 1").once
ActiveRecord::Base.connection.send(:exec_delete, "delete from posts where id = 1")
ensure
ActiveRecord::Base.connection.unstub(:annotate_sql)
end
end
def test_query_commenting_on_mysql_driver_with_action
PostsController.action(:driver_only).call(@env)
assert_match %r{select id from posts /\*application:rails,controller:posts,action:driver_only\*/$}, @queries.first
if using_rails_api?
PostsApiController.action(:driver_only).call(@env)
assert_match %r{select id from posts /\*application:rails,controller:posts_api,action:driver_only\*/$}, @queries.second
end
end
def test_configuring_application
Marginalia.application_name = "customapp"
PostsController.action(:driver_only).call(@env)
assert_match %r{/\*application:customapp,controller:posts,action:driver_only\*/$}, @queries.first
if using_rails_api?
PostsApiController.action(:driver_only).call(@env)
assert_match %r{/\*application:customapp,controller:posts_api,action:driver_only\*/$}, @queries.second
end
end
def test_configuring_query_components
Marginalia::Comment.components = [:controller]
PostsController.action(:driver_only).call(@env)
assert_match %r{/\*controller:posts\*/$}, @queries.first
if using_rails_api?
PostsApiController.action(:driver_only).call(@env)
assert_match %r{/\*controller:posts_api\*/$}, @queries.second
end
end
def test_last_line_component
Marginalia::Comment.components = [:line]
PostsController.action(:driver_only).call(@env)
# Because "lines_to_ignore" by default includes "marginalia" and "gem", the
# extracted line line will be from the line in this file that actually
# triggers the query.
assert_match %r{/\*line:test/query_comments_test.rb:[0-9]+:in `driver_only'\*/$}, @queries.first
end
def test_last_line_component_with_lines_to_ignore
Marginalia::Comment.lines_to_ignore = /foo bar/
Marginalia::Comment.components = [:line]
PostsController.action(:driver_only).call(@env)
# Because "lines_to_ignore" does not include "marginalia", the extracted
# line will be from marginalia/comment.rb.
assert_match %r{/\*line:.*lib/marginalia/comment.rb:[0-9]+}, @queries.first
end
def test_default_lines_to_ignore_regex
line = "/gems/a_gem/lib/a_gem.rb:1:in `some_method'"
call_stack = [line] + caller
assert_match(
call_stack.detect { |line| line !~ Marginalia::Comment::DEFAULT_LINES_TO_IGNORE_REGEX },
line
)
end
def test_hostname_and_pid
Marginalia::Comment.components = [:hostname, :pid]
PostsController.action(:driver_only).call(@env)
assert_match %r{/\*hostname:#{Socket.gethostname},pid:#{Process.pid}\*/$}, @queries.first
end
def test_controller_with_namespace
Marginalia::Comment.components = [:controller_with_namespace]
API::V1::PostsController.action(:driver_only).call(@env)
assert_match %r{/\*controller_with_namespace:API::V1::PostsController}, @queries.first
end
def test_db_host
Marginalia::Comment.components = [:db_host]
API::V1::PostsController.action(:driver_only).call(@env)
assert_match %r{/\*db_host:#{ENV["DB_HOST"] || "localhost"}}, @queries.first
end
def test_database
Marginalia::Comment.components = [:database]
API::V1::PostsController.action(:driver_only).call(@env)
assert_match %r{/\*database:marginalia_test}, @queries.first
end
if pool_db_config?
def test_socket
# setting socket in configuration would break some connections - mock it instead
pool = ActiveRecord::Base.connection_pool
pool.db_config.stubs(:configuration_hash).returns({:socket => "marginalia_socket"})
Marginalia::Comment.components = [:socket]
API::V1::PostsController.action(:driver_only).call(@env)
assert_match %r{/\*socket:marginalia_socket}, @queries.first
pool.db_config.unstub(:configuration_hash)
end
else
def test_socket
# setting socket in configuration would break some connections - mock it instead
pool = ActiveRecord::Base.connection_pool
pool.spec.stubs(:config).returns({:socket => "marginalia_socket"})
Marginalia::Comment.components = [:socket]
API::V1::PostsController.action(:driver_only).call(@env)
assert_match %r{/\*socket:marginalia_socket}, @queries.first
pool.spec.unstub(:config)
end
end
def test_request_id
@env["action_dispatch.request_id"] = "some-uuid"
Marginalia::Comment.components = [:request_id]
PostsController.action(:driver_only).call(@env)
assert_match %r{/\*request_id:some-uuid.*}, @queries.first
if using_rails_api?
PostsApiController.action(:driver_only).call(@env)
assert_match %r{/\*request_id:some-uuid.*}, @queries.second
end
end
def test_active_job
Marginalia::Comment.components = [:job]
PostsJob.perform_later
assert_match %{job:PostsJob}, @queries.first
Post.first
refute_match %{job:PostsJob}, @queries.last
end
def test_active_job_with_sidekiq
Marginalia::Comment.components = [:job, :sidekiq_job]
PostsJob.perform_later
assert_match %{job:PostsJob}, @queries.first
Post.first
refute_match %{job:PostsJob}, @queries.last
end
def test_sidekiq_job
Marginalia::Comment.components = [:sidekiq_job]
Marginalia::SidekiqInstrumentation.enable!
# Test harness does not run Sidekiq middlewares by default so include testing middleware.
Sidekiq::Testing.server_middleware do |chain|
chain.add Marginalia::SidekiqInstrumentation::Middleware
end
Sidekiq::Testing.fake!
PostsSidekiqJob.perform_async
PostsSidekiqJob.drain
assert_match %{sidekiq_job:PostsSidekiqJob}, @queries.first
Post.first
refute_match %{sidekiq_job:PostsSidekiqJob}, @queries.last
end
def test_good_comment
assert_equal Marginalia::Comment.escape_sql_comment('app:foo'), 'app:foo'
end
def test_bad_comments
assert_equal Marginalia::Comment.escape_sql_comment('*/; DROP TABLE USERS;/*'), '; DROP TABLE USERS;'
assert_equal Marginalia::Comment.escape_sql_comment('**//; DROP TABLE USERS;/*'), '; DROP TABLE USERS;'
end
def test_inline_annotations
Marginalia.with_annotation("foo") do
Post.first
end
Post.first
assert_match %r{/\*foo\*/$}, @queries.first
refute_match %r{/\*foo\*/$}, @queries.last
# Assert we're not adding an empty comment, either
refute_match %r{/\*\s*\*/$}, @queries.last
end
def test_nested_inline_annotations
Marginalia.with_annotation("foo") do
Marginalia.with_annotation("bar") do
Post.first
end
end
assert_match %r{/\*foobar\*/$}, @queries.first
end
def test_bad_inline_annotations
Marginalia.with_annotation("*/; DROP TABLE USERS;/*") do
Post.first
end
Marginalia.with_annotation("**//; DROP TABLE USERS;//**") do
Post.first
end
assert_match %r{/\*; DROP TABLE USERS;\*/$}, @queries.first
assert_match %r{/\*; DROP TABLE USERS;\*/$}, @queries.last
end
def test_inline_annotations_are_deduped
Marginalia.with_annotation("foo") do
ActiveRecord::Base.connection.execute "select id from posts /*foo*/"
end
assert_match %r{select id from posts /\*foo\*/ /\*application:rails\*/$}, @queries.first
end
def test_add_comments_to_beginning_of_query
Marginalia::Comment.prepend_comment = true
ActiveRecord::Base.connection.execute "select id from posts"
assert_match %r{/\*application:rails\*/ select id from posts$}, @queries.first
ensure
Marginalia::Comment.prepend_comment = nil
end
def teardown
Marginalia.application_name = nil
Marginalia::Comment.lines_to_ignore = nil
Marginalia::Comment.components = [:application, :controller, :action]
ActiveSupport::Notifications.unsubscribe "sql.active_record"
end
end
|