File: read_preference_spec.rb

package info (click to toggle)
ruby-mongo 2.23.0-1
  • links: PTS, VCS
  • area: main
  • in suites: forky, sid
  • size: 15,020 kB
  • sloc: ruby: 110,810; makefile: 5
file content (548 lines) | stat: -rw-r--r-- 15,525 bytes parent folder | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
# frozen_string_literal: true
# rubocop:todo all

require 'spec_helper'

# The only allowed read preference in transaction is primary.
# Because of this, the tests assert that the final read preference is primary.
# It would be preferable to assert that some other read preference is selected,
# but this would only work for non-transactional tests and would require
# duplicating the examples.

describe 'Read preference' do
  clean_slate_on_evergreen

  let(:client) do
    authorized_client.with(client_options)
  end

  let(:subscriber) { Mrss::EventSubscriber.new }

  before do
    client.subscribe(Mongo::Monitoring::COMMAND, subscriber)
  end

  let(:client_options) do
    {}
  end

  let(:session_options) do
    {}
  end

  let(:tx_options) do
    {}
  end

  let(:collection) { client['tx_read_pref_test'] }

  before do
    collection.drop
    collection.create(write_concern: {w: :majority})
  end

  let(:find_options) do
    {}
  end

  shared_examples_for 'does not send read preference when reading' do
    it 'does not send read preference when reading' do
      read_operation

      event = subscriber.single_command_started_event('find')
      actual_preference = event.command['$readPreference']
      expect(actual_preference).to be nil
    end
  end

  shared_examples_for 'non-transactional read preference examples' do
    it 'does not send read preference when writing' do
      write_operation

      event = subscriber.single_command_started_event('insert')
      actual_preference = event.command['$readPreference']
      expect(actual_preference).to be nil
    end

    context 'standalone' do
      require_topology :single

      it_behaves_like 'does not send read preference when reading'
    end

    context 'replica set' do
      # Supposedly read preference should only be sent in a sharded cluster
      # topology. However, transactions spec tests contain read preference
      # assertions also when they are run in RS topologies.
      require_topology :replica_set

      context 'pre-OP_MSG server' do
        max_server_version '3.4'

        it_behaves_like 'does not send read preference when reading'
      end

      context 'server supporting OP_MSG' do
        min_server_fcv '3.6'

        it 'sends expected read preference when reading' do
          read_operation

          event = subscriber.single_command_started_event('find')
          actual_preference = event.command['$readPreference']
          if expected_read_preference&.[]("mode") == "primary"
            expect(actual_preference).to be_nil
          else
            expect(actual_preference).to eq(expected_read_preference)
          end
        end
      end
    end

    context 'sharded cluster' do
      # Driver does not send $readPreference document to mongos when
      # specified mode is primary.
      require_topology :sharded
      it_behaves_like 'does not send read preference when reading'
    end
  end

  shared_examples_for 'sends expected read preference' do
    it_behaves_like 'non-transactional read preference examples'
  end

  shared_context 'non-transactional read preference specifications' do

    context 'when read preference is not explicitly given' do
      let(:client_options) do
        {}
      end

      let(:expected_read_preference) do
        nil
      end

      it_behaves_like 'sends expected read preference'
    end

    context 'when read preference is given in client options' do
      let(:client_options) do
        {read: { mode: :primary }}
      end

      let(:expected_read_preference) do
        {'mode' => 'primary'}
      end

      it_behaves_like 'sends expected read preference'
    end

    context 'when read preference is given in operation options' do
      let(:expected_read_preference) do
        {'mode' => 'primary'}
      end

      let(:find_options) do
        {read: {mode: :primary}}
      end

      it_behaves_like 'sends expected read preference'
    end

    context 'when read preference is given in client and operation options' do
      let(:client_options) do
        {read: { mode: :secondary }}
      end

      # Operation should override the client.
      let(:expected_read_preference) do
        {'mode' => 'primary'}
      end

      let(:find_options) do
        {read: {mode: :primary}}
      end

      it_behaves_like 'sends expected read preference'
    end

    context 'when read preference is given in collection and operation options' do
      let(:collection) do
        client['tx_read_pref_test', {read: {mode: :secondary}}]
      end

      # Operation should override the collection.
      let(:expected_read_preference) do
        {'mode' => 'primary'}
      end

      let(:find_options) do
        {read: {mode: :primary}}
      end

      it_behaves_like 'sends expected read preference'
    end
  end

  context 'not in transaction' do

    let(:write_operation) do
      collection.insert_one(hello: 'world')
    end

    let(:read_operation) do
      collection.with(write: {w: :majority}).insert_one(hello: 'world')
      res = collection.find({}, find_options || {}).to_a.count
      expect(res).to eq(1)
    end

    include_context 'non-transactional read preference specifications'

    context 'when read preference is given in collection options' do
      let(:client_options) do
        {}
      end

      let(:collection) do
        client['tx_read_pref_test', {read: {mode: :primary}}]
      end

      let(:expected_read_preference) do
        {'mode' => 'primary'}
      end

      it_behaves_like 'sends expected read preference'
    end

    context 'when read preference is given in collection options via #with' do
      let(:collection) do
        client['tx_read_pref_test'].with(read: {mode: :primary})
      end

      let(:expected_read_preference) do
        {'mode' => 'primary'}
      end

      it_behaves_like 'sends expected read preference'
    end

    context 'when read preference is given in client and collection options' do
      let(:client_options) do
        {read: { mode: :secondary }}
      end

      let(:collection) do
        client['tx_read_pref_test', {read: {mode: :primary}}]
      end

      # Collection should override the client.
      let(:expected_read_preference) do
        {'mode' => 'primary'}
      end

      it_behaves_like 'sends expected read preference'
    end
  end

  context 'in transaction' do
    # 4.0/RS is a valid topology to test against, but our tooling doesn't
    # support multiple constraint specifications like runOn does.
    # There is no loss of generality to constrain these tests to 4.2+.
    min_server_fcv '4.2'
    require_topology :sharded, :replica_set

    let(:write_operation) do
      expect do
        session = client.start_session(session_options)
        session.with_transaction(tx_options) do
          collection.insert_one({hello: 'world'}, session: session)
        end
      end.not_to raise_error
    end

    let(:read_operation) do
      expect do
        session = client.start_session(session_options)
        session.with_transaction(tx_options) do
          collection.insert_one({hello: 'world'}, session: session)
          res = collection.find({}, {session: session}.merge(find_options || {})).to_a.count
          expect(res).to eq(1)
        end
      end.not_to raise_error
    end

    shared_examples_for 'sends expected read preference' do
      it_behaves_like 'non-transactional read preference examples'

      context 'on sharded cluster' do
        require_topology :sharded

        it 'does not send read preference' do
          # Driver does not send $readPreference document to mongos when
          # specified mode is primary.
          collection.insert_one(hello: 'world')

          session = client.start_session(session_options)
          session.with_transaction(tx_options) do
            res = collection.find({}, {session: session}.merge(find_options || {})).to_a.count
            expect(res).to eq(1)
          end

          event = subscriber.single_command_started_event('find')
          actual_preference = event.command['$readPreference']
          expect(actual_preference).to be_nil
        end
      end

      context 'on replica set' do
        require_topology :replica_set
        it 'sends expected read preference when starting transaction' do
          collection.insert_one(hello: 'world')

          session = client.start_session(session_options)
          session.with_transaction(tx_options) do
            res = collection.find({}, {session: session}.merge(find_options || {})).to_a.count
            expect(res).to eq(1)
          end

          event = subscriber.single_command_started_event('find')
          actual_preference = event.command['$readPreference']
          if expected_read_preference&.[]("mode") == "primary"
            expect(actual_preference).to be_nil
          else
            expect(actual_preference).to eq(expected_read_preference)
          end
        end
      end
    end

    include_context 'non-transactional read preference specifications'

    context 'when read preference is given in collection options' do
      let(:client_options) do
        {}
      end

      let(:collection) do
        client['tx_read_pref_test', {read: {mode: :primary}}]
      end

      # collection read preference is ignored
      let(:expected_read_preference) do
        nil
      end

      it_behaves_like 'sends expected read preference'
    end

    context 'when read preference is given in collection options via #with' do
      let(:collection) do
        client['tx_read_pref_test'].with(read: {mode: :primary})
      end

      # collection read preference is ignored
      let(:expected_read_preference) do
        nil
      end

      it_behaves_like 'sends expected read preference'
    end

    context 'when read preference is given in client and collection options' do
      let(:client_options) do
        {read: { mode: :primary }}
      end

      let(:collection) do
        client['tx_read_pref_test', {read: {mode: :secondary}}]
      end

      # collection read preference is ignored, client read preference is used
      let(:expected_read_preference) do
        {'mode' => 'primary'}
      end

      it_behaves_like 'sends expected read preference'
    end

    context 'when read preference is given in default transaction options' do
      let(:session_options) do
        {default_transaction_options: {read: { mode: :primary }}}
      end

      let(:expected_read_preference) do
        {'mode' => 'primary'}
      end

      it_behaves_like 'sends expected read preference'
    end

    context 'when read preference is given in client and default transaction options' do
      let(:client_options) do
        {read: { mode: :secondary }}
      end

      let(:session_options) do
        {default_transaction_options: {read: { mode: :primary }}}
      end

      let(:expected_read_preference) do
        {'mode' => 'primary'}
      end

      it_behaves_like 'sends expected read preference'
    end

    context 'when read preference is given in collection and default transaction options' do
      let(:collection) do
        client['tx_read_pref_test', {read: {mode: :secondary}}]
      end

      let(:session_options) do
        {default_transaction_options: {read: { mode: :primary }}}
      end

      let(:expected_read_preference) do
        {'mode' => 'primary'}
      end

      it_behaves_like 'sends expected read preference'
    end

    context 'when read preference is given in default transaction and transaction options' do
      let(:session_options) do
        {default_transaction_options: {read: { mode: :secondary }}}
      end

      let(:tx_options) do
        {read: { mode: :primary }}
      end

      let(:expected_read_preference) do
        {'mode' => 'primary'}
      end

      it_behaves_like 'sends expected read preference'
    end

    context 'when read preference is given in default transaction and operation options' do
      let(:session_options) do
        {default_transaction_options: {read: { mode: :primary }}}
      end

      let(:find_options) do
        {read: {mode: :secondary}}
      end

      let(:expected_read_preference) do
        {'mode' => 'primary'}
      end

      it 'sends operation read preference and fails' do
        expect do
          session = client.start_session(session_options)
          session.with_transaction(tx_options) do
            collection.insert_one({hello: 'world'}, session: session)
            res = collection.find({}, {session: session}.merge(find_options || {})).to_a.count
            expect(res).to eq(1)
          end
        end.to raise_error(Mongo::Error::InvalidTransactionOperation, /read preference in a transaction must be primary \(requested: secondary\)/)
      end
    end

    context 'when read preference is given in transaction options' do
      let(:tx_options) do
        {read: { mode: :primary }}
      end

      let(:expected_read_preference) do
        {'mode' => 'primary'}
      end

      it_behaves_like 'sends expected read preference'
    end

    context 'when read preference is given in client and transaction options' do
      let(:client_options) do
        {read: { mode: :secondary }}
      end

      let(:tx_options) do
        {read: { mode: :primary }}
      end

      let(:expected_read_preference) do
        {'mode' => 'primary'}
      end

      it_behaves_like 'sends expected read preference'
    end

    context 'when read preference is given in collection and transaction options' do
      let(:collection) do
        client['tx_read_pref_test', {read: {mode: :secondary}}]
      end

      let(:tx_options) do
        {read: { mode: :primary }}
      end

      let(:expected_read_preference) do
        {'mode' => 'primary'}
      end

      it_behaves_like 'sends expected read preference'
    end

    context 'when read preference is given in transaction and operation options' do
      let(:tx_options) do
        {read: { mode: :primary }}
      end

      let(:find_options) do
        {read: {mode: :secondary}}
      end

      let(:expected_read_preference) do
        {'mode' => 'primary'}
      end

      it 'sends operation read preference and fails' do
        expect do
          session = client.start_session(session_options)
          session.with_transaction(tx_options) do
            collection.insert_one({hello: 'world'}, session: session)
            res = collection.find({}, {session: session}.merge(find_options || {})).to_a.count
            expect(res).to eq(1)
          end
        end.to raise_error(Mongo::Error::InvalidTransactionOperation, /read preference in a transaction must be primary \(requested: secondary\)/)
      end
    end
  end

  context 'secondary read with direct connection' do
    require_topology :replica_set

    let(:address_str) do
      Mongo::ServerSelector.get(mode: :secondary).
        select_server(authorized_client.cluster).address.seed
    end

    let(:secondary_client) do
      new_local_client([address_str],
        SpecConfig.instance.all_test_options.merge(connect: :direct))
    end

    it 'succeeds without read preference' do
      secondary_client['foo'].find.to_a
    end

    it 'succeeds with read preference: secondary' do
      secondary_client['foo', {read: {mode: :secondary}}].find.to_a
    end

    it 'succeeds with read preference: primary' do
      secondary_client['foo', {read: {mode: :primary}}].find.to_a
    end
  end
end