1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813
|
require 'spec_helper'
describe 'Retryable Writes' do
RETRYABLE_WRITES_TESTS.each do |file|
spec = Mongo::CRUD::Spec.new(file)
context(spec.description) do
spec.tests.each do |test|
context(test.description) do
let(:collection) do
client[TEST_COLL]
end
let(:client) do
authorized_client_with_retry_writes
end
before do
test.setup_test(collection)
end
after do
test.clear_fail_point(collection)
collection.delete_many
end
let(:results) do
if test.error?
error = nil
begin; test.run(collection); rescue => e; error = e; end
error
else
test.run(collection)
end
end
it 'has the correct data in the collection', if: (sessions_enabled? && replica_set? && test.outcome_collection_data) do
skip 'Test cannot be run on this server version' unless spec.server_version_satisfied?(client)
results
expect(collection.find.to_a).to match_collection_data(test)
end
if test.error?
it 'raises an error', if: sessions_enabled? && replica_set? do
skip 'Test cannot be run on this server version' unless spec.server_version_satisfied?(client)
expect(results).to be_a(Mongo::Error)
end
else
it 'returns the correct result', if: sessions_enabled? && replica_set? do
skip 'Test cannot be run on this server version' unless spec.server_version_satisfied?(client)
expect(results).to match_operation_result(test)
end
end
end
end
end
end
describe 'Retryable writes integration tests' do
let(:primary) do
primary = client.cluster.next_primary
end
let(:primary_connection) do
connection = primary.pool.checkout
connection.connect!
primary.pool.checkin(connection)
connection
end
let(:primary_socket) do
primary_connection.send(:socket)
end
after do
authorized_collection.delete_many
end
shared_examples_for 'an operation that is retried' do
context 'when the operation fails on the first attempt' do
before do
# Note that for writes, server.connectable? is called, refreshing the socket
allow(primary).to receive(:connectable?).and_return(true)
expect(primary_socket).to receive(:write).and_raise(error)
end
context 'when the error is retryable' do
before do
expect(Mongo::Logger.logger).to receive(:warn).once.and_call_original
expect(client.cluster).to receive(:scan!)
end
context 'when the error is a SocketError' do
let(:error) do
Mongo::Error::SocketError
end
it 'retries writes' do
operation
expect(expectation).to eq(successful_retry_value)
end
end
context 'when the error is a SocketTimeoutError' do
let(:error) do
Mongo::Error::SocketTimeoutError
end
it 'retries writes' do
operation
expect(expectation).to eq(successful_retry_value)
end
end
context 'when the error is a retryable OperationFailure' do
let(:error) do
Mongo::Error::OperationFailure.new('not master')
end
it 'retries writes' do
operation
expect(expectation).to eq(successful_retry_value)
end
end
end
context 'when the error is not retryable' do
context 'when the error is a non-retryable OperationFailure' do
let(:error) do
Mongo::Error::OperationFailure.new('other error')
end
it 'does not retry writes' do
expect {
operation
}.to raise_error(error)
expect(expectation).to eq(unsuccessful_retry_value)
end
end
end
end
context 'when the operation fails on the first attempt and again on the second attempt' do
before do
# Note that for writes, server.connectable? is called, refreshing the socket
allow(primary).to receive(:connectable?).and_return(true)
allow(primary_socket).to receive(:write).and_raise(error)
end
context 'when the selected server does not support retryable writes' do
before do
legacy_primary = double('legacy primary', :'retry_writes?' => false)
allow(client.cluster).to receive(:next_primary).and_return(primary, legacy_primary)
expect(primary_socket).to receive(:write).and_raise(error)
end
context 'when the error is a SocketError' do
let(:error) do
Mongo::Error::SocketError
end
it 'does not retry writes and raises the original error' do
expect {
operation
}.to raise_error(error)
expect(expectation).to eq(unsuccessful_retry_value)
end
end
context 'when the error is a SocketTimeoutError' do
let(:error) do
Mongo::Error::SocketTimeoutError
end
it 'does not retry writes and raises the original error' do
expect {
operation
}.to raise_error(error)
expect(expectation).to eq(unsuccessful_retry_value)
end
end
context 'when the error is a retryable OperationFailure' do
let(:error) do
Mongo::Error::OperationFailure.new('not master')
end
it 'does not retry writes and raises the original error' do
expect {
operation
}.to raise_error(error)
expect(expectation).to eq(unsuccessful_retry_value)
end
end
end
[Mongo::Error::SocketError,
Mongo::Error::SocketTimeoutError,
Mongo::Error::OperationFailure.new('not master')].each do |retryable_error|
context "when the first error is a #{retryable_error}" do
let(:error) do
retryable_error
end
before do
bad_socket = primary_connection.address.socket(primary_connection.socket_timeout,
primary_connection.send(:ssl_options))
good_socket = primary_connection.address.socket(primary_connection.socket_timeout,
primary_connection.send(:ssl_options))
allow(bad_socket).to receive(:write).and_raise(second_error)
allow(primary_connection.address).to receive(:socket).and_return(bad_socket, good_socket)
end
context 'when the second error is a SocketError' do
let(:second_error) do
Mongo::Error::SocketError
end
before do
expect(client.cluster).to receive(:scan!).twice
end
it 'does not retry writes and raises the second error' do
expect {
operation
}.to raise_error(second_error)
expect(expectation).to eq(unsuccessful_retry_value)
end
end
context 'when the second error is a SocketTimeoutError' do
before do
expect(client.cluster).to receive(:scan!).twice
end
let(:second_error) do
Mongo::Error::SocketTimeoutError
end
it 'does not retry writes and raises the second error' do
expect {
operation
}.to raise_error(second_error)
expect(expectation).to eq(unsuccessful_retry_value)
end
end
context 'when the second error is a retryable OperationFailure' do
before do
expect(client.cluster).to receive(:scan!).twice
end
let(:second_error) do
Mongo::Error::OperationFailure.new('not master')
end
it 'does not retry writes and raises the second error' do
expect {
operation
}.to raise_error(second_error)
expect(expectation).to eq(unsuccessful_retry_value)
end
end
context 'when the second error is a non-retryable OperationFailure' do
before do
expect(client.cluster).to receive(:scan!).once
end
let(:second_error) do
Mongo::Error::OperationFailure.new('other error')
end
it 'does not retry writes and raises the first error' do
expect {
operation
}.to raise_error(error)
expect(expectation).to eq(unsuccessful_retry_value)
end
end
context 'when the second error is a another error' do
let(:second_error) do
StandardError
end
it 'does not retry writes and raises the first error' do
expect {
operation
}.to raise_error(error)
expect(expectation).to eq(unsuccessful_retry_value)
end
end
end
end
end
end
shared_examples_for 'an operation that is not retried' do
before do
# Note that for writes, server.connectable? is called, refreshing the socket
allow(primary).to receive(:connectable?).and_return(true)
expect(primary_socket).to receive(:write).and_raise(Mongo::Error::SocketError)
expect(client.cluster).not_to receive(:scan!)
end
it 'does not retry writes' do
expect {
operation
}.to raise_error(Mongo::Error::SocketError)
expect(expectation).to eq(unsuccessful_retry_value)
end
end
shared_examples_for 'an operation that does not support retryable writes' do
let!(:client) do
authorized_client_with_retry_writes
end
let!(:collection) do
client[TEST_COLL, write: WRITE_CONCERN]
end
before do
# Note that for writes, server.connectable? is called, refreshing the socket
allow(primary).to receive(:connectable?).and_return(true)
expect(primary_socket).to receive(:write).and_raise(Mongo::Error::SocketError)
expect(client.cluster).not_to receive(:scan!)
end
it 'does not retry writes' do
expect {
operation
}.to raise_error(Mongo::Error::SocketError)
expect(expectation).to eq(unsuccessful_retry_value)
end
end
shared_examples_for 'supported retryable writes' do
context 'when the client has retry_writes set to true' do
let!(:client) do
authorized_client_with_retry_writes
end
context 'when the collection has write concern acknowledged' do
let!(:collection) do
client[TEST_COLL, write: WRITE_CONCERN]
end
context 'when the server supports retryable writes' do
before do
allow(primary).to receive(:retry_writes?).and_return(true)
end
if standalone? && sessions_enabled?
it_behaves_like 'an operation that is not retried'
elsif sessions_enabled?
it_behaves_like 'an operation that is retried'
end
end
context 'when the server does not support retryable writes' do
before do
allow(primary).to receive(:retry_writes?).and_return(false)
end
it_behaves_like 'an operation that is not retried'
end
end
context 'when the collection has write concern unacknowledged' do
let!(:collection) do
client[TEST_COLL, write: { w: 0 }]
end
it_behaves_like 'an operation that is not retried'
end
context 'when the collection has write concern not set' do
let!(:collection) do
client[TEST_COLL]
end
context 'when the server supports retryable writes' do
before do
allow(primary).to receive(:retry_writes?).and_return(true)
end
if standalone? && sessions_enabled?
it_behaves_like 'an operation that is not retried'
elsif sessions_enabled?
it_behaves_like 'an operation that is retried'
end
end
context 'when the server does not support retryable writes' do
before do
allow(primary).to receive(:retry_writes?).and_return(false)
end
it_behaves_like 'an operation that is not retried'
end
end
end
context 'when the client has retry_writes set to false' do
let!(:client) do
authorized_client.with(retry_writes: false)
end
after do
client.close
end
context 'when the collection has write concern acknowledged' do
let!(:collection) do
client[TEST_COLL, write: WRITE_CONCERN]
end
it_behaves_like 'an operation that is not retried'
end
context 'when the collection has write concern unacknowledged' do
let!(:collection) do
client[TEST_COLL, write: { w: 0 }]
end
it_behaves_like 'an operation that is not retried'
end
context 'when the collection has write concern not set' do
let!(:collection) do
client[TEST_COLL]
end
it_behaves_like 'an operation that is not retried'
end
end
context 'when the client has retry_writes not set' do
let!(:client) do
authorized_client
end
context 'when the collection has write concern acknowledged' do
let!(:collection) do
client[TEST_COLL, write: WRITE_CONCERN]
end
it_behaves_like 'an operation that is not retried'
end
context 'when the collection has write concern unacknowledged' do
let!(:collection) do
client[TEST_COLL, write: { w: 0 }]
end
it_behaves_like 'an operation that is not retried'
end
context 'when the collection has write concern not set' do
let!(:collection) do
client[TEST_COLL]
end
it_behaves_like 'an operation that is not retried'
end
end
end
context 'when the operation is insert_one' do
let(:operation) do
collection.insert_one(a:1)
end
let(:expectation) do
collection.find(a: 1).count
end
let(:successful_retry_value) do
1
end
let(:unsuccessful_retry_value) do
0
end
it_behaves_like 'supported retryable writes'
end
context 'when the operation is update_one' do
before do
# Account for when the collection has unacknowledged write concern and use authorized_collection here.
authorized_collection.insert_one(a:0)
end
let(:operation) do
collection.update_one({ a: 0 }, { '$set' => { a: 1 } })
end
let(:expectation) do
collection.find(a: 1).count
end
let(:successful_retry_value) do
1
end
let(:unsuccessful_retry_value) do
0
end
it_behaves_like 'supported retryable writes'
end
context 'when the operation is replace_one' do
before do
# Account for when the collection has unacknowledged write concern and use authorized_collection here.
authorized_collection.insert_one(a:0)
end
let(:operation) do
collection.replace_one({ a: 0 }, { a: 1 })
end
let(:expectation) do
collection.find(a: 1).count
end
let(:successful_retry_value) do
1
end
let(:unsuccessful_retry_value) do
0
end
it_behaves_like 'supported retryable writes'
end
context 'when the operation is delete_one' do
before do
# Account for when the collection has unacknowledged write concern and use authorized_collection here.
authorized_collection.insert_one(a:1)
end
let(:operation) do
collection.delete_one(a:1)
end
let(:expectation) do
collection.find(a: 1).count
end
let(:successful_retry_value) do
0
end
let(:unsuccessful_retry_value) do
1
end
it_behaves_like 'supported retryable writes'
end
context 'when the operation is find_one_and_update' do
before do
# Account for when the collection has unacknowledged write concern and use authorized_collection here.
authorized_collection.insert_one(a:0)
end
let(:operation) do
collection.find_one_and_update({ a: 0 }, { '$set' => { a: 1 } })
end
let(:expectation) do
collection.find(a: 1).count
end
let(:successful_retry_value) do
1
end
let(:unsuccessful_retry_value) do
0
end
it_behaves_like 'supported retryable writes'
end
context 'when the operation is find_one_and_replace' do
before do
# Account for when the collection has unacknowledged write concern and use authorized_collection here.
authorized_collection.insert_one(a:0)
end
let(:operation) do
collection.find_one_and_replace({ a: 0 }, { a: 3 })
end
let(:expectation) do
collection.find(a: 3).count
end
let(:successful_retry_value) do
1
end
let(:unsuccessful_retry_value) do
0
end
it_behaves_like 'supported retryable writes'
end
context 'when the operation is find_one_and_delete' do
before do
# Account for when the collection has unacknowledged write concern and use authorized_collection here.
authorized_collection.insert_one(a:1)
end
let(:operation) do
collection.find_one_and_delete({ a: 1 })
end
let(:expectation) do
collection.find(a: 1).count
end
let(:successful_retry_value) do
0
end
let(:unsuccessful_retry_value) do
1
end
it_behaves_like 'supported retryable writes'
end
context 'when the operation is update_many' do
before do
# Account for when the collection has unacknowledged write concern and use authorized_collection here.
authorized_collection.insert_one(a:0)
authorized_collection.insert_one(a:0)
end
let(:operation) do
collection.update_many({ a: 0 }, { '$set' => { a: 1 } })
end
let(:expectation) do
collection.find(a: 1).count
end
let(:unsuccessful_retry_value) do
0
end
it_behaves_like 'an operation that does not support retryable writes'
end
context 'when the operation is delete_many' do
before do
# Account for when the collection has unacknowledged write concern and use authorized_collection here.
authorized_collection.insert_one(a:1)
authorized_collection.insert_one(a:1)
end
let(:operation) do
collection.delete_many(a: 1)
end
let(:expectation) do
collection.find(a: 1).count
end
let(:unsuccessful_retry_value) do
2
end
it_behaves_like 'an operation that does not support retryable writes'
end
context 'when the operation is a bulk write' do
before do
# Account for when the collection has unacknowledged write concern and use authorized_collection here.
authorized_collection.insert_one(a: 1)
end
let(:operation) do
collection.bulk_write([{ delete_one: { filter: { a: 1 } } },
{ insert_one: { a: 1 } },
{ insert_one: { a: 1 } }])
end
let(:expectation) do
collection.find(a: 1).count
end
let(:successful_retry_value) do
2
end
let(:unsuccessful_retry_value) do
1
end
it_behaves_like 'supported retryable writes'
end
context 'when the operation is bulk write including delete_many' do
before do
# Account for when the collection has unacknowledged write concern and use authorized_collection here.
authorized_collection.insert_one(a:1)
authorized_collection.insert_one(a:1)
end
let(:operation) do
collection.bulk_write([{ delete_many: { filter: { a: 1 } } }])
end
let(:expectation) do
collection.find(a: 1).count
end
let(:unsuccessful_retry_value) do
2
end
it_behaves_like 'an operation that does not support retryable writes'
end
context 'when the operation is bulk write including update_many' do
before do
# Account for when the collection has unacknowledged write concern and use authorized_collection here.
authorized_collection.insert_one(a:0)
authorized_collection.insert_one(a:0)
end
let(:operation) do
collection.bulk_write([{ update_many: { filter: { a: 0 }, update: { a: 1 } } }])
end
let(:expectation) do
collection.find(a: 1).count
end
let(:unsuccessful_retry_value) do
0
end
it_behaves_like 'an operation that does not support retryable writes'
end
end
end
|