1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331
|
require "test_helper"
# Tests for ParseWithErrorHandlingTest
class ParseWithErrorHandlingTest < Minitest::Test
cover "MultiXml*"
def setup
@original_parser = MultiXml.instance_variable_get(:@parser)
end
def teardown
if @original_parser
MultiXml.instance_variable_set(:@parser, @original_parser)
elsif MultiXml.instance_variable_defined?(:@parser)
MultiXml.send(:remove_instance_variable, :@parser)
end
end
def test_parse_with_io_input_captures_xml_in_error
MultiXml.parser = :nokogiri
io = StringIO.new("<open></close>")
begin
MultiXml.parse(io)
rescue MultiXml::ParseError => e
assert_equal "<open></close>", e.xml
end
end
def test_parse_error_message_from_parser
MultiXml.parser = :nokogiri
begin
MultiXml.parse("<open></close>")
rescue MultiXml::ParseError => e
refute_nil e.message
refute_empty e.message
end
end
def test_parse_error_cause_is_parser_error
MultiXml.parser = :nokogiri
begin
MultiXml.parse("<open></close>")
rescue MultiXml::ParseError => e
assert_kind_of Exception, e.cause
end
end
def test_parse_returns_empty_hash_when_parser_returns_nil
MultiXml.parser = best_available_parser
result = MultiXml.parse("<root/>")
assert_kind_of Hash, result
end
end
# Tests for ParseWithErrorHandlingDetailedTest
class ParseWithErrorHandlingDetailedTest < Minitest::Test
cover "MultiXml*"
def setup
@original_parser = MultiXml.instance_variable_get(:@parser)
MultiXml.parser = :nokogiri
end
def teardown
return unless @original_parser
MultiXml.instance_variable_set(:@parser, @original_parser)
end
def test_parse_wraps_parser_error_with_xml
io = StringIO.new("<bad></wrong>")
begin
MultiXml.parse(io)
flunk "Expected ParseError"
rescue MultiXml::ParseError => e
assert_equal "<bad></wrong>", e.xml
end
end
def test_parse_wraps_parser_error_with_message
MultiXml.parse("<bad></wrong>")
flunk "Expected ParseError"
rescue MultiXml::ParseError => e
refute_nil e.message
end
def test_parse_wraps_parser_error_with_cause
MultiXml.parse("<bad></wrong>")
flunk "Expected ParseError"
rescue MultiXml::ParseError => e
refute_nil e.cause
end
end
# Tests for ParseWithErrorHandlingNilTest
class ParseWithErrorHandlingNilTest < Minitest::Test
cover "MultiXml*"
def setup
@original_parser = MultiXml.instance_variable_get(:@parser)
end
def teardown
return unless @original_parser
MultiXml.instance_variable_set(:@parser, @original_parser)
end
def test_parse_with_error_handling_handles_nil_parser_result
# When parser returns nil, should get empty hash not nil
MultiXml.parser = best_available_parser
result = MultiXml.parse("<empty/>")
# Result should be a hash, not nil
assert_kind_of Hash, result
end
def test_parse_error_with_io_uses_rewind
MultiXml.parser = :nokogiri
io = StringIO.new("<bad></wrong>")
begin
MultiXml.parse(io)
flunk "Expected ParseError"
rescue MultiXml::ParseError => e
# io should have been rewound and read
assert_equal "<bad></wrong>", e.xml
end
end
end
# Create a mock parser that returns nil
class NilReturningParser
def self.parse(_io)
nil
end
def self.parse_error
StandardError
end
end
# Create a mock parser that always fails
class FailingParser
class ParseFailed < StandardError; end
def self.parse(_io)
raise ParseFailed, "Parse failed"
end
def self.parse_error
ParseFailed
end
end
# Tests for ParseWithErrorHandlingNilReturnTest
class ParseWithErrorHandlingNilReturnTest < Minitest::Test
cover "MultiXml*"
def setup
@original_parser = MultiXml.instance_variable_get(:@parser)
end
def teardown
return unless @original_parser
MultiXml.instance_variable_set(:@parser, @original_parser)
end
def test_parse_returns_empty_hash_when_parser_returns_nil
# When parser returns nil, without || {} we'd get nil passed to undasherize_keys
MultiXml.parser = NilReturningParser
# Disable typecast to see raw result from parse_with_error_handling
result = MultiXml.parse("<test/>", typecast_xml_value: false)
# Must be empty hash, not nil
assert_empty(result)
end
def test_parse_returns_empty_hash_not_nil_when_parser_returns_nil
MultiXml.parser = NilReturningParser
# Disable typecast to see raw result
result = MultiXml.parse("<test/>", typecast_xml_value: false)
# Specifically test it's {} not nil
refute_nil result
assert_empty result
end
def test_parse_error_uses_to_s_on_string_input
# Strings respond to both, but we're testing the to_s path
MultiXml.parser = FailingParser
begin
MultiXml.parse("<bad/>")
flunk "Expected ParseError"
rescue MultiXml::ParseError => e
assert_equal "<bad/>", e.xml
end
end
def test_parse_error_with_io_that_responds_to_read
MultiXml.parser = FailingParser
io = StringIO.new("<bad/>")
begin
MultiXml.parse(io)
flunk "Expected ParseError"
rescue MultiXml::ParseError => e
assert_equal "<bad/>", e.xml
end
end
def test_parse_error_rewinds_io_before_reading
# The FailingParser raises an error during parse, so original_input
# still needs to be readable for error message
MultiXml.parser = :nokogiri
io = StringIO.new("<bad></wrong>")
begin
MultiXml.parse(io)
flunk "Expected ParseError"
rescue MultiXml::ParseError => e
# Should have rewound and read full content
assert_equal "<bad></wrong>", e.xml
end
end
end
# Tests parse error message handling
class ParseWithErrorHandlingMessageTest < Minitest::Test
cover "MultiXml*"
def setup
@original_parser = MultiXml.instance_variable_get(:@parser)
end
def teardown
return unless @original_parser
MultiXml.instance_variable_set(:@parser, @original_parser)
end
def test_parse_error_message_is_original_exception_message
MultiXml.parser = FailingParser
begin
MultiXml.parse("<bad/>")
flunk "Expected ParseError"
rescue MultiXml::ParseError => e
# Message must be the string "Parse failed", not nil or the exception object
assert_equal "Parse failed", e.message
assert_instance_of String, e.message
end
end
def test_parse_error_message_is_not_exception_object_to_s
# If e is passed instead of e.message, the message would be e.to_s
# which includes class name like "#<FailingParser::ParseFailed..."
MultiXml.parser = FailingParser
begin
MultiXml.parse("<bad/>")
flunk "Expected ParseError"
rescue MultiXml::ParseError => e
# Should be exactly "Parse failed", not the exception's inspect/to_s
refute_match(/FailingParser/, e.message)
refute_match(/#</, e.message)
end
end
end
# Tests parse error to_s behavior
class ParseWithErrorHandlingToSTest < Minitest::Test
cover "MultiXml*"
def setup
@original_parser = MultiXml.instance_variable_get(:@parser)
end
def teardown
return unless @original_parser
MultiXml.instance_variable_set(:@parser, @original_parser)
end
def test_parse_error_xml_uses_to_s_not_to_str
obj = obj_with_to_s("<from_to_s/>", to_str: "<from_to_str/>")
assert_equal "<from_to_s/>", parse_error_xml(obj)
end
def test_parse_error_xml_uses_to_s_not_raw_input
obj = obj_with_to_s("<converted/>")
assert_equal "<converted/>", parse_error_xml(obj)
assert_instance_of String, parse_error_xml(obj)
end
private
def obj_with_to_s(to_s_val, to_str: nil)
obj = Object.new
obj.define_singleton_method(:to_s) { to_s_val }
obj.define_singleton_method(:to_str) { to_str } if to_str
obj
end
def parse_error_xml(input)
MultiXml.parser = FailingParser
MultiXml.parse(input)
flunk "Expected ParseError"
rescue MultiXml::ParseError => e
e.xml
end
end
|