1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484
|
# frozen_string_literal: true
require "helper"
class TestNokogiriXMLSchema < Nokogiri::TestCase
describe Nokogiri::XML::Schema do
let(:xsd) { Nokogiri::XML::Schema(File.read(PO_SCHEMA_FILE)) }
describe "construction" do
it ".new" do
assert(xsd = Nokogiri::XML::Schema.new(File.read(PO_SCHEMA_FILE)))
assert_instance_of(Nokogiri::XML::Schema, xsd)
end
it ".read_memory" do
xsd = Nokogiri::XML::Schema.read_memory(File.read(PO_SCHEMA_FILE))
assert_instance_of(Nokogiri::XML::Schema, xsd)
doc = Nokogiri::XML(File.read(PO_XML_FILE))
assert(xsd.valid?(doc))
end
it ".read_memory given an IO" do
xsd = nil
File.open(PO_SCHEMA_FILE) do |f|
xsd = Nokogiri::XML::Schema.read_memory(f)
end
assert_instance_of(Nokogiri::XML::Schema, xsd)
doc = Nokogiri::XML(File.read(PO_XML_FILE))
assert(xsd.valid?(doc))
end
it ".from_document" do
doc = Nokogiri::XML(File.open(PO_SCHEMA_FILE))
assert(doc)
xsd = Nokogiri::XML::Schema.from_document(doc)
assert_instance_of(Nokogiri::XML::Schema, xsd)
end
it "invalid_schema_do_not_raise_exceptions" do
xsd = Nokogiri::XML::Schema.new(<<~EOF)
<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema">
<xs:group name="foo1">
<xs:sequence>
<xs:element name="bar" type="xs:boolean" />
</xs:sequence>
</xs:group>
<xs:group name="foo2">
<xs:sequence>
<xs:element name="bar" type="xs:string" />
</xs:sequence>
</xs:group>
<xs:element name="foo">
<xs:complexType>
<xs:choice>
<xs:group ref="foo1"/>
<xs:group ref="foo2"/>
</xs:choice>
</xs:complexType>
</xs:element>
</xs:schema>
EOF
assert_instance_of(Nokogiri::XML::Schema, xsd)
if Nokogiri.jruby?
refute_empty(xsd.errors)
assert_equal(1, xsd.errors.map(&:to_s).grep(/cos-element-consistent/).length)
assert_equal(1, xsd.errors.map(&:to_s).grep(/cos-nonambig/).length)
end
end
it ".from_document accepts a node, but warns about it" do
doc = Nokogiri::XML(File.open(PO_SCHEMA_FILE))
assert(doc)
xsd = nil
assert_output(nil, /Passing a Node as the first parameter to Schema.from_document is deprecated/) do
xsd = Nokogiri::XML::Schema.from_document(doc.root)
end
assert_instance_of(Nokogiri::XML::Schema, xsd)
end
it ".from_document not accept anything other than Node or Document" do
assert_raises(TypeError) { Nokogiri::XML::Schema.from_document(1234) }
assert_raises(TypeError) { Nokogiri::XML::Schema.from_document("asdf") }
assert_raises(TypeError) { Nokogiri::XML::Schema.from_document({}) }
assert_raises(TypeError) { Nokogiri::XML::Schema.from_document(nil) }
end
it "schema_validates_with_relative_paths" do
xsd = File.join(ASSETS_DIR, "foo", "foo.xsd")
xml = File.join(ASSETS_DIR, "valid_bar.xml")
doc = Nokogiri::XML(File.open(xsd))
xsd = Nokogiri::XML::Schema.from_document(doc)
doc = Nokogiri::XML(File.open(xml))
assert(xsd.valid?(doc))
end
it "parse_with_memory" do
assert_instance_of(Nokogiri::XML::Schema, xsd)
assert_equal(0, xsd.errors.length)
end
it "schema_method_with_parse_options" do
schema = Nokogiri::XML::Schema(File.read(PO_SCHEMA_FILE))
assert_equal(Nokogiri::XML::ParseOptions::DEFAULT_SCHEMA, schema.parse_options)
schema = Nokogiri::XML::Schema(File.read(PO_SCHEMA_FILE), Nokogiri::XML::ParseOptions.new.recover)
assert_equal(Nokogiri::XML::ParseOptions.new.recover, schema.parse_options)
end
it "schema_new_with_parse_options" do
schema = Nokogiri::XML::Schema.new(File.read(PO_SCHEMA_FILE))
assert_equal(Nokogiri::XML::ParseOptions::DEFAULT_SCHEMA, schema.parse_options)
schema = Nokogiri::XML::Schema.new(File.read(PO_SCHEMA_FILE), Nokogiri::XML::ParseOptions.new.recover)
assert_equal(Nokogiri::XML::ParseOptions.new.recover, schema.parse_options)
end
it "schema_from_document_with_parse_options" do
schema = Nokogiri::XML::Schema.from_document(Nokogiri::XML::Document.parse(File.read(PO_SCHEMA_FILE)))
assert_equal(Nokogiri::XML::ParseOptions::DEFAULT_SCHEMA, schema.parse_options)
schema = Nokogiri::XML::Schema.from_document(
Nokogiri::XML::Document.parse(File.read(PO_SCHEMA_FILE)),
Nokogiri::XML::ParseOptions.new.recover,
)
assert_equal(Nokogiri::XML::ParseOptions.new.recover, schema.parse_options)
end
it "schema_read_memory_with_parse_options" do
schema = Nokogiri::XML::Schema.read_memory(File.read(PO_SCHEMA_FILE))
assert_equal(Nokogiri::XML::ParseOptions::DEFAULT_SCHEMA, schema.parse_options)
schema = Nokogiri::XML::Schema.read_memory(File.read(PO_SCHEMA_FILE), Nokogiri::XML::ParseOptions.new.recover)
assert_equal(Nokogiri::XML::ParseOptions.new.recover, schema.parse_options)
end
it "parse_with_io" do
xsd = nil
File.open(PO_SCHEMA_FILE, "rb") do |f|
assert(xsd = Nokogiri::XML::Schema(f))
end
assert_equal(0, xsd.errors.length)
end
it "parse_with_errors" do
xml = File.read(PO_SCHEMA_FILE).sub('name="', "name=")
assert_raises(Nokogiri::XML::SyntaxError) do
Nokogiri::XML::Schema(xml)
end
end
end
describe "validation" do
it "validate_document" do
doc = Nokogiri::XML(File.read(PO_XML_FILE))
assert(errors = xsd.validate(doc))
assert_equal(0, errors.length)
end
it "validate_file" do
assert(errors = xsd.validate(PO_XML_FILE))
assert_equal(0, errors.length)
end
it "validate_invalid_document" do
doc = Nokogiri::XML(File.read(PO_XML_FILE))
doc.css("city").unlink
assert(errors = xsd.validate(doc))
assert_equal(2, errors.length)
if Nokogiri.uses_libxml?
assert_equal(
["/purchaseOrder/billTo/state", "/purchaseOrder/shipTo/state"],
errors.map(&:path).sort,
)
else
assert_equal(
[nil, nil],
errors.map(&:path).sort,
)
end
end
it "validate_invalid_file" do
tempfile = Tempfile.new("xml")
doc = Nokogiri::XML(File.read(PO_XML_FILE))
doc.css("city").unlink
tempfile.write(doc.to_xml)
tempfile.close
assert(errors = xsd.validate(tempfile.path))
assert_equal(2, errors.length)
assert_equal(
[nil, nil],
errors.map(&:path).sort,
)
end
it "validate_non_document" do
string = File.read(PO_XML_FILE)
assert_raises(ArgumentError) { xsd.validate(string) }
end
it "valid?" do
valid_doc = Nokogiri::XML(File.read(PO_XML_FILE))
invalid_doc = Nokogiri::XML(
File.read(PO_XML_FILE).gsub(%r{<city>[^<]*</city>}, ""),
)
assert(xsd.valid?(valid_doc))
refute(xsd.valid?(invalid_doc))
end
describe "error handling" do
let(:xsd) do
<<~EOF
<?xml version="1.0" encoding="UTF-8"?>
<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema"
targetNamespace="http://www.example.org/contactExample">
<xs:element name="Contacts"></xs:element>
</xs:schema>
EOF
end
let(:good_xml) { %(<Contacts xmlns="http://www.example.org/contactExample"><Contact></Contact></Contacts>) }
let(:bad_xml) { %(<Contacts xmlns="http://www.example.org/wrongNs"><Contact></Contact></Contacts>) }
let(:schema) { Nokogiri::XML::Schema.new(xsd) }
it "does not clobber @errors" do
bad_doc = Nokogiri::XML(bad_xml)
# assert on setup
assert_empty(schema.errors)
refute_empty(schema.validate(bad_doc))
# this is the bit under test
assert_empty(schema.errors)
end
it "returns only the most recent document's errors" do
# https://github.com/sparklemotion/nokogiri/issues/1282
good_doc = Nokogiri::XML(good_xml)
bad_doc = Nokogiri::XML(bad_xml)
# assert on setup
assert_empty(schema.validate(good_doc))
refute_empty(schema.validate(bad_doc))
# this is the bit under test
assert_empty(schema.validate(good_doc))
end
it "return errors for empty documents" do
doc = Nokogiri::XML("")
assert(errors = schema.validate(doc))
assert_equal(1, errors.length)
end
it "return errors for empty files" do
Tempfile.create do |f|
f.write("") && f.close
assert(errors = schema.validate(f.path))
assert_equal(1, errors.length)
end
end
it "returns errors when validating bad documents" do
doc = Nokogiri::XML("xyz")
assert(errors = schema.validate(doc))
assert_equal(1, errors.length)
end
it "returns errors when validating bad files" do
Tempfile.create do |f|
f.write("xyz") && f.close
assert(errors = schema.validate(f.path))
assert_equal(1, errors.length)
end
end
end
end
it "xsd_with_dtd" do
# https://github.com/sparklemotion/nokogiri/pull/791
Dir.chdir(File.join(ASSETS_DIR, "saml")) do
refute_raises do
Nokogiri::XML::Schema(File.read("xmldsig_schema.xsd"))
end
refute_raises do
Nokogiri::XML::Schema(File.read("saml20protocol_schema.xsd"))
end
end
end
it "xsd_import_with_no_systemid" do
# https://github.com/sparklemotion/nokogiri/pull/2296
xsd = <<~EOF
<?xml version="1.0" encoding="UTF-8"?>
<xs:schema
xmlns:xs="http://www.w3.org/2001/XMLSchema"
xmlns="http://www.w3.org/1998/Math/MathML"
targetNamespace="http://www.w3.org/1998/Math/MathML"
>
<xs:import/>
</xs:schema>
EOF
refute_raises do
Nokogiri::XML::Schema(xsd)
end
end
it "issue_1985_schema_parse_modifying_underlying_document" do
skip_unless_libxml2("Pure Java version doesn't have this bug")
# This is a test for a workaround for a bug in LibXML2:
#
# https://gitlab.gnome.org/GNOME/libxml2/issues/148
#
# Schema creation can modify the original document -- removal of blank text nodes -- which
# results in dangling pointers.
#
# If no nodes have been exposed, then it should be fine to create a schema. If nodes have
# been exposed to Ruby, then we need to make sure they won't be freed out from under us.
doc = <<~EOF
<?xml version="1.0" encoding="UTF-8" ?>
<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema">
<xs:element name="foo" type="xs:string"/>
</xs:schema>
EOF
# This is OK, no nodes have been exposed
xsd_doc = Nokogiri::XML(doc)
assert(Nokogiri::XML::Schema.from_document(xsd_doc))
# This is not OK, nodes have been exposed to Ruby
xsd_doc = Nokogiri::XML(doc)
child = xsd_doc.root.children.find(&:blank?) # Find a blank node that would be freed without the fix
Nokogiri::XML::Schema.from_document(xsd_doc)
assert(child.to_s) # This will raise a valgrind error if the node was freed
end
describe "CVE-2020-26247" do
# https://github.com/sparklemotion/nokogiri/security/advisories/GHSA-vr8q-g5c7-m54m
let(:schema) do
<<~EOSCHEMA
<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema">
<xs:import namespace="test" schemaLocation="http://localhost:8000/making-a-request"/>
</xs:schema>
EOSCHEMA
end
if Nokogiri.uses_libxml?
describe "with default parse options" do
it "XML::Schema parsing does not attempt to access external DTDs" do
doc = Nokogiri::XML::Schema.new(schema)
errors = doc.errors.map(&:to_s)
refute_empty(
errors.grep(/Attempt to load network entity/),
"Should see xmlIO.c:xmlNoNetExternalEntityLoader() raising XML_IO_NETWORK_ATTEMPT",
)
assert_empty(
errors.grep(/failed to load HTTP resource/),
"Should not see xmlIO.c:xmlCheckHTTPInput() raising 'failed to load HTTP resource'",
)
assert_empty(
errors.grep(/failed to load external entity/),
"Should not see xmlIO.c:xmlDefaultExternalEntityLoader() raising 'failed to load external entity'",
)
end
it "XML::Schema parsing of memory does not attempt to access external DTDs" do
doc = Nokogiri::XML::Schema.read_memory(schema)
errors = doc.errors.map(&:to_s)
refute_empty(
errors.grep(/Attempt to load network entity/),
"Should see xmlIO.c:xmlNoNetExternalEntityLoader() raising XML_IO_NETWORK_ATTEMPT",
)
assert_empty(
errors.grep(/failed to load HTTP resource/),
"Should not see xmlIO.c:xmlCheckHTTPInput() raising 'failed to load HTTP resource'",
)
assert_empty(
errors.grep(/failed to load external entity/),
"Should not see xmlIO.c:xmlDefaultExternalEntityLoader() raising 'failed to load external entity'",
)
end
end
describe "with NONET turned off" do
it "XML::Schema parsing attempts to access external DTDs" do
doc = Nokogiri::XML::Schema.new(schema, Nokogiri::XML::ParseOptions.new.nononet)
errors = doc.errors.map(&:to_s)
assert_empty(
errors.grep(/Attempt to load network entity/),
"Should not see xmlIO.c:xmlNoNetExternalEntityLoader() raising XML_IO_NETWORK_ATTEMPT",
)
assert_equal(1, errors.grep(%r{failed to load.*http://localhost:8000/making-a-request}).length)
end
it "XML::Schema parsing attempts to access external DTDs with kwargs" do
doc = Nokogiri::XML::Schema.new(schema, parse_options: Nokogiri::XML::ParseOptions.new.nononet)
errors = doc.errors.map(&:to_s)
assert_empty(
errors.grep(/Attempt to load network entity/),
"Should not see xmlIO.c:xmlNoNetExternalEntityLoader() raising XML_IO_NETWORK_ATTEMPT",
)
assert_equal(1, errors.grep(%r{failed to load.*http://localhost:8000/making-a-request}).length)
end
it "XML::Schema parsing of memory attempts to access external DTDs" do
doc = Nokogiri::XML::Schema.read_memory(schema, Nokogiri::XML::ParseOptions.new.nononet)
errors = doc.errors.map(&:to_s)
assert_empty(
errors.grep(/ERROR: Attempt to load network entity/),
"Should not see xmlIO.c:xmlNoNetExternalEntityLoader() raising XML_IO_NETWORK_ATTEMPT",
)
assert_equal(1, errors.grep(%r{failed to load.*http://localhost:8000/making-a-request}).length)
end
it "XML::Schema parsing of memory attempts to access external DTDs with kwargs" do
doc = Nokogiri::XML::Schema.read_memory(schema, parse_options: Nokogiri::XML::ParseOptions.new.nononet)
errors = doc.errors.map(&:to_s)
assert_empty(
errors.grep(/ERROR: Attempt to load network entity/),
"Should not see xmlIO.c:xmlNoNetExternalEntityLoader() raising XML_IO_NETWORK_ATTEMPT",
)
assert_equal(1, errors.grep(%r{failed to load.*http://localhost:8000/making-a-request}).length)
end
end
end
if Nokogiri.jruby?
describe "with default parse options" do
it "XML::Schema parsing does not attempt to access external DTDs" do
doc = Nokogiri::XML::Schema.new(schema)
assert_equal 1, doc.errors.map(&:to_s).grep(/WARNING: Attempt to load network entity/).length
end
it "XML::Schema parsing of memory does not attempt to access external DTDs" do
doc = Nokogiri::XML::Schema.read_memory(schema)
assert_equal 1, doc.errors.map(&:to_s).grep(/WARNING: Attempt to load network entity/).length
end
end
describe "with NONET turned off" do
it "XML::Schema parsing attempts to access external DTDs" do
doc = Nokogiri::XML::Schema.new(schema, Nokogiri::XML::ParseOptions.new.nononet)
assert_equal 0, doc.errors.map(&:to_s).grep(/WARNING: Attempt to load network entity/).length
end
it "XML::Schema parsing attempts to access external DTDs with kwargs" do
doc = Nokogiri::XML::Schema.new(schema, parse_options: Nokogiri::XML::ParseOptions.new.nononet)
assert_equal 0, doc.errors.map(&:to_s).grep(/WARNING: Attempt to load network entity/).length
end
it "XML::Schema parsing of memory attempts to access external DTDs" do
doc = Nokogiri::XML::Schema.read_memory(schema, Nokogiri::XML::ParseOptions.new.nononet)
assert_equal 0, doc.errors.map(&:to_s).grep(/WARNING: Attempt to load network entity/).length
end
it "XML::Schema parsing of memory attempts to access external DTDs with kwargs" do
doc = Nokogiri::XML::Schema.read_memory(schema, parse_options: Nokogiri::XML::ParseOptions.new.nononet)
assert_equal 0, doc.errors.map(&:to_s).grep(/WARNING: Attempt to load network entity/).length
end
end
end
end
end
end
|