1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
|
# frozen_string_literal: true
require 'spec_helper'
require 'puppet/resource_api/simple_provider'
RSpec.describe Puppet::ResourceApi::SimpleProvider do
let(:context) { instance_double('Puppet::ResourceApi::BaseContext', 'context') }
let(:type_def) { instance_double('Puppet::ResourceApi::TypeDefinition', 'type_def') }
let(:provider_class) do
Class.new(described_class) do
def get(context, _names = nil); end
def create(context, _name, _should); end
def update(context, _name, _should); end
def delete(context, _name); end
end
end
let(:provider) { provider_class.new }
before(:each) do
allow(context).to receive(:type).and_return(type_def)
allow(type_def).to receive(:ensurable?).and_return(true)
end
context 'without overriding the crud methods' do
it 'create fails' do
expect { described_class.new.create(context, nil, nil) }.to raise_error StandardError, %r{has not implemented.*create}
end
it 'update fails' do
expect { described_class.new.update(context, nil, nil) }.to raise_error StandardError, %r{has not implemented.*update}
end
it 'delete fails' do
expect { described_class.new.delete(context, nil) }.to raise_error StandardError, %r{has not implemented.*delete}
end
end
context 'with no changes' do
let(:changes) { {} }
it 'does not call create' do
expect(provider).to receive(:create).never
provider.set(context, changes)
end
it 'does not call update' do
expect(provider).to receive(:update).never
provider.set(context, changes)
end
it 'does not call delete' do
expect(provider).to receive(:delete).never
provider.set(context, changes)
end
end
context 'with a single change to create a resource' do
let(:should_values) { { name: 'title', ensure: 'present' } }
let(:changes) do
{ 'title' =>
{
should: should_values,
} }
end
before(:each) do
allow(context).to receive(:creating).with('title').and_yield
allow(context).to receive(:type).and_return(type_def)
allow(type_def).to receive(:feature?).with('simple_get_filter')
allow(type_def).to receive(:check_schema)
allow(type_def).to receive(:namevars).and_return([:name])
end
it 'calls create once' do
expect(provider).to receive(:create).with(context, 'title', should_values).once
provider.set(context, changes)
end
it 'does not call update' do
expect(provider).to receive(:update).never
provider.set(context, changes)
end
it 'does not call delete' do
expect(provider).to receive(:delete).never
provider.set(context, changes)
end
context 'with a type that supports `simple_get_filter`' do
before(:each) do
allow(context).to receive(:type).and_return(type_def)
allow(type_def).to receive(:feature?).with('simple_get_filter').and_return(true)
end
it 'calls `get` with name' do
expect(provider).to receive(:get).with(context, ['title'])
provider.set(context, changes)
end
end
end
context 'with a single change to update a resource' do
let(:is_values) { { name: 'title', ensure: 'present' } }
let(:should_values) { { name: 'title', ensure: 'present' } }
let(:changes) do
{ 'title' =>
{
is: is_values,
should: should_values,
} }
end
before(:each) do
allow(context).to receive(:updating).with('title').and_yield
allow(context).to receive(:type).and_return(type_def)
allow(type_def).to receive(:feature?).with('simple_get_filter')
allow(type_def).to receive(:namevars).and_return([:name])
end
it 'does not call create' do
expect(provider).to receive(:create).never
provider.set(context, changes)
end
it 'calls update once' do
expect(provider).to receive(:update).with(context, 'title', should_values).once
provider.set(context, changes)
end
it 'does not call delete' do
expect(provider).to receive(:delete).never
provider.set(context, changes)
end
end
context 'with a single change to update a resource with an optional ensure' do
let(:is_values) { { name: 'title', ensure: 'present', prop: 'a' } }
let(:should_values) { { name: 'title', prop: 'b' } }
let(:changes) do
{ 'title' =>
{
is: is_values,
should: should_values,
} }
end
before(:each) do
allow(context).to receive(:updating).with('title').and_yield
allow(context).to receive(:type).and_return(type_def)
allow(type_def).to receive(:feature?).with('simple_get_filter')
allow(type_def).to receive(:namevars).and_return([:name])
end
it 'does not call create' do
expect(provider).to receive(:create).never
provider.set(context, changes)
end
it 'calls update once' do
expect(provider).to receive(:update).with(context, 'title', should_values).once
provider.set(context, changes)
end
it 'does not call delete' do
expect(provider).to receive(:delete).never
provider.set(context, changes)
end
end
context 'with a single change to delete a resource' do
let(:is_values) { { name: 'title', ensure: 'present' } }
let(:should_values) { { name: 'title', ensure: 'absent' } }
let(:changes) do
{ 'title' =>
{
is: is_values,
should: should_values,
} }
end
before(:each) do
allow(context).to receive(:deleting).with('title').and_yield
allow(context).to receive(:type).and_return(type_def)
allow(type_def).to receive(:feature?).with('simple_get_filter')
allow(type_def).to receive(:namevars).and_return([:name])
end
it 'does not call create' do
expect(provider).to receive(:create).never
provider.set(context, changes)
end
it 'does not call update' do
expect(provider).to receive(:update).never
provider.set(context, changes)
end
it 'calls delete once' do
expect(provider).to receive(:delete).with(context, 'title').once
provider.set(context, changes)
end
end
context 'with multiple changes' do
let(:changes) do
{ 'to create' =>
{
should: { name: 'to create', ensure: 'present' },
},
'to update' =>
{
is: { name: 'to update', ensure: 'present' },
should: { name: 'to update', ensure: 'present' },
},
'to delete' =>
{
is: { name: 'to create', ensure: 'present' },
should: { name: 'to create', ensure: 'absent' },
} }
end
before(:each) do
allow(context).to receive(:creating).with('to create').and_yield
allow(context).to receive(:updating).with('to update').and_yield
allow(context).to receive(:deleting).with('to delete').and_yield
allow(type_def).to receive(:feature?).with('simple_get_filter').exactly(3).times
allow(type_def).to receive(:namevars).and_return([:name])
end
it 'calls the crud methods' do
expect(provider).to receive(:create).with(context, 'to create', hash_including(name: 'to create'))
expect(provider).to receive(:update).with(context, 'to update', hash_including(name: 'to update'))
expect(provider).to receive(:delete).with(context, 'to delete')
expect(type_def).to receive(:check_schema)
provider.set(context, changes)
end
end
context 'with a type that does not implement ensurable' do
let(:is_values) { { name: 'title', content: 'foo' } }
let(:should_values) { { name: 'title', content: 'bar' } }
let(:changes) do
{ 'title' =>
{
is: is_values,
should: should_values,
} }
end
before(:each) do
allow(context).to receive(:updating).with('title').and_yield
allow(type_def).to receive(:feature?).with('simple_get_filter')
allow(type_def).to receive(:ensurable?).and_return(false)
end
it { expect { provider.set(context, changes) }.to raise_error %r{SimpleProvider cannot be used with a Type that is not ensurable} }
end
context 'with changes from a composite namevar type' do
let(:changes) do
{
{ name1: 'value1', name2: 'value2' } =>
{
should: { name1: 'value1', name2: 'value2', ensure: 'present' },
},
}
end
before(:each) do
allow(context).to receive(:creating).with(name1: 'value1', name2: 'value2').and_yield
allow(type_def).to receive(:feature?).with('simple_get_filter').and_return(true)
allow(type_def).to receive(:namevars).and_return([:name1, :name2])
allow(type_def).to receive(:check_schema)
end
it 'calls the crud methods with the right title' do
expect(provider).to receive(:create).with(context, { name1: 'value1', name2: 'value2' }, hash_including(name1: 'value1'))
provider.set(context, changes)
end
end
end
|
