1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
|
# frozen_string_literal: true
require 'spec_helper'
require 'tempfile'
require 'open3'
RSpec.describe 'a transport' do
let(:common_args) { '--verbose --trace --debug --strict=error --modulepath spec/fixtures' }
before(:all) do
FileUtils.mkdir_p(File.expand_path('~/.puppetlabs/opt/puppet/cache/devices/the_node/state'))
end
describe 'using `puppet device`' do
let(:common_args) { super() + ' --target the_node' }
let(:device_conf) { Tempfile.new('device.conf') }
let(:device_conf_content) do
<<DEVICE_CONF
[the_node]
type test_device_sensitive
url file://#{device_credentials.path}
DEVICE_CONF
end
let(:device_credentials) { Tempfile.new('credentials.txt') }
def is_device_apply_supported?
Gem::Version.new(Puppet::PUPPETVERSION) >= Gem::Version.new('5.3.6') && Gem::Version.new(Puppet::PUPPETVERSION) != Gem::Version.new('5.4.0')
end
before(:each) do
skip "No device --apply in puppet before v5.3.6 nor in v5.4.0 (v#{Puppet::PUPPETVERSION} is installed)" unless is_device_apply_supported?
device_conf.write(device_conf_content)
device_conf.close
device_credentials.write(device_credentials_content)
device_credentials.close
end
after(:each) do
device_conf.unlink
device_credentials.unlink
end
context 'when all sensitive values are valid' do
let(:device_credentials_content) do
<<DEVICE_CREDS
{
username: foo
secret_string: wibble
optional_secret: bar
array_secret: [meep]
variant_secret: 1234567890
}
DEVICE_CREDS
end
it 'does not throw' do
Tempfile.create('apply_success') do |f|
f.write 'notify { "foo": }'
f.close
stdout_str, status = Open3.capture2e("puppet device #{common_args} --deviceconfig #{device_conf.path} --apply #{f.path}")
expect(status.exitstatus).to eq 0
expect(stdout_str).not_to match %r{Value type mismatch}
expect(stdout_str).not_to match %r{Error}
expect(stdout_str).to match %r{transport connection_info:}
expect(stdout_str).to match %r{:username=>"foo"}
expect(stdout_str).not_to match %r{wibble}
expect(stdout_str).not_to match %r{bar}
expect(stdout_str).not_to match %r{meep}
expect(stdout_str).not_to match %r{1234567890}
end
end
end
context 'with a sensitive string value that is invalid' do
let(:device_credentials_content) do
<<DEVICE_CREDS
{
username: foo
secret_string: 12345
optional_secret: wibble
array_secret: [meep]
variant_secret: 21
}
DEVICE_CREDS
end
it 'Value type mismatch' do
Tempfile.create('apply_success') do |f|
f.write 'notify { "foo": }'
f.close
stdout_str, status = Open3.capture2e("puppet device #{common_args} --deviceconfig #{device_conf.path} --apply #{f.path}")
expect(stdout_str).to match %r{Error}
expect(stdout_str).to match %r{Value type mismatch}
expect(stdout_str).to match %r{secret_string: << redacted value >> }
expect(stdout_str).not_to match %r{optional_secret}
expect(stdout_str).not_to match %r{array_secret}
expect(stdout_str).not_to match %r{variant_secret}
expect(status.exitstatus).to eq 1
end
end
end
context 'with an optional sensitive string value that is invalid' do
let(:device_credentials_content) do
<<DEVICE_CREDS
{
username: foo
secret_string: wibble
optional_secret: 12345
array_secret: [meep]
variant_secret: 21
}
DEVICE_CREDS
end
it 'Value type mismatch' do
Tempfile.create('apply_success') do |f|
f.write 'notify { "foo": }'
f.close
stdout_str, status = Open3.capture2e("puppet device #{common_args} --deviceconfig #{device_conf.path} --apply #{f.path}")
expect(stdout_str).to match %r{Error}
expect(stdout_str).to match %r{Value type mismatch}
expect(stdout_str).not_to match %r{secret_string }
expect(stdout_str).to match %r{optional_secret: << redacted value >>}
expect(stdout_str).not_to match %r{array_secret}
expect(stdout_str).not_to match %r{variant_secret}
expect(status.exitstatus).to eq 1
end
end
end
context 'with an array of sensitive strings that is invalid' do
let(:device_credentials_content) do
<<DEVICE_CREDS
{
username: foo
secret_string: wibble
optional_secret: bar
array_secret: [17]
variant_secret: 21
}
DEVICE_CREDS
end
it 'Value type mismatch' do
Tempfile.create('apply_success') do |f|
f.write 'notify { "foo": }'
f.close
stdout_str, status = Open3.capture2e("puppet device #{common_args} --deviceconfig #{device_conf.path} --apply #{f.path}")
expect(stdout_str).to match %r{Error}
expect(stdout_str).to match %r{Value type mismatch}
expect(stdout_str).not_to match %r{secret_string }
expect(stdout_str).not_to match %r{optional_secret}
expect(stdout_str).to match %r{array_secret: << redacted value >>}
expect(stdout_str).not_to match %r{variant_secret}
expect(status.exitstatus).to eq 1
end
end
end
context 'with an variant containing a sensitive value that is invalid' do
let(:device_credentials_content) do
<<DEVICE_CREDS
{
username: foo
secret_string: wibble
optional_secret: bar
array_secret: [meep]
variant_secret: wobble
}
DEVICE_CREDS
end
it 'Value type mismatch' do
Tempfile.create('apply_success') do |f|
f.write 'notify { "foo": }'
f.close
stdout_str, status = Open3.capture2e("puppet device #{common_args} --deviceconfig #{device_conf.path} --apply #{f.path}")
expect(stdout_str).to match %r{Error}
expect(stdout_str).to match %r{Value type mismatch}
expect(stdout_str).not_to match %r{secret_string }
expect(stdout_str).not_to match %r{optional_secret}
expect(stdout_str).not_to match %r{array_secret}
expect(stdout_str).to match %r{variant_secret: << redacted value >>}
expect(status.exitstatus).to eq 1
end
end
end
end
end
|
