1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
|
require 'spec_helper'
require 'puppet'
describe PuppetSyntax::Manifests do
let(:subject) { PuppetSyntax::Manifests.new }
it 'expects an array of files' do
expect { subject.check(nil) }.to raise_error(/Expected an array of files/)
end
it 'returns nothing from a valid file' do
files = fixture_manifests('pass.pp')
output, has_errors = subject.check(files)
expect(output).to eq([])
expect(has_errors).to eq(false)
end
it 'returns nothing from a valid file with a class using tag parameter' do
files = fixture_manifests('tag_notice.pp')
output, has_errors = subject.check(files)
expect(output).to eq([])
expect(has_errors).to eq(false)
end
it 'returns nothing from a valid file with a class using schedule parameter' do
files = fixture_manifests('schedule_notice.pp')
output, has_errors = subject.check(files)
expect(output).to eq([])
expect(has_errors).to eq(false)
end
it 'returns an error from an invalid file' do
files = fixture_manifests('fail_error.pp')
output, has_errors = subject.check(files)
expect(output.size).to eq(3)
expect(output[2]).to match(/2 errors. Giving up/)
expect(has_errors).to eq(true)
end
it 'returns a warning from an invalid file' do
files = fixture_manifests('fail_warning.pp')
output, has_errors = subject.check(files)
expect(output.size).to eq(2)
expect(has_errors).to eq(true)
expect(output[0]).to match(/Unrecogni(s|z)ed escape sequence '\\\['/)
expect(output[1]).to match(/Unrecogni(s|z)ed escape sequence '\\\]'/)
end
it 'ignores warnings about storeconfigs' do
files = fixture_manifests('pass_storeconfigs.pp')
output, has_errors = subject.check(files)
expect(output).to eq([])
expect(has_errors).to eq(false)
end
it 'reads more than one valid file' do
files = fixture_manifests(['pass.pp', 'pass_storeconfigs.pp'])
output, has_errors = subject.check(files)
expect(output).to eq([])
expect(has_errors).to eq(false)
end
it 'continues after finding an error in the first file' do
files = fixture_manifests(['fail_error.pp', 'fail_warning.pp'])
output, has_errors = subject.check(files)
expect(has_errors).to eq(true)
expect(output.size).to eq(5)
expect(output[0]).to match(%r{This Name has no effect. A Host Class Definition can not end with a value-producing expression without other effect \(file: \S*/fail_error.pp, line: 2, column: 32\)$})
expect(output[1]).to match(%r{This Name has no effect. A value was produced and then forgotten \(one or more preceding expressions may have the wrong form\) \(file: \S*/fail_error.pp, line: 2, column: 3\)$})
expect(output[2]).to match('2 errors. Giving up')
expect(output[3]).to match(/Unrecogni(s|z)ed escape sequence '\\\['/)
expect(output[4]).to match(/Unrecogni(s|z)ed escape sequence '\\\]'/)
end
describe 'deprecation notices' do
it 'insteads be failures' do
files = fixture_manifests('deprecation_notice.pp')
output, has_errors = subject.check(files)
expect(has_errors).to eq(true)
expect(output.size).to eq(1)
expect(output[0]).to match(/Node inheritance is not supported in Puppet >= 4.0.0/)
end
end
end
|
