1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
|
require 'puppetserver/ca/action/import'
require 'puppetserver/ca/utils/config'
require 'utils/ssl'
def mode(file)
File.stat(file).mode.to_s(8)[-3..-1]
end
def default_config(conf, bundle, key, chain)
shared_flags = {'config' => conf, 'subject-alt-names' => '', 'certname' => 'foocert'}
import_flags = {'cert-bundle' => bundle, 'private-key' => key, 'crl-chain' => chain}
importing ? shared_flags.merge(import_flags) : shared_flags.merge({'ca-name' => '', 'root-ca-name' => ''})
end
def flags_without_sans(*args)
config = default_config(*args)
config.flat_map{|k,v| k =~ /subject-alt-names/ ? [] : ["--#{k}", v] }
end
RSpec.shared_examples 'properly sets up ca and ssl dir' do |action_class|
include Utils::SSL
let(:importing) { action_class == Puppetserver::Ca::Action::Import }
it 'creates all files with correct permissions' do
Dir.mktmpdir do |tmpdir|
with_files_in_default_dirs tmpdir do |bundle, key, chain, conf|
setup = action_class.new(logger)
config = default_config(conf, bundle, key, chain)
exit_code = setup.run(config)
expect(exit_code).to eq(0)
ca_files = [['ca', 'ca_crt.pem', '644'],
['ca', 'ca_crl.pem', '644'],
['ca', 'ca_key.pem', '640'],
['ca', 'ca_pub.pem', '644'],
['ca', 'infra_crl.pem', '644'],
['ca', 'inventory.txt', '644'],
['ca', 'infra_inventory.txt', '644'],
['ca', 'serial', '644'],
['ca', 'infra_serials', '644']]
ssl_files = [['ssl', 'certs', 'foocert.pem', '644'],
['ssl', 'private_keys', 'foocert.pem', '640'],
['ssl', 'public_keys', 'foocert.pem', '644']]
confdir = File.join(tmpdir, 'puppet')
ca_files.each do |args|
perms = args.pop
file = File.join(Puppetserver::Ca::Utils::Config.puppetserver_confdir(confdir), *args)
expect(File.exist?(file)).to be(true), "#{file} does not exist"
expect(mode(file)).to eq(perms)
end
ssl_files.each do |args|
perms = args.pop
file = File.join(confdir, *args)
expect(File.exist?(file)).to be(true), "#{file} does not exist"
expect(mode(file)).to eq(perms)
end
old_cadir = Puppetserver::Ca::Utils::Config.old_default_cadir(confdir)
new_cadir = Puppetserver::Ca::Utils::Config.new_default_cadir(confdir)
expect(File.symlink?(old_cadir)).to be(true), "#{old_cadir} is not a symlink"
expect(File.readlink(old_cadir)).to eq(new_cadir)
unless importing
file = File.join(new_cadir, 'root_key.pem')
expect(File.exist?(file)).to be(true), "#{file} does not exist"
expect(mode(file)).to eq('640')
end
end
end
end
it 'accepts unprefixed alt names' do
Dir.mktmpdir do |tmpdir|
with_files_in tmpdir do |bundle, key, chain, conf|
flags = flags_without_sans(bundle, key, chain, conf)
result, maybe_code = subject.parse(flags + ['--subject-alt-names', 'foo.com'])
expect(maybe_code).to eq(nil)
expect(result['subject-alt-names']).to eq('foo.com')
end
end
end
it 'accepts DNS and IP alt names' do
Dir.mktmpdir do |tmpdir|
with_files_in tmpdir do |bundle, key, chain, conf|
flags = flags_without_sans(bundle, key, chain, conf)
result, maybe_code = subject.parse(flags + ['--subject-alt-names', 'DNS:foo.com,IP:123.456.789'])
expect(maybe_code).to eq(nil)
expect(result['subject-alt-names']).to eq('DNS:foo.com,IP:123.456.789')
end
end
end
it 'adds default subject alt names to the server cert' do
Dir.mktmpdir do |tmpdir|
with_files_in tmpdir do |bundle, key, chain, conf|
config = default_config(conf, bundle, key, chain)
exit_code = subject.run(config)
expect(exit_code).to eq(0)
server_cert_file = File.join(tmpdir, 'ssl', 'certs', 'foocert.pem')
expect(File.exist?(server_cert_file)).to be true
server_cert = OpenSSL::X509::Certificate.new(File.read(server_cert_file))
alt_names = server_cert.extensions.find do |ext|
ext.to_s =~ /subjectAltName/
end
expect(alt_names.to_s).to eq("subjectAltName = DNS:puppet, DNS:foocert")
end
end
end
it 'adds custom subject alt names to the server cert' do
Dir.mktmpdir do |tmpdir|
with_files_in tmpdir do |bundle, key, chain, conf|
config = default_config(conf, bundle, key, chain)
exit_code = subject.run(config.merge({'subject-alt-names' => 'bar.net,IP:123.123.0.1'}))
expect(exit_code).to eq(0)
server_cert_file = File.join(tmpdir, 'ssl', 'certs', 'foocert.pem')
expect(File.exist?(server_cert_file)).to be true
server_cert = OpenSSL::X509::Certificate.new(File.read(server_cert_file))
alt_names = server_cert.extensions.find do |ext|
ext.to_s =~ /subjectAltName/
end
expect(alt_names.to_s).to eq("subjectAltName = DNS:foocert, DNS:bar.net, IP Address:123.123.0.1")
end
end
end
it 'will not overwrite existing CA files' do
Dir.mktmpdir do |tmpdir|
with_files_in tmpdir do |bundle, key, chain, conf|
config = default_config(conf, bundle, key, chain)
exit_code = subject.run(config)
expect(exit_code).to eq(0)
exit_code2 = subject.run(config)
expect(exit_code2).to eq(1)
expect(stderr.string).to match(/Existing file.*/)
expect(stderr.string).to match(/.*please delete the existing files.*/)
end
end
end
it 'honors existing server key pair when generating servers cert' do
Dir.mktmpdir do |tmpdir|
with_files_in tmpdir do |bundle, key, chain, conf|
private_path = File.join(tmpdir, 'ssl', 'private_keys', 'foocert.pem')
public_path = File.join(tmpdir, 'ssl', 'public_keys', 'foocert.pem')
cert_path = File.join(tmpdir, 'ssl', 'certs', 'foocert.pem')
FileUtils.mkdir_p(File.dirname(private_path))
FileUtils.mkdir_p(File.dirname(public_path))
pkey = OpenSSL::PKey::RSA.new(512)
File.write(private_path, pkey.to_pem)
File.write(public_path, pkey.public_key.to_pem)
config = default_config(conf, bundle, key, chain)
exit_code = subject.run(config)
expect(exit_code).to eq(0)
expect(File.exist?(File.join(cert_path))).to be true
expect(File.read(private_path)).to eq pkey.to_pem
expect(File.read(public_path)).to eq pkey.public_key.to_pem
cert = OpenSSL::X509::Certificate.new(File.read(cert_path))
expect(cert.public_key.to_pem).to eq pkey.public_key.to_pem
expect(cert.check_private_key(pkey)).to be true
end
end
end
it 'fails if only one of servers public, private keys are present' do
Dir.mktmpdir do |tmpdir|
with_files_in tmpdir do |bundle, key, chain, conf|
pkey = OpenSSL::PKey::RSA.new(512)
private_path = File.join(tmpdir, 'ssl', 'private_keys', 'foocert.pem')
FileUtils.mkdir_p File.dirname(private_path)
File.write(private_path, pkey.to_pem)
config = default_config(conf, bundle, key, chain)
exit_code = subject.run(config)
expect(exit_code).to eq(1)
expect(stderr.string).to match(/Missing public key/)
end
end
Dir.mktmpdir do |tmpdir|
with_files_in tmpdir do |bundle, key, chain, conf|
pkey = OpenSSL::PKey::RSA.new(512)
public_path = File.join(tmpdir, 'ssl', 'public_keys', 'foocert.pem')
FileUtils.mkdir_p File.dirname(public_path)
File.write(public_path, pkey.public_key.to_pem)
config = default_config(conf, bundle, key, chain)
exit_code = subject.run(config)
expect(exit_code).to eq(1)
expect(stderr.string).to match(/Missing private key/)
end
end
end
end
|
