1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508
|
RSpec.describe "have_http_status" do
def create_response(opts = {})
ActionDispatch::TestResponse.new(opts.fetch(:status)).tap { |x|
x.request = ActionDispatch::Request.new({})
}
end
shared_examples_for "supports different response instances" do
context "given an ActionDispatch::Response" do
it "returns true for a response with the same code" do
response = ::ActionDispatch::Response.new(code).tap { |x|
x.request = ActionDispatch::Request.new({})
}
expect(matcher.matches?(response)).to be(true)
end
end
context "given a Rack::MockResponse" do
it "returns true for a response with the same code" do
response = ::Rack::MockResponse.new(code, {}, "")
expect(matcher.matches?(response)).to be(true)
end
end
context "given an ActionDispatch::TestResponse" do
it "returns true for a response with the same code" do
response = ::ActionDispatch::TestResponse.new(code).tap { |x|
x.request = ActionDispatch::Request.new({})
}
expect(matcher.matches?(response)).to be(true)
end
end
context "given something that acts as a Capybara::Session" do
it "returns true for a response with the same code" do
response = instance_double(
'::Capybara::Session',
status_code: code,
response_headers: {},
body: ""
)
expect(matcher.matches?(response)).to be(true)
end
end
it "returns false given another type" do
response = Object.new
expect(matcher.matches?(response)).to be(false)
end
it "has a failure message reporting it was given another type" do
response = Object.new
expect { matcher.matches?(response) }
.to change(matcher, :failure_message)
.to("expected a response object, but an instance of Object was received")
end
it "has a negated failure message reporting it was given another type" do
response = Object.new
expect { matcher.matches?(response) }
.to change(matcher, :failure_message_when_negated)
.to("expected a response object, but an instance of Object was received")
end
end
context "with a numeric status code" do
it_behaves_like "supports different response instances" do
subject(:matcher) { have_http_status(code) }
let(:code) { 209 }
end
describe "matching a response" do
it "returns true for a response with the same code" do
any_numeric_code = 209
have_numeric_code = have_http_status(any_numeric_code)
response = create_response(status: any_numeric_code)
expect(have_numeric_code.matches?(response)).to be(true)
end
it "returns false for a response with a different code" do
any_numeric_code = 209
have_numeric_code = have_http_status(any_numeric_code)
response = create_response(status: any_numeric_code + 1)
expect(have_numeric_code.matches?(response)).to be(false)
end
end
it "describes responding with the numeric status code" do
any_numeric_code = 209
have_numeric_code = have_http_status(any_numeric_code)
expect(have_numeric_code.description)
.to eq("respond with numeric status code 209")
end
it "has a failure message reporting the expected and actual status codes" do
any_numeric_code = 209
have_numeric_code = have_http_status(any_numeric_code)
response = create_response(status: any_numeric_code + 1)
expect { have_numeric_code.matches? response }
.to change(have_numeric_code, :failure_message)
.to("expected the response to have status code 209 but it was 210")
end
it "has a negated failure message reporting the expected status code" do
any_numeric_code = 209
have_numeric_code = have_http_status(any_numeric_code)
expect(have_numeric_code.failure_message_when_negated)
.to eq("expected the response not to have status code 209 but it did")
end
end
context "with a symbolic status" do
# :created => 201 status code
# see https://guides.rubyonrails.org/layouts_and_rendering.html#the-status-option
let(:created_code) { 201 }
let(:created_symbolic_status) { :created }
it_behaves_like "supports different response instances" do
subject(:matcher) { have_http_status(created_symbolic_status) }
let(:code) { created_code }
end
describe "matching a response" do
it "returns true for a response with the equivalent code" do
any_symbolic_status = created_symbolic_status
have_symbolic_status = have_http_status(any_symbolic_status)
response = create_response(status: created_code)
expect(have_symbolic_status.matches?(response)).to be(true)
end
it "returns false for a response with a different code" do
any_symbolic_status = created_symbolic_status
have_symbolic_status = have_http_status(any_symbolic_status)
response = create_response(status: created_code + 1)
expect(have_symbolic_status.matches?(response)).to be(false)
end
end
it "describes responding by the symbolic and associated numeric status code" do
any_symbolic_status = created_symbolic_status
have_symbolic_status = have_http_status(any_symbolic_status)
expect(have_symbolic_status.description)
.to eq("respond with status code :created (201)")
end
it "has a failure message reporting the expected and actual statuses" do
any_symbolic_status = created_symbolic_status
have_symbolic_status = have_http_status(any_symbolic_status)
response = create_response(status: created_code + 1)
expect { have_symbolic_status.matches? response }
.to change(have_symbolic_status, :failure_message)
.to("expected the response to have status code :created (201) but it was :accepted (202)")
end
it "has a negated failure message reporting the expected status code" do
any_symbolic_status = created_symbolic_status
have_symbolic_status = have_http_status(any_symbolic_status)
expect(have_symbolic_status.failure_message_when_negated)
.to eq("expected the response not to have status code :created (201) but it did")
end
it "raises an ArgumentError" do
expect { have_http_status(:not_a_status) }.to raise_error ArgumentError
end
end
shared_examples_for 'status code matcher' do
# within the calling block, define:
# let(:expected_code) { <value> } # such as 555, 444, 333, 222
# let(:other_code) { <value> } # such as 555, 444, 333, 222
# let(:failure_message) {
# /an error status code \(5xx\) but it was 400/
# } # for example
# let(:negated_message) {
# /not to have an error status code \(5xx\) but it was 555/
# } # for example
# let(:description) {
# 'respond with an error status code (5xx)'
# } # for example
# subject(:matcher) { <matcher> } # e.g. { have_http_status(:error) }
describe "matching a response" do
it "returns true for a response with code" do
response = create_response(status: expected_code)
expect(matcher.matches?(response)).to be(true)
end
it "returns false for a response with a different code" do
response = create_response(status: other_code)
expect(matcher.matches?(response)).to be(false)
end
end
it "describes #{description}" do
expect(matcher.description).to eq(description)
end
it "has a failure message reporting the expected and actual status codes" do
response = create_response(status: other_code)
expect { matcher.matches? response }
.to change(matcher, :failure_message)
.to(failure_message)
end
it "has a negated failure message reporting the expected and actual status codes" do
response = create_response(status: expected_code)
expect { matcher.matches? response }
.to change(matcher, :failure_message_when_negated)
.to(negated_message)
end
end
context "with general status code group", ":error" do
# The error query is an alias for `server_error?`:
#
# - https://github.com/rails/rails/blob/ca200378/actionpack/lib/action_dispatch/testing/test_response.rb#L27
# - https://github.com/rails/rails/blob/main/actionpack/lib/action_dispatch/testing/test_response.rb
#
# `server_error?` is part of the Rack Helpers and is defined as:
#
# status >= 500 && status < 600
#
# See:
#
# - https://github.com/rack/rack/blob/ce4a3959/lib/rack/response.rb#L122
# - https://github.com/rack/rack/blob/master/lib/rack/response.rb
subject(:matcher) { have_http_status(:error) }
it_behaves_like 'status code matcher' do
let(:expected_code) { 555 }
let(:other_code) { 400 }
let(:failure_message) { /an error status code \(5xx\) but it was 400/ }
let(:negated_message) {
/not to have an error status code \(5xx\) but it was 555/
}
let(:description) {
'respond with an error status code (5xx)'
}
end
it_behaves_like "supports different response instances" do
let(:code) { 555 }
end
end
context "with general status code group", ":server_error" do
subject(:matcher) { have_http_status(:server_error) }
it_behaves_like 'status code matcher' do
let(:expected_code) { 555 }
let(:other_code) { 400 }
let(:failure_message) { /a server_error status code \(5xx\) but it was 400/ }
let(:negated_message) {
/not to have a server_error status code \(5xx\) but it was 555/
}
let(:description) {
'respond with a server_error status code (5xx)'
}
end
it_behaves_like "supports different response instances" do
let(:code) { 555 }
end
end
context "with general status code group", ":success" do
# The success query is an alias for `successful?`:
#
# - https://github.com/rails/rails/blob/ca200378/actionpack/lib/action_dispatch/testing/test_response.rb#L18
# - https://github.com/rails/rails/blob/main/actionpack/lib/action_dispatch/testing/test_response.rb
#
# `successful?` is part of the Rack Helpers and is defined as:
#
# status >= 200 && status < 300
#
# See:
#
# - https://github.com/rack/rack/blob/ce4a3959/lib/rack/response.rb#L119
# - https://github.com/rack/rack/blob/master/lib/rack/response.rb
subject(:matcher) { have_http_status(:success) }
it_behaves_like 'status code matcher' do
let(:expected_code) { 222 }
let(:other_code) { 400 }
let(:failure_message) {
/a success status code \(2xx\) but it was 400/
}
let(:negated_message) {
/not to have a success status code \(2xx\) but it was 222/
}
let(:description) {
'respond with a success status code (2xx)'
}
end
it_behaves_like "supports different response instances" do
let(:code) { 222 }
end
end
context "with general status code group", ":successful" do
subject(:matcher) { have_http_status(:successful) }
it_behaves_like 'status code matcher' do
let(:expected_code) { 222 }
let(:other_code) { 400 }
let(:failure_message) {
/a successful status code \(2xx\) but it was 400/
}
let(:negated_message) {
/not to have a successful status code \(2xx\) but it was 222/
}
let(:description) {
'respond with a successful status code (2xx)'
}
end
it_behaves_like "supports different response instances" do
let(:code) { 222 }
end
end
context "with general status code group", ":missing" do
# The missing query is an alias for `not_found?`:
#
# - https://github.com/rails/rails/blob/ca200378/actionpack/lib/action_dispatch/testing/test_response.rb#L21
# - https://github.com/rails/rails/blob/main/actionpack/lib/action_dispatch/testing/test_response.rb
#
# `not_found?` is part of the Rack Helpers and is defined as:
#
# status == 404
#
# See:
#
# - https://github.com/rack/rack/blob/ce4a3959/lib/rack/response.rb#L130
# - https://github.com/rack/rack/blob/master/lib/rack/response.rb
subject(:matcher) { have_http_status(:missing) }
it_behaves_like 'status code matcher' do
let(:expected_code) { 404 }
let(:other_code) { 400 }
let(:failure_message) {
/a missing status code \(404\) but it was 400/
}
let(:negated_message) {
/not to have a missing status code \(404\) but it was 404/
}
let(:description) {
'respond with a missing status code (404)'
}
end
it_behaves_like "supports different response instances" do
let(:code) { 404 }
end
end
context "with general status code group", ":not_found" do
subject(:matcher) { have_http_status(:not_found) }
it_behaves_like 'status code matcher' do
let(:expected_code) { 404 }
let(:other_code) { 400 }
let(:failure_message) {
/a not_found status code \(404\) but it was 400/
}
let(:negated_message) {
/not to have a not_found status code \(404\) but it was 404/
}
let(:description) {
'respond with a not_found status code (404)'
}
end
it_behaves_like "supports different response instances" do
subject(:matcher) { have_http_status(:not_found) }
let(:code) { 404 }
end
end
context "with general status code group", ":redirect" do
# The redirect query is an alias for `redirection?`:
#
# - https://github.com/rails/rails/blob/ca200378/actionpack/lib/action_dispatch/testing/test_response.rb#L24
# - https://github.com/rails/rails/blob/main/actionpack/lib/action_dispatch/testing/test_response.rb
#
# `redirection?` is part of the Rack Helpers and is defined as:
#
# status >= 300 && status < 400
#
# See:
#
# - https://github.com/rack/rack/blob/ce4a3959/lib/rack/response.rb#L120
# - https://github.com/rack/rack/blob/master/lib/rack/response.rb
subject(:matcher) { have_http_status(:redirect) }
it_behaves_like 'status code matcher' do
let(:expected_code) { 308 }
let(:other_code) { 400 }
let(:failure_message) {
/a redirect status code \(3xx\) but it was 400/
}
let(:negated_message) {
/not to have a redirect status code \(3xx\) but it was 308/
}
let(:description) {
'respond with a redirect status code (3xx)'
}
end
it_behaves_like "supports different response instances" do
let(:code) { 308 }
end
end
context "with a nil status" do
it "raises an ArgumentError" do
expect { have_http_status(nil) }.to raise_error ArgumentError
end
end
shared_examples_for "does not use deprecated methods for Rails 5.2+" do
it "does not use deprecated method for Rails >= 5.2" do
previous_stderr = $stderr
begin
splitter = RSpec::Support::StdErrSplitter.new(previous_stderr)
$stderr = splitter
response = ::ActionDispatch::Response.new(code).tap { |x|
x.request = ActionDispatch::Request.new({})
}
expect(matcher.matches?(response)).to be(true)
expect(splitter.has_output?).to be false
ensure
$stderr = previous_stderr
end
end
end
context 'http status :missing' do
it_behaves_like "does not use deprecated methods for Rails 5.2+" do
subject(:matcher) { have_http_status(:missing) }
let(:code) { 404 }
end
end
context 'http status :success' do
it_behaves_like "does not use deprecated methods for Rails 5.2+" do
subject(:matcher) { have_http_status(:success) }
let(:code) { 222 }
end
end
context 'http status :error' do
it_behaves_like "does not use deprecated methods for Rails 5.2+" do
subject(:matcher) { have_http_status(:error) }
let(:code) { 555 }
end
end
context 'http status :not_found' do
it_behaves_like "supports different response instances" do
subject(:matcher) { have_http_status(:not_found) }
let(:code) { 404 }
end
end
context 'http status :successful' do
it_behaves_like "supports different response instances" do
subject(:matcher) { have_http_status(:successful) }
let(:code) { 222 }
end
end
context 'http status :server_error' do
it_behaves_like "supports different response instances" do
subject(:matcher) { have_http_status(:server_error) }
let(:code) { 555 }
end
end
context 'with deprecated rack status codes' do
it 'supports the original names' do
expect(create_response(status: 422)).to have_http_status(:unprocessable_entity)
end
end
end
|