1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
|
require 'rspec/expectations/block_snippet_extractor'
module RSpec::Expectations
RSpec.describe BlockSnippetExtractor, :if => RSpec::Support::RubyFeatures.ripper_supported? do
subject(:extractor) do
BlockSnippetExtractor.new(proc_object, 'target_method')
end
let(:proc_object) do
@proc_object
end
def target_method(*, &block)
@proc_object = block
end
def another_method(*)
end
before do
expression
end
describe '.try_extracting_single_line_body_of' do
subject(:try_extracting_single_line_body) do
BlockSnippetExtractor.try_extracting_single_line_body_of(proc_object, 'target_method')
end
context 'with a single line body block' do
let(:expression) do
target_method { 1.positive? }
end
it 'returns the body' do
expect(try_extracting_single_line_body).to eq('1.positive?')
end
end
context 'with a multiline body block' do
let(:expression) do
target_method do
1.positive?
2.negative?
end
end
it 'returns nil' do
expect(try_extracting_single_line_body).to be_nil
end
end
context 'when the block snippet cannot be extracted due to ambiguity' do
let(:expression) do
target_method { 1.positive? }; dummy_object.target_method { 2.negative? }
end
let(:dummy_object) do
double('dummy_object', :target_method => nil)
end
it 'returns nil' do
expect(try_extracting_single_line_body).to be_nil
end
end
end
describe '#body_content_lines' do
subject(:body_content_lines) do
extractor.body_content_lines
end
context 'with `target_method {}`' do
let(:expression) do
target_method {}
end
it 'returns empty lines' do
expect(body_content_lines).to eq([])
end
end
context 'with `target_method { body }`' do
let(:expression) do
target_method { 1.positive? }
end
it 'returns the body content lines' do
expect(body_content_lines).to eq(['1.positive?'])
end
end
context 'with `target_method do body end`' do
let(:expression) do
target_method do 1.positive? end
end
it 'returns the body content lines' do
expect(body_content_lines).to eq(['1.positive?'])
end
end
context 'with `target_method { |arg1, arg2| body }`' do
let(:expression) do
target_method { |arg1, arg2| 1.positive? }
end
it 'returns the body content lines' do
expect(body_content_lines).to eq(['1.positive?'])
end
end
context 'with `target_method(:arg1, :arg2) { body }`' do
let(:expression) do
target_method(:arg1, :arg2) { 1.positive? }
end
it 'returns the body content lines' do
expect(body_content_lines).to eq(['1.positive?'])
end
end
context 'with `target_method(:arg1,:arg2){|arg1,arg2|body}`' do
let(:expression) do
target_method(:arg1,:arg2){|arg1,arg2|1.positive?}
end
it 'returns the body content lines' do
expect(body_content_lines).to eq(['1.positive?'])
end
end
context 'with a multiline block containing a single line body' do
let(:expression) do
target_method do
1.positive?
end
end
it 'returns the body content lines' do
expect(body_content_lines).to eq(['1.positive?'])
end
end
context 'with a multiline body block' do
let(:expression) do
target_method do
1.positive?
2.negative?
end
end
it 'returns the body content lines' do
expect(body_content_lines).to eq([
'1.positive?',
'2.negative?'
])
end
end
context 'with `target_method { { :key => "value" } }`' do
let(:expression) do
target_method { { :key => "value" } }
end
it 'does not confuse the hash curly with the block closer' do
expect(body_content_lines).to eq(['{ :key => "value" }'])
end
end
context 'with a do-end block containing another do-end block' do
let(:expression) do
target_method do
2.times do |index|
puts index
end
end
end
it 'does not confuse the inner `end` with the outer `end`' do
expect(body_content_lines).to eq([
'2.times do |index|',
'puts index',
'end'
])
end
end
context "when there's another method invocation on the same line before the target" do
let(:expression) do
another_method { 2.negative? }; target_method { 1.positive? }
end
it 'correctly extracts the target snippet' do
expect(body_content_lines).to eq(['1.positive?'])
end
end
context "when there's another method invocation on the same line after the target" do
let(:expression) do
target_method { 1.positive? }; another_method { 2.negative? }
end
it 'correctly extracts the target snippet' do
expect(body_content_lines).to eq(['1.positive?'])
end
end
context "when there's another method invocation with the same name on the same line before the target" do
let(:expression) do
dummy_object.target_method { 2.negative? }; target_method { 1.positive? }
end
let(:dummy_object) do
double('dummy_object', :target_method => nil)
end
it 'raises AmbiguousTargetError' do
expect { body_content_lines }.to raise_error(BlockSnippetExtractor::AmbiguousTargetError)
end
end
context "when there's another method invocation with the same name on the same line after the target" do
let(:expression) do
target_method { 1.positive? }; dummy_object.target_method { 2.negative? }
end
let(:dummy_object) do
double('dummy_object', :target_method => nil)
end
it 'raises AmbiguousTargetError' do
expect { body_content_lines }.to raise_error(BlockSnippetExtractor::AmbiguousTargetError)
end
end
context "when there's another method invocation with the same name without block on the same line before the target" do
let(:expression) do
dummy_object.target_method; target_method { 1.positive? }
end
let(:dummy_object) do
double('dummy_object', :target_method => nil)
end
it 'correctly extracts the target snippet' do
expect(body_content_lines).to eq(['1.positive?'])
end
end
context "when there's another method invocation with the same name without block on the same line after the target" do
let(:expression) do
target_method { 1.positive? }; dummy_object.target_method
end
let(:dummy_object) do
double('dummy_object', :target_method => nil)
end
it 'correctly extracts the target snippet' do
expect(body_content_lines).to eq(['1.positive?'])
end
end
context 'when a hash is given as an argument' do
let(:expression) do
target_method({ :key => "value" }) { 1.positive? }
end
it 'correctly extracts the target snippet' do
expect(body_content_lines).to eq(['1.positive?'])
end
end
context 'when another method invocation with block is given as an argument' do
let(:expression) do
target_method(another_method { 2.negative? }) { 1.positive? }
end
it 'correctly extracts the target snippet' do
expect(body_content_lines).to eq(['1.positive?'])
end
end
context "when the block literal is described on different line with the method invocation" do
let(:expression) do
block = proc { 1.positive? }
target_method(&block)
end
it 'raises TargetNotFoundError' do
expect { body_content_lines }.to raise_error(BlockSnippetExtractor::TargetNotFoundError)
end
end
context 'with &:symbol syntax' do
let(:expression) do
target_method(&:positive?)
end
it 'raises TargetNotFoundError' do
expect { body_content_lines }.to raise_error(BlockSnippetExtractor::TargetNotFoundError)
end
end
end
end
end
|
