1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467
|
# frozen_string_literal: true
RSpec.describe RuboCop::AST::ProcessedSource do
subject(:processed_source) { described_class.new(source, ruby_version, path) }
let(:source) { <<~RUBY }
# an awesome method
def some_method
puts 'foo'
end
some_method
RUBY
let(:path) { 'ast/and_node_spec.rb' }
shared_context 'invalid encoding source' do
let(:source) { "# \xf9" }
end
describe '.from_file' do
describe 'when the file exists' do
around do |example|
org_pwd = Dir.pwd
Dir.chdir("#{__dir__}/..")
example.run
Dir.chdir(org_pwd)
end
let(:processed_source) { described_class.from_file(path, ruby_version) }
it 'returns an instance of ProcessedSource' do
expect(processed_source.is_a?(described_class)).to be(true)
end
it "sets the file path to the instance's #path" do
expect(processed_source.path).to eq(path)
end
end
it 'raises a Errno::ENOENT when the file does not exist' do
expect do
described_class.from_file('foo', ruby_version)
end.to raise_error(Errno::ENOENT)
end
end
describe '#path' do
it 'is the path passed to .new' do
expect(processed_source.path).to eq(path)
end
end
describe '#buffer' do
it 'is a source buffer' do
expect(processed_source.buffer.is_a?(Parser::Source::Buffer)).to be(true)
end
end
describe '#ast' do
it 'is the root node of AST' do
expect(processed_source.ast.is_a?(RuboCop::AST::Node)).to be(true)
end
end
describe '#comments' do
it 'is an array of comments' do
expect(processed_source.comments.is_a?(Array)).to be(true)
expect(
processed_source.comments.first.is_a?(Parser::Source::Comment)
).to be(true)
end
context 'when the source is invalid' do
include_context 'invalid encoding source'
it 'returns []' do
expect(processed_source.comments).to eq []
end
end
end
describe '#tokens' do
it 'has an array of tokens' do
expect(processed_source.tokens.is_a?(Array)).to be(true)
expect(processed_source.tokens.first.is_a?(RuboCop::AST::Token)).to be(true)
end
end
describe '#parser_error' do
context 'when the source was properly parsed' do
it 'is nil' do
expect(processed_source.parser_error.nil?).to be(true)
end
end
context 'when the source lacks encoding comment and is really utf-8 ' \
'encoded but has been read as US-ASCII' do
let(:source) do
# When files are read into RuboCop, the encoding of source code
# lacking an encoding comment will default to the external encoding,
# which could for example be US-ASCII if the LC_ALL environment
# variable is set to "C".
(+'号码 = 3').force_encoding('US-ASCII')
end
it 'is nil' do
# ProcessedSource#parse sets UTF-8 as default encoding, so no error.
expect(processed_source.parser_error.nil?).to be(true)
end
end
context 'when the source could not be parsed due to encoding error' do
include_context 'invalid encoding source'
it 'returns the error' do
expect(processed_source.parser_error.is_a?(Exception)).to be(true)
expect(processed_source.parser_error.message)
.to include('invalid byte sequence')
end
end
end
describe '#lines' do
it 'is an array' do
expect(processed_source.lines.is_a?(Array)).to be(true)
end
it 'has same number of elements as line count' do
# Since the source has a trailing newline, there is a final empty line
expect(processed_source.lines.size).to eq(6)
end
it 'contains lines as string without linefeed' do
first_line = processed_source.lines.first
expect(first_line).to eq('# an awesome method')
end
end
describe '#[]' do
context 'when an index is passed' do
it 'returns the line' do
expect(processed_source[3]).to eq('end')
end
end
context 'when a range is passed' do
it 'returns the array of lines' do
expect(processed_source[3..4]).to eq(%w[end some_method])
end
end
context 'when start index and length are passed' do
it 'returns the array of lines' do
expect(processed_source[3, 2]).to eq(%w[end some_method])
end
end
end
describe 'valid_syntax?' do
subject { processed_source.valid_syntax? }
context 'when the source is completely valid' do
let(:source) { 'def valid_code; end' }
it 'returns true' do
expect(processed_source.diagnostics.empty?).to be(true)
expect(processed_source.valid_syntax?).to be(true)
end
end
context 'when the source is invalid' do
let(:source) { 'def invalid_code; en' }
it 'returns false' do
expect(processed_source.valid_syntax?).to be(false)
end
end
context 'when the source is valid but has some warning diagnostics' do
let(:source) { 'do_something *array' }
it 'returns true' do
expect(processed_source.diagnostics.empty?).to be(false)
expect(processed_source.diagnostics.first.level).to eq(:warning)
expect(processed_source.valid_syntax?).to be(true)
end
end
context 'when the source could not be parsed due to encoding error' do
include_context 'invalid encoding source'
it 'returns false' do
expect(processed_source.valid_syntax?).to be(false)
end
end
# https://github.com/whitequark/parser/issues/283
context 'when the source itself is valid encoding but includes strange ' \
'encoding literals that are accepted by MRI' do
let(:source) do
'p "\xff"'
end
it 'returns true' do
expect(processed_source.diagnostics.empty?).to be(true)
expect(processed_source.valid_syntax?).to be(true)
end
end
context 'when a line starts with an integer literal' do
let(:source) { '1 + 1' }
# regression test
it 'tokenizes the source correctly' do
expect(processed_source.tokens[0].text).to eq '1'
end
end
end
context 'with heavily commented source' do
let(:source) { <<~RUBY }
# comment one
[ 1,
{ a: 2,
b: 3 # comment two
}
]
RUBY
describe '#each_comment' do
it 'yields all comments' do
comments = []
processed_source.each_comment do |item|
expect(item.is_a?(Parser::Source::Comment)).to be true
comments << item
end
expect(comments.size).to eq 2
end
end
describe '#find_comment' do
it 'yields correct comment' do
comment = processed_source.find_comment do |item|
item.text == '# comment two'
end
expect(comment.text).to eq '# comment two'
end
it 'yields nil when there is no match' do
comment = processed_source.find_comment do |item|
item.text == '# comment four'
end
expect(comment).to eq nil
end
end
describe '#comment_at_line' do
it 'returns the comment at the given line number' do
expect(processed_source.comment_at_line(1).text).to eq '# comment one'
expect(processed_source.comment_at_line(4).text).to eq '# comment two'
end
it 'returns nil if line has no comment' do
expect(processed_source.comment_at_line(3)).to be nil
end
end
describe '#each_comment_in_lines' do
it 'yields the comments' do
enum = processed_source.each_comment_in_lines(1..4)
expect(enum.is_a?(Enumerable)).to be(true)
expect(enum.to_a).to eq processed_source.comments
expect(processed_source.each_comment_in_lines(2..5).map(&:text)).to eq ['# comment two']
end
end
describe '#line_with_comment?' do
it 'returns true for lines with comments' do
expect(processed_source.line_with_comment?(1)).to be true
expect(processed_source.line_with_comment?(4)).to be true
end
it 'returns false for lines without comments' do
expect(processed_source.line_with_comment?(2)).to be false
expect(processed_source.line_with_comment?(5)).to be false
end
end
describe '#contains_comment?' do
subject(:commented) { processed_source.contains_comment?(range) }
let(:ast) { processed_source.ast }
let(:array) { ast }
let(:hash) { array.children[1] }
context 'provided source_range on line without comment' do
let(:range) { hash.pairs.first.loc.expression }
it { is_expected.to be false }
end
context 'provided source_range on comment line' do
let(:range) { processed_source.find_token(&:comment?).pos }
it { is_expected.to be true }
end
context 'provided source_range on line with comment' do
let(:range) { hash.pairs.last.loc.expression }
it { is_expected.to be true }
end
context 'provided a multiline source_range with at least one line with comment' do
let(:range) { array.loc.expression }
it { is_expected.to be true }
end
end
describe '#comments_before_line' do
let(:source) { <<~RUBY }
# comment one
# comment two
[ 1, 2 ]
# comment three
RUBY
it 'returns comments on or before given line' do
expect(processed_source.comments_before_line(1).size).to eq 1
expect(processed_source.comments_before_line(2).size).to eq 2
expect(processed_source.comments_before_line(3).size).to eq 2
expect(processed_source.comments_before_line(4).size).to eq 3
expect(processed_source.comments_before_line(1)
.first
.is_a?(Parser::Source::Comment)).to be true
end
end
end
context 'token enumerables' do
let(:source) { <<~RUBY }
foo(1, 2)
RUBY
describe '#each_token' do
it 'yields all tokens' do
tokens = []
processed_source.each_token do |item|
expect(item.is_a?(RuboCop::AST::Token)).to be true
tokens << item
end
expect(tokens.size).to eq 7
end
end
describe '#find_token' do
it 'yields correct token' do
token = processed_source.find_token(&:comma?)
expect(token.text).to eq ','
end
it 'yields nil when there is no match' do
token = processed_source.find_token(&:right_bracket?)
expect(token).to eq nil
end
end
end
describe '#file_path' do
it 'returns file path' do
expect(processed_source.file_path).to eq path
end
end
describe '#blank?' do
context 'with source of no content' do
let(:source) { <<~RUBY }
RUBY
it 'returns true' do
expect(processed_source.blank?).to eq true
end
end
context 'with source with content' do
let(:source) { <<~RUBY }
foo
RUBY
it 'returns false' do
expect(processed_source.blank?).to eq false
end
end
end
describe '#start_with?' do
context 'with blank source' do
let(:source) { <<~RUBY }
RUBY
it 'returns false' do
expect(processed_source.start_with?('start')).to eq false
expect(processed_source.start_with?('#')).to eq false
expect(processed_source.start_with?('')).to eq false
end
end
context 'with present source' do
let(:source) { <<~RUBY }
foo
RUBY
it 'returns true when passed string that starts source' do
expect(processed_source.start_with?('foo')).to eq true
expect(processed_source.start_with?('f')).to eq true
expect(processed_source.start_with?('')).to eq true
end
it 'returns false when passed string that does not start source' do
expect(processed_source.start_with?('bar')).to eq false
expect(processed_source.start_with?('qux')).to eq false
expect(processed_source.start_with?('1')).to eq false
end
end
end
describe '#preceding_line' do
let(:source) { <<~RUBY }
[ line, 1 ]
{ line: 2 }
# line 3
RUBY
it 'returns source of line before token' do
brace_token = processed_source.find_token(&:left_brace?)
expect(processed_source.preceding_line(brace_token)).to eq '[ line, 1 ]'
comment_token = processed_source.find_token(&:comment?)
expect(processed_source.preceding_line(comment_token)).to eq '{ line: 2 }'
end
end
describe '#following_line' do
let(:source) { <<~RUBY }
[ line, 1 ]
{ line: 2 }
# line 3
RUBY
it 'returns source of line after token' do
bracket_token = processed_source.find_token(&:right_bracket?)
expect(processed_source.following_line(bracket_token)).to eq '{ line: 2 }'
brace_token = processed_source.find_token(&:left_brace?)
expect(processed_source.following_line(brace_token)).to eq '# line 3'
end
end
end
|