1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
|
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Performance::StringInclude do
subject(:cop) { described_class.new }
shared_examples 'different match methods' do |method|
it "autocorrects str#{method} /abc/" do
new_source = autocorrect_source("str#{method} /abc/")
expect(new_source).to eq "str.include?('abc')"
end
it "autocorrects /abc/#{method} str" do
new_source = autocorrect_source("/abc/#{method} 'str'")
expect(new_source).to eq "'str'.include?('abc')"
end
# escapes like "\n"
# note that "\b" is a literal backspace char in a double-quoted string...
# but in a regex, it's an anchor on a word boundary
%w[a e f r t v].each do |str|
it "autocorrects str#{method} /\\#{str}/" do
new_source = autocorrect_source("str#{method} /\\#{str}/")
expect(new_source).to eq %{str.include?("\\#{str}")}
end
it "autocorrects /\\#{str}#{method} str/" do
new_source = autocorrect_source("/\\#{str}/#{method} 'str'")
expect(new_source).to eq %{'str'.include?("\\#{str}")}
end
end
# regexp metacharacters
%w[. * ? $ ^ |].each do |str|
it "autocorrects str#{method} /\\#{str}/" do
new_source = autocorrect_source("str#{method} /\\#{str}/")
expect(new_source).to eq "str.include?('#{str}')"
end
it "autocorrects /\\#{str}/#{method} str" do
new_source = autocorrect_source("/\\#{str}/#{method} 'str'")
expect(new_source).to eq "'str'.include?('#{str}')"
end
it "doesn't register an error for str#{method} /prefix#{str}/" do
expect_no_offenses("str#{method} /prefix#{str}/")
end
it "doesn't register an error for /prefix#{str}/#{method} str" do
expect_no_offenses("/prefix#{str}/#{method} str")
end
end
# character classes, anchors
%w[w W s S d D A Z z G b B h H R X S].each do |str|
it "doesn't register an error for str#{method} /\\#{str}/" do
expect_no_offenses("str#{method} /\\#{str}/")
end
it "doesn't register an error for /\\#{str}/#{method} str" do
expect_no_offenses("/\\#{str}/#{method} str")
end
end
# characters with no special meaning whatsoever
%w[i j l m o q y].each do |str|
it "autocorrects str#{method} /\\#{str}/" do
new_source = autocorrect_source("str#{method} /\\#{str}/")
expect(new_source).to eq "str.include?('#{str}')"
end
it "autocorrects /\\#{str}#{method} str/" do
new_source = autocorrect_source("/\\#{str}/#{method} 'str'")
expect(new_source).to eq "'str'.include?('#{str}')"
end
end
it "formats the error message correctly for str#{method} /abc/" do
inspect_source("str#{method} /abc/")
expect(cop.messages).to eq(['Use `String#include?` instead of a regex match with literal-only pattern.'])
end
it "formats the error message correctly for /abc/#{method} str" do
inspect_source("/abc/#{method} 'str'")
expect(cop.messages).to eq(['Use `String#include?` instead of a regex match with literal-only pattern.'])
end
it "autocorrects str#{method} /\\\\/" do
new_source = autocorrect_source("str#{method} /\\\\/")
expect(new_source).to eq("str.include?('\\\\')")
end
it "autocorrects /\\\\/#{method} str" do
new_source = autocorrect_source("/\\\\/#{method} 'str'")
expect(new_source).to eq("'str'.include?('\\\\')")
end
end
include_examples('different match methods', '.match?')
include_examples('different match methods', ' =~')
include_examples('different match methods', '.match')
it 'allows match without a receiver' do
expect_no_offenses('expect(subject.spin).to match(/\A\n/)')
end
# Symbol object does not have `include?` method.
# A variable possible to be a symbol object, so if `match?` argument is
# a variable, accept it.
it 'allows argument of `match?` is not a string literal' do
expect_no_offenses('/ /.match?(content_as_symbol)')
end
end
|
