1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
|
# frozen_string_literal: true
module RuboCop
module Cop
module RSpec
# Checks void `expect()`.
#
# @example
# # bad
# expect(something)
#
# # good
# expect(something).to be(1)
#
class VoidExpect < Base
MSG = 'Do not use `expect()` without `.to` or `.not_to`. ' \
'Chain the methods or remove it.'
RESTRICT_ON_SEND = %i[expect].freeze
# @!method expect?(node)
def_node_matcher :expect?, <<-PATTERN
(send nil? :expect ...)
PATTERN
# @!method expect_block?(node)
def_node_matcher :expect_block?, <<-PATTERN
(block #expect? (args) _body)
PATTERN
def on_send(node)
return unless expect?(node)
check_expect(node)
end
def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
return unless expect_block?(node)
check_expect(node)
end
private
def check_expect(node)
return unless void?(node)
add_offense(node)
end
def void?(expect)
parent = expect.parent
return true unless parent
return true if parent.begin_type?
return true if parent.block_type? && parent.body == expect
end
end
end
end
end
|
