1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
|
require_relative "spec_helper"
describe "pg_auto_constraint_validations plugin" do
def create_model(ds)
@ds = ds
@ds.send(:columns=, [:id, :i])
@db.fetch = @metadata_results.dup
c = Sequel::Model(@ds)
c.plugin :pg_auto_constraint_validations
c
end
before do
info = @info = {:schema=>'public', :table=>'items'}
@db = Sequel.mock(:host=>'postgres')
def @db.schema(*) [[:i, {}], [:id, {}]] end
@set_error = lambda{|ec, ei| @db.fetch = @db.autoid = @db.numrows = ec; info.merge!(ei)}
@db.define_singleton_method(:error_info){|e| info}
@metadata_results = [
[{:constraint=>'items_i_check', :column=>'i', :definition=>'CHECK i'}, {:constraint=>'items_i_id_check', :column=>'i', :definition=>'CHECK i + id < 20'}, {:constraint=>'items_i_id_check', :column=>'id', :definition=>'CHECK i + id < 20'}, {:constraint=>'items_i_foo_check', :column=>nil, :definition=>'CHECK foo() < 20'}],
[{:name=>'items_i_uidx', :unique=>true, :column=>'i', :deferrable=>false}, {:name=>'items_i2_idx', :unique=>false, :column=>'i', :deferrable=>false}],
[{:name=>'items_i_fk', :column=>'i', :on_update=>'a', :on_delete=>'a', :table=>'items2', :refcolumn=>'id', :schema=>'public'}],
[{:name=>'items2_i_fk', :column=>'id', :on_update=>'a', :on_delete=>'a', :table=>'items2', :refcolumn=>'i', :schema=>'public'}],
[{:nspname=>'public', :relname=>'items'}]
]
@c = create_model(@db[:items])
end
it "should handle check constraint failures as validation errors when creating" do
o = @c.new(:i=>12)
@set_error[Sequel::CheckConstraintViolation, :constraint=>'items_i_check']
proc{o.save}.must_raise Sequel::ValidationFailed
o.errors.must_equal(:i=>['is invalid'])
end
it "should handle check constraint failures as validation errors when updating" do
o = @c.load(:i=>3)
@set_error[Sequel::CheckConstraintViolation, :constraint=>'items_i_check']
proc{o.update(:i=>12)}.must_raise Sequel::ValidationFailed
o.errors.must_equal(:i=>['is invalid'])
end
it "should handle unique constraint failures as validation errors when creating" do
o = @c.new(:i=>2)
@set_error[Sequel::UniqueConstraintViolation, :constraint=>'items_i_uidx']
proc{o.save}.must_raise Sequel::ValidationFailed
o.errors.must_equal(:i=>['is already taken'])
end
it "should handle unique constraint failures as validation errors when updating" do
o = @c.load(:id=>5, :i=>3)
@set_error[Sequel::UniqueConstraintViolation, :constraint=>'items_i_uidx']
proc{o.update(:i=>2)}.must_raise Sequel::ValidationFailed
o.errors.must_equal(:i=>['is already taken'])
end
it "should handle not null constraint failures as validation errors when creating" do
o = @c.new(:i=>5)
@set_error[Sequel::NotNullConstraintViolation, :column=>'i']
proc{o.save}.must_raise Sequel::ValidationFailed
o.errors.must_equal(:i=>['is not present'])
end
it "should handle not null constraint failures as validation errors when updating" do
o = @c.load(:i=>3)
@set_error[Sequel::NotNullConstraintViolation, :column=>'i']
proc{o.update(:i=>nil)}.must_raise Sequel::ValidationFailed
o.errors.must_equal(:i=>['is not present'])
end
it "should handle foreign key constraint failures as validation errors when creating" do
o = @c.new(:i=>3)
@set_error[Sequel::ForeignKeyConstraintViolation, :constraint=>'items_i_fk', :message_primary=>'insert or']
proc{o.save}.must_raise Sequel::ValidationFailed
o.errors.must_equal(:i=>['is invalid'])
end
it "should handle foreign key constraint failures as validation errors when updating" do
o = @c.load(:i=>1)
@set_error[Sequel::ForeignKeyConstraintViolation, :constraint=>'items_i_fk', :message_primary=>'insert or']
proc{o.update(:i=>3)}.must_raise Sequel::ValidationFailed
o.errors.must_equal(:i=>['is invalid'])
end
it "should handle foreign key constraint failures in other tables as validation errors when updating" do
o = @c.load(:i=>1)
@set_error[Sequel::ForeignKeyConstraintViolation, :constraint=>'items2_i_fk', :message_primary=>'update or', :schema=>'public', :table=>'items2']
proc{o.update(:i=>3)}.must_raise Sequel::ValidationFailed
o.errors.must_equal(:i=>['cannot be changed currently'])
end
it "should handle symbol, string, and identifier table names" do
[@db[:items], @db.from('items'), @db.from{items}, @db.from{public[:items]}].each do |ds|
c = create_model(ds)
@set_error[Sequel::CheckConstraintViolation, :constraint=>'items_i_check']
o = c.new(:i=>3)
proc{o.save}.must_raise Sequel::ValidationFailed
o.errors.must_equal(:i=>['is invalid'])
end
end
it "should skip handling of other table types such as subqueries and functions" do
[@db.from{foo(:bar)}, @db[:a, :b]].each do |ds|
@db.fetch = @metadata_results.dup
@c.dataset = ds
o = @c.new(:i=>3)
@set_error[Sequel::CheckConstraintViolation, :constraint=>'items_i_check']
proc{o.save}.must_raise Sequel::CheckConstraintViolation
end
end
it "should skip handling if the error_info method is not supported" do
@db.singleton_class.send(:remove_method, :error_info)
c = create_model(@db[:items])
@set_error[Sequel::CheckConstraintViolation, :constraint=>'items_i_check']
o = c.new(:i=>3)
proc{o.save}.must_raise Sequel::CheckConstraintViolation
end
it "should not handle constraint failures if they can't be converted" do
o = @c.new(:i=>12)
@set_error[Sequel::NotNullConstraintViolation, {}]
proc{o.save}.must_raise Sequel::NotNullConstraintViolation
@set_error[Sequel::CheckConstraintViolation, {}]
proc{o.save}.must_raise Sequel::CheckConstraintViolation
@set_error[Sequel::UniqueConstraintViolation, {}]
proc{o.save}.must_raise Sequel::UniqueConstraintViolation
@set_error[Sequel::ForeignKeyConstraintViolation, {}]
proc{o.save}.must_raise Sequel::ForeignKeyConstraintViolation
@set_error[Sequel::ForeignKeyConstraintViolation, :constraint=>'items_i_fk', :message_primary=>'foo']
proc{o.save}.must_raise Sequel::ForeignKeyConstraintViolation
@set_error[Sequel::ForeignKeyConstraintViolation, :constraint=>'items_i_fk', :message_primary=>'update or']
proc{o.save}.must_raise Sequel::ForeignKeyConstraintViolation
@set_error[Sequel::ForeignKeyConstraintViolation, :constraint=>'items_x_fk', :message_primary=>'insert or']
proc{o.save}.must_raise Sequel::ForeignKeyConstraintViolation
end
it "should reraise original exception if there is an error" do
o = @c.new(:i=>12)
def o.add_pg_constraint_validation_error; end
@set_error[Sequel::NotNullConstraintViolation, :column=>'i']
proc{o.save}.must_raise Sequel::NotNullConstraintViolation
end
it "should not handle constraint failures if schema or table do not match" do
o = @c.new(:i=>12)
@set_error[Sequel::CheckConstraintViolation, :constraint=>'items_i_check', :schema=>'x']
proc{o.save}.must_raise Sequel::CheckConstraintViolation
@set_error[Sequel::CheckConstraintViolation, :constraint=>'items_i_check', :schema=>'public', :table=>'x']
proc{o.save}.must_raise Sequel::CheckConstraintViolation
end
it "should handle constraint failures when disabling insert returning" do
c = create_model(@db[:items].disable_insert_returning)
o = c.new(:i=>12)
o.id = 1
@set_error[Sequel::CheckConstraintViolation, :constraint=>'items_i_check']
proc{o.save}.must_raise Sequel::ValidationFailed
o.errors.must_equal(:i=>['is invalid'])
end
it "should handle multi-column constraint failures as validation errors" do
o = @c.new(:i=>12)
@set_error[Sequel::CheckConstraintViolation, :constraint=>'items_i_id_check']
proc{o.save}.must_raise Sequel::ValidationFailed
o.errors.must_equal([:i, :id]=>['is invalid'])
end
it "should handle multi-column constraint failures as validation errors when using the error_splitter plugin" do
@c.plugin :error_splitter
o = @c.new(:i=>12)
@set_error[Sequel::CheckConstraintViolation, :constraint=>'items_i_id_check']
proc{o.save}.must_raise Sequel::ValidationFailed
o.errors.must_equal(:i=>['is invalid'], :id=>['is invalid'])
end
it "should handle overridden constraint failures as validation errors when updating" do
o = @c.load(:i=>3)
@c.pg_auto_constraint_validation_override(:items_i_ocheck, :i, "foo bar")
@set_error[Sequel::CheckConstraintViolation, :constraint=>'items_i_ocheck']
proc{o.update(:i=>12)}.must_raise Sequel::ValidationFailed
o.errors.must_equal(:i=>['foo bar'])
end
it "should handle dumping cached metadata and loading metadata from cache" do
cache_file = "spec/files/pgacv-spec-#{$$}.cache"
begin
@ds = @db[:items]
@ds.send(:columns=, [:id, :i])
@db.fetch = @metadata_results.dup
c = Sequel::Model(@ds)
def c.name; 'Foo' end
@db.sqls
c.plugin :pg_auto_constraint_validations, :cache_file=>cache_file
@db.sqls.length.must_equal 5
o = c.new(:i=>12)
@set_error[Sequel::CheckConstraintViolation, :constraint=>'items_i_id_check']
proc{o.save}.must_raise Sequel::ValidationFailed
c.dump_pg_auto_constraint_validations_cache
@db.fetch = []
c = Sequel::Model(@ds)
def c.name; 'Foo' end
@db.sqls
c.plugin :pg_auto_constraint_validations, :cache_file=>cache_file
@db.sqls.must_be_empty
o = c.new(:i=>12)
@set_error[Sequel::CheckConstraintViolation, :constraint=>'items_i_id_check']
proc{o.save}.must_raise Sequel::ValidationFailed
ensure
File.delete(cache_file) if File.file?(cache_file)
end
end
it "should raise error if attempting to dump cached metadata when not using caching" do
proc{@c.dump_pg_auto_constraint_validations_cache}.must_raise Sequel::Error
end
it "should allow loading into models without a dataset" do
c = Class.new(Sequel::Model)
c.plugin :pg_auto_constraint_validations
c.pg_auto_constraint_validations.must_be_nil
end
end
|
