1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
|
import unittest
from unittest.mock import patch, PropertyMock
import api.v1.spamcheck_pb2 as spam
from app import config, ValidationError
from app.spammable import issue
from tests.app.helpers import MockContext, MockML
class TestIssue(unittest.TestCase):
def test_verdict_project_not_allowed(self):
i = issue.Issue(spam.Issue(title="test"), MockContext())
i._project_allowed = False
v = i.verdict()
self.assertEqual(
spam.SpamVerdict.NOOP, v.verdict, "Disallowed project should return NOOP"
)
def test_score(self):
s = issue.Issue(spam.Issue(title="test"), MockContext())
self.assertEqual(
spam.SpamVerdict.ALLOW,
s.calculate_verdict(0.39),
"Confidence less than 0.4 should be allowed",
)
self.assertEqual(
spam.SpamVerdict.CONDITIONAL_ALLOW,
s.calculate_verdict(0.41),
"Confidence between 0.4 and 0,5 should be conditionally allowed",
)
self.assertEqual(
spam.SpamVerdict.CONDITIONAL_ALLOW,
s.calculate_verdict(0.55),
"Confidence between 0.5 and 0.9 should be disallowed",
)
self.assertEqual(
spam.SpamVerdict.CONDITIONAL_ALLOW,
s.calculate_verdict(0.9),
"Confidence of 0.9 or greater should be blocked",
)
def test_verdict(self):
issue.classifier = MockML(1.0)
i = issue.Issue(spam.Issue(title="test"), MockContext())
i._project_allowed = False
self.assertEqual(
spam.SpamVerdict.NOOP,
i.verdict().verdict,
"Disallowed project should return NOOP",
)
i._project_allowed = True
i._email_allowed = True
self.assertEqual(
spam.SpamVerdict.ALLOW,
i.verdict().verdict,
"Allowed email should return ALLOW",
)
i._email_allowed = False
self.assertEqual(
spam.SpamVerdict.CONDITIONAL_ALLOW,
i.verdict().verdict,
"ML inference of 1.0 should be conditionally allowed",
)
issue.classifier.set_score(0.1)
self.assertEqual(
spam.SpamVerdict.ALLOW,
i.verdict().verdict,
"ML inference of 0.1 should be allowed",
)
def test_verdict_no_ml(self):
issue.classifier = None
i = issue.Issue(spam.Issue(title="test"), MockContext())
i.project_allowed = True
self.assertEqual(
spam.SpamVerdict.NOOP,
i.verdict().verdict,
"Issue ML not loaded should return NOOP",
)
def test_issue_property(self):
i = issue.Issue(spam.Issue(title="spam"), MockContext())
i.allowed_domains = {"gitlab.com"}
self.assertEqual("spam", i.spammable.title, "Issue should have been set")
self.assertEqual(False, i._email_allowed, "Blank email should not be allowed")
args = {"user": {"emails": [{"email": "test@gitlab.com", "verified": True}]}}
new_issue = spam.Issue(**args)
i.spammable = new_issue
self.assertEqual(
True,
i._email_allowed,
"Email should not be allowed after updating issue",
)
def test_validation(self):
self.assertRaises(ValidationError, issue.Issue, spam.Issue(), MockContext())
|
