1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518
|
require 'spec_helper'
module Spy
describe "#any_instance" do
class CustomErrorForAnyInstanceSpec < StandardError;end
let(:klass) do
Class.new do
def existing_method; :existing_method_return_value; end
def existing_method_with_arguments(arg_one, arg_two = nil); :existing_method_with_arguments_return_value; end
def another_existing_method; end
private
def private_method; :private_method_return_value; end
end
end
let(:existing_method_return_value){ :existing_method_return_value }
context "with #stub" do
it "does not suppress an exception when a method that doesn't exist is invoked" do
Spy.on_instance_method(klass, :existing_method)
expect { klass.new.bar }.to raise_error(NoMethodError)
end
context 'multiple methods' do
it "allows multiple methods to be stubbed in a single invocation" do
Spy.on_instance_method(klass, :existing_method => 'foo', :another_existing_method => 'bar')
instance = klass.new
expect(instance.existing_method).to eq('foo')
expect(instance.another_existing_method).to eq('bar')
end
end
context "behaves as 'every instance'" do
it "stubs every instance in the spec" do
Subroutine.new(klass, :foo, false).hook(force: true).and_return(result = Object.new)
expect(klass.new.foo).to eq(result)
expect(klass.new.foo).to eq(result)
end
it "stubs instance created before any_instance was called" do
instance = klass.new
Spy.on_instance_method(klass, :existing_method).and_return(result = Object.new)
expect(instance.existing_method).to eq(result)
end
end
context "with #and_return" do
it "stubs a method that doesn't exist" do
Spy.on_instance_method(klass, :existing_method).and_return(1)
expect(klass.new.existing_method).to eq(1)
end
it "stubs a method that exists" do
Spy.on_instance_method(klass, :existing_method).and_return(1)
expect(klass.new.existing_method).to eq(1)
end
it "returns the same object for calls on different instances" do
return_value = Object.new
Spy.on_instance_method(klass, :existing_method).and_return(return_value)
expect(klass.new.existing_method).to be(return_value)
expect(klass.new.existing_method).to be(return_value)
end
end
context "with #and_yield" do
it "yields the value specified" do
yielded_value = Object.new
Spy.on_instance_method(klass, :existing_method).and_yield(yielded_value)
klass.new.existing_method{|value| expect(value).to be(yielded_value)}
end
end
context "with #and_raise" do
it "stubs a method that doesn't exist" do
Spy.on_instance_method(klass, :existing_method).and_raise(CustomErrorForAnyInstanceSpec)
expect { klass.new.existing_method}.to raise_error(CustomErrorForAnyInstanceSpec)
end
it "stubs a method that exists" do
Spy.on_instance_method(klass, :existing_method).and_raise(CustomErrorForAnyInstanceSpec)
expect { klass.new.existing_method}.to raise_error(CustomErrorForAnyInstanceSpec)
end
end
context "with a block" do
it "stubs a method" do
Spy.on_instance_method(klass, :existing_method) { 1 }
expect(klass.new.existing_method).to eq(1)
end
it "returns the same computed value for calls on different instances" do
Spy.on_instance_method(klass, :existing_method) { 1 + 2 }
expect(klass.new.existing_method).to eq(klass.new.existing_method)
end
end
context "core ruby objects" do
it "works uniformly across *everything*" do
Object.any_instance.stub(:foo).and_return(1)
expect(Object.new.foo).to eq(1)
end
it "works with the non-standard constructor []" do
Array.any_instance.stub(:foo).and_return(1)
expect([].foo).to eq(1)
end
it "works with the non-standard constructor {}" do
Hash.any_instance.stub(:foo).and_return(1)
expect({}.foo).to eq(1)
end
it "works with the non-standard constructor \"\"" do
String.any_instance.stub(:foo).and_return(1)
expect("".foo).to eq(1)
end
it "works with the non-standard constructor \'\'" do
String.any_instance.stub(:foo).and_return(1)
expect(''.foo).to eq(1)
end
it "works with the non-standard constructor module" do
Module.any_instance.stub(:foo).and_return(1)
module RSpec::SampleRspecTestModule;end
expect(RSpec::SampleRspecTestModule.foo).to eq(1)
end
it "works with the non-standard constructor class" do
Class.any_instance.stub(:foo).and_return(1)
class RSpec::SampleRspecTestClass;end
expect(RSpec::SampleRspecTestClass.foo).to eq(1)
end
end
end
context "unstub implementation" do
it "replaces the stubbed method with the original method" do
Spy.on_instance_method(klass, :existing_method)
klass.any_instance.unstub(:existing_method)
expect(klass.new.existing_method).to eq(:existing_method_return_value)
end
it "removes all stubs with the supplied method name" do
Spy.on_instance_method(klass, :existing_method).with(1)
Spy.on_instance_method(klass, :existing_method).with(2)
klass.any_instance.unstub(:existing_method)
expect(klass.new.existing_method).to eq(:existing_method_return_value)
end
it "does not remove any expectations with the same method name" do
klass.any_instance.should_receive(:existing_method_with_arguments).with(3).and_return(:three)
Spy.on_instance_method(klass, :existing_method_with_arguments).with(1)
Spy.on_instance_method(klass, :existing_method_with_arguments).with(2)
klass.any_instance.unstub(:existing_method_with_arguments)
expect(klass.new.existing_method_with_arguments(3)).to eq(:three)
end
it "raises a MockExpectationError if the method has not been stubbed" do
expect {
klass.any_instance.unstub(:existing_method)
}.to raise_error(RSpec::Mocks::MockExpectationError, 'The method `existing_method` was not stubbed or was already unstubbed')
end
end
context "with #should_receive" do
let(:foo_expectation_error_message) { 'Exactly one instance should have received the following message(s) but didn\'t: foo' }
let(:existing_method_expectation_error_message) { 'Exactly one instance should have received the following message(s) but didn\'t: existing_method' }
context "with an expectation is set on a method which does not exist" do
it "returns the expected value" do
klass.any_instance.should_receive(:foo).and_return(1)
expect(klass.new.foo(1)).to eq(1)
end
it "fails if an instance is created but no invocation occurs" do
expect do
klass.any_instance.should_receive(:foo)
klass.new
klass.rspec_verify
end.to raise_error(RSpec::Mocks::MockExpectationError, foo_expectation_error_message)
end
it "fails if no instance is created" do
expect do
klass.any_instance.should_receive(:foo).and_return(1)
klass.rspec_verify
end.to raise_error(RSpec::Mocks::MockExpectationError, foo_expectation_error_message)
end
it "fails if no instance is created and there are multiple expectations" do
expect do
klass.any_instance.should_receive(:foo)
klass.any_instance.should_receive(:bar)
klass.rspec_verify
end.to raise_error(RSpec::Mocks::MockExpectationError, 'Exactly one instance should have received the following message(s) but didn\'t: bar, foo')
end
it "allows expectations on instances to take priority" do
klass.any_instance.should_receive(:foo)
klass.new.foo
instance = klass.new
instance.should_receive(:foo).and_return(result = Object.new)
expect(instance.foo).to eq(result)
end
context "behaves as 'exactly one instance'" do
it "passes if subsequent invocations do not receive that message" do
klass.any_instance.should_receive(:foo)
klass.new.foo
klass.new
end
it "fails if the method is invoked on a second instance" do
instance_one = klass.new
instance_two = klass.new
expect do
klass.any_instance.should_receive(:foo)
instance_one.foo
instance_two.foo
end.to raise_error(RSpec::Mocks::MockExpectationError, "The message 'foo' was received by #{instance_two.inspect} but has already been received by #{instance_one.inspect}")
end
end
context "normal expectations on the class object" do
it "fail when unfulfilled" do
expect do
klass.any_instance.should_receive(:foo)
klass.should_receive(:woot)
klass.new.foo
klass.rspec_verify
end.to(raise_error(RSpec::Mocks::MockExpectationError) do |error|
expect(error.message).not_to eq(existing_method_expectation_error_message)
end)
end
it "pass when expectations are met" do
klass.any_instance.should_receive(:foo)
klass.should_receive(:woot).and_return(result = Object.new)
klass.new.foo
expect(klass.woot).to eq(result)
end
end
end
context "with an expectation is set on a method that exists" do
it "returns the expected value" do
klass.any_instance.should_receive(:existing_method).and_return(1)
expect(klass.new.existing_method(1)).to eq(1)
end
it "fails if an instance is created but no invocation occurs" do
expect do
klass.any_instance.should_receive(:existing_method)
klass.new
klass.rspec_verify
end.to raise_error(RSpec::Mocks::MockExpectationError, existing_method_expectation_error_message)
end
it "fails if no instance is created" do
expect do
klass.any_instance.should_receive(:existing_method)
klass.rspec_verify
end.to raise_error(RSpec::Mocks::MockExpectationError, existing_method_expectation_error_message)
end
it "fails if no instance is created and there are multiple expectations" do
expect do
klass.any_instance.should_receive(:existing_method)
klass.any_instance.should_receive(:another_existing_method)
klass.rspec_verify
end.to raise_error(RSpec::Mocks::MockExpectationError, 'Exactly one instance should have received the following message(s) but didn\'t: another_existing_method, existing_method')
end
context "after any one instance has received a message" do
it "passes if subsequent invocations do not receive that message" do
klass.any_instance.should_receive(:existing_method)
klass.new.existing_method
klass.new
end
it "fails if the method is invoked on a second instance" do
instance_one = klass.new
instance_two = klass.new
expect do
klass.any_instance.should_receive(:existing_method)
instance_one.existing_method
instance_two.existing_method
end.to raise_error(RSpec::Mocks::MockExpectationError, "The message 'existing_method' was received by #{instance_two.inspect} but has already been received by #{instance_one.inspect}")
end
end
end
end
context "when resetting post-verification" do
let(:space) { RSpec::Mocks::Space.new }
context "existing method" do
before(:each) do
space.add(klass)
end
context "with stubbing" do
context "public methods" do
before(:each) do
Spy.on_instance_method(klass, :existing_method).and_return(1)
expect(klass.method_defined?(:__existing_method_without_any_instance__)).to be_true
end
it "restores the class to its original state after each example when no instance is created" do
space.verify_all
expect(klass.method_defined?(:__existing_method_without_any_instance__)).to be_false
expect(klass.new.existing_method).to eq(existing_method_return_value)
end
it "restores the class to its original state after each example when one instance is created" do
klass.new.existing_method
space.verify_all
expect(klass.method_defined?(:__existing_method_without_any_instance__)).to be_false
expect(klass.new.existing_method).to eq(existing_method_return_value)
end
it "restores the class to its original state after each example when more than one instance is created" do
klass.new.existing_method
klass.new.existing_method
space.verify_all
expect(klass.method_defined?(:__existing_method_without_any_instance__)).to be_false
expect(klass.new.existing_method).to eq(existing_method_return_value)
end
end
context "private methods" do
before :each do
Spy.on_instance_method(klass, :private_method).and_return(:something)
space.verify_all
end
it "cleans up the backed up method" do
expect(klass.method_defined?(:__existing_method_without_any_instance__)).to be_false
end
it "restores a stubbed private method after the spec is run" do
expect(klass.private_method_defined?(:private_method)).to be_true
end
it "ensures that the restored method behaves as it originally did" do
expect(klass.new.send(:private_method)).to eq(:private_method_return_value)
end
end
end
context "with expectations" do
context "private methods" do
before :each do
klass.any_instance.should_receive(:private_method).and_return(:something)
klass.new.private_method
space.verify_all
end
it "cleans up the backed up method" do
expect(klass.method_defined?(:__existing_method_without_any_instance__)).to be_false
end
it "restores a stubbed private method after the spec is run" do
expect(klass.private_method_defined?(:private_method)).to be_true
end
it "ensures that the restored method behaves as it originally did" do
expect(klass.new.send(:private_method)).to eq(:private_method_return_value)
end
end
context "ensures that the subsequent specs do not see expectations set in previous specs" do
context "when the instance created after the expectation is set" do
it "first spec" do
klass.any_instance.should_receive(:existing_method).and_return(Object.new)
klass.new.existing_method
end
it "second spec" do
expect(klass.new.existing_method).to eq(existing_method_return_value)
end
end
context "when the instance created before the expectation is set" do
before :each do
@instance = klass.new
end
it "first spec" do
klass.any_instance.should_receive(:existing_method).and_return(Object.new)
@instance.existing_method
end
it "second spec" do
expect(@instance.existing_method).to eq(existing_method_return_value)
end
end
end
it "ensures that the next spec does not see that expectation" do
klass.any_instance.should_receive(:existing_method).and_return(Object.new)
klass.new.existing_method
space.verify_all
expect(klass.new.existing_method).to eq(existing_method_return_value)
end
end
end
context "with multiple calls to any_instance in the same example" do
it "does not prevent the change from being rolled back" do
Spy.on_instance_method(klass, :existing_method).and_return(false)
Spy.on_instance_method(klass, :existing_method).and_return(true)
klass.rspec_verify
expect(klass.new).to respond_to(:existing_method)
expect(klass.new.existing_method).to eq(existing_method_return_value)
end
end
it "adds an class to the current space when #any_instance is invoked" do
klass.any_instance
expect(RSpec::Mocks::space.send(:receivers)).to include(klass)
end
it "adds an instance to the current space when stubbed method is invoked" do
Spy.on_instance_method(klass, :foo)
instance = klass.new
instance.foo
expect(RSpec::Mocks::space.send(:receivers)).to include(instance)
end
end
context 'when used in conjunction with a `dup`' do
it "doesn't cause an infinite loop" do
Spy::Subroutine.new(Object, :some_method, false).hook(force: true)
o = Object.new
o.some_method
expect { o.dup.some_method }.to_not raise_error(SystemStackError)
end
it "doesn't bomb if the object doesn't support `dup`" do
klass = Class.new do
undef_method :dup
end
Spy::Subroutine.new(Object, :some_method, false).hook(force: true)
end
it "doesn't fail when dup accepts parameters" do
klass = Class.new do
def dup(funky_option)
end
end
Spy::Subroutine.new(Object, :some_method, false).hook(force: true)
expect { klass.new.dup('Dup dup dup') }.to_not raise_error(ArgumentError)
end
end
context "when directed at a method defined on a superclass" do
let(:sub_klass) { Class.new(klass) }
it "stubs the method correctly" do
Spy.on_instance_method(klass, :existing_method).and_return("foo")
expect(sub_klass.new.existing_method).to eq "foo"
end
it "mocks the method correctly" do
instance_one = sub_klass.new
instance_two = sub_klass.new
expect do
klass.any_instance.should_receive(:existing_method)
instance_one.existing_method
instance_two.existing_method
end.to raise_error(RSpec::Mocks::MockExpectationError, "The message 'existing_method' was received by #{instance_two.inspect} but has already been received by #{instance_one.inspect}")
end
end
context "when a class overrides Object#method" do
let(:http_request_class) { Struct.new(:method, :uri) }
it "stubs the method correctly" do
http_request_class.any_instance.stub(:existing_method).and_return("foo")
expect(http_request_class.new.existing_method).to eq "foo"
end
it "mocks the method correctly" do
http_request_class.any_instance.should_receive(:existing_method).and_return("foo")
expect(http_request_class.new.existing_method).to eq "foo"
end
end
context "when used after the test has finished" do
it "restores the original behavior of a stubbed method" do
Spy.on_instance_method(klass, :existing_method).and_return(:stubbed_return_value)
instance = klass.new
expect(instance.existing_method).to eq :stubbed_return_value
RSpec::Mocks.verify
expect(instance.existing_method).to eq :existing_method_return_value
end
end
end
end
|