1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418
|
# frozen_string_literal: true
require 'helper'
require 'parser/ruby18'
class TestSourceCommentAssociator < Minitest::Test
def parse_with_comments(code)
parser = Parser::Ruby18.new
buffer = Parser::Source::Buffer.new('(comments)')
buffer.source = code
parser.parse_with_comments(buffer)
end
def associate(code)
ast, comments = parse_with_comments(code)
associations = Parser::Source::Comment.associate(ast, comments)
[ ast, associations ]
end
def associate_locations(code)
ast, comments = parse_with_comments(code)
associations = Parser::Source::Comment.associate_locations(ast, comments)
[ ast, associations ]
end
def associate_by_identity(code)
ast, comments = parse_with_comments(code)
associations = Parser::Source::Comment.associate_by_identity(ast, comments)
[ ast, associations ]
end
def test_associate
ast, associations = associate(<<-END)
#!/usr/bin/env ruby
# coding: utf-8
# class preceding
# another class preceding
class Foo # class keyword line
# method foo preceding
def foo
puts 'foo'
end # method foo decorating
# method bar preceding
def bar
# expression preceding
1 + # 1 decorating
2
# method bar sparse
end # method bar decorating
# class sparse
end # class decorating
END
klass_node = ast
klass_name_node = klass_node.children[0]
foo_node = klass_node.children[2].children[0] # def foo
bar_node = klass_node.children[2].children[1] # def bar
expr_node = bar_node.children[2] # 1 + 2
one_node = expr_node.children[0] # 1
assert_equal 6, associations.size
assert_equal [
'# class preceding',
'# another class preceding',
'# class sparse',
'# class decorating'
], associations[klass_node].map(&:text)
assert_equal [
'# class keyword line'
], associations[klass_name_node].map(&:text)
assert_equal [
'# method foo preceding',
'# method foo decorating'
], associations[foo_node].map(&:text)
assert_equal [
'# method bar preceding',
'# method bar sparse',
'# method bar decorating'
], associations[bar_node].map(&:text)
assert_equal [
'# expression preceding'
], associations[expr_node].map(&:text)
assert_equal [
'# 1 decorating'
], associations[one_node].map(&:text)
end
def setup_dupe_statement(method = :associate)
@ast, @associations = send(method, <<-END)
class Foo
def bar
f1 # comment on 1st call to f1
f2
f1 # comment on 2nd call to f1
end
end
END
_klass_node = @ast
@method_node = @ast.children[2]
@body = @method_node.children[2]
@f1_1_node = @body.children[0]
@f1_2_node = @body.children[2]
end
# The bug below is fixed by using associate_locations
def test_associate_dupe_statement
setup_dupe_statement
assert_equal 1, @associations.size
assert_equal ['# comment on 1st call to f1', '# comment on 2nd call to f1'],
@associations[@f1_1_node].map(&:text)
assert_equal ['# comment on 1st call to f1', '# comment on 2nd call to f1'],
@associations[@f1_2_node].map(&:text)
end
def test_associate_by_identity_dupe_statement
setup_dupe_statement(:associate_by_identity)
assert_equal 2, @associations.size
assert_equal ['# comment on 1st call to f1'],
@associations[@f1_1_node].map(&:text)
assert_equal ['# comment on 2nd call to f1'],
@associations[@f1_2_node].map(&:text)
end
def test_associate_locations
ast, associations = associate_locations(<<-END)
#!/usr/bin/env ruby
# coding: utf-8
# class preceding
# another class preceding
class Foo # class keyword line
# method foo preceding
def foo
puts 'foo'
end # method foo decorating
# method bar preceding
def bar
# expression preceding
1 + # 1 decorating
2
# method bar sparse
end # method bar decorating
# class sparse
end # class decorating
END
klass_node = ast
klass_name_node = klass_node.children[0]
foo_node = klass_node.children[2].children[0] # def foo
bar_node = klass_node.children[2].children[1] # def bar
expr_node = bar_node.children[2] # 1 + 2
one_node = expr_node.children[0] # 1
assert_equal 6, associations.size
assert_equal [
'# class preceding',
'# another class preceding',
'# class sparse',
'# class decorating'
], associations[klass_node.loc].map(&:text)
assert_equal [
'# class keyword line'
], associations[klass_name_node.loc].map(&:text)
assert_equal [
'# method foo preceding',
'# method foo decorating'
], associations[foo_node.loc].map(&:text)
assert_equal [
'# method bar preceding',
'# method bar sparse',
'# method bar decorating'
], associations[bar_node.loc].map(&:text)
assert_equal [
'# expression preceding'
], associations[expr_node.loc].map(&:text)
assert_equal [
'# 1 decorating'
], associations[one_node.loc].map(&:text)
end
def test_associate_locations_dupe_statement
ast, associations = associate_locations(<<-END)
class Foo
def bar
f1 # comment on 1st call to f1
f2
f1 # comment on 2nd call to f1
end
end
END
_klass_node = ast
method_node = ast.children[2]
body = method_node.children[2]
f1_1_node = body.children[0]
f1_2_node = body.children[2]
assert_equal 2, associations.size
assert_equal ['# comment on 1st call to f1'],
associations[f1_1_node.loc].map(&:text)
assert_equal ['# comment on 2nd call to f1'],
associations[f1_2_node.loc].map(&:text)
end
def test_associate_no_body
ast, associations = associate(<<-END)
# foo
class Foo
end
END
assert_equal 1, associations.size
assert_equal ['# foo'],
associations[ast].map(&:text)
end
def test_associate_empty_tree
_ast, associations = associate("")
assert_equal 0, associations.size
end
def test_associate_shebang_only
_ast, associations = associate(<<-END)
#!ruby
class Foo
end
END
assert_equal 0, associations.size
end
def test_associate_frozen_string_literal
_ast, associations = associate(<<-END)
# frozen_string_literal: true
class Foo
end
END
assert_equal 0, associations.size
end
def test_associate_frozen_string_literal_dash_star_dash
_ast, associations = associate(<<-END)
# -*- frozen_string_literal: true -*-
class Foo
end
END
assert_equal 0, associations.size
end
def test_associate_frozen_string_literal_no_space_after_colon
_ast, associations = associate(<<-END)
# frozen_string_literal:true
class Foo
end
END
assert_equal 0, associations.size
end
def test_associate_warn_indent
_ast, associations = associate(<<-END)
# warn_indent: true
class Foo
end
END
assert_equal 0, associations.size
end
def test_associate_warn_indent_dash_star_dash
_ast, associations = associate(<<-END)
# -*- warn_indent: true -*-
class Foo
end
END
assert_equal 0, associations.size
end
def test_associate_warn_past_scope
_ast, associations = associate(<<-END)
# warn_past_scope: true
class Foo
end
END
assert_equal 0, associations.size
end
def test_associate_warn_past_scope_dash_star_dash
_ast, associations = associate(<<-END)
# -*- warn_past_scope: true -*-
class Foo
end
END
assert_equal 0, associations.size
end
def test_associate_multiple
_ast, associations = associate(<<-END)
# frozen_string_literal: true; warn_indent: true
class Foo
end
END
assert_equal 0, associations.size
end
def test_associate_multiple_dash_star_dash
_ast, associations = associate(<<-END)
# -*- frozen_string_literal: true; warn_indent: true -*-
class Foo
end
END
assert_equal 0, associations.size
end
def test_associate_no_comments
_ast, associations = associate(<<-END)
class Foo
end
END
assert_equal 0, associations.size
end
def test_associate_comments_after_root_node
_ast, associations = associate(<<-END)
class Foo
end
# not associated
END
assert_equal 0, associations.size
end
def test_associate_stray_comment
ast, associations = associate(<<-END)
def foo
# foo
end
END
assert_equal 1, associations.size
assert_equal ['# foo'],
associations[ast].map(&:text)
end
def test_associate___ENCODING__
ast, associations = associate(<<-END)
# foo
__ENCODING__
END
assert_equal 1, associations.size
assert_equal ['# foo'],
associations[ast].map(&:text)
end
def test_associate_inside_heredoc
ast, associations = associate(<<-END)
<<x
\#{
foo # bar
}
x
END
begin_node = ast.children[0]
send_node = begin_node.children[0]
assert_equal 1, associations.size
assert_equal ['# bar'],
associations[send_node].map(&:text)
end
def test_associate_conditional_parent_class
ast, associations = associate(<<-END)
class Foo
# bar
class Bar
end
end if some_condition
END
if_node = ast
_condition, foo_class = if_node.children
_foo, _sub_class, bar_class = foo_class.children
assert_equal 1, associations.size
assert_equal ['# bar'],
associations[bar_class].map(&:text)
end
def test_children_in_source_order
obj = Parser::Source::Comment::Associator.new(nil, nil)
for_each_node do |node|
with_loc = node.children.select do |child|
child.is_a?(AST::Node) && child.loc && child.loc.expression
end
slow_sort = with_loc.sort_by.with_index do |child, index| # Index to ensure stable sort
[child.loc.expression.begin_pos, index]
end
optimized = obj.send(:children_in_source_order, node)
assert_equal slow_sort, optimized, "children_in_source_order incorrect for #{node}"
end
end
end
|