1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
|
use pgp::{
types::{PublicKeyTrait, SecretKeyTrait},
Deserializable, Message,
};
/// RPG-022
#[test]
fn rpg_022_message_from_armor_single_panic2() {
// expected bug behavior:
// thread '[..]' panicked at [..]/src/armor/reader.rs:489:13:
// invalid state
let bad_input: &[u8] = b"-----BEGIN PGP SIGNATURE-----\n00LL";
let _ = Message::from_armor_single(std::io::Cursor::new(bad_input));
}
/// RPG-019
#[test]
fn rpg_019_message_decrypt_with_password_panic1() {
let bad_input: &[u8] = &[
140, 159, 4, 1, 0, 0, 0, 167, 167, 167, 167, 167, 167, 167, 167, 0, 0, 0, 0, 0, 0, 0, 145,
68, 32, 70, 73, 76, 69, 208, 0, 0, 0, 0, 227, 167, 167, 76, 69, 210, 69, 208, 210, 167,
167, 167, 227, 167, 167, 76, 69, 210, 167, 167, 167, 167, 167, 167, 227, 167, 167, 76, 69,
210, 69, 208, 210, 167, 167, 167, 227, 167, 167, 76, 69, 227, 167, 167, 76, 69, 1, 0, 0, 0,
0, 0, 4, 184, 167, 167, 167, 227, 167, 167, 76, 69, 167, 167, 167, 167, 167, 167, 68, 32,
70, 73, 76, 69, 208, 210, 167, 167, 167, 227, 167, 167, 76, 69, 210, 69, 208, 210, 167,
167, 167, 227, 167, 167, 76, 69, 227, 167, 167, 69, 73, 76, 69, 208, 210, 167, 167, 167,
227, 167, 167, 76, 69, 210, 69, 208, 210, 167, 167, 167, 227, 167, 167, 76, 69, 227, 167,
167,
];
let message = Message::from_bytes(bad_input).unwrap();
// expected bug behavior
// thread '<unnamed>' panicked at library/alloc/src/raw_vec.rs:545:5:
// capacity overflow
let _ = message.decrypt_with_password(|| "password does not matter".into());
}
/// RPG-019
#[test]
fn rpg_019_message_decrypt_with_password_panic2() {
let bad_input: &[u8] = &[
0xc3, 0x20, 0x04, 0x01, 0x01, 0x02, 0x32, 0xf6, 0xe3, 0xff, 0xff, 0xac, 0xa7, 0xa7, 0xa7,
0xff, 0xff, 0xa7, 0x26, 0xaf, 0x20, 0x4b, 0xaf, 0xa7, 0xa7, 0xa7, 0xa7, 0xd1, 0x22, 0xa7,
0xa7, 0xa7, 0x00, 0xa7, 0xa7, 0xd1, 0x22, 0xff, 0xff, 0xff, 0xa7, 0x26, 0xaf, 0x20, 0x4b,
0xaf,
];
let message = Message::from_bytes(bad_input).unwrap();
// note that for this crash, the password does matter
// expected bug behavior
// thread '[..]' panicked at [..]/src/crypto/sym.rs:265:52:
// not implemented: CFB resync is not here
let _ = message.decrypt_with_password(|| "bogus_password".into());
}
/// RPG-016
/// Only present in 0.11, added as regression test
#[test]
fn rpg_016_message_parser_panic2() {
// expected bug behavior:
// thread '<unnamed>' panicked at 'assertion failed: length > 0', src/packet/many.rs:140:17:
let bad_input: &[u8] = &[0xb7];
let _ = Message::from_bytes(bad_input);
}
/// RPG-015
#[test]
fn rpg_015_cleartext_signed_message_from_armor_panic1() {
let bad_input: &[u8] = &[
45, 45, 45, 45, 45, 66, 69, 71, 73, 78, 32, 80, 71, 80, 32, 83, 73, 71, 78, 69, 68, 32, 77,
69, 83, 83, 65, 71, 69, 45, 45, 45, 45, 45, 10, 10, 22, 10, 45, 45, 45, 45, 45, 66, 69, 71,
73, 78, 32, 80, 71, 80, 32, 83, 73, 71, 78, 65, 84, 85, 82, 69, 45, 45, 45, 45, 45, 10, 72,
];
let _ = pgp::composed::cleartext::CleartextSignedMessage::from_armor(bad_input);
}
/// RPG-015
#[test]
fn rgp_015_cleartext_signed_message_from_string_panic1() {
// this triggers the same bug as the from_armor() case, but is more human readable
let bad_input = "-----BEGIN PGP SIGNED MESSAGE-----\n\n-\n-----BEGIN PGP SIGNATURE-----\n-";
let _ = pgp::composed::cleartext::CleartextSignedMessage::from_string(bad_input);
}
/// RPG-015
#[test]
fn rpg_015_cleartext_signed_message_from_string_panic2() {
let data = "-----BEGIN PGP SIGNED MESSAGE-----\n\r\nqq\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n-----BEGIN PGP SIGNATURE-----\n\n\n\n\n\n\n\n\n
qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq-qqqqqqqqqqqqqqqq\0----BE\u{7}IN-D*'S-- \u{1}{\0\0\u{1}\0\0\0\0\0\0\0\0\0\0\0\0\0\0-----BEGIN PGP PRIVATE KEY BLOCK
-----\n-----CEGIN PGP-----BEGIN OPENSSH PRIVATE qqqKEY----- M-----BEGIN OPENSSH PRIVATE KEY---- KEY----- M[ESSA-----BEGIN PGP SIGNED MESSAGE-----GE\t-
--\0\0\0\0\0\0>ATE KEY B- M[ESSAGE\t0--\0\0\0\0\0\0>ATE KEY BLOCK----%\n-----\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\
0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0>>>>>>>>\0\0\0\0\"DE-----END PGP PRIVATE KEY BLOCK---------BEYGIN PGP M[ESSAGE\t---\0\0>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>#>>>>>>>>>>>>>>>>>>>>>>>>>>>>qq>>>>>>>>>>>>>>>>>>>\t>>>>>>>PGP M[ESSAGE\t---\0\0>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>[ESSAGE\tw:::::::";
let _ = pgp::composed::cleartext::CleartextSignedMessage::from_string(data);
}
/// RPG-015
#[test]
fn rpg_015_cleartext_signed_message_from_armor_panic2() {
let data = vec![
45, 45, 45, 45, 45, 66, 69, 71, 73, 78, 32, 80, 71, 80, 32, 83, 73, 71, 78, 69, 68, 32, 77,
69, 83, 83, 65, 71, 69, 45, 45, 45, 45, 45, 10, 9, 10, 10, 10, 10, 10, 10, 10, 10, 10, 45,
89, 45, 45, 45, 45, 45, 10, 10, 10, 10, 10, 10, 10, 10, 10, 45, 45, 45, 45, 45, 66, 69, 71,
73, 78, 32, 80, 71, 80, 32, 83, 73, 71, 78, 65, 84, 85, 82, 69, 45, 45, 45, 45, 45, 10, 10,
10, 10, 10, 26, 45, 45, 45, 45, 45, 45, 45, 10, 10, 86, 10, 10, 10, 10, 10, 10, 10, 10, 10,
45, 45, 69, 78, 68, 32, 68, 83, 65, 32, 80, 82, 73, 86, 65, 84, 69, 32, 75, 69, 89, 45, 58,
26, 10, 10, 10, 10, 10, 10, 10, 86, 10, 10, 0, 0, 0, 0, 58, 58, 58, 58, 58, 58, 58, 58, 58,
58, 58, 58, 45, 0, 45, 45, 45, 45, 10, 10, 10, 10, 10, 45, 45, 45, 45, 45, 66, 69, 71, 73,
78, 32, 69, 67, 32, 80, 45, 45, 45, 45, 45, 66, 69, 71, 73, 78, 32, 80, 255, 255, 255, 255,
255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255,
255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255,
255, 255, 255, 255, 255, 255, 255, 255, 255, 71, 80, 32, 83, 73, 71, 78, 69, 68, 32, 77,
69, 83, 83, 65, 71, 69, 45, 0, 13, 10, 247, 255, 15, 0, 45, 45, 45, 45, 45, 45, 45, 69, 78,
68, 32, 69, 67, 32, 80, 82, 71, 80, 32, 80, 82, 73, 86, 65, 84, 69, 32, 75, 189, 10, 73,
86, 65, 84, 69, 45, 45, 45, 66, 187, 175, 73, 78, 32, 80, 71, 80, 32, 77, 69, 83, 83, 65,
71, 69, 45, 45, 83, 83, 65, 71, 69, 45, 45, 45, 45, 45, 133, 133, 133, 133, 10, 10, 10, 10,
10, 133, 133, 133, 64, 10, 86, 10, 10, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 7, 121, 0, 0, 0,
0, 0, 45, 0, 0, 0, 45, 45, 0, 13, 10, 45, 45, 45, 45, 10, 13, 10, 10, 45, 45, 45, 10, 166,
];
let _ = pgp::composed::cleartext::CleartextSignedMessage::from_armor(&data[..]);
}
/// RPG-007
#[test]
fn rpg_007_message_parser_panic1() {
let bad_input: &[u8] = &[0xff, 0x1];
// expected behavior
// [...] panicked at src/packet/many.rs:128:70:
// range end index 1 out of range for slice of length 0
let _ = Message::from_bytes(bad_input);
}
/// RPG-007
#[test]
fn rpg_007_message_from_armor_single_panic1() {
let bad_input: &[u8] = &[
45, 45, 45, 45, 45, 66, 69, 71, 73, 78, 32, 80, 71, 80, 32, 77, 69, 83, 83, 65, 71, 69, 45,
45, 45, 45, 45, 10, 54, 84, 54, 53, 45, 45, 45, 45, 45, 69, 78, 68, 32, 80, 71, 80, 32, 77,
69, 83, 83, 65, 71, 69, 45, 45, 45, 45, 45,
];
// expected bug behavior
// thread '<unnamed>' panicked at [..]/src/packet/many.rs:126:70:
// range end index 62 out of range for slice of length 1
let _ = Message::from_armor_single(bad_input);
}
/// RPG-017
#[test]
fn rpg_017_signed_public_key_as_unsigned_panic1() {
let bad_input: &[u8] = &[155, 4, 228, 4, 0, 4, 0];
let key = pgp::composed::SignedPublicKey::from_bytes(bad_input).unwrap();
// expected bug behavior:
// thread '<unnamed>' panicked at src/composed/signed_key/shared.rs:116:35:
// missing user ids
let _ = key.as_unsigned();
}
/// RPG-021
/// Actual fix is in RustCrypto/RSA
#[test]
fn rpg_021_signed_secret_key_encrypt_panic1() {
let bad_input: &[u8] = &[
197, 159, 4, 159, 1, 0, 20, 2, 0, 61, 0, 0, 0, 64, 0, 201, 0, 197, 0, 1, 251, 213, 0, 201,
0, 250, 196, 0, 197, 0, 197, 0, 197, 0, 201, 0, 197, 0, 197, 0, 201, 255, 255, 255, 255,
255, 255, 255, 5, 205, 205, 205, 205, 43, 129, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 1, 1, 1,
161, 4, 0, 242, 143, 4, 4, 135, 6, 0, 0, 0, 0, 6, 0, 0, 0, 0, 242, 143, 4, 4, 0, 0, 0, 0,
0, 0, 0, 2, 0, 0, 0, 1, 1, 1, 161, 4, 0, 143, 4, 4, 135, 6, 0, 0, 0, 0, 4, 0, 242, 143, 4,
4, 135, 6, 0, 0, 0, 0, 0, 0, 0, 0, 242, 143, 4, 4, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 1,
1, 143, 4, 4, 135, 6, 0, 0, 0, 0,
];
// no particular meaning of this data
let dummy_plaintext = vec![0u8; 128];
// note, this is non-deterministic, but does not matter for reproduction
let mut rng = rand::thread_rng();
let key = pgp::composed::SignedSecretKey::from_bytes(bad_input).unwrap();
// expected bug behavior on --release:
// thread '<unnamed>' panicked at [..]/rsa-0.9.6/src/algorithms/pkcs1v15.rs:51:39:
// range end index 18446744073709551492 out of range for slice of length 5
//
// expected bug behavior on --debug:
// thread 'signed_secret_key_encrypt_panic1' panicked at [..]/rsa-0.9.6/src/algorithms/pkcs1v15.rs:44:20:
// attempt to subtract with overflow
//
// crash also happens with pgp::types::EskType::V3_4
let _ciphertext = {
key.encrypt(
&mut rng,
dummy_plaintext.as_slice(),
pgp::types::EskType::V6,
)
};
}
/// RPG-021
#[cfg(feature = "unstable-curve448")]
#[test]
fn rpg_021_signed_secret_key_encrypt_panic2() {
let bad_input: &[u8] = &[
0x97, 0x04, 0x00, 0x1a, 0x1a, 0x1a, 0x1a, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x29,
];
// no particular meaning of this data
let dummy_plaintext = vec![0u8; 1];
// note, this is non-deterministic, but does not matter for reproduction
let mut rng = rand::thread_rng();
let key = pgp::composed::SignedSecretKey::from_bytes(bad_input).unwrap();
// expected bug behavior:
// thread '[..]' panicked at [..]/src/crypto/x448.rs:149:75:
// 56
//
// crash also happens with pgp::types::EskType::V3_4
let _ciphertext = {
key.encrypt(
&mut rng,
dummy_plaintext.as_slice(),
pgp::types::EskType::V6,
)
};
}
/// RPG-020
/// Actual fix is done in RustCrypto/RSA
#[test]
fn rpg_020_signed_secret_key_create_signature_panic1() {
let bad_input: &[u8] = &[
151, 3, 255, 251, 255, 63, 39, 254, 3, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 4,
];
let dummy_data: &[u8] = &[0];
let key = pgp::composed::SignedSecretKey::from_bytes(bad_input).unwrap();
// expected bug behavior:
// thread '<unnamed>' panicked at [..]/num-bigint-dig-0.8.4/src/algorithms/sub.rs:75:5:
// Cannot subtract b from a because b is larger than a.
let _ = key.create_signature(
|| "pw".into(),
pgp::crypto::hash::HashAlgorithm::SHA2_256,
dummy_data,
);
}
/// RPG-020
#[test]
fn rpg_020_signed_secret_key_create_signature_panic2() {
let bad_input: &[u8] = &[
0x97, 0x04, 0x00, 0x00, 0x08, 0x29, 0xc1, 0xfd, 0xff, 0x03, 0x03, 0x02, 0x08, 0x00, 0xf8,
0xff, 0x00, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0x00, 0xf8, 0xf8, 0xff, 0x00, 0xff,
0x00, 0xff, 0x00,
];
let dummy_data: &[u8] = &[0];
let key = pgp::composed::SignedSecretKey::from_bytes(bad_input).unwrap();
// expected bug behavior for --debug:
// thread [..] panicked at [..]/src/types/params/encrypted_secret.rs:155:48:
// attempt to subtract with overflow
//
// expected bug behavior for --release:
// thread '[..]' panicked at [..]/src/types/params/encrypted_secret.rs:155:39:
// assertion failed: mid <= self.len()
let _ = key.create_signature(
|| "pw".into(),
pgp::crypto::hash::HashAlgorithm::SHA2_256,
dummy_data,
);
}
/// RPG-020
#[test]
fn rpg_020_signed_secret_key_create_signature_oom_crash1() {
let bad_input: &[u8] = &[
0x97, 0x04, 0x00, 0x00, 0x08, 0x29, 0xc1, 0xfd, 0xff, 0x9f, 0x04, 0x8f, 0xe4, 0xff, 0xff,
0xff, 0xff, 0x80, 0x8f, 0x8f, 0x8f, 0x00, 0x01, 0x00, 0x00, 0x00, 0xaf, 0xf8, 0x1b, 0x1b,
];
let dummy_data: &[u8] = &[0];
let key = pgp::composed::SignedSecretKey::from_bytes(bad_input).unwrap();
// expected bug behavior:
// memory allocation of 137438871552 bytes failed
let _ = key.create_signature(
|| "pw".into(),
pgp::crypto::hash::HashAlgorithm::SHA2_256,
dummy_data,
);
}
/// RPG-010
#[test]
fn rpg_010_standalone_signature_subtract_with_overflow1() {
let bad_input: &[u8] = &[209, 3, 0, 252, 45];
// expected bug behavior
// thread '<unnamed>' panicked at src/packet/user_attribute.rs:165:41:
// attempt to subtract with overflow
let _ = pgp::composed::StandaloneSignature::from_bytes(bad_input);
}
/// RPG-009
#[test]
fn rpg_009_message_from_bytes_subtract_with_overflow1() {
let bad_input: &[u8] = &[187, 6, 227, 0, 255, 255, 255, 255, 255, 255, 255];
// depends on "--debug" profile
// expected bug behavior
// thread '<unnamed>' panicked at src/packet/public_key_parser.rs:250:47:
// attempt to subtract with overflow
let _ = Message::from_bytes(bad_input);
}
/// RPG-009
#[test]
fn rpg_009_message_from_bytes_subtract_with_overflow2() {
let bad_input: &[u8] = &[139, 4, 16, 0, 0, 0, 2, 0, 0];
// depends on "--debug" profile
// expected bug behavior
// thread '<unnamed>' panicked at src/packet/signature/de.rs:391:25:
// attempt to subtract with overflow
let _ = Message::from_bytes(bad_input);
}
/// RPG-009
#[test]
fn rpg_009_message_from_bytes_subtract_with_overflow3() {
let bad_input: &[u8] = &[151, 6, 7, 8, 0, 0, 0, 0, 0, 0, 0, 113, 113];
// depends on "--debug" profile
// expected bug behavior
// thread '<unnamed>' panicked at src/types/params/secret.rs:106:47:
// attempt to subtract with overflow
let _ = Message::from_bytes(bad_input);
}
|
