1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491
|
//@ check-pass
//@ aux-build:external_extern_fn.rs
#![crate_type = "lib"]
mod redeclared_different_signature {
mod a {
extern "C" {
fn clash(x: u8);
}
}
mod b {
extern "C" {
fn clash(x: u64); //~ WARN `clash` redeclared with a different signature
}
}
}
mod redeclared_same_signature {
mod a {
extern "C" {
fn no_clash(x: u8);
}
}
mod b {
extern "C" {
fn no_clash(x: u8);
}
}
}
extern crate external_extern_fn;
mod extern_no_clash {
// Should not clash with external_extern_fn::extern_fn.
extern "C" {
fn extern_fn(x: u8);
}
}
extern "C" {
fn some_other_new_name(x: i16);
#[link_name = "extern_link_name"]
fn some_new_name(x: i16);
#[link_name = "link_name_same"]
fn both_names_different(x: i16);
}
fn link_name_clash() {
extern "C" {
fn extern_link_name(x: u32);
//~^ WARN `extern_link_name` redeclared with a different signature
#[link_name = "some_other_new_name"]
//~^ WARN `some_other_extern_link_name` redeclares `some_other_new_name` with a different
fn some_other_extern_link_name(x: u32);
#[link_name = "link_name_same"]
//~^ WARN `other_both_names_different` redeclares `link_name_same` with a different
fn other_both_names_different(x: u32);
}
}
mod a {
extern "C" {
fn different_mod(x: u8);
}
}
mod b {
extern "C" {
fn different_mod(x: u64); //~ WARN `different_mod` redeclared with a different signature
}
}
extern "C" {
fn variadic_decl(x: u8, ...);
}
fn variadic_clash() {
extern "C" {
fn variadic_decl(x: u8); //~ WARN `variadic_decl` redeclared with a different signature
}
}
#[no_mangle]
fn no_mangle_name(x: u8) {}
extern "C" {
#[link_name = "unique_link_name"]
fn link_name_specified(x: u8);
}
fn tricky_no_clash() {
extern "C" {
// Shouldn't warn, because the declaration above actually declares a different symbol (and
// Rust's name resolution rules around shadowing will handle this gracefully).
fn link_name_specified() -> u32;
// The case of a no_mangle name colliding with an extern decl (see #28179) is related but
// shouldn't be reported by ClashingExternDeclarations, because this is an example of
// unmangled name clash causing bad behaviour in functions with a defined body.
fn no_mangle_name() -> u32;
}
}
mod banana {
mod one {
#[repr(C)]
struct Banana {
weight: u32,
length: u16,
}
extern "C" {
fn weigh_banana(count: *const Banana) -> u64;
}
}
mod two {
#[repr(C)]
struct Banana {
weight: u32,
length: u16,
} // note: distinct type
// This should not trigger the lint because two::Banana is structurally equivalent to
// one::Banana.
extern "C" {
fn weigh_banana(count: *const Banana) -> u64;
}
}
mod three {
// This _should_ trigger the lint, because repr(packed) should generate a struct that has a
// different layout.
#[repr(C, packed)]
struct Banana {
weight: u32,
length: u16,
}
#[allow(improper_ctypes)]
extern "C" {
fn weigh_banana(count: *const Banana) -> u64;
//~^ WARN `weigh_banana` redeclared with a different signature
}
}
mod four {
// This _should_ trigger the lint, because the type is not repr(C).
struct Banana {
weight: u32,
length: u16,
}
#[allow(improper_ctypes)]
extern "C" {
fn weigh_banana(count: *const Banana) -> u64;
//~^ WARN `weigh_banana` redeclared with a different signature
}
}
}
// 3-field structs can't be distinguished by ScalarPair, side-stepping some shortucts
// the logic used to (incorrectly) take.
mod banana3 {
mod one {
#[repr(C)]
struct Banana {
weight: u32,
length: u16,
color: u8,
}
extern "C" {
fn weigh_banana3(count: *const Banana) -> u64;
}
}
mod two {
#[repr(C)]
struct Banana {
weight: u32,
length: u16,
color: u8,
} // note: distinct type
// This should not trigger the lint because two::Banana is structurally equivalent to
// one::Banana.
extern "C" {
fn weigh_banana3(count: *const Banana) -> u64;
}
}
mod three {
// This _should_ trigger the lint, because repr(packed) should generate a struct that has a
// different layout.
#[repr(C, packed)]
struct Banana {
weight: u32,
length: u16,
color: u8,
}
#[allow(improper_ctypes)]
extern "C" {
fn weigh_banana3(count: *const Banana) -> u64;
//~^ WARN `weigh_banana3` redeclared with a different signature
}
}
mod four {
// This _should_ trigger the lint, because the type is not repr(C).
struct Banana {
weight: u32,
length: u16,
color: u8,
}
#[allow(improper_ctypes)]
extern "C" {
fn weigh_banana3(count: *const Banana) -> u64;
//~^ WARN `weigh_banana3` redeclared with a different signature
}
}
}
mod sameish_members {
mod a {
#[repr(C)]
struct Point {
x: i16,
y: i16,
}
extern "C" {
fn draw_point(p: Point);
}
}
mod b {
#[repr(C)]
struct Point {
coordinates: [i16; 2],
}
// It's possible we are overconservative for this case, as accessing the elements of the
// coordinates array might end up correctly accessing `.x` and `.y`. However, this may not
// always be the case, for every architecture and situation. This is also a really odd
// thing to do anyway.
extern "C" {
fn draw_point(p: Point);
//~^ WARN `draw_point` redeclared with a different signature
}
}
}
mod same_sized_members_clash {
mod a {
#[repr(C)]
struct Point3 {
x: f32,
y: f32,
z: f32,
}
extern "C" {
fn origin() -> Point3;
}
}
mod b {
#[repr(C)]
struct Point3 {
x: i32,
y: i32,
z: i32, // NOTE: Incorrectly redeclared as i32
}
extern "C" {
fn origin() -> Point3; //~ WARN `origin` redeclared with a different signature
}
}
}
mod transparent {
#[repr(transparent)]
struct T(usize);
mod a {
use super::T;
extern "C" {
fn transparent() -> T;
fn transparent_incorrect() -> T;
}
}
mod b {
extern "C" {
// Shouldn't warn here, because repr(transparent) guarantees that T's layout is the
// same as just the usize.
fn transparent() -> usize;
// Should warn, because there's a signedness conversion here:
fn transparent_incorrect() -> isize;
//~^ WARN `transparent_incorrect` redeclared with a different signature
}
}
}
mod missing_return_type {
mod a {
extern "C" {
fn missing_return_type() -> usize;
}
}
mod b {
extern "C" {
// This should output a warning because we can't assume that the first declaration is
// the correct one -- if this one is the correct one, then calling the usize-returning
// version would allow reads into uninitialised memory.
fn missing_return_type();
//~^ WARN `missing_return_type` redeclared with a different signature
}
}
}
mod non_zero_and_non_null {
mod a {
extern "C" {
fn non_zero_usize() -> core::num::NonZero<usize>;
fn non_null_ptr() -> core::ptr::NonNull<usize>;
}
}
mod b {
extern "C" {
// If there's a clash in either of these cases you're either gaining an incorrect
// invariant that the value is non-zero, or you're missing out on that invariant. Both
// cases are warning for, from both a caller-convenience and optimisation perspective.
fn non_zero_usize() -> usize;
//~^ WARN `non_zero_usize` redeclared with a different signature
fn non_null_ptr() -> *const usize;
//~^ WARN `non_null_ptr` redeclared with a different signature
}
}
}
// See #75739
mod non_zero_transparent {
mod a1 {
extern "C" {
fn f1() -> std::num::NonZero<usize>;
}
}
mod b1 {
#[repr(transparent)]
struct X(std::num::NonZero<usize>);
extern "C" {
fn f1() -> X;
}
}
mod a2 {
extern "C" {
fn f2() -> std::num::NonZero<usize>;
}
}
mod b2 {
#[repr(transparent)]
struct X1(std::num::NonZero<usize>);
#[repr(transparent)]
struct X(X1);
extern "C" {
// Same case as above, but with two layers of newtyping.
fn f2() -> X;
}
}
mod a3 {
#[repr(transparent)]
struct X(core::ptr::NonNull<i32>);
extern "C" {
fn f3() -> X;
}
}
mod b3 {
extern "C" {
fn f3() -> core::ptr::NonNull<i32>;
}
}
mod a4 {
#[repr(transparent)]
enum E {
X(std::num::NonZero<usize>),
}
extern "C" {
fn f4() -> E;
}
}
mod b4 {
extern "C" {
fn f4() -> std::num::NonZero<usize>;
}
}
}
mod null_optimised_enums {
mod a {
extern "C" {
fn option_non_zero_usize() -> usize;
fn option_non_zero_isize() -> isize;
fn option_non_null_ptr() -> *const usize;
fn option_non_zero_usize_incorrect() -> usize;
fn option_non_null_ptr_incorrect() -> *const usize;
}
}
mod b {
extern "C" {
// This should be allowed, because these conversions are guaranteed to be FFI-safe (see
// #60300)
fn option_non_zero_usize() -> Option<core::num::NonZero<usize>>;
fn option_non_zero_isize() -> Option<core::num::NonZero<isize>>;
fn option_non_null_ptr() -> Option<core::ptr::NonNull<usize>>;
// However, these should be incorrect (note isize instead of usize)
fn option_non_zero_usize_incorrect() -> isize;
//~^ WARN `option_non_zero_usize_incorrect` redeclared with a different signature
fn option_non_null_ptr_incorrect() -> *const isize;
//~^ WARN `option_non_null_ptr_incorrect` redeclared with a different signature
}
}
}
#[allow(improper_ctypes)]
mod unknown_layout {
mod a {
extern "C" {
pub fn generic(l: Link<u32>);
}
#[repr(C)]
pub struct Link<T> {
pub item: T,
pub next: *const Link<T>,
}
}
mod b {
extern "C" {
pub fn generic(l: Link<u32>);
}
#[repr(C)]
pub struct Link<T> {
pub item: T,
pub next: *const Link<T>,
}
}
}
mod hidden_niche {
mod a {
extern "C" {
fn hidden_niche_transparent() -> usize;
fn hidden_niche_transparent_no_niche() -> usize;
fn hidden_niche_unsafe_cell() -> usize;
}
}
mod b {
use std::cell::UnsafeCell;
use std::num::NonZero;
#[repr(transparent)]
struct Transparent {
x: NonZero<usize>,
}
#[repr(transparent)]
struct TransparentNoNiche {
y: UnsafeCell<NonZero<usize>>,
}
extern "C" {
fn hidden_niche_transparent() -> Option<Transparent>;
fn hidden_niche_transparent_no_niche() -> Option<TransparentNoNiche>;
//~^ WARN redeclared with a different signature
//~| WARN block uses type `Option<TransparentNoNiche>`, which is not FFI-safe
fn hidden_niche_unsafe_cell() -> Option<UnsafeCell<NonZero<usize>>>;
//~^ WARN redeclared with a different signature
//~| WARN block uses type `Option<UnsafeCell<NonZero<usize>>>`, which is not FFI-safe
}
}
}
|