1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468
|
//! This file contains tests relevant to Rustup's handling of updating PATHs.
//! It depends on self-update working, so if absolutely everything here breaks,
//! check those tests as well.
// Prefer omitting actually unpacking content while just testing paths.
const INIT_NONE: [&str; 4] = ["rustup-init", "-y", "--default-toolchain", "none"];
#[cfg(unix)]
mod unix {
use std::fmt::Display;
use std::fs;
use std::path::PathBuf;
use rustup::utils::raw;
use rustup_macros::integration_test as test;
use super::INIT_NONE;
use rustup::test::mock::clitools::{self, Scenario};
// Let's write a fake .rc which looks vaguely like a real script.
const FAKE_RC: &str = r#"
# Sources fruity punch.
. ~/fruit/punch
# Adds apples to PATH.
export PATH="$HOME/apple/bin"
"#;
const DEFAULT_EXPORT: &str = "export PATH=\"$HOME/.cargo/bin:$PATH\"\n";
const POSIX_SH: &str = "env";
fn source(dir: impl Display, sh: impl Display) -> String {
format!(". \"{dir}/{sh}\"\n")
}
// In 1.23 we used `source` instead of `.` by accident. This is not POSIX
// so we want to ensure that if we put this into someone's dot files, then
// with newer rustups we will revert that.
fn non_posix_source(dir: impl Display, sh: impl Display) -> String {
format!("source \"{dir}/{sh}\"\n")
}
#[test]
fn install_creates_necessary_scripts() {
clitools::test(Scenario::Empty, &|config| {
// Override the test harness so that cargo home looks like
// $HOME/.cargo by removing CARGO_HOME from the environment,
// otherwise the literal path will be written to the file.
let mut cmd = clitools::cmd(config, "rustup-init", &INIT_NONE[1..]);
let files: Vec<PathBuf> = [".cargo/env", ".profile", ".zshenv"]
.iter()
.map(|file| config.homedir.join(file))
.collect();
for file in &files {
assert!(!file.exists());
}
cmd.env_remove("CARGO_HOME");
cmd.env("SHELL", "zsh");
assert!(cmd.output().unwrap().status.success());
let mut rcs = files.iter();
let env = rcs.next().unwrap();
let envfile = fs::read_to_string(env).unwrap();
let (_, envfile_export) = envfile.split_at(envfile.find("export PATH").unwrap_or(0));
assert_eq!(&envfile_export[..DEFAULT_EXPORT.len()], DEFAULT_EXPORT);
for rc in rcs {
let expected = source("$HOME/.cargo", POSIX_SH);
let new_profile = fs::read_to_string(rc).unwrap();
assert_eq!(new_profile, expected);
}
});
}
#[test]
fn install_updates_bash_rcs() {
clitools::test(Scenario::Empty, &|config| {
let rcs: Vec<PathBuf> = [".bashrc", ".bash_profile", ".bash_login", ".profile"]
.iter()
.map(|rc| config.homedir.join(rc))
.collect();
for rc in &rcs {
raw::write_file(rc, FAKE_RC).unwrap();
}
config.expect_ok(&INIT_NONE);
let expected = FAKE_RC.to_owned() + &source(config.cargodir.display(), POSIX_SH);
for rc in &rcs {
let new_rc = fs::read_to_string(rc).unwrap();
assert_eq!(new_rc, expected);
}
})
}
#[test]
fn install_does_not_create_bash_rcs() {
clitools::test(Scenario::Empty, &|config| {
let rcs: Vec<PathBuf> = [".bashrc", ".bash_profile", ".bash_login"]
.iter()
.map(|rc| config.homedir.join(rc))
.collect();
let rcs_before = rcs.iter().map(|rc| rc.exists());
config.expect_ok(&INIT_NONE);
for (before, after) in rcs_before.zip(rcs.iter().map(|rc| rc.exists())) {
assert!(!before);
assert_eq!(before, after);
}
});
}
// This test should NOT be run as root!
#[test]
fn install_errors_when_rc_cannot_be_updated() {
clitools::test(Scenario::Empty, &|config| {
let rc = config.homedir.join(".profile");
fs::File::create(&rc).unwrap();
let mut perms = fs::metadata(&rc).unwrap().permissions();
perms.set_readonly(true);
fs::set_permissions(&rc, perms).unwrap();
config.expect_err(&INIT_NONE, "amend shell");
});
}
#[test]
fn install_with_zdotdir() {
clitools::test(Scenario::Empty, &|config| {
let zdotdir = tempfile::Builder::new()
.prefix("zdotdir")
.tempdir()
.unwrap();
let rc = zdotdir.path().join(".zshenv");
raw::write_file(&rc, FAKE_RC).unwrap();
let mut cmd = clitools::cmd(config, "rustup-init", &INIT_NONE[1..]);
cmd.env("SHELL", "zsh");
cmd.env("ZDOTDIR", zdotdir.path());
assert!(cmd.output().unwrap().status.success());
let new_rc = fs::read_to_string(&rc).unwrap();
let expected = FAKE_RC.to_owned() + &source(config.cargodir.display(), POSIX_SH);
assert_eq!(new_rc, expected);
});
}
#[test]
fn install_with_zdotdir_from_calling_zsh() {
// This test requires that zsh is callable.
if std::process::Command::new("zsh")
.arg("-c")
.arg("true")
.status()
.is_err()
{
return;
}
clitools::test(Scenario::Empty, &|config| {
let zdotdir = tempfile::Builder::new()
.prefix("zdotdir")
.tempdir()
.unwrap();
let rc = zdotdir.path().join(".zshenv");
raw::write_file(&rc, FAKE_RC).unwrap();
// If $SHELL doesn't include "zsh", Zsh::zdotdir() will call zsh to obtain $ZDOTDIR.
// ZDOTDIR could be set directly in the environment, but having ~/.zshenv set
// ZDOTDIR is a normal setup, and ensures that the value came from calling zsh.
let home_zshenv = config.homedir.join(".zshenv");
let export_zdotdir = format!(
"export ZDOTDIR=\"{}\"\n",
zdotdir.path().as_os_str().to_str().unwrap()
);
raw::write_file(&home_zshenv, &export_zdotdir).unwrap();
let mut cmd = clitools::cmd(config, "rustup-init", &INIT_NONE[1..]);
cmd.env("SHELL", "/bin/sh");
assert!(cmd.output().unwrap().status.success());
let new_rc = fs::read_to_string(&rc).unwrap();
let expected = FAKE_RC.to_owned() + &source(config.cargodir.display(), POSIX_SH);
assert_eq!(new_rc, expected);
});
}
#[test]
fn install_adds_path_to_rc_just_once() {
clitools::test(Scenario::Empty, &|config| {
let profile = config.homedir.join(".profile");
raw::write_file(&profile, FAKE_RC).unwrap();
config.expect_ok(&INIT_NONE);
config.expect_ok(&INIT_NONE);
let new_profile = fs::read_to_string(&profile).unwrap();
let expected = FAKE_RC.to_owned() + &source(config.cargodir.display(), POSIX_SH);
assert_eq!(new_profile, expected);
});
}
#[test]
fn install_adds_path_to_rc_handling_no_newline() {
clitools::test(Scenario::Empty, &|config| {
let profile = config.homedir.join(".profile");
let fake_rc_modified = FAKE_RC.strip_suffix('\n').expect("Should end in a newline");
raw::write_file(&profile, fake_rc_modified).unwrap();
// Run once to add the configuration
config.expect_ok(&INIT_NONE);
// Run twice to test that the process is idempotent
config.expect_ok(&INIT_NONE);
let new_profile = fs::read_to_string(&profile).unwrap();
let expected = FAKE_RC.to_owned() + &source(config.cargodir.display(), POSIX_SH);
assert_eq!(new_profile, expected);
});
}
#[test]
fn install_adds_path_to_multiple_rc_files() {
clitools::test(Scenario::Empty, &|config| {
// Two RC files that are both from the same shell
let bash_profile = config.homedir.join(".bash_profile");
let bashrc = config.homedir.join(".bashrc");
let expected = FAKE_RC.to_owned() + &source(config.cargodir.display(), POSIX_SH);
// The order that the two files are processed isn't known, so test both orders
for [path1, path2] in &[[&bash_profile, &bashrc], [&bashrc, &bash_profile]] {
raw::write_file(path1, &expected).unwrap();
raw::write_file(path2, FAKE_RC).unwrap();
config.expect_ok(&INIT_NONE);
let new1 = fs::read_to_string(path1).unwrap();
assert_eq!(new1, expected);
let new2 = fs::read_to_string(path2).unwrap();
assert_eq!(new2, expected);
}
});
}
#[test]
#[cfg(not(feature = "no-self-update"))]
fn uninstall_removes_source_from_rcs() {
clitools::test(Scenario::Empty, &|config| {
let rcs: Vec<PathBuf> = [
".bashrc",
".bash_profile",
".bash_login",
".profile",
".zshenv",
]
.iter()
.map(|rc| config.homedir.join(rc))
.collect();
for rc in &rcs {
raw::write_file(rc, FAKE_RC).unwrap();
}
config.expect_ok(&INIT_NONE);
config.expect_ok(&["rustup", "self", "uninstall", "-y"]);
for rc in &rcs {
let new_rc = fs::read_to_string(rc).unwrap();
assert_eq!(new_rc, FAKE_RC);
}
})
}
#[test]
fn install_adds_sources_while_removing_legacy_paths() {
clitools::test(Scenario::Empty, &|config| {
let zdotdir = tempfile::Builder::new()
.prefix("zdotdir")
.tempdir()
.unwrap();
let rcs: Vec<PathBuf> = [".bash_profile", ".profile"]
.iter()
.map(|rc| config.homedir.join(rc))
.collect();
let zprofiles = vec![
config.homedir.join(".zprofile"),
zdotdir.path().join(".zprofile"),
];
let old_rc =
FAKE_RC.to_owned() + DEFAULT_EXPORT + &non_posix_source("$HOME/.cargo", POSIX_SH);
for rc in rcs.iter().chain(zprofiles.iter()) {
raw::write_file(rc, &old_rc).unwrap();
}
let mut cmd = clitools::cmd(config, "rustup-init", &INIT_NONE[1..]);
cmd.env("SHELL", "zsh");
cmd.env("ZDOTDIR", zdotdir.path());
cmd.env_remove("CARGO_HOME");
assert!(cmd.output().unwrap().status.success());
let fixed_rc = FAKE_RC.to_owned() + &source("$HOME/.cargo", POSIX_SH);
for rc in &rcs {
let new_rc = fs::read_to_string(rc).unwrap();
assert_eq!(new_rc, fixed_rc);
}
for rc in &zprofiles {
let new_rc = fs::read_to_string(rc).unwrap();
assert_eq!(new_rc, FAKE_RC);
}
})
}
#[test]
#[cfg(not(feature = "no-self-update"))]
fn uninstall_cleans_up_legacy_paths() {
clitools::test(Scenario::Empty, &|config| {
// Install first, then overwrite.
config.expect_ok(&INIT_NONE);
let zdotdir = tempfile::Builder::new()
.prefix("zdotdir")
.tempdir()
.unwrap();
let mut cmd = clitools::cmd(config, "rustup-init", &INIT_NONE[1..]);
cmd.env("SHELL", "zsh");
cmd.env("ZDOTDIR", zdotdir.path());
cmd.env_remove("CARGO_HOME");
assert!(cmd.output().unwrap().status.success());
let mut rcs: Vec<PathBuf> = [".bash_profile", ".profile", ".zprofile"]
.iter()
.map(|rc| config.homedir.join(rc))
.collect();
rcs.push(zdotdir.path().join(".zprofile"));
let old_rc =
FAKE_RC.to_owned() + DEFAULT_EXPORT + &non_posix_source("$HOME/.cargo", POSIX_SH);
for rc in &rcs {
raw::write_file(rc, &old_rc).unwrap();
}
let mut cmd = clitools::cmd(config, "rustup", ["self", "uninstall", "-y"]);
cmd.env("SHELL", "zsh");
cmd.env("ZDOTDIR", zdotdir.path());
cmd.env_remove("CARGO_HOME");
assert!(cmd.output().unwrap().status.success());
for rc in &rcs {
let new_rc = fs::read_to_string(rc).unwrap();
// It's not ideal, but it's OK, if we leave whitespace.
assert_eq!(new_rc, FAKE_RC);
}
})
}
// In the default case we want to write $HOME/.cargo/bin as the path,
// not the full path.
#[test]
#[cfg(not(feature = "no-self-update"))]
fn when_cargo_home_is_the_default_write_path_specially() {
clitools::test(Scenario::Empty, &|config| {
// Override the test harness so that cargo home looks like
// $HOME/.cargo by removing CARGO_HOME from the environment,
// otherwise the literal path will be written to the file.
let profile = config.homedir.join(".profile");
raw::write_file(&profile, FAKE_RC).unwrap();
let mut cmd = clitools::cmd(config, "rustup-init", &INIT_NONE[1..]);
cmd.env_remove("CARGO_HOME");
assert!(cmd.output().unwrap().status.success());
let new_profile = fs::read_to_string(&profile).unwrap();
let expected = format!("{FAKE_RC}. \"$HOME/.cargo/env\"\n");
assert_eq!(new_profile, expected);
let mut cmd = clitools::cmd(config, "rustup", ["self", "uninstall", "-y"]);
cmd.env_remove("CARGO_HOME");
assert!(cmd.output().unwrap().status.success());
let new_profile = fs::read_to_string(&profile).unwrap();
assert_eq!(new_profile, FAKE_RC);
});
}
#[test]
fn install_doesnt_modify_path_if_passed_no_modify_path() {
clitools::test(Scenario::Empty, &|config| {
let profile = config.homedir.join(".profile");
config.expect_ok(&[
"rustup-init",
"-y",
"--no-modify-path",
"--default-toolchain",
"none",
]);
assert!(!profile.exists());
});
}
}
#[cfg(windows)]
mod windows {
use rustup::test::mock::clitools::{self, Scenario};
use rustup::test::{get_path, with_saved_path};
use rustup_macros::integration_test as test;
use super::INIT_NONE;
#[test]
/// Smoke test for end-to-end code connectivity of the installer path mgmt on windows.
fn install_uninstall_affect_path() {
clitools::test(Scenario::Empty, &|config| {
with_saved_path(&mut || {
let cfg_path = config.cargodir.join("bin").display().to_string();
let get_path_ = || get_path().unwrap().unwrap().to_string();
config.expect_ok(&INIT_NONE);
assert!(
get_path_().contains(cfg_path.trim_matches('"')),
"`{}` not in `{}`",
cfg_path,
get_path_()
);
config.expect_ok(&["rustup", "self", "uninstall", "-y"]);
assert!(!get_path_().contains(&cfg_path));
})
});
}
#[test]
/// Smoke test for end-to-end code connectivity of the installer path mgmt on windows.
fn install_uninstall_affect_path_with_non_unicode() {
use std::ffi::OsString;
use std::os::windows::ffi::OsStrExt;
use winreg::enums::{RegType, HKEY_CURRENT_USER, KEY_READ, KEY_WRITE};
use winreg::{RegKey, RegValue};
clitools::test(Scenario::Empty, &|config| {
with_saved_path(&mut || {
// Set up a non unicode PATH
let reg_value = RegValue {
bytes: vec![
0x00, 0xD8, // leading surrogate
0x01, 0x01, // bogus trailing surrogate
0x00, 0x00, // null
],
vtype: RegType::REG_EXPAND_SZ,
};
RegKey::predef(HKEY_CURRENT_USER)
.open_subkey_with_flags("Environment", KEY_READ | KEY_WRITE)
.unwrap()
.set_raw_value("PATH", ®_value)
.unwrap();
// compute expected path after installation
let expected = RegValue {
bytes: OsString::from(config.cargodir.join("bin"))
.encode_wide()
.flat_map(|v| vec![v as u8, (v >> 8) as u8])
.chain(vec![b';', 0])
.chain(reg_value.bytes.iter().copied())
.collect(),
vtype: RegType::REG_EXPAND_SZ,
};
config.expect_ok(&INIT_NONE);
assert_eq!(get_path().unwrap().unwrap(), expected);
config.expect_ok(&["rustup", "self", "uninstall", "-y"]);
assert_eq!(get_path().unwrap().unwrap(), reg_value);
})
});
}
}
|