1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478
|
;;;; package lock tests with side effects
;;;; This software is part of the SBCL system. See the README file for
;;;; more information.
;;;;
;;;; While most of SBCL is derived from the CMU CL system, the test
;;;; files (like this one) were written from scratch after the fork
;;;; from CMU CL.
;;;;
;;;; This software is in the public domain and is provided with
;;;; absolutely no warranty. See the COPYING and CREDITS files for
;;;; more information.
(in-package :cl-user)
(load "assertoid.lisp")
(use-package "ASSERTOID")
;;;; Our little labrats and a few utilities
(defpackage :test-used)
(defpackage :test-unused)
(defpackage :test-aux (:export #:noslot #:noslot2))
(defpackage :test
(:use :test-used)
(:shadow #:shadowed)
(:export
#:*special*
#:car
#:cdr
#:class
#:constant
#:external
#:function
#:macro
#:noclass
#:noclass-slot
#:nocondition
#:nocondition-slot
#:nospecial
#:nostruct
#:nostruct2
#:nostruct-slot
#:nosymbol-macro
#:notype
#:num
#:numfun
#:shadowed
#:symbol-macro
#:unused
))
(defvar *uninterned* "UNINTERNED")
(defvar *interned* "INTERNED")
(defun maybe-unintern (name package)
(let ((s (find-symbol name package)))
(when s
(unintern s package))))
(defun set-test-locks (lock-p)
(dolist (p '(:test :test-aux :test-delete))
(when (find-package p)
(if lock-p
(sb-ext:lock-package p)
(sb-ext:unlock-package p)))))
(defun reset-test (lock)
"Reset TEST package to a known state, ensure that TEST-DELETE exists."
(unless (find-package :test-delete)
(make-package :test-delete))
(sb-ext:with-unlocked-packages (:test :test-aux)
(dolist (s '(test:nosymbol-macro
test:noclass test:nostruct test:nostruct2 test:nocondition))
(makunbound s)
(unintern s)
(intern (symbol-name s) :test))
(rename-package (find-package :test) :test)
(unexport (intern "INTERNAL" :test) :test)
(intern *interned* :test)
(use-package :test-used :test)
(export 'test::external :test)
(unuse-package :test-unused :test)
(defclass test:class () ())
(defun test:function () 'test:function)
(defmacro test:macro () ''test:macro)
(defparameter test:*special* 'test:*special*)
(defconstant test:constant 'test:constant)
(intern "UNUSED" :test)
(dolist (s '(test:nocondition-slot test:noclass-slot test:nostruct-slot
test-aux:noslot test-aux:noslot2))
(fmakunbound s))
(ignore-errors (progn
(fmakunbound 'test:unused)
(makunbound 'test:unused)))
(maybe-unintern *uninterned* :test)
(maybe-unintern "NOT-FROM-TEST" :test)
(defconstant test:num 0)
(define-symbol-macro test:symbol-macro "SYMBOL-MACRO")
(defun test:numfun (n) n)
(defun test:car (cons) (cl:car cons))
(defun (setf test:cdr) (obj cons) (setf (cl:cdr cons) obj))
(assert (not (find-symbol *uninterned* :test))))
(set-test-locks lock))
(defun tmp-fmakunbound (x)
"FMAKUNDBOUND x, then restore the original binding."
(let ((f (fdefinition x)))
(fmakunbound x)
(ignore-errors (setf (fdefinition x) f))))
(defmacro with-error-info ((string &rest args) &body forms)
`(handler-bind ((error (lambda (e)
(format t ,string ,@args)
(finish-output))))
(progn ,@forms)))
;;;; Test cases
;;; A collection of forms that are legal both with and without package
;;; locks.
(defvar *legal-forms*
'(;; package alterations that don't actually mutate the package
(intern *interned* :test)
(import 'test:unused :test)
(shadowing-import 'test:shadowed :test)
(export 'test:unused :test)
(unexport 'test::internal :test)
(let ((p (find-package :test)))
(rename-package p :test))
(use-package :test-used :test)
(unuse-package :test-unused :test)
(shadow "SHADOWED" :test)
(let ((s (with-unlocked-packages (:test)
(let ((s (intern *uninterned* :test)))
(unintern s :test)
s))))
(unintern s :test))
;; binding and altering value
(let ((test:function 123))
(assert (eql test:function 123)))
(let ((test:*special* :foo))
(assert (eql test:*special* :foo)))
(progn
(setf test:*special* :quux)
(assert (eql test:*special* :quux)))
(let ((test:unused :zot))
(assert (eql test:unused :zot)))
;; symbol-macrolet
(symbol-macrolet ((test:function :sym-ok))
(assert (eql test:function :sym-ok)))
(symbol-macrolet ((test:unused :sym-ok2))
(assert (eql test:unused :sym-ok2)))
;; binding as a function
(flet ((test:*special* () :yes))
(assert (eql (test:*special*) :yes)))
(flet ((test:unused () :yes!))
(assert (eql (test:unused) :yes!)))
(labels ((test:*special* () :yes))
(assert (eql (test:*special*) :yes)))
(labels ((test:unused () :yes!))
(assert (eql (test:unused) :yes!)))
;; binding as a macro
(macrolet ((test:*special* () :ok))
(assert (eql (test:*special*) :ok)))
))
;;; A collection of forms that cause runtime package lock violations
;;; on TEST, and will also signal an error on LOAD even if first
;;; compiled with COMPILE-FILE with TEST unlocked.
(defvar *illegal-runtime-forms*
'(;; package alterations
(intern *uninterned* :test)
(import 'not-from-test :test)
(export 'test::internal :test)
(unexport 'test:external :test)
(shadowing-import 'not-from-test :test)
(let ((p (find-package :test)))
(rename-package p :test '(:test-nick)))
(use-package :test-unused :test)
(unuse-package :test-used :test)
(shadow 'not-from-test :test)
(unintern (or (find-symbol *interned* :test) (error "bugo")) :test)
(delete-package :test-delete)
;; defining or undefining as a function
(defun test:unused () 'foo)
(setf (fdefinition 'test:unused) (lambda () 'bar))
(setf (symbol-function 'test:unused) (lambda () 'quux))
(tmp-fmakunbound 'test:function)
;; defining or undefining as a macro or compiler macro
(defmacro test:unused () ''foo)
(setf (macro-function 'test:unused) (constantly 'foo))
(define-compiler-macro test:unused (&whole form arg)
form)
(setf (compiler-macro-function 'test:unused) (constantly 'foo))
;; type-specifier or structure
(progn
(defstruct test:nostruct test:nostruct-slot)
;; test creation as well, since the structure-class won't be
;; finalized before that
(make-nostruct :nostruct-slot :foo))
(defclass test:noclass ()
((slot :initform nil :accessor test:noclass-slot)))
(deftype test:notype () 'string)
(define-condition test:nocondition (error)
((slot :initform nil :accessor test:nocondition-slot)))
;; symbol-macro
(define-symbol-macro test:nosymbol-macro 'foo)
;; declaration proclamation
(proclaim '(declaration test:unused))
;; declare special
(declaim (special test:nospecial))
(proclaim '(special test:nospecial))
;; declare type
(declaim (type fixnum test:num))
(proclaim '(type fixnum test:num))
;; declare ftype
(declaim (ftype (function (fixnum) fixnum) test:numfun))
(proclaim '(ftype (function (fixnum) fixnum) test:numfun))
;; setf expanders
(defsetf test:car rplaca) ; strictly speaking wrong, but ok as a test
(defsetf test:car (cons) (new-car)
`(setf (car ,cons) ,new-car))
(define-setf-expander test:car (place)
(multiple-value-bind (dummies vals newval setter getter)
(get-setf-expansion place)
(let ((store (gensym)))
(values dummies
vals
`(,store)
`(progn (rplaca ,getter ,store) ,store)
`(car ,getter)))))
;; setf function names
(defun (setf test:function) (obj)
obj)
(tmp-fmakunbound '(setf test:cdr))
;; define-method-combination
(define-method-combination test:unused)
;; setf find-class
(setf (find-class 'test:class) (find-class 'standard-class))
))
;;; Forms that cause violations on two distinct packages.
(defvar *illegal-double-forms*
'((defclass test:noclass () ((x :accessor test-aux:noslot)))
(define-condition test:nocondition (error)
((x :accessor test-aux:noslot2)))))
;;; A collection of forms that cause compile-time package lock
;;; violations on TEST, and will not signal an error on LOAD if first
;;; compiled by COMPILE-FILE with test unlocked. CAR is the affected
;;; symbol, CDR the form affecting it.
(defvar *illegal-lexical-forms-alist*
'(;; binding
;; binding as a function
(test:function . (flet ((test:function () :shite))
(test:function)))
(test:function . (labels ((test:function () :shite))
(test:function)))
(test:macro . (flet ((test:macro () :shite))
(test:macro)))
(test:macro . (labels ((test:macro () :shite))
(test:macro)))
;; macrolet
(test:function . (macrolet ((test:function () :yuk))
(test:function)))
(test:macro . (macrolet ((test:macro () :yuk))
(test:macro)))
;; setf name
(test:function . (flet (((setf test:function) (obj)
obj))
(setf (test:function) 1)))
;; ftype
(test:function . (locally
(declare (ftype function test:function))
(cons t t)))
;; type
(test:num . (locally
(declare (type fixnum test:num))
(cons t t)))
;; special
(test:nospecial . (locally
(declare (special test:nospecial))
(cons t t)))
;; declare ftype
(test:numfun . (locally
(declare (ftype (function (fixnum) fixnum) test:numfun))
(cons t t)))))
(defvar *illegal-lexical-forms*
(mapcar #'cdr *illegal-lexical-forms-alist*))
(defvar *illegal-forms* (append *illegal-runtime-forms*
*illegal-lexical-forms*
*illegal-double-forms*))
;;;; Running the tests
;;; Unlocked. No errors nowhere.
(reset-test nil)
(dolist (form (append *legal-forms* *illegal-forms*))
(with-error-info ("~Unlocked form: ~S~%" form)
(eval form)))
;;; Locked. Errors for all illegal forms, none for legal.
(reset-test t)
(dolist (form *legal-forms*)
(with-error-info ("locked legal form: ~S~%" form)
(eval form)))
(dolist (form (append *illegal-runtime-forms* *illegal-double-forms*))
(with-error-info ("locked illegal runtime form: ~S~%" form)
(let ((fun (compile nil `(lambda () ,form))))
(assert (raises-error? (funcall fun) sb-ext:package-lock-violation)))
(assert (raises-error? (eval form) sb-ext:package-lock-violation))))
(dolist (pair *illegal-lexical-forms-alist*)
(let ((form (cdr pair)))
(with-error-info ("compile locked illegal lexical form: ~S~%" form)
(let ((fun (compile nil `(lambda () ,form))))
(assert (raises-error? (funcall fun) program-error)))
(assert (raises-error? (eval form) program-error)))))
;;; Locked, WITHOUT-PACKAGE-LOCKS
(reset-test t)
(dolist (form *illegal-runtime-forms*)
(with-error-info ("without-package-locks illegal runtime form: ~S~%" form)
(funcall (compile nil `(lambda () (without-package-locks ,form))))))
(dolist (form *illegal-lexical-forms*)
(let ((fun (without-package-locks (compile nil `(lambda () ,form)))))
(funcall fun))
(without-package-locks (eval form)))
;;; Locked, DISABLE-PACKAGE-LOCKS
(reset-test t)
(dolist (pair *illegal-lexical-forms-alist*)
(destructuring-bind (sym . form) pair
(with-error-info ("disable-package-locks on illegal form: ~S~%"
form)
(funcall (compile nil `(lambda ()
(declare (disable-package-locks ,sym))
,form)))
(eval `(locally
(declare (disable-package-locks ,sym))
,form)))))
;;; Locked, one error per "lexically apparent violated package", also
;;; test restarts.
(reset-test t)
(dolist (form *illegal-runtime-forms*)
(with-error-info ("one error per form ~S~%" form)
(let ((errorp nil))
(handler-bind ((package-lock-violation (lambda (e)
(when errorp
(error "multiple errors"))
(setf errorp t)
(continue e))))
(eval form)))))
(dolist (form *illegal-double-forms*)
(with-error-info ("two errors per form: ~S~%" form)
(let ((error-count 0))
;; check that we don't get multiple errors from a single form
(handler-bind ((package-lock-violation (lambda (x)
(declare (ignore x))
(incf error-count)
(continue x))))
(eval form)
(unless (= 2 error-count)
(error "expected 2 errors per form, got ~A for ~A"
error-count form))))))
;;; COMPILE-FILE when unlocked, LOAD locked -- *illegal-runtime-forms* only
;;;
;;; This is not part of the interface, but it is the behaviour we want
(let* ((tmp "package-locks.tmp.lisp")
(fasl (compile-file-pathname tmp))
(n 0))
(dolist (form *illegal-runtime-forms*)
(unwind-protect
(with-simple-restart (next "~S failed, continue with next test" form)
(reset-test nil)
(with-open-file (f tmp :direction :output)
(prin1 form f))
(multiple-value-bind (file warnings failure-p) (compile-file tmp)
(set-test-locks t)
(assert (raises-error? (load fasl)
sb-ext:package-lock-violation))))
(when (probe-file tmp)
(delete-file tmp))
(when (probe-file fasl)
(delete-file fasl)))))
;;;; Tests for enable-package-locks declarations
(reset-test t)
(dolist (pair *illegal-lexical-forms-alist*)
(destructuring-bind (sym . form) pair
(let ((fun (compile nil `(lambda ()
(declare (disable-package-locks ,sym))
,form
(locally (declare (enable-package-locks ,sym))
,form)))))
(assert (raises-error? (funcall fun) program-error)))
(assert (raises-error?
(eval `(locally (declare (disable-package-locks ,sym))
,form
(locally (declare (enable-package-locks ,sym))
,form)))
program-error))))
;;;; See that trace on functions in locked packages doesn't break
;;;; anything.
(assert (trace test:function :break t))
;;;; No bogus violations from defclass with accessors in a locked
;;;; package. Reported by by Francois-Rene Rideau.
(assert (package-locked-p :sb-gray))
(multiple-value-bind (fun compile-errors)
(ignore-errors
(compile
nil
'(lambda ()
(defclass fare-class ()
((line-column :initform 0 :reader sb-gray:stream-line-column))))))
(assert (not compile-errors))
(assert fun)
(multiple-value-bind (class run-errors) (ignore-errors (funcall fun))
(assert (not run-errors))
(assert (eq class (find-class 'fare-class)))))
;;;; No bogus violations from DECLARE's done by PCL behind the
;;;; scenes. Reported by David Wragg on sbcl-help.
(reset-test t)
(defmethod pcl-type-declaration-method-bug ((test:*special* stream))
test:*special*)
(assert (eq *terminal-io* (pcl-type-declaration-method-bug *terminal-io*)))
(assert (raises-error?
(eval
'(defmethod pcl-type-declaration-method-bug ((test:*special* stream))
(declare (type stream test:*special*))
test:*special*))
program-error))
;;; WOOT! Done.
|