1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
|
From: Damien Goutte-Gattat <dgouttegattat@incenp.org>
Date: Sat, 19 May 2018 22:03:21 +0000 (+0100)
Subject: Do not request certificate data when LEARNing.
X-Git-Url: http://git.gnupg.org/cgi-bin/gitweb.cgi?p=scute.git;a=commitdiff_plain;h=f31e6af6e2d9e320dedc89e0b6b2692b7d72cda7
Do not request certificate data when LEARNing.
* src/agent.c (scute_agent_learn): Use LEARN --sendinfo instead
of LEARN --send.
--
Using --send is useless here and we don't even collect the data
that the agent may send (no data callback), which may cause the
LEARN command to fail.
Of note, the --sendinfo option is available since GnuPG 2.1.1,
meaning Scute would not work anymore with GnuPG 2.0.x. Since that
branch is now EOLed, this should not be a concern.
Signed-off-by: Damien Goutte-Gattat <dgouttegattat@incenp.org>
---
diff --git a/src/agent.c b/src/agent.c
index 108e1ea..46d56d5 100644
--- a/src/agent.c
+++ b/src/agent.c
@@ -640,7 +640,7 @@ scute_agent_learn (struct agent_card_info_s *info)
gpg_error_t err;
memset (info, 0, sizeof (*info));
- err = assuan_transact (agent_ctx, "LEARN --send",
+ err = assuan_transact (agent_ctx, "LEARN --sendinfo",
NULL, NULL, default_inq_cb,
NULL, learn_status_cb, info);
|
