1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512
|
/*
* This file is open source software, licensed to you under the terms
* of the Apache License, Version 2.0 (the "License"). See the NOTICE file
* distributed with this work for additional information regarding copyright
* ownership. You may not use this file except in compliance with the License.
*
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
/*
* Copyright (C) 2021 ScyllaDB
*/
#include <seastar/core/thread.hh>
#include <seastar/core/sleep.hh>
#include <seastar/testing/random.hh>
#include <seastar/testing/test_case.hh>
#include <seastar/testing/thread_test_case.hh>
#include <seastar/testing/test_runner.hh>
#include <seastar/core/reactor.hh>
#include <seastar/core/when_all.hh>
#include <seastar/core/file.hh>
#include <seastar/core/io_queue.hh>
#include <seastar/core/io_intent.hh>
#include <seastar/core/internal/io_request.hh>
#include <seastar/core/internal/io_sink.hh>
#include <seastar/util/assert.hh>
#include <seastar/util/internal/iovec_utils.hh>
using namespace seastar;
struct fake_file {
std::unordered_map<uint64_t, int> data;
static internal::io_request make_write_req(size_t idx, int* buf) {
return internal::io_request::make_write(0, idx, buf, 1, false);
}
static internal::io_request make_writev_req(size_t idx, int* buf, size_t nr, size_t buf_len, std::vector<::iovec>& vecs) {
vecs.reserve(nr);
for (unsigned i = 0; i < nr; i++) {
vecs.push_back({ &buf[i], buf_len });
}
return internal::io_request::make_writev(0, idx, vecs, false);
}
void execute_write_req(const internal::io_request& rq, io_completion* desc) {
const auto& op = rq.as<internal::io_request::operation::write>();
data[op.pos] = *(reinterpret_cast<int*>(op.addr));
desc->complete_with(op.size);
}
void execute_writev_req(const internal::io_request& rq, io_completion* desc) {
size_t len = 0;
const auto& op = rq.as<internal::io_request::operation::writev>();
for (unsigned i = 0; i < op.iov_len; i++) {
data[op.pos + i] = *(reinterpret_cast<int*>(op.iovec[i].iov_base));
len += op.iovec[i].iov_len;
}
desc->complete_with(len);
}
};
struct io_queue_for_tests {
io_group_ptr group;
internal::io_sink sink;
io_queue queue;
timer<> kicker;
io_queue_for_tests()
: group(std::make_shared<io_group>(io_queue::config{0}, 1))
, sink()
, queue(group, sink)
, kicker([this] { kick(); })
{
kicker.arm_periodic(std::chrono::microseconds(500));
}
void kick() {
for (auto&& fg : group->_fgs) {
fg.replenish_capacity(std::chrono::steady_clock::now());
}
}
future<size_t> queue_request(internal::priority_class pc, internal::io_direction_and_length dnl, internal::io_request req, io_intent* intent, iovec_keeper iovs) noexcept {
return queue.queue_request(pc, dnl, std::move(req), intent, std::move(iovs));
}
};
internal::priority_class get_default_pc() {
return internal::priority_class(current_scheduling_group());
}
SEASTAR_THREAD_TEST_CASE(test_basic_flow) {
io_queue_for_tests tio;
fake_file file;
auto val = std::make_unique<int>(42);
auto f = tio.queue_request(get_default_pc(), internal::io_direction_and_length(internal::io_direction_and_length::write_idx, 0), file.make_write_req(0, val.get()), nullptr, {})
.then([&file] (size_t len) {
BOOST_REQUIRE(file.data[0] == 42);
});
seastar::sleep(std::chrono::milliseconds(500)).get();
tio.queue.poll_io_queue();
tio.sink.drain([&file] (const internal::io_request& rq, io_completion* desc) -> bool {
file.execute_write_req(rq, desc);
return true;
});
f.get();
}
enum class part_flaw { none, partial, error };
static void do_test_large_request_flow(part_flaw flaw) {
io_queue_for_tests tio;
fake_file file;
int values[3] = { 13, 42, 73 };
auto limits = tio.queue.get_request_limits();
std::vector<::iovec> vecs;
auto f = tio.queue_request(get_default_pc(), internal::io_direction_and_length(internal::io_direction_and_length::write_idx, limits.max_write * 3),
file.make_writev_req(0, values, 3, limits.max_write, vecs), nullptr, std::move(vecs))
.then([&file, &values, &limits, flaw] (size_t len) {
size_t expected = limits.max_write;
BOOST_REQUIRE_EQUAL(file.data[0 * limits.max_write], values[0]);
if (flaw == part_flaw::none) {
BOOST_REQUIRE_EQUAL(file.data[1 * limits.max_write], values[1]);
BOOST_REQUIRE_EQUAL(file.data[2 * limits.max_write], values[2]);
expected += 2 * limits.max_write;
}
if (flaw == part_flaw::partial) {
BOOST_REQUIRE_EQUAL(file.data[1 * limits.max_write], values[1]);
expected += limits.max_write / 2;
}
BOOST_REQUIRE_EQUAL(len, expected);
});
for (int i = 0; i < 3; i++) {
seastar::sleep(std::chrono::milliseconds(500)).get();
tio.queue.poll_io_queue();
tio.sink.drain([&file, i, flaw] (const internal::io_request& rq, io_completion* desc) -> bool {
if (i == 1) {
if (flaw == part_flaw::partial) {
const auto& op = rq.as<internal::io_request::operation::writev>();
op.iovec[0].iov_len /= 2;
}
if (flaw == part_flaw::error) {
desc->complete_with(-EIO);
return true;
}
}
file.execute_writev_req(rq, desc);
return true;
});
}
f.get();
}
SEASTAR_THREAD_TEST_CASE(test_large_request_flow) {
do_test_large_request_flow(part_flaw::none);
}
SEASTAR_THREAD_TEST_CASE(test_large_request_flow_partial) {
do_test_large_request_flow(part_flaw::partial);
}
SEASTAR_THREAD_TEST_CASE(test_large_request_flow_error) {
do_test_large_request_flow(part_flaw::error);
}
SEASTAR_THREAD_TEST_CASE(test_intent_safe_ref) {
auto get_cancelled = [] (internal::intent_reference& iref) -> bool {
try {
iref.retrieve();
return false;
} catch(seastar::cancelled_error& err) {
return true;
}
};
io_intent intent, intent_x;
internal::intent_reference ref_orig(&intent);
BOOST_REQUIRE(ref_orig.retrieve() == &intent);
// Test move armed
internal::intent_reference ref_armed(std::move(ref_orig));
BOOST_REQUIRE(ref_orig.retrieve() == nullptr);
BOOST_REQUIRE(ref_armed.retrieve() == &intent);
internal::intent_reference ref_armed_2(&intent_x);
ref_armed_2 = std::move(ref_armed);
BOOST_REQUIRE(ref_armed.retrieve() == nullptr);
BOOST_REQUIRE(ref_armed_2.retrieve() == &intent);
intent.cancel();
BOOST_REQUIRE(get_cancelled(ref_armed_2));
// Test move cancelled
internal::intent_reference ref_cancelled(std::move(ref_armed_2));
BOOST_REQUIRE(ref_armed_2.retrieve() == nullptr);
BOOST_REQUIRE(get_cancelled(ref_cancelled));
internal::intent_reference ref_cancelled_2(&intent_x);
ref_cancelled_2 = std::move(ref_cancelled);
BOOST_REQUIRE(ref_cancelled.retrieve() == nullptr);
BOOST_REQUIRE(get_cancelled(ref_cancelled_2));
// Test move empty
internal::intent_reference ref_empty(std::move(ref_orig));
BOOST_REQUIRE(ref_empty.retrieve() == nullptr);
internal::intent_reference ref_empty_2(&intent_x);
ref_empty_2 = std::move(ref_empty);
BOOST_REQUIRE(ref_empty_2.retrieve() == nullptr);
}
static constexpr int nr_requests = 24;
SEASTAR_THREAD_TEST_CASE(test_io_cancellation) {
fake_file file;
io_queue_for_tests tio;
auto pc0 = internal::priority_class(create_scheduling_group("a", 100).get());
auto pc1 = internal::priority_class(create_scheduling_group("b", 100).get());
size_t idx = 0;
int val = 100;
io_intent live, dead;
std::vector<future<>> finished;
std::vector<future<>> cancelled;
auto queue_legacy_request = [&] (io_queue_for_tests& q, internal::priority_class pc) {
auto buf = std::make_unique<int>(val);
auto f = q.queue_request(pc, internal::io_direction_and_length(internal::io_direction_and_length::write_idx, 0), file.make_write_req(idx, buf.get()), nullptr, {})
.then([&file, idx, val, buf = std::move(buf)] (size_t len) {
BOOST_REQUIRE(file.data[idx] == val);
return make_ready_future<>();
});
finished.push_back(std::move(f));
idx++;
val++;
};
auto queue_live_request = [&] (io_queue_for_tests& q, internal::priority_class pc) {
auto buf = std::make_unique<int>(val);
auto f = q.queue_request(pc, internal::io_direction_and_length(internal::io_direction_and_length::write_idx, 0), file.make_write_req(idx, buf.get()), &live, {})
.then([&file, idx, val, buf = std::move(buf)] (size_t len) {
BOOST_REQUIRE(file.data[idx] == val);
return make_ready_future<>();
});
finished.push_back(std::move(f));
idx++;
val++;
};
auto queue_dead_request = [&] (io_queue_for_tests& q, internal::priority_class pc) {
auto buf = std::make_unique<int>(val);
auto f = q.queue_request(pc, internal::io_direction_and_length(internal::io_direction_and_length::write_idx, 0), file.make_write_req(idx, buf.get()), &dead, {})
.then_wrapped([buf = std::move(buf)] (auto&& f) {
try {
f.get();
BOOST_REQUIRE(false);
} catch(...) {}
return make_ready_future<>();
})
.then([&file, idx] () {
BOOST_REQUIRE(file.data[idx] == 0);
});
cancelled.push_back(std::move(f));
idx++;
val++;
};
auto seed = std::random_device{}();
std::default_random_engine reng(seed);
std::uniform_int_distribution<> dice(0, 5);
for (int i = 0; i < nr_requests; i++) {
int pc = dice(reng) % 2;
if (dice(reng) < 3) {
fmt::print("queue live req to pc {}\n", pc);
queue_live_request(tio, pc == 0 ? pc0 : pc1);
} else if (dice(reng) < 5) {
fmt::print("queue dead req to pc {}\n", pc);
queue_dead_request(tio, pc == 0 ? pc0 : pc1);
} else {
fmt::print("queue legacy req to pc {}\n", pc);
queue_legacy_request(tio, pc == 0 ? pc0 : pc1);
}
}
dead.cancel();
// cancelled requests must resolve right at once
when_all_succeed(cancelled.begin(), cancelled.end()).get();
seastar::sleep(std::chrono::milliseconds(500)).get();
tio.queue.poll_io_queue();
tio.sink.drain([&file] (const internal::io_request& rq, io_completion* desc) -> bool {
file.execute_write_req(rq, desc);
return true;
});
when_all_succeed(finished.begin(), finished.end()).get();
}
SEASTAR_TEST_CASE(test_request_buffer_split) {
auto ensure = [] (const std::vector<internal::io_request::part>& parts, const internal::io_request& req, int idx, uint64_t pos, size_t size, uintptr_t mem) {
BOOST_REQUIRE(parts[idx].req.opcode() == req.opcode());
const auto& op = req.as<internal::io_request::operation::read>();
const auto& sub_op = parts[idx].req.as<internal::io_request::operation::read>();
BOOST_REQUIRE_EQUAL(sub_op.fd, op.fd);
BOOST_REQUIRE_EQUAL(sub_op.pos, pos);
BOOST_REQUIRE_EQUAL(sub_op.size, size);
BOOST_REQUIRE_EQUAL(sub_op.addr, reinterpret_cast<void*>(mem));
BOOST_REQUIRE_EQUAL(sub_op.nowait_works, op.nowait_works);
BOOST_REQUIRE_EQUAL(parts[idx].iovecs.size(), 0);
BOOST_REQUIRE_EQUAL(parts[idx].size, sub_op.size);
};
// No split
{
internal::io_request req = internal::io_request::make_read(5, 13, reinterpret_cast<void*>(0x420), 17, true);
auto parts = req.split(21);
BOOST_REQUIRE_EQUAL(parts.size(), 1);
ensure(parts, req, 0, 13, 17, 0x420);
}
// Without tail
{
internal::io_request req = internal::io_request::make_read(7, 24, reinterpret_cast<void*>(0x4321), 24, true);
auto parts = req.split(12);
BOOST_REQUIRE_EQUAL(parts.size(), 2);
ensure(parts, req, 0, 24, 12, 0x4321);
ensure(parts, req, 1, 24 + 12, 12, 0x4321 + 12);
}
// With tail
{
internal::io_request req = internal::io_request::make_read(9, 42, reinterpret_cast<void*>(0x1234), 33, true);
auto parts = req.split(13);
BOOST_REQUIRE_EQUAL(parts.size(), 3);
ensure(parts, req, 0, 42, 13, 0x1234);
ensure(parts, req, 1, 42 + 13, 13, 0x1234 + 13);
ensure(parts, req, 2, 42 + 26, 7, 0x1234 + 26);
}
return make_ready_future<>();
}
static void show_request(const internal::io_request& req, void* buf_off, std::string pfx = "") {
if (!seastar_logger.is_enabled(log_level::trace)) {
return;
}
const auto& op = req.as<internal::io_request::operation::readv>();
seastar_logger.trace("{}{} iovecs on req:", pfx, op.iov_len);
for (unsigned i = 0; i < op.iov_len; i++) {
seastar_logger.trace("{} base={} len={}", pfx, reinterpret_cast<uintptr_t>(op.iovec[i].iov_base) - reinterpret_cast<uintptr_t>(buf_off), op.iovec[i].iov_len);
}
}
static void show_request_parts(const std::vector<internal::io_request::part>& parts, void* buf_off) {
if (!seastar_logger.is_enabled(log_level::trace)) {
return;
}
seastar_logger.trace("{} parts", parts.size());
for (const auto& p : parts) {
seastar_logger.trace(" size={} iovecs={}", p.size, p.iovecs.size());
seastar_logger.trace(" {} iovecs on part:", p.iovecs.size());
for (const auto& iov : p.iovecs) {
seastar_logger.trace(" base={} len={}", reinterpret_cast<uintptr_t>(iov.iov_base) - reinterpret_cast<uintptr_t>(buf_off), iov.iov_len);
}
show_request(p.req, buf_off, " ");
}
}
SEASTAR_TEST_CASE(test_request_iovec_split) {
char large_buffer[1025];
auto clear_buffer = [&large_buffer] {
memset(large_buffer, 0, sizeof(large_buffer));
};
auto bump_buffer = [] (const std::vector<::iovec>& vecs) {
for (auto&& v : vecs) {
for (unsigned i = 0; i < v.iov_len; i++) {
(reinterpret_cast<char*>(v.iov_base))[i]++;
}
}
};
auto check_buffer = [&large_buffer] (size_t len, char value) {
SEASTAR_ASSERT(len < sizeof(large_buffer));
bool fill_match = true;
bool train_match = true;
for (unsigned i = 0; i < sizeof(large_buffer); i++) {
if (i < len) {
if (large_buffer[i] != value) {
fill_match = false;
}
} else {
if (large_buffer[i] != '\0') {
train_match = false;
}
}
}
BOOST_REQUIRE_EQUAL(fill_match, true);
BOOST_REQUIRE_EQUAL(train_match, true);
};
auto ensure = [] (const std::vector<internal::io_request::part>& parts, const internal::io_request& req, int idx, uint64_t pos) {
BOOST_REQUIRE(parts[idx].req.opcode() == req.opcode());
const auto& op = req.as<internal::io_request::operation::writev>();
const auto& sub_op = parts[idx].req.as<internal::io_request::operation::writev>();
BOOST_REQUIRE_EQUAL(sub_op.fd, op.fd);
BOOST_REQUIRE_EQUAL(sub_op.pos, pos);
BOOST_REQUIRE_EQUAL(sub_op.iov_len, parts[idx].iovecs.size());
BOOST_REQUIRE_EQUAL(sub_op.nowait_works, op.nowait_works);
BOOST_REQUIRE_EQUAL(parts[idx].size, internal::iovec_len(parts[idx].iovecs));
for (unsigned iov = 0; iov < parts[idx].iovecs.size(); iov++) {
BOOST_REQUIRE_EQUAL(sub_op.iovec[iov].iov_base, parts[idx].iovecs[iov].iov_base);
BOOST_REQUIRE_EQUAL(sub_op.iovec[iov].iov_len, parts[idx].iovecs[iov].iov_len);
}
};
std::default_random_engine& reng = testing::local_random_engine;
auto dice = std::uniform_int_distribution<uint16_t>(1, 31);
auto stop = std::chrono::steady_clock::now() + std::chrono::seconds(4);
uint64_t iter = 0;
unsigned no_splits = 0;
unsigned no_tails = 0;
do {
seastar_logger.debug("===== iter {} =====", iter++);
std::vector<::iovec> vecs;
unsigned nr_vecs = dice(reng) % 13 + 1;
seastar_logger.debug("Generate {} iovecs", nr_vecs);
size_t total = 0;
for (unsigned i = 0; i < nr_vecs; i++) {
::iovec iov;
iov.iov_base = reinterpret_cast<void*>(large_buffer + total);
iov.iov_len = dice(reng);
SEASTAR_ASSERT(iov.iov_len != 0);
total += iov.iov_len;
vecs.push_back(std::move(iov));
}
SEASTAR_ASSERT(total > 0);
clear_buffer();
bump_buffer(vecs);
check_buffer(total, 1);
size_t file_off = dice(reng);
internal::io_request req = internal::io_request::make_readv(5, file_off, vecs, true);
show_request(req, large_buffer);
size_t max_len = dice(reng) * 3;
unsigned nr_parts = (total + max_len - 1) / max_len;
seastar_logger.debug("Split {} into {}-bytes ({} parts)", total, max_len, nr_parts);
auto parts = req.split(max_len);
show_request_parts(parts, large_buffer);
BOOST_REQUIRE_EQUAL(parts.size(), nr_parts);
size_t parts_total = 0;
for (unsigned p = 0; p < nr_parts; p++) {
ensure(parts, req, p, file_off + parts_total);
if (p < nr_parts - 1) {
BOOST_REQUIRE_EQUAL(parts[p].size, max_len);
}
parts_total += parts[p].size;
bump_buffer(parts[p].iovecs);
}
BOOST_REQUIRE_EQUAL(parts_total, total);
check_buffer(total, 2);
if (parts.size() == 1) {
no_splits++;
}
if (parts.back().size == max_len) {
no_tails++;
}
} while (std::chrono::steady_clock::now() < stop || iter < 32 || no_splits < 16 || no_tails < 16);
seastar_logger.info("{} iters ({} no-splits, {} no-tails)", iter, no_splits, no_tails);
return make_ready_future<>();
}
|