1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
|
// Copyright (c) 2018-2022, Sylabs Inc. All rights reserved.
// This software is licensed under a 3-clause BSD license. Please consult the
// LICENSE.md file distributed with the sources of this project regarding your
// rights to use or distribute this software.
package cgroups
import (
"os"
"os/exec"
"path"
"path/filepath"
"testing"
specs "github.com/opencontainers/runtime-spec/specs-go"
"github.com/sylabs/singularity/v4/internal/pkg/test"
"github.com/sylabs/singularity/v4/internal/pkg/test/tool/require"
)
// This file contains tests that will run under cgroups v1 only.
func TestCgroupsV1(t *testing.T) {
test.EnsurePrivilege(t)
require.CgroupsV1(t)
tests := CgroupTests{
{
name: "GetCGroupRootPath",
testFunc: testGetCgroupRootPathV1,
},
{
name: "GetCGroupRelPath",
testFunc: testGetCgroupRelPathV1,
},
{
name: "NewUpdate",
testFunc: testNewUpdateV1,
},
{
name: "UpdateUnified",
testFunc: testUpdateUnifiedV1,
},
{
name: "AddProc",
testFunc: testAddProcV1,
},
{
name: "FreezeThaw",
testFunc: testFreezeThawV1,
},
}
runCgroupfsTests(t, tests)
runSystemdTests(t, tests)
}
func testGetCgroupRootPathV1(t *testing.T, systemd bool) {
// This cgroup won't be created in the fs as we don't add a PID through the manager
group := filepath.Join("/singularity/rootpathtest")
if systemd {
group = "system.slice:singularity:rootpathtest"
}
manager, err := newManager(&specs.LinuxResources{}, group, systemd)
if err != nil {
t.Fatalf("While creating manager: %v", err)
}
rootPath, err := manager.GetCgroupRootPath()
if err != nil {
t.Errorf("While getting root path: %v", err)
}
// With v1 the mount could be somewhere odd... but we can test indirectly.
// The root path + '/devices' + the rel path should give us the absolute path
// for the cgroup with the devices controller.
// The rel path is tested explicitly, so we know it works.
relPath, err := manager.GetCgroupRelPath()
if err != nil {
t.Errorf("While getting rel path: %v", err)
}
absDevicePath := path.Join(rootPath, "devices", relPath)
if absDevicePath != manager.cgroup.Path("devices") {
t.Errorf("Expected %s, got %s", unifiedMountPoint, rootPath)
}
}
func testGetCgroupRelPathV1(t *testing.T, systemd bool) {
// This cgroup won't be created in the fs as we don't add a PID through the manager
group := filepath.Join("/singularity/rootpathtest")
wantPath := group
if systemd {
group = "system.slice:singularity:rootpathtest"
wantPath = "/system.slice/singularity-rootpathtest.scope"
}
manager, err := newManager(&specs.LinuxResources{}, group, systemd)
if err != nil {
t.Fatalf("While creating manager: %v", err)
}
relPath, err := manager.GetCgroupRelPath()
if err != nil {
t.Errorf("While getting root path: %v", err)
}
if relPath != wantPath {
t.Errorf("Expected %s, got %s", wantPath, relPath)
}
}
func testNewUpdateV1(t *testing.T, systemd bool) {
_, manager, cleanup := testManager(t, systemd)
defer cleanup()
// Check for correct 1024 value
pidsMax := filepath.Join(manager.cgroup.Path("pids"), "pids.max")
ensureInt(t, pidsMax, 1024)
// Write a new config with [pids] limit = 512
content := []byte("[pids]\nlimit = 512")
tmpfile, err := os.CreateTemp("", "cgroups")
if err != nil {
t.Fatalf("While creating update file: %v", err)
}
defer os.Remove(tmpfile.Name())
if _, err := tmpfile.Write(content); err != nil {
t.Fatalf("While writing update file: %v", err)
}
if err := tmpfile.Close(); err != nil {
t.Fatalf("While closing update file: %v", err)
}
// Update existing cgroup from new config
if err := manager.UpdateFromFile(tmpfile.Name()); err != nil {
t.Fatalf("While updating cgroup: %v", err)
}
// Check pids.max is now 512
ensureInt(t, pidsMax, 512)
}
func testUpdateUnifiedV1(t *testing.T, systemd bool) {
_, manager, cleanup := testManager(t, systemd)
defer cleanup()
// Try to update existing cgroup from unified style config setting [Unified] pids.max directly
if err := manager.UpdateFromFile("example/cgroups-unified.toml"); err == nil {
t.Fatalf("Unexpected success applying unified config on cgroups v1")
}
}
func testAddProcV1(t *testing.T, systemd bool) {
pid, manager, cleanup := testManager(t, systemd)
cmd := exec.Command("/bin/cat", "/dev/zero")
if err := cmd.Start(); err != nil {
t.Fatalf("While starting test process: %v", err)
}
newPid := cmd.Process.Pid
defer func() {
cmd.Process.Kill()
cmd.Process.Wait()
cleanup()
}()
if err := manager.AddProc(newPid); err != nil {
t.Errorf("While adding proc to cgroup: %v", err)
}
cgroupProcs := filepath.Join(manager.cgroup.Path("pids"), "cgroup.procs")
ensureContainsInt(t, cgroupProcs, int64(pid))
ensureContainsInt(t, cgroupProcs, int64(newPid))
}
func testFreezeThawV1(t *testing.T, systemd bool) {
manager := &Manager{}
if err := manager.Freeze(); err == nil {
t.Errorf("unexpected success with PID 0")
}
if err := manager.Thaw(); err == nil {
t.Errorf("unexpected success with PID 0")
}
pid, manager, cleanup := testManager(t, systemd)
defer cleanup()
manager.Freeze()
// cgroups v1 freeze is to uninterruptible sleep
ensureStateBecomes(t, pid, "D")
manager.Thaw()
ensureStateBecomes(t, pid, "RS")
}
|
