1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
|
// -*- Mode: Go; indent-tabs-mode: t -*-
/*
* Copyright (C) 2016 Canonical Ltd
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 3 as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
package apparmor_test
import (
"io/ioutil"
"os"
"path"
"path/filepath"
"testing"
. "gopkg.in/check.v1"
"github.com/snapcore/snapd/dirs"
"github.com/snapcore/snapd/interfaces/apparmor"
"github.com/snapcore/snapd/osutil"
apparmor_sandbox "github.com/snapcore/snapd/sandbox/apparmor"
"github.com/snapcore/snapd/testutil"
)
func Test(t *testing.T) {
TestingT(t)
}
type appArmorSuite struct {
testutil.BaseTest
profilesFilename string
}
var _ = Suite(&appArmorSuite{})
func (s *appArmorSuite) SetUpTest(c *C) {
s.BaseTest.SetUpTest(c)
// Mock the list of profiles in the running kernel
s.profilesFilename = path.Join(c.MkDir(), "profiles")
apparmor.MockProfilesPath(&s.BaseTest, s.profilesFilename)
}
// Tests for LoadProfiles()
func (s *appArmorSuite) TestLoadProfilesRunsAppArmorParserReplace(c *C) {
cmd := testutil.MockCommand(c, "apparmor_parser", "")
defer cmd.Restore()
err := apparmor.LoadProfiles([]string{"/path/to/snap.samba.smbd"}, apparmor_sandbox.CacheDir, 0)
c.Assert(err, IsNil)
c.Assert(cmd.Calls(), DeepEquals, [][]string{
{"apparmor_parser", "--replace", "--write-cache", "-O", "no-expr-simplify", "--cache-loc=/var/cache/apparmor", "--quiet", "/path/to/snap.samba.smbd"},
})
}
func (s *appArmorSuite) TestLoadProfilesMany(c *C) {
cmd := testutil.MockCommand(c, "apparmor_parser", "")
defer cmd.Restore()
err := apparmor.LoadProfiles([]string{"/path/to/snap.samba.smbd", "/path/to/another.profile"}, apparmor_sandbox.CacheDir, 0)
c.Assert(err, IsNil)
c.Assert(cmd.Calls(), DeepEquals, [][]string{
{"apparmor_parser", "--replace", "--write-cache", "-O", "no-expr-simplify", "--cache-loc=/var/cache/apparmor", "--quiet", "/path/to/snap.samba.smbd", "/path/to/another.profile"},
})
}
func (s *appArmorSuite) TestLoadProfilesNone(c *C) {
cmd := testutil.MockCommand(c, "apparmor_parser", "")
defer cmd.Restore()
err := apparmor.LoadProfiles([]string{}, apparmor_sandbox.CacheDir, 0)
c.Assert(err, IsNil)
c.Check(cmd.Calls(), HasLen, 0)
}
func (s *appArmorSuite) TestLoadProfilesReportsErrors(c *C) {
cmd := testutil.MockCommand(c, "apparmor_parser", "exit 42")
defer cmd.Restore()
err := apparmor.LoadProfiles([]string{"/path/to/snap.samba.smbd"}, apparmor_sandbox.CacheDir, 0)
c.Assert(err.Error(), Equals, `cannot load apparmor profiles: exit status 42
apparmor_parser output:
`)
c.Assert(cmd.Calls(), DeepEquals, [][]string{
{"apparmor_parser", "--replace", "--write-cache", "-O", "no-expr-simplify", "--cache-loc=/var/cache/apparmor", "--quiet", "/path/to/snap.samba.smbd"},
})
}
func (s *appArmorSuite) TestLoadProfilesRunsAppArmorParserReplaceWithSnapdDebug(c *C) {
os.Setenv("SNAPD_DEBUG", "1")
defer os.Unsetenv("SNAPD_DEBUG")
cmd := testutil.MockCommand(c, "apparmor_parser", "")
defer cmd.Restore()
err := apparmor.LoadProfiles([]string{"/path/to/snap.samba.smbd"}, apparmor_sandbox.CacheDir, 0)
c.Assert(err, IsNil)
c.Assert(cmd.Calls(), DeepEquals, [][]string{
{"apparmor_parser", "--replace", "--write-cache", "-O", "no-expr-simplify", "--cache-loc=/var/cache/apparmor", "/path/to/snap.samba.smbd"},
})
}
// Tests for Profile.Unload()
func (s *appArmorSuite) TestUnloadProfilesMany(c *C) {
err := apparmor.UnloadProfiles([]string{"/path/to/snap.samba.smbd", "/path/to/another.profile"}, apparmor_sandbox.CacheDir)
c.Assert(err, IsNil)
}
func (s *appArmorSuite) TestUnloadProfilesNone(c *C) {
err := apparmor.UnloadProfiles([]string{}, apparmor_sandbox.CacheDir)
c.Assert(err, IsNil)
}
func (s *appArmorSuite) TestUnloadRemovesCachedProfile(c *C) {
cmd := testutil.MockCommand(c, "apparmor_parser", "")
defer cmd.Restore()
dirs.SetRootDir(c.MkDir())
defer dirs.SetRootDir("")
err := os.MkdirAll(apparmor_sandbox.CacheDir, 0755)
c.Assert(err, IsNil)
fname := filepath.Join(apparmor_sandbox.CacheDir, "profile")
ioutil.WriteFile(fname, []byte("blob"), 0600)
err = apparmor.UnloadProfiles([]string{"profile"}, apparmor_sandbox.CacheDir)
c.Assert(err, IsNil)
_, err = os.Stat(fname)
c.Check(os.IsNotExist(err), Equals, true)
}
func (s *appArmorSuite) TestUnloadRemovesCachedProfileInForest(c *C) {
cmd := testutil.MockCommand(c, "apparmor_parser", "")
defer cmd.Restore()
dirs.SetRootDir(c.MkDir())
defer dirs.SetRootDir("")
err := os.MkdirAll(apparmor_sandbox.CacheDir, 0755)
c.Assert(err, IsNil)
// mock the forest subdir and features file
subdir := filepath.Join(apparmor_sandbox.CacheDir, "deadbeef.0")
err = os.MkdirAll(subdir, 0700)
c.Assert(err, IsNil)
features := filepath.Join(subdir, ".features")
ioutil.WriteFile(features, []byte("blob"), 0644)
fname := filepath.Join(subdir, "profile")
ioutil.WriteFile(fname, []byte("blob"), 0600)
err = apparmor.UnloadProfiles([]string{"profile"}, apparmor_sandbox.CacheDir)
c.Assert(err, IsNil)
_, err = os.Stat(fname)
c.Check(os.IsNotExist(err), Equals, true)
c.Check(osutil.FileExists(features), Equals, true)
}
// Tests for LoadedProfiles()
func (s *appArmorSuite) TestLoadedApparmorProfilesReturnsErrorOnMissingFile(c *C) {
profiles, err := apparmor.LoadedProfiles()
c.Assert(err, ErrorMatches, "open .*: no such file or directory")
c.Check(profiles, IsNil)
}
func (s *appArmorSuite) TestLoadedApparmorProfilesCanParseEmptyFile(c *C) {
ioutil.WriteFile(s.profilesFilename, []byte(""), 0600)
profiles, err := apparmor.LoadedProfiles()
c.Assert(err, IsNil)
c.Check(profiles, HasLen, 0)
}
func (s *appArmorSuite) TestLoadedApparmorProfilesParsesAndFiltersData(c *C) {
ioutil.WriteFile(s.profilesFilename, []byte(
// The output contains some of the snappy-specific elements
// and some non-snappy elements pulled from Ubuntu 16.04 desktop
//
// The pi2-piglow.{background,foreground}.snap entries are the only
// ones that should be reported by the function.
`/sbin/dhclient (enforce)
/usr/bin/ubuntu-core-launcher (enforce)
/usr/bin/ubuntu-core-launcher (enforce)
/usr/lib/NetworkManager/nm-dhcp-client.action (enforce)
/usr/lib/NetworkManager/nm-dhcp-helper (enforce)
/usr/lib/connman/scripts/dhclient-script (enforce)
/usr/lib/lightdm/lightdm-guest-session (enforce)
/usr/lib/lightdm/lightdm-guest-session//chromium (enforce)
/usr/lib/telepathy/telepathy-* (enforce)
/usr/lib/telepathy/telepathy-*//pxgsettings (enforce)
/usr/lib/telepathy/telepathy-*//sanitized_helper (enforce)
snap.pi2-piglow.background (enforce)
snap.pi2-piglow.foreground (enforce)
webbrowser-app (enforce)
webbrowser-app//oxide_helper (enforce)
`), 0600)
profiles, err := apparmor.LoadedProfiles()
c.Assert(err, IsNil)
c.Check(profiles, DeepEquals, []string{
"snap.pi2-piglow.background",
"snap.pi2-piglow.foreground",
})
}
func (s *appArmorSuite) TestLoadedApparmorProfilesHandlesParsingErrors(c *C) {
ioutil.WriteFile(s.profilesFilename, []byte("broken stuff here\n"), 0600)
profiles, err := apparmor.LoadedProfiles()
c.Assert(err, ErrorMatches, "newline in format does not match input")
c.Check(profiles, IsNil)
ioutil.WriteFile(s.profilesFilename, []byte("truncated"), 0600)
profiles, err = apparmor.LoadedProfiles()
c.Assert(err, ErrorMatches, `syntax error, expected: name \(mode\)`)
c.Check(profiles, IsNil)
}
func (s *appArmorSuite) TestMaybeSetNumberOfJobs(c *C) {
var cpus int
restore := apparmor.MockRuntimeNumCPU(func() int {
return cpus
})
defer restore()
cpus = 10
c.Check(apparmor.MaybeSetNumberOfJobs(), Equals, "-j8")
cpus = 2
c.Check(apparmor.MaybeSetNumberOfJobs(), Equals, "-j1")
cpus = 1
c.Check(apparmor.MaybeSetNumberOfJobs(), Equals, "")
}
|
