1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
|
// -*- Mode: Go; indent-tabs-mode: t -*-
/*
* Copyright (C) 2016-2018 Canonical Ltd
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 3 as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
package builtin_test
import (
"fmt"
. "gopkg.in/check.v1"
"github.com/snapcore/snapd/dirs"
"github.com/snapcore/snapd/interfaces"
"github.com/snapcore/snapd/interfaces/apparmor"
"github.com/snapcore/snapd/interfaces/builtin"
"github.com/snapcore/snapd/interfaces/mount"
"github.com/snapcore/snapd/interfaces/seccomp"
"github.com/snapcore/snapd/interfaces/udev"
"github.com/snapcore/snapd/osutil"
"github.com/snapcore/snapd/release"
"github.com/snapcore/snapd/snap"
"github.com/snapcore/snapd/testutil"
)
type X11InterfaceSuite struct {
iface interfaces.Interface
coreSlotInfo *snap.SlotInfo
coreSlot *interfaces.ConnectedSlot
corePlugInfo *snap.PlugInfo
corePlug *interfaces.ConnectedPlug
classicSlotInfo *snap.SlotInfo
classicSlot *interfaces.ConnectedSlot
plugInfo *snap.PlugInfo
plug *interfaces.ConnectedPlug
}
var _ = Suite(&X11InterfaceSuite{
iface: builtin.MustInterface("x11"),
})
const x11MockPlugSnapInfoYaml = `name: consumer
version: 0
apps:
app:
plugs: [x11]
`
// an x11 slot on an x11 snap (as installed on a core/all-snap system)
const x11CoreYaml = `name: x11
version: 0
apps:
app:
slots: [x11-provider]
plugs: [x11-consumer]
plugs:
x11-consumer:
interface: x11
slots:
x11-provider:
interface: x11
`
// an x11 slot on the core snap (as automatically added on classic)
const x11ClassicYaml = `name: core
version: 0
type: os
slots:
x11:
interface: x11
`
func (s *X11InterfaceSuite) SetUpTest(c *C) {
s.plug, s.plugInfo = MockConnectedPlug(c, x11MockPlugSnapInfoYaml, nil, "x11")
s.coreSlot, s.coreSlotInfo = MockConnectedSlot(c, x11CoreYaml, nil, "x11-provider")
s.corePlug, s.corePlugInfo = MockConnectedPlug(c, x11CoreYaml, nil, "x11-consumer")
s.classicSlot, s.classicSlotInfo = MockConnectedSlot(c, x11ClassicYaml, nil, "x11")
}
func (s *X11InterfaceSuite) TestName(c *C) {
c.Assert(s.iface.Name(), Equals, "x11")
}
func (s *X11InterfaceSuite) TestSanitizeSlot(c *C) {
c.Assert(interfaces.BeforePrepareSlot(s.iface, s.coreSlotInfo), IsNil)
c.Assert(interfaces.BeforePrepareSlot(s.iface, s.classicSlotInfo), IsNil)
}
func (s *X11InterfaceSuite) TestSanitizePlug(c *C) {
c.Assert(interfaces.BeforePreparePlug(s.iface, s.plugInfo), IsNil)
}
func (s *X11InterfaceSuite) TestMountSpec(c *C) {
// case A: x11 slot is provided by the system
spec := &mount.Specification{}
c.Assert(spec.AddConnectedPlug(s.iface, s.plug, s.classicSlot), IsNil)
c.Assert(spec.MountEntries(), DeepEquals, []osutil.MountEntry{{
Name: "/var/lib/snapd/hostfs/tmp/.X11-unix",
Dir: "/tmp/.X11-unix",
Options: []string{"bind", "ro"},
}})
c.Assert(spec.UserMountEntries(), HasLen, 0)
// case B: x11 slot is provided by another snap on the system
spec = &mount.Specification{}
c.Assert(spec.AddConnectedPlug(s.iface, s.plug, s.coreSlot), IsNil)
c.Assert(spec.MountEntries(), DeepEquals, []osutil.MountEntry{{
Name: "/var/lib/snapd/hostfs/tmp/snap-private-tmp/snap.x11/tmp/.X11-unix",
Dir: "/tmp/.X11-unix",
Options: []string{"bind", "ro"},
}})
c.Assert(spec.UserMountEntries(), HasLen, 0)
// case C: x11 slot is both provided and consumed by a snap on the system.
spec = &mount.Specification{}
c.Assert(spec.AddConnectedPlug(s.iface, s.corePlug, s.coreSlot), IsNil)
c.Assert(spec.MountEntries(), HasLen, 0)
c.Assert(spec.UserMountEntries(), HasLen, 0)
}
func (s *X11InterfaceSuite) TestAppArmorSpec(c *C) {
// case A: x11 slot is provided by the classic system
restore := release.MockOnClassic(true)
defer restore()
// Plug side connection permissions
spec := &apparmor.Specification{}
c.Assert(spec.AddConnectedPlug(s.iface, s.plug, s.classicSlot), IsNil)
c.Assert(spec.SecurityTags(), DeepEquals, []string{"snap.consumer.app"})
c.Assert(spec.SnippetForTag("snap.consumer.app"), testutil.Contains, "fontconfig")
c.Assert(spec.UpdateNS(), HasLen, 1)
c.Assert(spec.UpdateNS()[0], testutil.Contains, `mount options=(rw, bind) /var/lib/snapd/hostfs/tmp/.X11-unix/ -> /tmp/.X11-unix/,`)
// case B: x11 slot is provided by another snap on the system
restore = release.MockOnClassic(false)
defer restore()
// Plug side connection permissions
spec = &apparmor.Specification{}
c.Assert(spec.AddConnectedPlug(s.iface, s.plug, s.coreSlot), IsNil)
c.Assert(spec.SecurityTags(), DeepEquals, []string{"snap.consumer.app"})
c.Assert(spec.SnippetForTag("snap.consumer.app"), testutil.Contains, "fontconfig")
c.Assert(spec.UpdateNS(), HasLen, 1)
c.Assert(spec.UpdateNS()[0], testutil.Contains, `mount options=(rw, bind) /var/lib/snapd/hostfs/tmp/snap-private-tmp/snap.x11/tmp/.X11-unix/ -> /tmp/.X11-unix/,`)
// Slot side connection permissions
spec = &apparmor.Specification{}
c.Assert(spec.AddConnectedSlot(s.iface, s.plug, s.coreSlot), IsNil)
c.Assert(spec.SecurityTags(), DeepEquals, []string{"snap.x11.app"})
c.Assert(spec.SnippetForTag("snap.x11.app"), testutil.Contains, `peer=(label="snap.consumer.app"),`)
c.Assert(spec.UpdateNS(), HasLen, 0)
// Slot side permantent permissions
spec = &apparmor.Specification{}
c.Assert(spec.AddPermanentSlot(s.iface, s.coreSlotInfo), IsNil)
c.Assert(spec.SecurityTags(), DeepEquals, []string{"snap.x11.app"})
c.Assert(spec.SnippetForTag("snap.x11.app"), testutil.Contains, "capability sys_tty_config,")
c.Assert(spec.UpdateNS(), HasLen, 0)
// case C: x11 slot is both provided and consumed by a snap on the system.
spec = &apparmor.Specification{}
c.Assert(spec.AddConnectedPlug(s.iface, s.corePlug, s.coreSlot), IsNil)
c.Assert(spec.SecurityTags(), DeepEquals, []string{"snap.x11.app"})
c.Assert(spec.SnippetForTag("snap.x11.app"), testutil.Contains, "fontconfig")
// Self-connection does not need bind mounts, so no additional permissions are provided to snap-update-ns.
c.Assert(spec.UpdateNS(), HasLen, 0)
}
func (s *X11InterfaceSuite) TestAppArmorSpecOnClassic(c *C) {
// on a classic system with x11 slot coming from the core snap.
restore := release.MockOnClassic(true)
defer restore()
// connected plug to classic slot
spec := &apparmor.Specification{}
c.Assert(spec.AddConnectedPlug(s.iface, s.plug, s.classicSlot), IsNil)
c.Assert(spec.SecurityTags(), DeepEquals, []string{"snap.consumer.app"})
c.Assert(spec.SnippetForTag("snap.consumer.app"), testutil.Contains, "owner /run/user/[0-9]*/.Xauthority r,")
// connected classic slot to plug
spec = &apparmor.Specification{}
c.Assert(spec.AddConnectedSlot(s.iface, s.plug, s.classicSlot), IsNil)
c.Assert(spec.SecurityTags(), HasLen, 0)
// permanent classic slot
spec = &apparmor.Specification{}
c.Assert(spec.AddPermanentSlot(s.iface, s.classicSlotInfo), IsNil)
c.Assert(spec.SecurityTags(), HasLen, 0)
}
func (s *X11InterfaceSuite) TestSecCompOnClassic(c *C) {
// on a classic system with x11 slot coming from the core snap.
restore := release.MockOnClassic(true)
defer restore()
seccompSpec := &seccomp.Specification{}
err := seccompSpec.AddPermanentSlot(s.iface, s.classicSlotInfo)
c.Assert(err, IsNil)
err = seccompSpec.AddConnectedPlug(s.iface, s.plug, s.classicSlot)
c.Assert(err, IsNil)
// app snap has additional seccomp rules
c.Assert(seccompSpec.SecurityTags(), DeepEquals, []string{"snap.consumer.app"})
c.Assert(seccompSpec.SnippetForTag("snap.consumer.app"), testutil.Contains, "bind\n")
}
func (s *X11InterfaceSuite) TestSecCompOnCore(c *C) {
// on a core system with x11 slot coming from a snap.
restore := release.MockOnClassic(false)
defer restore()
seccompSpec := &seccomp.Specification{}
err := seccompSpec.AddPermanentSlot(s.iface, s.coreSlotInfo)
c.Assert(err, IsNil)
err = seccompSpec.AddConnectedPlug(s.iface, s.plug, s.coreSlot)
c.Assert(err, IsNil)
// both app and x11 have secomp rules set
c.Assert(seccompSpec.SecurityTags(), DeepEquals, []string{"snap.consumer.app", "snap.x11.app"})
c.Assert(seccompSpec.SnippetForTag("snap.x11.app"), testutil.Contains, "listen\n")
c.Assert(seccompSpec.SnippetForTag("snap.consumer.app"), testutil.Contains, "bind\n")
}
func (s *X11InterfaceSuite) TestUDev(c *C) {
// on a core system with x11 slot coming from a regular app snap.
restore := release.MockOnClassic(false)
defer restore()
spec := &udev.Specification{}
c.Assert(spec.AddPermanentSlot(s.iface, s.coreSlotInfo), IsNil)
c.Assert(spec.Snippets(), HasLen, 6)
c.Assert(spec.Snippets(), testutil.Contains, `# x11
KERNEL=="event[0-9]*", TAG+="snap_x11_app"`)
c.Assert(spec.Snippets(), testutil.Contains, `# x11
KERNEL=="mice", TAG+="snap_x11_app"`)
c.Assert(spec.Snippets(), testutil.Contains, `# x11
KERNEL=="mouse[0-9]*", TAG+="snap_x11_app"`)
c.Assert(spec.Snippets(), testutil.Contains, `# x11
KERNEL=="ts[0-9]*", TAG+="snap_x11_app"`)
c.Assert(spec.Snippets(), testutil.Contains, `# x11
KERNEL=="tty[0-9]*", TAG+="snap_x11_app"`)
c.Assert(spec.Snippets(), testutil.Contains, fmt.Sprintf(`TAG=="snap_x11_app", RUN+="%v/snap-device-helper $env{ACTION} snap_x11_app $devpath $major:$minor"`, dirs.DistroLibExecDir))
c.Assert(spec.TriggeredSubsystems(), DeepEquals, []string{"input"})
// on a classic system with x11 slot coming from the core snap.
restore = release.MockOnClassic(true)
defer restore()
spec = &udev.Specification{}
c.Assert(spec.AddPermanentSlot(s.iface, s.classicSlotInfo), IsNil)
c.Assert(spec.Snippets(), HasLen, 0)
c.Assert(spec.TriggeredSubsystems(), IsNil)
}
func (s *X11InterfaceSuite) TestStaticInfo(c *C) {
si := interfaces.StaticInfoOf(s.iface)
c.Assert(si.ImplicitOnCore, Equals, false)
c.Assert(si.ImplicitOnClassic, Equals, true)
c.Assert(si.Summary, Equals, `allows interacting with or running as an X11 server`)
c.Assert(si.BaseDeclarationSlots, testutil.Contains, "x11")
}
func (s *X11InterfaceSuite) TestAutoConnect(c *C) {
c.Assert(s.iface.AutoConnect(s.plugInfo, s.coreSlotInfo), Equals, true)
c.Assert(s.iface.AutoConnect(s.plugInfo, s.classicSlotInfo), Equals, true)
}
func (s *X11InterfaceSuite) TestInterfaces(c *C) {
c.Check(builtin.Interfaces(), testutil.DeepContains, s.iface)
}
|
