1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832
|
// -*- Mode: Go; indent-tabs-mode: t -*-
/*
* Copyright (C) 2016-2018 Canonical Ltd
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 3 as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
package apparmor_test
import (
"fmt"
"strings"
. "gopkg.in/check.v1"
"github.com/snapcore/snapd/interfaces"
"github.com/snapcore/snapd/interfaces/apparmor"
"github.com/snapcore/snapd/interfaces/ifacetest"
"github.com/snapcore/snapd/snap"
"github.com/snapcore/snapd/snap/snaptest"
"github.com/snapcore/snapd/testutil"
)
type specSuite struct {
testutil.BaseTest
iface *ifacetest.TestInterface
spec *apparmor.Specification
plugInfo *snap.PlugInfo
plug *interfaces.ConnectedPlug
slotInfo *snap.SlotInfo
slot *interfaces.ConnectedSlot
}
var _ = Suite(&specSuite{
iface: &ifacetest.TestInterface{
InterfaceName: "test",
AppArmorConnectedPlugCallback: func(spec *apparmor.Specification, plug *interfaces.ConnectedPlug, slot *interfaces.ConnectedSlot) error {
spec.AddSnippet("connected-plug")
return nil
},
AppArmorConnectedSlotCallback: func(spec *apparmor.Specification, plug *interfaces.ConnectedPlug, slot *interfaces.ConnectedSlot) error {
spec.AddSnippet("connected-slot")
return nil
},
AppArmorPermanentPlugCallback: func(spec *apparmor.Specification, plug *snap.PlugInfo) error {
spec.AddSnippet("permanent-plug")
return nil
},
AppArmorPermanentSlotCallback: func(spec *apparmor.Specification, slot *snap.SlotInfo) error {
spec.AddSnippet("permanent-slot")
return nil
},
},
})
func (s *specSuite) SetUpTest(c *C) {
s.BaseTest.SetUpTest(c)
s.BaseTest.AddCleanup(snap.MockSanitizePlugsSlots(func(snapInfo *snap.Info) {}))
const plugYaml = `name: snap1
version: 1
apps:
app1:
plugs: [name]
`
s.plug, s.plugInfo = ifacetest.MockConnectedPlug(c, plugYaml, nil, "name")
s.spec = apparmor.NewSpecification(s.plug.AppSet())
const slotYaml = `name: snap2
version: 1
slots:
name:
interface: test
apps:
app2:
`
s.slot, s.slotInfo = ifacetest.MockConnectedSlot(c, slotYaml, nil, "name")
}
func (s *specSuite) TearDownTest(c *C) {
s.BaseTest.TearDownTest(c)
}
// The spec.Specification can be used through the interfaces.Specification interface
func (s *specSuite) TestSpecificationIface(c *C) {
appSet, err := interfaces.NewSnapAppSet(s.plugInfo.Snap, nil)
c.Assert(err, IsNil)
spec := apparmor.NewSpecification(appSet)
var r interfaces.Specification = spec
c.Assert(r.AddConnectedPlug(s.iface, s.plug, s.slot), IsNil)
c.Assert(r.AddPermanentPlug(s.iface, s.plugInfo), IsNil)
c.Assert(spec.Snippets(), DeepEquals, map[string][]string{
"snap.snap1.app1": {"connected-plug", "permanent-plug"},
})
appSet, err = interfaces.NewSnapAppSet(s.slotInfo.Snap, nil)
c.Assert(err, IsNil)
spec = apparmor.NewSpecification(appSet)
r = spec
c.Assert(r.AddConnectedSlot(s.iface, s.plug, s.slot), IsNil)
c.Assert(r.AddPermanentSlot(s.iface, s.slotInfo), IsNil)
c.Assert(spec.Snippets(), DeepEquals, map[string][]string{
"snap.snap2.app2": {"connected-slot", "permanent-slot"},
})
}
// MetadataTagSnippet wraps a snippet in the given metadata tags.
func (s *specSuite) TestMetadataTagSnippet(c *C) {
tagFoo := apparmor.RegisterMetadataTagWithInterface("foo", "an-interface")
tagBar := apparmor.RegisterMetadataTagWithInterface("bar", "another")
tagBaz := apparmor.RegisterMetadataTagWithInterface("baz", "yet-another")
tagQux := apparmor.RegisterMetadataTagWithInterface("qux", "an-interface")
restore := apparmor.MockMetadataTagsSupported(func() bool { return true })
defer restore()
snippetShort := "/foo r,"
snippetLong := `/path/to/dir/1 r,
/path/to/dir/2 rw,
/path/to/dir/3 rwkl,`
for _, testCase := range []struct {
snippet string
tags []apparmor.MetadataTag
expected string
}{
{
snippet: snippetShort,
tags: []apparmor.MetadataTag{},
expected: snippetShort,
},
{
snippet: snippetShort,
tags: []apparmor.MetadataTag{tagBar},
expected: `
tags=(bar) {
/foo r,
}
`,
},
{
snippet: snippetShort,
tags: []apparmor.MetadataTag{tagBar, tagBaz},
expected: `
tags=(bar baz) {
/foo r,
}
`,
},
{
snippet: snippetLong,
tags: []apparmor.MetadataTag{},
expected: snippetLong,
},
{
snippet: snippetLong,
tags: []apparmor.MetadataTag{tagBar},
expected: `
tags=(bar) {
/path/to/dir/1 r,
/path/to/dir/2 rw,
/path/to/dir/3 rwkl,
}
`,
},
{
snippet: snippetLong,
tags: []apparmor.MetadataTag{tagBar, tagBaz},
expected: `
tags=(bar baz) {
/path/to/dir/1 r,
/path/to/dir/2 rw,
/path/to/dir/3 rwkl,
}
`,
},
} {
result := apparmor.MetadataTagSnippet(testCase.snippet, testCase.tags)
c.Check(result, Equals, testCase.expected)
}
// Tags may be nested
inner := apparmor.MetadataTagSnippet("/ijk rwkl,", []apparmor.MetadataTag{tagFoo, tagBar})
snippet := fmt.Sprintf("/abc r,\n%s\n/xyz w,", inner)
result := apparmor.MetadataTagSnippet(snippet, []apparmor.MetadataTag{tagBaz, tagQux})
c.Check(result, Equals, `
tags=(baz qux) {
/abc r,
tags=(foo bar) {
/ijk rwkl,
}
/xyz w,
}
`)
// When metadata tags are not supported, snippets should be returned unchanged
restore = apparmor.MockMetadataTagsSupported(func() bool { return false })
defer restore()
for _, tags := range [][]apparmor.MetadataTag{
{},
{tagBar},
{tagBar, tagBaz},
} {
result := apparmor.MetadataTagSnippet(snippetShort, tags)
c.Check(result, Equals, snippetShort)
result = apparmor.MetadataTagSnippet(snippetLong, tags)
c.Check(result, Equals, snippetLong)
}
}
// AddSnippet adds a snippet for the given security tag.
func (s *specSuite) TestAddSnippet(c *C) {
restore := apparmor.SetSpecScope(s.spec, []string{"snap.demo.command", "snap.demo.service"})
defer restore()
// Add two snippets in the context we are in.
s.spec.AddSnippet("snippet 1")
s.spec.AddSnippet("snippet 2")
// The snippets were recorded correctly.
c.Assert(s.spec.UpdateNS(), HasLen, 0)
c.Assert(s.spec.Snippets(), DeepEquals, map[string][]string{
"snap.demo.command": {"snippet 1", "snippet 2"},
"snap.demo.service": {"snippet 1", "snippet 2"},
})
c.Assert(s.spec.SnippetsForTag("snap.demo.command"), DeepEquals, []string{"snippet 1", "snippet 2"})
c.Assert(s.spec.SnippetForTag("snap.demo.command"), Equals, "snippet 1\nsnippet 2")
c.Assert(s.spec.SecurityTags(), DeepEquals, []string{"snap.demo.command", "snap.demo.service"})
}
// AddDeduplicatedSnippet adds a snippet for the given security tag.
func (s *specSuite) TestAddDeduplicatedSnippet(c *C) {
restore := apparmor.SetSpecScope(s.spec, []string{"snap.demo.command", "snap.demo.service"})
defer restore()
// Add two snippets in the context we are in.
s.spec.AddDeduplicatedSnippet("dedup snippet 1")
s.spec.AddDeduplicatedSnippet("dedup snippet 1")
s.spec.AddDeduplicatedSnippet("dedup snippet 2")
s.spec.AddDeduplicatedSnippet("dedup snippet 2")
// The snippets were recorded correctly.
c.Assert(s.spec.UpdateNS(), HasLen, 0)
c.Assert(s.spec.Snippets(), DeepEquals, map[string][]string{
"snap.demo.command": {"dedup snippet 1", "dedup snippet 2"},
"snap.demo.service": {"dedup snippet 1", "dedup snippet 2"},
})
c.Assert(s.spec.SnippetsForTag("snap.demo.command"), DeepEquals, []string{"dedup snippet 1", "dedup snippet 2"})
c.Assert(s.spec.SnippetForTag("snap.demo.command"), Equals, "dedup snippet 1\ndedup snippet 2")
c.Assert(s.spec.SecurityTags(), DeepEquals, []string{"snap.demo.command", "snap.demo.service"})
}
func (s *specSuite) TestAddParametricSnippet(c *C) {
restore := apparmor.SetSpecScope(s.spec, []string{"snap.demo.command", "snap.demo.service"})
defer restore()
s.spec.AddParametricSnippet([]string{"prefix ", " postfix"}, "param1")
s.spec.AddParametricSnippet([]string{"prefix ", " postfix"}, "param1")
s.spec.AddParametricSnippet([]string{"prefix ", " postfix"}, "param2")
s.spec.AddParametricSnippet([]string{"prefix ", " postfix"}, "param2")
s.spec.AddParametricSnippet([]string{"other "}, "param")
c.Assert(s.spec.SnippetsForTag("snap.demo.command"), DeepEquals, []string{
"other param",
"prefix {param1,param2} postfix",
})
c.Assert(s.spec.SnippetForTag("snap.demo.command"), Equals, "other param\nprefix {param1,param2} postfix")
c.Assert(s.spec.Snippets(), DeepEquals, map[string][]string{
"snap.demo.command": {"other param", "prefix {param1,param2} postfix"},
"snap.demo.service": {"other param", "prefix {param1,param2} postfix"},
})
}
// All of AddSnippet, AddDeduplicatedSnippet, AddParameticSnippet work correctly together.
func (s *specSuite) TestAddSnippetAndAddDeduplicatedAndParamSnippet(c *C) {
restore := apparmor.SetSpecScope(s.spec, []string{"snap.demo.command", "snap.demo.service"})
defer restore()
// Add three snippets in the context we are in.
s.spec.AddSnippet("normal")
s.spec.AddDeduplicatedSnippet("dedup")
s.spec.AddParametricSnippet([]string{""}, "param")
// The snippets were recorded correctly.
c.Assert(s.spec.UpdateNS(), HasLen, 0)
c.Assert(s.spec.Snippets(), DeepEquals, map[string][]string{
"snap.demo.command": {"normal", "dedup", "param"},
"snap.demo.service": {"normal", "dedup", "param"},
})
c.Assert(s.spec.SnippetsForTag("snap.demo.command"), DeepEquals, []string{"normal", "dedup", "param"})
c.Assert(s.spec.SnippetForTag("snap.demo.command"), Equals, "normal\ndedup\nparam")
c.Assert(s.spec.SecurityTags(), DeepEquals, []string{"snap.demo.command", "snap.demo.service"})
}
// Define tags but don't add any snippets.
func (s *specSuite) TestTagsButNoSnippets(c *C) {
restore := apparmor.SetSpecScope(s.spec, []string{"snap.demo.command", "snap.demo.service"})
defer restore()
c.Assert(s.spec.UpdateNS(), HasLen, 0)
c.Assert(s.spec.Snippets(), DeepEquals, map[string][]string{})
c.Assert(s.spec.SnippetsForTag("snap.demo.command"), DeepEquals, []string(nil))
c.Assert(s.spec.SnippetForTag("snap.demo.command"), Equals, "")
c.Assert(s.spec.SecurityTags(), DeepEquals, []string(nil))
}
// Don't define any tags but add snippets.
func (s *specSuite) TestNoTagsButWithSnippets(c *C) {
restore := apparmor.SetSpecScope(s.spec, []string{})
defer restore()
s.spec.AddSnippet("normal")
s.spec.AddDeduplicatedSnippet("dedup")
s.spec.AddParametricSnippet([]string{""}, "param")
c.Assert(s.spec.UpdateNS(), HasLen, 0)
c.Assert(s.spec.Snippets(), DeepEquals, map[string][]string{})
c.Assert(s.spec.SnippetsForTag("snap.demo.command"), DeepEquals, []string(nil))
c.Assert(s.spec.SnippetForTag("snap.demo.command"), Equals, "")
c.Assert(s.spec.SecurityTags(), DeepEquals, []string(nil))
}
// Don't define any tags or snippets.
func (s *specSuite) TestsNoTagsOrSnippets(c *C) {
restore := apparmor.SetSpecScope(s.spec, []string{})
defer restore()
c.Assert(s.spec.UpdateNS(), HasLen, 0)
c.Assert(s.spec.Snippets(), DeepEquals, map[string][]string{})
c.Assert(s.spec.SnippetsForTag("snap.demo.command"), DeepEquals, []string(nil))
c.Assert(s.spec.SnippetForTag("snap.demo.command"), Equals, "")
c.Assert(s.spec.SecurityTags(), DeepEquals, []string(nil))
}
// AddUpdateNS adds a snippet for the snap-update-ns profile for a given snap.
func (s *specSuite) TestAddUpdateNS(c *C) {
restore := apparmor.SetSpecScope(s.spec, []string{"snap.demo.command", "snap.demo.service"})
defer restore()
// Add a two snap-update-ns snippets in the context we are in.
s.spec.AddUpdateNS("s-u-n snippet 1")
s.spec.AddUpdateNS("s-u-n snippet 2")
// Check the order of the snippets can be retrieved.
idx, ok := s.spec.UpdateNSIndexOf("s-u-n snippet 2")
c.Assert(ok, Equals, true)
c.Check(idx, Equals, 1)
// The snippets were recorded correctly and in the right place.
c.Assert(s.spec.UpdateNS(), DeepEquals, []string{
"s-u-n snippet 1", "s-u-n snippet 2",
})
c.Assert(s.spec.SnippetForTag("snap.demo.command"), Equals, "")
c.Assert(s.spec.SecurityTags(), HasLen, 0)
}
const snapWithLayout = `
name: vanguard
version: 0
apps:
vanguard:
command: vanguard
layout:
/usr/foo:
bind: $SNAP/usr/foo
/var/tmp:
type: tmpfs
mode: 1777
/var/cache/mylink:
symlink: $SNAP_DATA/link/target
/etc/foo.conf:
bind-file: $SNAP/foo.conf
`
func (s *specSuite) TestApparmorSnippetsFromLayout(c *C) {
snapInfo := snaptest.MockInfo(c, snapWithLayout, &snap.SideInfo{Revision: snap.R(42)})
restore := apparmor.SetSpecScope(s.spec, []string{"snap.vanguard.vanguard"})
defer restore()
appSet, err := interfaces.NewSnapAppSet(snapInfo, nil)
c.Assert(err, IsNil)
s.spec.AddLayout(appSet)
c.Assert(s.spec.Snippets(), DeepEquals, map[string][]string{
"snap.vanguard.vanguard": {
"# Layout path: /etc/foo.conf\n\"/etc/foo.conf\" mrwklix,",
"# Layout path: /usr/foo\n\"/usr/foo{,/**}\" mrwklix,",
"# Layout path: /var/cache/mylink\n# (no extra permissions required for symlink)",
"# Layout path: /var/tmp\n\"/var/tmp{,/**}\" mrwklix,",
},
})
updateNS := s.spec.UpdateNS()
profile0 := ` # Layout /etc/foo.conf: bind-file $SNAP/foo.conf
mount options=(bind, rw) "/snap/vanguard/42/foo.conf" -> "/etc/foo.conf",
mount options=(rprivate) -> "/etc/foo.conf",
umount "/etc/foo.conf",
# Writable mimic /etc
# .. permissions for traversing the prefix that is assumed to exist
"/" r,
# .. variant with mimic at /etc/
# Allow reading the mimic directory, it must exist in the first place.
"/etc/" r,
# Allow setting the read-only directory aside via a bind mount.
"/tmp/.snap/etc/" rw,
mount options=(rbind, rw) "/etc/" -> "/tmp/.snap/etc/",
# Allow mounting tmpfs over the read-only directory.
mount fstype=tmpfs options=(rw) tmpfs -> "/etc/",
# Allow creating empty files and directories for bind mounting things
# to reconstruct the now-writable parent directory.
"/tmp/.snap/etc/*/" rw,
"/etc/*/" rw,
mount options=(rbind, rw) "/tmp/.snap/etc/*/" -> "/etc/*/",
"/tmp/.snap/etc/*" rw,
"/etc/*" rw,
mount options=(bind, rw) "/tmp/.snap/etc/*" -> "/etc/*",
# Allow unmounting the auxiliary directory.
# TODO: use fstype=tmpfs here for more strictness (LP: #1613403)
mount options=(rprivate) -> "/tmp/.snap/etc/",
umount "/tmp/.snap/etc/",
# Allow unmounting the destination directory as well as anything
# inside. This lets us perform the undo plan in case the writable
# mimic fails.
mount options=(rprivate) -> "/etc/",
mount options=(rprivate) -> "/etc/*",
mount options=(rprivate) -> "/etc/*/",
umount "/etc/",
umount "/etc/*",
umount "/etc/*/",
# Writable mimic /snap/vanguard/42
"/snap/" r,
"/snap/vanguard/" r,
# .. variant with mimic at /snap/vanguard/42/
"/snap/vanguard/42/" r,
"/tmp/.snap/snap/vanguard/42/" rw,
mount options=(rbind, rw) "/snap/vanguard/42/" -> "/tmp/.snap/snap/vanguard/42/",
mount fstype=tmpfs options=(rw) tmpfs -> "/snap/vanguard/42/",
"/tmp/.snap/snap/vanguard/42/*/" rw,
"/snap/vanguard/42/*/" rw,
mount options=(rbind, rw) "/tmp/.snap/snap/vanguard/42/*/" -> "/snap/vanguard/42/*/",
"/tmp/.snap/snap/vanguard/42/*" rw,
"/snap/vanguard/42/*" rw,
mount options=(bind, rw) "/tmp/.snap/snap/vanguard/42/*" -> "/snap/vanguard/42/*",
mount options=(rprivate) -> "/tmp/.snap/snap/vanguard/42/",
umount "/tmp/.snap/snap/vanguard/42/",
mount options=(rprivate) -> "/snap/vanguard/42/",
mount options=(rprivate) -> "/snap/vanguard/42/*",
mount options=(rprivate) -> "/snap/vanguard/42/*/",
umount "/snap/vanguard/42/",
umount "/snap/vanguard/42/*",
umount "/snap/vanguard/42/*/",
`
// Find the slice that describes profile0 by looking for the first unique
// line of the next profile.
start := 0
end, _ := s.spec.UpdateNSIndexOf(" # Layout /usr/foo: bind $SNAP/usr/foo\n")
c.Assert(strings.Join(updateNS[start:end], ""), Equals, profile0)
profile1 := ` # Layout /usr/foo: bind $SNAP/usr/foo
mount options=(rbind, rw) "/snap/vanguard/42/usr/foo/" -> "/usr/foo/",
mount options=(rprivate) -> "/usr/foo/",
umount "/usr/foo/",
# Writable mimic /usr
# .. variant with mimic at /usr/
"/usr/" r,
"/tmp/.snap/usr/" rw,
mount options=(rbind, rw) "/usr/" -> "/tmp/.snap/usr/",
mount fstype=tmpfs options=(rw) tmpfs -> "/usr/",
"/tmp/.snap/usr/*/" rw,
"/usr/*/" rw,
mount options=(rbind, rw) "/tmp/.snap/usr/*/" -> "/usr/*/",
"/tmp/.snap/usr/*" rw,
"/usr/*" rw,
mount options=(bind, rw) "/tmp/.snap/usr/*" -> "/usr/*",
mount options=(rprivate) -> "/tmp/.snap/usr/",
umount "/tmp/.snap/usr/",
mount options=(rprivate) -> "/usr/",
mount options=(rprivate) -> "/usr/*",
mount options=(rprivate) -> "/usr/*/",
umount "/usr/",
umount "/usr/*",
umount "/usr/*/",
# Writable mimic /snap/vanguard/42/usr
# .. variant with mimic at /snap/vanguard/42/usr/
"/snap/vanguard/42/usr/" r,
"/tmp/.snap/snap/vanguard/42/usr/" rw,
mount options=(rbind, rw) "/snap/vanguard/42/usr/" -> "/tmp/.snap/snap/vanguard/42/usr/",
mount fstype=tmpfs options=(rw) tmpfs -> "/snap/vanguard/42/usr/",
"/tmp/.snap/snap/vanguard/42/usr/*/" rw,
"/snap/vanguard/42/usr/*/" rw,
mount options=(rbind, rw) "/tmp/.snap/snap/vanguard/42/usr/*/" -> "/snap/vanguard/42/usr/*/",
"/tmp/.snap/snap/vanguard/42/usr/*" rw,
"/snap/vanguard/42/usr/*" rw,
mount options=(bind, rw) "/tmp/.snap/snap/vanguard/42/usr/*" -> "/snap/vanguard/42/usr/*",
mount options=(rprivate) -> "/tmp/.snap/snap/vanguard/42/usr/",
umount "/tmp/.snap/snap/vanguard/42/usr/",
mount options=(rprivate) -> "/snap/vanguard/42/usr/",
mount options=(rprivate) -> "/snap/vanguard/42/usr/*",
mount options=(rprivate) -> "/snap/vanguard/42/usr/*/",
umount "/snap/vanguard/42/usr/",
umount "/snap/vanguard/42/usr/*",
umount "/snap/vanguard/42/usr/*/",
`
// Find the slice that describes profile1 by looking for the first unique
// line of the next profile.
start = end
end, _ = s.spec.UpdateNSIndexOf(" # Layout /var/cache/mylink: symlink $SNAP_DATA/link/target\n")
c.Assert(strings.Join(updateNS[start:end], ""), Equals, profile1)
profile2 := ` # Layout /var/cache/mylink: symlink $SNAP_DATA/link/target
"/var/cache/mylink" rw,
# Writable mimic /var/cache
# .. variant with mimic at /var/
"/var/" r,
"/tmp/.snap/var/" rw,
mount options=(rbind, rw) "/var/" -> "/tmp/.snap/var/",
mount fstype=tmpfs options=(rw) tmpfs -> "/var/",
"/tmp/.snap/var/*/" rw,
"/var/*/" rw,
mount options=(rbind, rw) "/tmp/.snap/var/*/" -> "/var/*/",
"/tmp/.snap/var/*" rw,
"/var/*" rw,
mount options=(bind, rw) "/tmp/.snap/var/*" -> "/var/*",
mount options=(rprivate) -> "/tmp/.snap/var/",
umount "/tmp/.snap/var/",
mount options=(rprivate) -> "/var/",
mount options=(rprivate) -> "/var/*",
mount options=(rprivate) -> "/var/*/",
umount "/var/",
umount "/var/*",
umount "/var/*/",
# .. variant with mimic at /var/cache/
"/var/cache/" r,
"/tmp/.snap/var/cache/" rw,
mount options=(rbind, rw) "/var/cache/" -> "/tmp/.snap/var/cache/",
mount fstype=tmpfs options=(rw) tmpfs -> "/var/cache/",
"/tmp/.snap/var/cache/*/" rw,
"/var/cache/*/" rw,
mount options=(rbind, rw) "/tmp/.snap/var/cache/*/" -> "/var/cache/*/",
"/tmp/.snap/var/cache/*" rw,
"/var/cache/*" rw,
mount options=(bind, rw) "/tmp/.snap/var/cache/*" -> "/var/cache/*",
mount options=(rprivate) -> "/tmp/.snap/var/cache/",
umount "/tmp/.snap/var/cache/",
mount options=(rprivate) -> "/var/cache/",
mount options=(rprivate) -> "/var/cache/*",
mount options=(rprivate) -> "/var/cache/*/",
umount "/var/cache/",
umount "/var/cache/*",
umount "/var/cache/*/",
`
// Find the slice that describes profile2 by looking for the first unique
// line of the next profile.
start = end
end, _ = s.spec.UpdateNSIndexOf(" # Layout /var/tmp: type tmpfs, mode: 01777\n")
c.Assert(strings.Join(updateNS[start:end], ""), Equals, profile2)
profile3 := ` # Layout /var/tmp: type tmpfs, mode: 01777
mount fstype=tmpfs tmpfs -> "/var/tmp/",
mount options=(rprivate) -> "/var/tmp/",
umount "/var/tmp/",
# Writable mimic /var
`
// Find the slice that describes profile2 by looking till the end of the list.
start = end
c.Assert(strings.Join(updateNS[start:], ""), Equals, profile3)
c.Assert(strings.Join(updateNS, ""), DeepEquals, strings.Join([]string{profile0, profile1, profile2, profile3}, ""))
}
const snapTrivial = `
name: some-snap
version: 0
apps:
app:
command: app-command
`
func (s *specSuite) TestApparmorOvernameSnippetsNotInstanceKeyed(c *C) {
snapInfo := snaptest.MockInfo(c, snapTrivial, &snap.SideInfo{Revision: snap.R(42)})
restore := apparmor.SetSpecScope(s.spec, []string{"snap.some-snap.app"})
defer restore()
s.spec.AddOvername(snapInfo)
c.Assert(s.spec.Snippets(), HasLen, 0)
// non instance-keyed snaps require no extra snippets
c.Assert(s.spec.UpdateNS(), HasLen, 0)
}
func (s *specSuite) TestApparmorOvernameSnippets(c *C) {
snapInfo := snaptest.MockInfo(c, snapTrivial, &snap.SideInfo{Revision: snap.R(42)})
snapInfo.InstanceKey = "instance"
restore := apparmor.SetSpecScope(s.spec, []string{"snap.some-snap_instace.app"})
defer restore()
s.spec.AddOvername(snapInfo)
c.Assert(s.spec.Snippets(), HasLen, 0)
updateNS := s.spec.UpdateNS()
c.Assert(updateNS, HasLen, 1)
profile := ` # Allow parallel instance snap mount namespace adjustments
mount options=(rw rbind) /snap/some-snap_instance/ -> /snap/some-snap/,
mount options=(rw rbind) /var/snap/some-snap_instance/ -> /var/snap/some-snap/,
`
c.Assert(updateNS[0], Equals, profile)
}
func (s *specSuite) TestApparmorExtraLayouts(c *C) {
snapInfo := snaptest.MockInfo(c, snapTrivial, &snap.SideInfo{Revision: snap.R(42)})
snapInfo.InstanceKey = "instance"
restore := apparmor.SetSpecScope(s.spec, []string{"snap.some-snap_instace.app"})
defer restore()
extraLayouts := []snap.Layout{
{
Path: "/test",
Bind: "/usr/home/test",
Mode: 0755,
},
}
s.spec.AddExtraLayouts(snapInfo, extraLayouts)
updateNS := s.spec.UpdateNS()
// verify that updateNS does indeed add all the additional layout
// lines. This just so happens to be 10 in this case because of reverse
// traversal for the path /usr/home/test
c.Assert(updateNS, HasLen, 10)
// make sure the extra layout is added
c.Assert(updateNS[0], Equals, " # Layout /test: bind /usr/home/test\n")
c.Assert(updateNS[1], Equals, " mount options=(rbind, rw) \"/usr/home/test/\" -> \"/test/\",\n")
c.Assert(updateNS[2], Equals, " mount options=(rprivate) -> \"/test/\",\n")
// lines 3..9 is the traversal of the prefix for /usr/home/test
}
func (s *specSuite) TestAddEnsureDirMounts(c *C) {
ensureDirSpecs := []*interfaces.EnsureDirSpec{
{MustExistDir: "$HOME", EnsureDir: "$HOME/.local/share"},
{MustExistDir: "$HOME", EnsureDir: "$HOME/dir1/dir2"},
{MustExistDir: "/", EnsureDir: "/dir1/dir2"},
{MustExistDir: "/dir1", EnsureDir: "/dir1"},
}
s.spec.AddEnsureDirMounts("personal-files", ensureDirSpecs)
c.Check("\n"+strings.Join(s.spec.UpdateNS(), "\n"), Equals, `
# Allow the personal-files interface to create potentially missing directories
owner @{HOME}/ rw,
owner @{HOME}/.local/ rw,
owner @{HOME}/.local/share/ rw,
owner @{HOME}/dir1/ rw,
owner @{HOME}/dir1/dir2/ rw,
owner / rw,
owner /dir1/ rw,
owner /dir1/dir2/ rw,`)
}
func (s *specSuite) TestAddEnsureDirMountsReturnsOnDirsMatch(c *C) {
ensureDirSpecs := []*interfaces.EnsureDirSpec{
{MustExistDir: "/dir", EnsureDir: "/dir"},
}
s.spec.AddEnsureDirMounts("personal-files", ensureDirSpecs)
c.Check(s.spec.UpdateNS(), HasLen, 0)
}
func (s *specSuite) TestAddEnsureDirMountsReturnsOnPathIteratorError(c *C) {
ensureDirSpecs := []*interfaces.EnsureDirSpec{
{MustExistDir: "/dir1", EnsureDir: "/../"},
}
s.spec.AddEnsureDirMounts("personal-files", ensureDirSpecs)
c.Check(s.spec.UpdateNS(), HasLen, 0)
}
func (s *specSuite) TestUsesPtraceTrace(c *C) {
c.Assert(s.spec.UsesPtraceTrace(), Equals, false)
s.spec.SetUsesPtraceTrace()
c.Assert(s.spec.UsesPtraceTrace(), Equals, true)
}
func (s *specSuite) TestSuppressPtraceTrace(c *C) {
c.Assert(s.spec.SuppressPtraceTrace(), Equals, false)
s.spec.SetSuppressPtraceTrace()
c.Assert(s.spec.SuppressPtraceTrace(), Equals, true)
}
func (s *specSuite) TestSetSuppressHomeIx(c *C) {
c.Assert(s.spec.SuppressHomeIx(), Equals, false)
s.spec.SetSuppressHomeIx()
c.Assert(s.spec.SuppressHomeIx(), Equals, true)
}
func (s *specSuite) TestSetSuppressPycacheDeny(c *C) {
c.Assert(s.spec.SuppressPycacheDeny(), Equals, false)
s.spec.SetSuppressPycacheDeny()
c.Assert(s.spec.SuppressPycacheDeny(), Equals, true)
}
var key1 = apparmor.RegisterSnippetKey("testkey1")
var key2 = apparmor.RegisterSnippetKey("testkey2")
func (s *specSuite) TestPrioritySnippets(c *C) {
restoreScope1 := apparmor.SetSpecScope(s.spec, []string{"snap.demo.scope1"})
defer restoreScope1()
// Test a scope with a normal snippet and prioritized ones
s.spec.AddSnippet("Test snippet 1")
s.spec.AddPrioritizedSnippet("Prioritized snippet 1", key1, 0)
s.spec.AddPrioritizedSnippet("Prioritized snippet 2", key1, 0)
s.spec.AddPrioritizedSnippet("Prioritized snippet 3", key2, 1)
s.spec.AddPrioritizedSnippet("Prioritized snippet 4", key2, 2)
s.spec.AddPrioritizedSnippet("Prioritized snippet 5", key2, 0)
// Test a scope with only prioritized snippets
restoreScope2 := apparmor.SetSpecScope(s.spec, []string{"snap.demo.scope2"})
defer restoreScope2()
s.spec.AddPrioritizedSnippet("Prioritized snippet 6", key1, 0)
s.spec.AddPrioritizedSnippet("Prioritized snippet 7", key1, 0)
s.spec.AddPrioritizedSnippet("Prioritized snippet 8", key2, 1)
s.spec.AddPrioritizedSnippet("Prioritized snippet 9", key2, 2)
s.spec.AddPrioritizedSnippet("Prioritized snippet 10", key2, 0)
snippets := s.spec.SnippetForTag("snap.demo.scope1")
c.Assert(snippets, testutil.Contains, "Test snippet 1")
c.Assert(snippets, testutil.Contains, "Prioritized snippet 1")
c.Assert(snippets, testutil.Contains, "Prioritized snippet 2")
c.Assert(snippets, Not(testutil.Contains), "Prioritized snippet 3")
c.Assert(snippets, testutil.Contains, "Prioritized snippet 4")
c.Assert(snippets, Not(testutil.Contains), "Prioritized snippet 5")
snippets = s.spec.SnippetForTag("snap.demo.scope2")
c.Assert(snippets, testutil.Contains, "Prioritized snippet 6")
c.Assert(snippets, testutil.Contains, "Prioritized snippet 7")
// Overridden by higher-priority snippet 9 with the same key (key2)
c.Assert(snippets, Not(testutil.Contains), "Prioritized snippet 8")
c.Assert(snippets, testutil.Contains, "Prioritized snippet 9")
// Overridden by higher-priority snippet 9 with the same key (key2)
c.Assert(snippets, Not(testutil.Contains), "Prioritized snippet 10")
tags := s.spec.SecurityTags()
c.Assert(tags, testutil.Contains, "snap.demo.scope1")
c.Assert(tags, testutil.Contains, "snap.demo.scope2")
}
func (s *specSuite) TestPrioritySnippetsNoRegisteredKey(c *C) {
var key1 apparmor.SnippetKey = apparmor.SnippetKey{}
c.Assert(func() { s.spec.AddPrioritizedSnippet("Prioritized snippet 1", key1, 0) }, PanicMatches, "priority key is not registered")
}
func (s *specSuite) TestRegisterSameSnippetKeyTwice(c *C) {
c.Assert(func() { apparmor.RegisterSnippetKey("testkey1") }, PanicMatches, "priority key testkey1 is already registered")
}
func (s *specSuite) TestMoreSnippets(c *C) {
keylist := apparmor.RegisteredSnippetKeys()
c.Assert(keylist, testutil.Contains, "testkey1")
c.Assert(keylist, testutil.Contains, "testkey2")
c.Assert(len(keylist), Equals, 2)
}
func (s *specSuite) TestInterfaceForMetadataTag(c *C) {
_ = apparmor.RegisterMetadataTagWithInterface("testtag1", "an-interface")
_ = apparmor.RegisterMetadataTagWithInterface("testtag2", "another")
_ = apparmor.RegisterMetadataTagWithInterface("testtag3", "yet-another")
iface, ok := apparmor.InterfaceForMetadataTag("testtag1")
c.Check(ok, Equals, true)
c.Check(iface, Equals, "an-interface")
iface, ok = apparmor.InterfaceForMetadataTag("testtag2")
c.Check(ok, Equals, true)
c.Check(iface, Equals, "another")
iface, ok = apparmor.InterfaceForMetadataTag("testtag3")
c.Check(ok, Equals, true)
c.Check(iface, Equals, "yet-another")
iface, ok = apparmor.InterfaceForMetadataTag("testtag4")
c.Check(ok, Equals, false)
c.Check(iface, Equals, "")
}
func (s *specSuite) TestRegisterSameTagSameInterfaceTwice(c *C) {
tag1 := apparmor.RegisterMetadataTagWithInterface("will-be-associated", "with-me")
c.Check(tag1.String(), Equals, "will-be-associated")
tag2 := apparmor.RegisterMetadataTagWithInterface("will-be-associated", "with-me")
c.Check(tag2.String(), Equals, "will-be-associated")
iface, ok := apparmor.InterfaceForMetadataTag("will-be-associated")
c.Check(ok, Equals, true)
c.Check(iface, Equals, "with-me")
}
func (s *specSuite) TestRegisterSameTagDifferentInterface(c *C) {
tag1 := apparmor.RegisterMetadataTagWithInterface("something", "an-interface")
c.Check(tag1.String(), Equals, "something")
c.Check(func() { apparmor.RegisterMetadataTagWithInterface("something", "another") }, PanicMatches, `cannot register metadata tag "something" to two different interfaces: "an-interface" and "another"`)
}
func (s *specSuite) TestRegisterMetadataTagWithInterfaceEmpty(c *C) {
c.Check(func() { apparmor.RegisterMetadataTagWithInterface("to-nothing", "") }, PanicMatches, `cannot register metadata tag with missing interface: "to-nothing"`)
}
func (s *specSuite) TestRegisterMetadataTagInvalid(c *C) {
for _, badTag := range []string{"a,b", "a(b", "a)b", "a[b", "a]b", "a{b", "a}b", "a?b", "a*b", "a^b", `a"b`, `1ab`, `aBc`, `Ab`, `a/b`} {
c.Check(func() { apparmor.RegisterMetadataTagWithInterface(badTag, "something") }, PanicMatches, `cannot register invalid metadata tag: .*`)
}
}
|