1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
|
// -*- Mode: Go; indent-tabs-mode: t -*-
/*
* Copyright (C) 2018 Canonical Ltd
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 3 as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
package patch
import (
"errors"
"github.com/snapcore/snapd/interfaces"
"github.com/snapcore/snapd/overlord/state"
"github.com/snapcore/snapd/snap"
)
type connStatePatch6_1 struct {
Auto bool `json:"auto,omitempty"`
ByGadget bool `json:"by-gadget,omitempty"`
Interface string `json:"interface,omitempty"`
Undesired bool `json:"undesired,omitempty"`
StaticPlugAttrs map[string]any `json:"plug-static,omitempty"`
DynamicPlugAttrs map[string]any `json:"plug-dynamic,omitempty"`
StaticSlotAttrs map[string]any `json:"slot-static,omitempty"`
DynamicSlotAttrs map[string]any `json:"slot-dynamic,omitempty"`
}
// processConns updates conns map and augments it with plug-static and slot-static attributes from current snap info.
// NOTE: missing snap or missing plugs/slots are ignored and not reported as errors as we might have stale connections
// and ifacemgr deals with them (i.e. discards) on startup; we want to process all good slots and plugs here.
func processConns(conns map[string]connStatePatch6_1, infos map[string]*snap.Info) (bool, error) {
var updated bool
for id, conn := range conns {
// static attributes already present
if len(conn.StaticPlugAttrs) > 0 || len(conn.StaticSlotAttrs) > 0 {
continue
}
// undesired connections have all their attributes dropped, so don't set them
if conn.Undesired {
continue
}
connRef, err := interfaces.ParseConnRef(id)
if err != nil {
return false, err
}
var ok bool
var plugSnapInfo, slotSnapInfo *snap.Info
// read current snap info from disk and keep it around in infos map
if plugSnapInfo, ok = infos[connRef.PlugRef.Snap]; !ok {
plugSnapInfo, err = snap.ReadCurrentInfo(connRef.PlugRef.Snap)
if err == nil {
infos[connRef.PlugRef.Snap] = plugSnapInfo
}
}
if slotSnapInfo, ok = infos[connRef.SlotRef.Snap]; !ok {
slotSnapInfo, err = snap.ReadCurrentInfo(connRef.SlotRef.Snap)
if err == nil {
infos[connRef.SlotRef.Snap] = slotSnapInfo
}
}
if slotSnapInfo != nil {
if slot, ok := slotSnapInfo.Slots[connRef.SlotRef.Name]; ok && slot.Attrs != nil {
conn.StaticSlotAttrs = slot.Attrs
updated = true
}
}
if plugSnapInfo != nil {
if plug, ok := plugSnapInfo.Plugs[connRef.PlugRef.Name]; ok && plug.Attrs != nil {
conn.StaticPlugAttrs = plug.Attrs
updated = true
}
}
conns[id] = conn
}
return updated, nil
}
// patch6_1:
// - add static plug and slot attributes to connections that miss them. Attributes are read from current snap info.
func patch6_1(st *state.State) error {
infos := make(map[string]*snap.Info)
// update all pending "discard-conns" tasks as they may keep connection data in "removed".
for _, task := range st.Tasks() {
if task.Change().Status().Ready() {
continue
}
var removed map[string]connStatePatch6_1
if task.Kind() == "discard-conns" {
err := task.Get("removed", &removed)
if errors.Is(err, state.ErrNoState) {
continue
}
if err != nil {
return err
}
}
updated, err := processConns(removed, infos)
if err != nil {
return err
}
if updated {
task.Set("removed", removed)
}
}
// update conns
var conns map[string]connStatePatch6_1
err := st.Get("conns", &conns)
if errors.Is(err, state.ErrNoState) {
// no connections to process
return nil
}
if err != nil {
return err
}
updated, err := processConns(conns, infos)
if err != nil {
return err
}
if updated {
st.Set("conns", conns)
}
return nil
}
|
