1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
|
// -*- Mode: Go; indent-tabs-mode: t -*-
/*
* Copyright (C) 2019 Canonical Ltd
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 3 as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
package patch
import (
"encoding/json"
"errors"
"fmt"
"github.com/snapcore/snapd/logger"
"github.com/snapcore/snapd/overlord/state"
"github.com/snapcore/snapd/snap/channel"
)
// normChan will take a potentially unclean channel from the state
// (with leading or trailing extra "/") and return a cleaned version.
func normChan(in string) string {
out, err := channel.Full(in)
if err != nil {
logger.Noticef("cannot parse channel string %q: %v", in, err)
return in
}
return out
}
// patch6_3:
// - ensure channel spec is valid
func patch6_3(st *state.State) error {
var snaps map[string]*json.RawMessage
if err := st.Get("snaps", &snaps); err != nil && !errors.Is(err, state.ErrNoState) {
return fmt.Errorf("internal error: cannot get snaps: %s", err)
}
// Migrate snapstate
dirty := false
for name, raw := range snaps {
var snapst map[string]any
if err := json.Unmarshal([]byte(*raw), &snapst); err != nil {
return err
}
ch, _ := snapst["channel"].(string)
if ch != "" {
normed := normChan(ch)
if normed != ch {
snapst["channel"] = normed
data, err := json.Marshal(snapst)
if err != nil {
return err
}
newRaw := json.RawMessage(data)
snaps[name] = &newRaw
dirty = true
}
}
}
if dirty {
st.Set("snaps", snaps)
}
// migrate tasks' snap setup
for _, task := range st.Tasks() {
chg := task.Change()
if chg != nil && chg.Status().Ready() {
continue
}
// check task snap-setup
var snapsup map[string]any
err := task.Get("snap-setup", &snapsup)
if err != nil && !errors.Is(err, state.ErrNoState) {
return fmt.Errorf("internal error: cannot get snap-setup of task %s: %s", task.ID(), err)
}
if err == nil {
ch, _ := snapsup["channel"].(string)
if ch != "" {
normed := normChan(ch)
if normed != ch {
snapsup["channel"] = normed
task.Set("snap-setup", snapsup)
}
}
}
// check tasks "old-channel" data
var oldCh string
task.Get("old-channel", &oldCh)
if oldCh != "" {
normed := normChan(oldCh)
if normed != oldCh {
task.Set("old-channel", normed)
}
}
}
return nil
}
|
