1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933
|
// -*- Mode: Go; indent-tabs-mode: t -*-
/*
* Copyright (C) 2018 Canonical Ltd
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 3 as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
package store_test
import (
"bytes"
"context"
"crypto"
"errors"
"fmt"
"io"
"net/http"
"net/http/httptest"
"os"
"os/exec"
"path/filepath"
"time"
"github.com/juju/ratelimit"
. "gopkg.in/check.v1"
"gopkg.in/retry.v1"
"github.com/snapcore/snapd/dirs"
"github.com/snapcore/snapd/overlord/auth"
"github.com/snapcore/snapd/progress"
"github.com/snapcore/snapd/release"
"github.com/snapcore/snapd/snap"
"github.com/snapcore/snapd/store"
"github.com/snapcore/snapd/testutil"
)
type downloadSuite struct {
mockXdelta *testutil.MockCmd
testutil.BaseTest
}
var _ = Suite(&downloadSuite{})
func (s *downloadSuite) SetUpTest(c *C) {
s.BaseTest.SetUpTest(c)
store.MockDownloadRetryStrategy(&s.BaseTest, retry.LimitCount(5, retry.Exponential{
Initial: time.Millisecond,
Factor: 2.5,
}))
s.mockXdelta = testutil.MockCommand(c, "xdelta3", "")
s.AddCleanup(s.mockXdelta.Restore)
}
func (s *downloadSuite) TestActualDownload(c *C) {
n := 0
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
c.Check(r.Header.Get("Snap-CDN"), Equals, "")
c.Check(r.Header.Get("Snap-Device-Location"), Equals, "")
c.Check(r.Header.Get("Snap-Refresh-Reason"), Equals, "")
n++
io.WriteString(w, "response-data")
}))
c.Assert(mockServer, NotNil)
defer mockServer.Close()
theStore := store.New(&store.Config{}, nil)
var buf SillyBuffer
// keep tests happy
sha3 := ""
err := store.Download(context.TODO(), "foo", sha3, mockServer.URL, nil, theStore, &buf, 0, nil, nil)
c.Assert(err, IsNil)
c.Check(buf.String(), Equals, "response-data")
c.Check(n, Equals, 1)
}
func (s *downloadSuite) TestActualDownloadAutoRefresh(c *C) {
n := 0
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
c.Check(r.Header.Get("Snap-Refresh-Reason"), Equals, "scheduled")
n++
io.WriteString(w, "response-data")
}))
c.Assert(mockServer, NotNil)
defer mockServer.Close()
theStore := store.New(&store.Config{}, nil)
var buf SillyBuffer
// keep tests happy
sha3 := ""
err := store.Download(context.TODO(), "foo", sha3, mockServer.URL, nil, theStore, &buf, 0, nil, &store.DownloadOptions{Scheduled: true})
c.Assert(err, IsNil)
c.Check(buf.String(), Equals, "response-data")
c.Check(n, Equals, 1)
}
func (s *downloadSuite) TestActualDownloadNoCDN(c *C) {
os.Setenv("SNAPPY_STORE_NO_CDN", "1")
defer os.Unsetenv("SNAPPY_STORE_NO_CDN")
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
c.Check(r.Header.Get("Snap-CDN"), Equals, "none")
c.Check(r.Header.Get("Snap-Device-Location"), Equals, "")
io.WriteString(w, "response-data")
}))
c.Assert(mockServer, NotNil)
defer mockServer.Close()
theStore := store.New(&store.Config{}, nil)
var buf SillyBuffer
// keep tests happy
sha3 := ""
err := store.Download(context.TODO(), "foo", sha3, mockServer.URL, nil, theStore, &buf, 0, nil, nil)
c.Assert(err, IsNil)
c.Check(buf.String(), Equals, "response-data")
}
func (s *downloadSuite) TestActualDownloadFullCloudInfoFromAuthContext(c *C) {
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
c.Check(r.Header.Get("Snap-CDN"), Equals, `cloud-name="aws" region="us-east-1" availability-zone="us-east-1c"`)
c.Check(r.Header.Get("Snap-Device-Location"), Equals, `cloud-name="aws" region="us-east-1" availability-zone="us-east-1c"`)
io.WriteString(w, "response-data")
}))
c.Assert(mockServer, NotNil)
defer mockServer.Close()
device := createTestDevice()
theStore := store.New(&store.Config{}, &testDauthContext{c: c, device: device, cloudInfo: &auth.CloudInfo{Name: "aws", Region: "us-east-1", AvailabilityZone: "us-east-1c"}})
var buf SillyBuffer
// keep tests happy
sha3 := ""
err := store.Download(context.TODO(), "foo", sha3, mockServer.URL, nil, theStore, &buf, 0, nil, nil)
c.Assert(err, IsNil)
c.Check(buf.String(), Equals, "response-data")
}
func (s *downloadSuite) TestActualDownloadLessDetailedCloudInfoFromAuthContext(c *C) {
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
c.Check(r.Header.Get("Snap-CDN"), Equals, `cloud-name="openstack" availability-zone="nova"`)
c.Check(r.Header.Get("Snap-Device-Location"), Equals, `cloud-name="openstack" availability-zone="nova"`)
io.WriteString(w, "response-data")
}))
c.Assert(mockServer, NotNil)
defer mockServer.Close()
device := createTestDevice()
theStore := store.New(&store.Config{}, &testDauthContext{c: c, device: device, cloudInfo: &auth.CloudInfo{Name: "openstack", Region: "", AvailabilityZone: "nova"}})
var buf SillyBuffer
// keep tests happy
sha3 := ""
err := store.Download(context.TODO(), "foo", sha3, mockServer.URL, nil, theStore, &buf, 0, nil, nil)
c.Assert(err, IsNil)
c.Check(buf.String(), Equals, "response-data")
}
func (s *downloadSuite) TestDownloadCancellation(c *C) {
ctx, cancel := context.WithCancel(context.Background())
n := 0
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
n++
io.WriteString(w, "foo")
cancel()
io.WriteString(w, "bar")
time.Sleep(10 * time.Millisecond)
}))
c.Assert(mockServer, NotNil)
defer mockServer.Close()
theStore := store.New(&store.Config{}, nil)
sha3 := ""
var buf SillyBuffer
err := store.Download(ctx, "foo", sha3, mockServer.URL, nil, theStore, &buf, 0, nil, nil)
c.Check(n, Equals, 1)
c.Assert(err, ErrorMatches, "the download has been cancelled: context canceled")
}
type nopeSeeker struct{ io.ReadWriter }
func (nopeSeeker) Seek(int64, int) (int64, error) {
return -1, errors.New("what is this, quidditch?")
}
func (s *downloadSuite) TestActualDownloadNonPurchased402(c *C) {
n := 0
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
n++
// XXX: the server doesn't behave correctly ATM
// but 401 for paid snaps is the unlikely case so far
w.WriteHeader(402)
}))
c.Assert(mockServer, NotNil)
defer mockServer.Close()
theStore := store.New(&store.Config{}, nil)
var buf bytes.Buffer
err := store.Download(context.TODO(), "foo", "sha3", mockServer.URL, nil, theStore, nopeSeeker{&buf}, -1, nil, nil)
c.Assert(err, NotNil)
c.Check(err.Error(), Equals, "please buy foo before installing it")
c.Check(n, Equals, 1)
}
func (s *downloadSuite) TestActualDownload404(c *C) {
n := 0
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
n++
w.WriteHeader(404)
}))
c.Assert(mockServer, NotNil)
defer mockServer.Close()
theStore := store.New(&store.Config{}, nil)
var buf SillyBuffer
err := store.Download(context.TODO(), "foo", "sha3", mockServer.URL, nil, theStore, &buf, 0, nil, nil)
c.Assert(err, NotNil)
c.Assert(err, FitsTypeOf, &store.DownloadError{})
c.Check(err.(*store.DownloadError).Code, Equals, 404)
c.Check(n, Equals, 1)
}
func (s *downloadSuite) TestActualDownload500(c *C) {
n := 0
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
n++
w.WriteHeader(500)
}))
c.Assert(mockServer, NotNil)
defer mockServer.Close()
theStore := store.New(&store.Config{}, nil)
var buf SillyBuffer
err := store.Download(context.TODO(), "foo", "sha3", mockServer.URL, nil, theStore, &buf, 0, nil, nil)
c.Assert(err, NotNil)
c.Assert(err, FitsTypeOf, &store.DownloadError{})
c.Check(err.(*store.DownloadError).Code, Equals, 500)
c.Check(n, Equals, 5)
}
func (s *downloadSuite) TestActualDownload500Once(c *C) {
n := 0
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
n++
if n == 1 {
w.WriteHeader(500)
} else {
io.WriteString(w, "response-data")
}
}))
c.Assert(mockServer, NotNil)
defer mockServer.Close()
theStore := store.New(&store.Config{}, nil)
var buf SillyBuffer
// keep tests happy
sha3 := ""
err := store.Download(context.TODO(), "foo", sha3, mockServer.URL, nil, theStore, &buf, 0, nil, nil)
c.Assert(err, IsNil)
c.Check(buf.String(), Equals, "response-data")
c.Check(n, Equals, 2)
}
// SillyBuffer is a ReadWriteSeekTruncater buffer with a limited size for the tests
// (bytes does not implement an ReadWriteSeekTruncater)
type SillyBuffer struct {
buf [1024]byte
pos int64
end int64
}
func NewSillyBufferString(s string) *SillyBuffer {
sb := &SillyBuffer{
pos: int64(len(s)),
end: int64(len(s)),
}
copy(sb.buf[0:], []byte(s))
return sb
}
func (sb *SillyBuffer) Read(b []byte) (n int, err error) {
if sb.pos >= int64(sb.end) {
return 0, io.EOF
}
n = copy(b, sb.buf[sb.pos:sb.end])
sb.pos += int64(n)
return n, nil
}
func (sb *SillyBuffer) Seek(offset int64, whence int) (int64, error) {
if whence != 0 {
panic("only io.SeekStart implemented in SillyBuffer")
}
if offset < 0 || offset > int64(sb.end) {
return 0, fmt.Errorf("seek out of bounds: %d", offset)
}
sb.pos = offset
return sb.pos, nil
}
func (sb *SillyBuffer) Write(p []byte) (n int, err error) {
n = copy(sb.buf[sb.pos:], p)
sb.pos += int64(n)
if sb.pos > sb.end {
sb.end = sb.pos
}
return n, nil
}
func (sb *SillyBuffer) Truncate(size int64) error {
if size < 0 || size > int64(len(sb.buf)) {
return fmt.Errorf("truncate out of bounds: %d", size)
}
sb.end = size
return nil
}
func (sb *SillyBuffer) String() string {
return string(sb.buf[0:sb.pos])
}
func (s *downloadSuite) TestActualDownloadResume(c *C) {
n := 0
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
n++
w.WriteHeader(206)
io.WriteString(w, "data")
}))
c.Assert(mockServer, NotNil)
defer mockServer.Close()
theStore := store.New(&store.Config{}, nil)
buf := NewSillyBufferString("some ")
// calc the expected hash
h := crypto.SHA3_384.New()
h.Write([]byte("some data"))
sha3 := fmt.Sprintf("%x", h.Sum(nil))
err := store.Download(context.TODO(), "foo", sha3, mockServer.URL, nil, theStore, buf, int64(len("some ")), nil, nil)
c.Check(err, IsNil)
c.Check(buf.String(), Equals, "some data")
c.Check(n, Equals, 1)
}
func (s *downloadSuite) TestActualDownloadServerNoResumeHandeled(c *C) {
n := 0
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
n++
switch n {
case 1:
c.Check(r.Header["Range"], HasLen, 1)
default:
c.Fatal("only one request expected")
}
// server does not do partial content and sends full data instead
w.WriteHeader(200)
io.WriteString(w, "some data")
}))
c.Assert(mockServer, NotNil)
defer mockServer.Close()
theStore := store.New(&store.Config{}, nil)
buf := NewSillyBufferString("some ")
// calc the expected hash
h := crypto.SHA3_384.New()
h.Write([]byte("some data"))
sha3 := fmt.Sprintf("%x", h.Sum(nil))
err := store.Download(context.TODO(), "foo", sha3, mockServer.URL, nil, theStore, buf, int64(len("some ")), nil, nil)
c.Check(err, IsNil)
c.Check(buf.String(), Equals, "some data")
c.Check(n, Equals, 1)
}
func (s *downloadSuite) TestUseDeltas(c *C) {
// get rid of the mock xdelta3 because we mock all our own stuff
s.mockXdelta.Restore()
origPath := os.Getenv("PATH")
defer os.Setenv("PATH", origPath)
origUseDeltas := os.Getenv("SNAPD_USE_DELTAS_EXPERIMENTAL")
defer os.Setenv("SNAPD_USE_DELTAS_EXPERIMENTAL", origUseDeltas)
restore := release.MockOnClassic(false)
defer restore()
origSnapMountDir := dirs.SnapMountDir
defer func() { dirs.SnapMountDir = origSnapMountDir }()
dirs.SnapMountDir = c.MkDir()
exeInCorePath := filepath.Join(dirs.SnapMountDir, "/core/current/usr/bin/xdelta3")
interpInCorePath := filepath.Join(dirs.SnapMountDir, "/core/current/lib64/ld-linux-x86-64.so.2")
scenarios := []struct {
env string
classic bool
exeInHost bool
exeInCore bool
wantDelta bool
}{
{env: "", classic: false, exeInHost: false, exeInCore: false, wantDelta: false},
{env: "", classic: false, exeInHost: false, exeInCore: true, wantDelta: true},
{env: "", classic: false, exeInHost: true, exeInCore: false, wantDelta: true},
{env: "", classic: false, exeInHost: true, exeInCore: true, wantDelta: true},
{env: "", classic: true, exeInHost: false, exeInCore: false, wantDelta: false},
{env: "", classic: true, exeInHost: false, exeInCore: true, wantDelta: true},
{env: "", classic: true, exeInHost: true, exeInCore: false, wantDelta: true},
{env: "", classic: true, exeInHost: true, exeInCore: true, wantDelta: true},
{env: "0", classic: false, exeInHost: false, exeInCore: false, wantDelta: false},
{env: "0", classic: false, exeInHost: false, exeInCore: true, wantDelta: false},
{env: "0", classic: false, exeInHost: true, exeInCore: false, wantDelta: false},
{env: "0", classic: false, exeInHost: true, exeInCore: true, wantDelta: false},
{env: "0", classic: true, exeInHost: false, exeInCore: false, wantDelta: false},
{env: "0", classic: true, exeInHost: false, exeInCore: true, wantDelta: false},
{env: "0", classic: true, exeInHost: true, exeInCore: false, wantDelta: false},
{env: "0", classic: true, exeInHost: true, exeInCore: true, wantDelta: false},
{env: "1", classic: false, exeInHost: false, exeInCore: false, wantDelta: false},
{env: "1", classic: false, exeInHost: false, exeInCore: true, wantDelta: true},
{env: "1", classic: false, exeInHost: true, exeInCore: false, wantDelta: true},
{env: "1", classic: false, exeInHost: true, exeInCore: true, wantDelta: true},
{env: "1", classic: true, exeInHost: false, exeInCore: false, wantDelta: false},
{env: "1", classic: true, exeInHost: false, exeInCore: true, wantDelta: true},
{env: "1", classic: true, exeInHost: true, exeInCore: false, wantDelta: true},
{env: "1", classic: true, exeInHost: true, exeInCore: true, wantDelta: true},
}
for _, scenario := range scenarios {
var hostXdelta3Cmd, coreInterpCmd *testutil.MockCmd
var cleanups []func()
comment := Commentf("%#v", scenario)
// setup the env var for the scenario
os.Setenv("SNAPD_USE_DELTAS_EXPERIMENTAL", scenario.env)
release.MockOnClassic(scenario.classic)
// setup binaries for the scenario
if scenario.exeInCore {
// We need both the xdelta3 command for determining the interpreter
// as well as the actual interpreter for executing the basic
// "xdelta3 config" command.
// For the interpreter, since that's how we execute xdelta3, mock
// that as a command, but we don't need to mock the xdelta3 command
// in the core snap since that doesn't get executed by our fake
// interpreter. Mocking the interpreter and executing that as a
// MockCommand has the advantage that it avoids the specific ELF
// handling that is per-arch, etc. of the real CommandFromSystemSnap
// implementation.
coreInterpCmd = testutil.MockCommand(c, interpInCorePath, "")
r := store.MockSnapdtoolCommandFromSystemSnap(func(name string, args ...string) (*exec.Cmd, error) {
c.Assert(name, Equals, "/usr/bin/xdelta3")
c.Assert(args, DeepEquals, []string{"config"})
// use realistic arguments like what we actually get from
// snapdtool.CommandFromSystemSnap(), namely the interpreter and
// a library path which is derived from ld.so - this is
// artificial and we could use any mocked arguments here, but
// this more closely matches reality to return something like
// this.
interpArgs := append([]string{"--library-path", "/some/dir/from/etc/ld.so", exeInCorePath}, args...)
return exec.Command(coreInterpCmd.Exe(), interpArgs...), nil
})
cleanups = append(cleanups, r)
// Forget the calls to the interpreter at the end of the test - this
// deletes the log which otherwise would continue to persist for
// each iteration leading to incorrect checks for the calls to the
// absolute binary that we mocked here, as the log file will be the
// same for each iteration.
// For the inverse reason, we don't need to forget calls for the
// hostXdelta3Cmd mock command, it gets a new dir with a new log
// file each iteration.
cleanups = append(cleanups, func() {
coreInterpCmd.ForgetCalls()
// note this is currently not needed, since Restore() just
// resets $PATH, but for an absolute path the $PATH doesn't get
// modified to begin with in MockCommand, but keep it here just
// to be safe in case something does ever change
coreInterpCmd.Restore()
})
}
if scenario.exeInHost {
// just mock the xdelta3 command directly
hostXdelta3Cmd = testutil.MockCommand(c, "xdelta3", "")
// note we don't add a Restore() to cleanups, it is called directly
// below after the first UseDeltas() but before the second
// UseDeltas() in order to properly test the caching behavior
}
// if there is not meant to be xdelta3 on the host or in core, then set
// PATH to be empty such that we won't find xdelta3 from the host
// running these tests
if !scenario.exeInHost && !scenario.exeInCore {
os.Setenv("PATH", "")
// also reset PATH at the end, otherwise an empty PATH leads
// testutil.MockCommand fails in future iterations that mock a
// command
cleanups = append(cleanups, func() {
os.Setenv("PATH", origPath)
})
}
// run the check for delta usage, we call it twice
sto := &store.Store{}
c.Check(sto.UseDeltas(), Equals, scenario.wantDelta, comment)
// cleanup the files we may have created before calling the function
// again to ensure that the caching works as expected
if scenario.exeInCore {
err := os.Remove(interpInCorePath)
c.Assert(err, IsNil)
}
if scenario.exeInHost {
hostXdelta3Cmd.Restore()
}
// also now that we have deleted the mock interpreter and unset the
// search path, we should still get the same result as above when
// we call UseDeltas() since it was cached, if it wasn't cached then
// this would fail
c.Check(sto.UseDeltas(), Equals, scenario.wantDelta, comment)
if scenario.wantDelta {
// if we should have been able to use deltas, make sure we picked
// the expected one, - if both were true we should have picked the
// one from core instead of the one from the host first
if scenario.exeInCore {
// check that during trying to check whether to use deltas or
// not, we called the interpreter with the xdelta3 config
// command too
c.Check(coreInterpCmd.Calls(), DeepEquals, [][]string{
{"ld-linux-x86-64.so.2", "--library-path", "/some/dir/from/etc/ld.so", exeInCorePath, "config"},
}, comment)
// also check that now after caching the xdelta3 command, it
// returns the expected format
expArgs := []string{
interpInCorePath,
"--library-path",
"/some/dir/from/etc/ld.so",
exeInCorePath,
"foo",
"bar",
}
// check that the Xdelta3Cmd function we cached uses the
// interpreter that was returned from CommandFromSystemSnap
c.Check(sto.Xdelta3Cmd("foo", "bar").Args, DeepEquals, expArgs, comment)
} else if scenario.exeInHost {
// similar checks for the host case, except in the host case we
// just called xdelta3 directly
c.Check(hostXdelta3Cmd.Calls(), DeepEquals, [][]string{
{"xdelta3", "config"},
}, comment)
// and args are passed to the command cached too
expArgs := []string{hostXdelta3Cmd.Exe(), "foo", "bar"}
c.Check(sto.Xdelta3Cmd("foo", "bar").Args, DeepEquals, expArgs, comment)
}
} else {
// quick check that the test case makes sense, if we didn't want
// deltas, the scenario should have either disabled via an env var,
// or had both exes missing
c.Assert((scenario.env == "0") ||
(!scenario.exeInCore && !scenario.exeInHost),
Equals, true)
}
// cleanup for the next iteration
for _, r := range cleanups {
r()
}
}
}
type downloadBehaviour []struct {
url string
error bool
}
var deltaTests = []struct {
downloads downloadBehaviour
info snap.DownloadInfo
expectedContent string
}{{
// The full snap is not downloaded, but rather the delta
// is downloaded and applied.
downloads: downloadBehaviour{
{url: "delta-url"},
},
info: snap.DownloadInfo{
DownloadURL: "full-snap-url",
Deltas: []snap.DeltaInfo{
{DownloadURL: "delta-url", Format: "xdelta3"},
},
},
expectedContent: "snap-content-via-delta",
}, {
// If there is an error during the delta download, the
// full snap is downloaded as per normal.
downloads: downloadBehaviour{
{error: true},
{url: "full-snap-url"},
},
info: snap.DownloadInfo{
DownloadURL: "full-snap-url",
Deltas: []snap.DeltaInfo{
{DownloadURL: "delta-url", Format: "xdelta3"},
},
},
expectedContent: "full-snap-url-content",
}, {
// If more than one matching delta is returned by the store
// we ignore deltas and do the full download.
downloads: downloadBehaviour{
{url: "full-snap-url"},
},
info: snap.DownloadInfo{
DownloadURL: "full-snap-url",
Deltas: []snap.DeltaInfo{
{DownloadURL: "delta-url", Format: "xdelta3"},
{DownloadURL: "delta-url-2", Format: "xdelta3"},
},
},
expectedContent: "full-snap-url-content",
}}
func (s *downloadSuite) TestDownloadWithDelta(c *C) {
origUseDeltas := os.Getenv("SNAPD_USE_DELTAS_EXPERIMENTAL")
defer os.Setenv("SNAPD_USE_DELTAS_EXPERIMENTAL", origUseDeltas)
c.Assert(os.Setenv("SNAPD_USE_DELTAS_EXPERIMENTAL", "1"), IsNil)
for _, testCase := range deltaTests {
testCase.info.Size = int64(len(testCase.expectedContent))
downloadIndex := 0
restore := store.MockDownload(func(ctx context.Context, name, sha3, url string, user *auth.UserState, s *store.Store, w io.ReadWriteSeeker, resume int64, pbar progress.Meter, dlOpts *store.DownloadOptions) error {
if testCase.downloads[downloadIndex].error {
downloadIndex++
return errors.New("Bang")
}
c.Check(url, Equals, testCase.downloads[downloadIndex].url)
w.Write([]byte(testCase.downloads[downloadIndex].url + "-content"))
downloadIndex++
return nil
})
defer restore()
restore = store.MockApplyDelta(func(_ *store.Store, name string, deltaPath string, deltaInfo *snap.DeltaInfo, targetPath string, targetSha3_384 string) error {
c.Check(deltaInfo, Equals, &testCase.info.Deltas[0])
err := os.WriteFile(targetPath, []byte("snap-content-via-delta"), 0644)
c.Assert(err, IsNil)
return nil
})
defer restore()
theStore := store.New(&store.Config{}, nil)
path := filepath.Join(c.MkDir(), "subdir", "downloaded-file")
err := theStore.Download(context.TODO(), "foo", path, &testCase.info, nil, nil, nil)
c.Assert(err, IsNil)
defer os.Remove(path)
c.Assert(path, testutil.FileEquals, testCase.expectedContent)
}
}
func (s *downloadSuite) TestActualDownloadRateLimited(c *C) {
var ratelimitReaderUsed bool
restore := store.MockRatelimitReader(func(r io.Reader, bucket *ratelimit.Bucket) io.Reader {
ratelimitReaderUsed = true
return r
})
defer restore()
canary := "downloaded data"
ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
fmt.Fprint(w, canary)
}))
defer ts.Close()
theStore := store.New(&store.Config{}, nil)
var buf SillyBuffer
err := store.Download(context.TODO(), "example-name", "", ts.URL, nil, theStore, &buf, 0, nil, &store.DownloadOptions{RateLimit: 1})
c.Assert(err, IsNil)
c.Check(buf.String(), Equals, canary)
c.Check(ratelimitReaderUsed, Equals, true)
}
func (s *downloadSuite) TestActualDownloadIcon(c *C) {
n := 0
const existingEtag = ""
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
c.Check(r.Header.Get("Snap-CDN"), Equals, "")
c.Check(r.Header.Get("Snap-Device-Location"), Equals, "")
c.Check(r.Header.Get("Snap-Refresh-Reason"), Equals, "")
n++
io.WriteString(w, "response-data")
}))
c.Assert(mockServer, NotNil)
defer mockServer.Close()
var buf SillyBuffer
newEtag, err := store.DownloadIconImpl(context.TODO(), "foo", existingEtag, mockServer.URL, &buf)
c.Assert(err, IsNil)
c.Check(newEtag, Equals, "")
c.Check(buf.String(), Equals, "response-data")
c.Check(n, Equals, 1)
}
func (s *downloadSuite) TestActualDownloadIconWithNewEtag(c *C) {
s.testActualDownloadIconWithNewEtagVariant(c, "etag")
s.testActualDownloadIconWithNewEtagVariant(c, "Etag")
s.testActualDownloadIconWithNewEtagVariant(c, "ETag")
}
func (s *downloadSuite) testActualDownloadIconWithNewEtagVariant(c *C, etagSpelling string) {
n := 0
const existingEtag = ""
const newEtag = "some-unique-value"
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
n++
c.Assert(r.Header.Get("If-None-Match"), Equals, existingEtag)
w.Header().Set(etagSpelling, newEtag) // set the http header according to etagSpelling
io.WriteString(w, "response-data")
}))
c.Assert(mockServer, NotNil)
defer mockServer.Close()
var buf SillyBuffer
receivedEtag, err := store.DownloadIconImpl(context.TODO(), "foo", existingEtag, mockServer.URL, &buf)
c.Assert(err, IsNil)
c.Check(receivedEtag, Equals, newEtag)
c.Check(buf.String(), Equals, "response-data")
c.Check(n, Equals, 1)
}
func (s *downloadSuite) TestActualDownloadIconWithExistingEtag(c *C) {
n := 0
const etag = "some-unique-value"
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
n++
c.Assert(r.Header.Get("If-None-Match"), Equals, etag)
w.Header().Set("Etag", etag) // use correct etag case here
w.WriteHeader(304) // 304 Not Modified
}))
c.Assert(mockServer, NotNil)
defer mockServer.Close()
var buf SillyBuffer
receivedEtag, err := store.DownloadIconImpl(context.TODO(), "foo", etag, mockServer.URL, &buf)
c.Check(err, Equals, store.ErrIconUnchanged)
c.Check(receivedEtag, Equals, "") // since we return an error, expect empty etag
c.Check(buf.String(), Equals, "")
c.Check(n, Equals, 1)
}
func (s *downloadSuite) TestActualDownloadIconWithChangedEtag(c *C) {
n := 0
const existingEtag = "some-unique-value"
const newEtag = "another-unique-value"
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
n++
c.Assert(r.Header.Get("If-None-Match"), Equals, existingEtag)
w.Header().Set("ETag", newEtag) // use another etag variant here
// return 200, not 304, since etag is different
io.WriteString(w, "response-data")
}))
c.Assert(mockServer, NotNil)
defer mockServer.Close()
var buf SillyBuffer
receivedEtag, err := store.DownloadIconImpl(context.TODO(), "foo", existingEtag, mockServer.URL, &buf)
c.Assert(err, IsNil)
c.Check(receivedEtag, Equals, newEtag)
c.Check(buf.String(), Equals, "response-data")
c.Check(n, Equals, 1)
}
func (s *downloadSuite) TestActualDownloadIconTooLarge(c *C) {
var maxSize int64 = 1000 // Must be less than size of SillyBuffer, so we can write enough to exceed the limit
restore := store.MockMaxIconFilesize(maxSize)
defer restore()
n := 0
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
n++
response := make([]byte, maxSize+1)
w.Write(response)
}))
c.Assert(mockServer, NotNil)
defer mockServer.Close()
var buf SillyBuffer
receivedEtag, err := store.DownloadIconImpl(context.TODO(), "foo", "fake-etag", mockServer.URL, &buf)
c.Assert(err, ErrorMatches, "unsupported Content-Length .*")
c.Check(receivedEtag, Equals, "")
c.Check(n, Equals, 1)
}
type BadWriter struct {
SillyBuffer
}
func (bw *BadWriter) Write(p []byte) (n int, err error) {
// Do the write
bw.SillyBuffer.Write(p)
// but return EOF
return -1, io.EOF
}
func (s *downloadSuite) TestActualDownloadIconCopyError(c *C) {
n := 0
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
n++
response := make([]byte, 5)
for i := range response[:5] {
// respond with 5 'a' bytes so we can check that it's been seeked and truncated
response[i] = 'a'
}
w.Write(response)
}))
c.Assert(mockServer, NotNil)
defer mockServer.Close()
var buf BadWriter
receivedEtag, err := store.DownloadIconImpl(context.TODO(), "foo", "fake-etag", mockServer.URL, &buf)
c.Check(err, testutil.ErrorIs, io.EOF)
c.Check(receivedEtag, Equals, "")
c.Check(n, Equals, 5)
// Check that the buffer only has 5 'a' bytes, indicating that it was
// seeked/truncated after each failed attempt
c.Check(buf.buf[:15], DeepEquals, []byte{'a', 'a', 'a', 'a', 'a', 0, 0, 0, 0, 0, 0, 0, 0, 0, 0})
}
func (s *downloadSuite) TestDownloadIconCancellation(c *C) {
ctx, cancel := context.WithCancel(context.Background())
n := 0
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
n++
io.WriteString(w, "foo")
cancel()
io.WriteString(w, "bar")
time.Sleep(10 * time.Millisecond)
}))
c.Assert(mockServer, NotNil)
defer mockServer.Close()
var buf SillyBuffer
receivedEtag, err := store.DownloadIconImpl(ctx, "foo", "fake-etag", mockServer.URL, &buf)
c.Check(n, Equals, 1)
c.Assert(err, testutil.ErrorIs, context.Canceled)
c.Check(receivedEtag, Equals, "")
}
func (s *downloadSuite) TestActualDownloadIcon404(c *C) {
n := 0
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
n++
w.WriteHeader(404)
}))
c.Assert(mockServer, NotNil)
defer mockServer.Close()
var buf SillyBuffer
receivedEtag, err := store.DownloadIconImpl(context.TODO(), "foo", "fake-etag", mockServer.URL, &buf)
c.Assert(err, NotNil)
c.Assert(err, FitsTypeOf, &store.DownloadError{})
c.Check(err.(*store.DownloadError).Code, Equals, 404)
c.Check(receivedEtag, Equals, "")
c.Check(n, Equals, 1)
}
func (s *downloadSuite) TestActualDownloadIcon500(c *C) {
n := 0
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
n++
w.WriteHeader(500)
}))
c.Assert(mockServer, NotNil)
defer mockServer.Close()
var buf SillyBuffer
receivedEtag, err := store.DownloadIconImpl(context.TODO(), "foo", "fake-etag", mockServer.URL, &buf)
c.Assert(err, NotNil)
c.Assert(err, FitsTypeOf, &store.DownloadError{})
c.Check(err.(*store.DownloadError).Code, Equals, 500)
c.Check(receivedEtag, Equals, "")
c.Check(n, Equals, 5)
}
func (s *downloadSuite) TestActualDownloadIcon500Once(c *C) {
n := 0
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
n++
if n == 1 {
w.WriteHeader(500)
} else {
io.WriteString(w, "response-data")
}
}))
c.Assert(mockServer, NotNil)
defer mockServer.Close()
var buf SillyBuffer
receivedEtag, err := store.DownloadIconImpl(context.TODO(), "foo", "fake-etag", mockServer.URL, &buf)
c.Assert(err, IsNil)
c.Check(buf.String(), Equals, "response-data")
c.Check(receivedEtag, Equals, "")
c.Check(n, Equals, 2)
}
|