1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787
|
// -*- Mode: Go; indent-tabs-mode: t -*-
/*
* Copyright (C) 2017 Canonical Ltd
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 3 as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
package main
import (
"fmt"
"os"
"path/filepath"
"strings"
"syscall"
"github.com/snapcore/snapd/logger"
"github.com/snapcore/snapd/osutil"
"github.com/snapcore/snapd/osutil/sys"
"github.com/snapcore/snapd/strutil"
)
// not available through syscall
const (
umountNoFollow = 8
// StReadOnly is the equivalent of ST_RDONLY
StReadOnly = 1
// SquashfsMagic is the equivalent of SQUASHFS_MAGIC
SquashfsMagic = 0x73717368
// Ext4Magic is the equivalent of EXT4_SUPER_MAGIC
Ext4Magic = 0xef53
// TmpfsMagic is the equivalent of TMPFS_MAGIC
TmpfsMagic = 0x01021994
)
// For mocking everything during testing.
var (
osLstat = os.Lstat
osReadlink = os.Readlink
osRemove = os.Remove
sysClose = syscall.Close
sysMkdirat = syscall.Mkdirat
sysMount = syscall.Mount
sysOpen = syscall.Open
sysOpenat = syscall.Openat
sysUnmount = syscall.Unmount
sysFchown = sys.Fchown
sysFstat = syscall.Fstat
sysFstatfs = syscall.Fstatfs
sysSymlinkat = osutil.Symlinkat
sysReadlinkat = osutil.Readlinkat
sysFchdir = syscall.Fchdir
sysLstat = syscall.Lstat
sysGetuid = sys.Getuid
sysGetgid = sys.Getgid
osReadDir = os.ReadDir
)
// ReadOnlyFsError is an error encapsulating encountered EROFS.
type ReadOnlyFsError struct {
Path string
}
func (e *ReadOnlyFsError) Error() string {
return fmt.Sprintf("cannot operate on read-only filesystem at %s", e.Path)
}
// OpenPath creates a path file descriptor for the given
// path, making sure no components are symbolic links.
//
// The file descriptor is opened using the O_PATH, O_NOFOLLOW,
// and O_CLOEXEC flags.
func OpenPath(path string) (int, error) {
iter, err := strutil.NewPathIterator(path)
if err != nil {
return -1, fmt.Errorf("cannot open path: %s", err)
}
if !filepath.IsAbs(iter.Path()) {
return -1, fmt.Errorf("path %v is not absolute", iter.Path())
}
iter.Next() // Advance iterator to '/'
// We use the following flags to open:
// O_PATH: we don't intend to use the fd for IO
// O_NOFOLLOW: don't follow symlinks
// O_DIRECTORY: we expect to find directories (except for the leaf)
// O_CLOEXEC: don't leak file descriptors over exec() boundaries
openFlags := sys.O_PATH | syscall.O_NOFOLLOW | syscall.O_DIRECTORY | syscall.O_CLOEXEC
fd, err := sysOpen("/", openFlags, 0)
if err != nil {
return -1, err
}
for iter.Next() {
// Ensure the parent file descriptor is closed
defer sysClose(fd)
if iter.IsCurrentBaseLeaf() {
openFlags &^= syscall.O_DIRECTORY
}
fd, err = sysOpenat(fd, iter.CurrentBase(), openFlags, 0)
if err != nil {
return -1, err
}
}
var statBuf syscall.Stat_t
err = sysFstat(fd, &statBuf)
if err != nil {
sysClose(fd)
return -1, err
}
if statBuf.Mode&syscall.S_IFMT == syscall.S_IFLNK {
sysClose(fd)
return -1, fmt.Errorf("%q is a symbolic link", path)
}
return fd, nil
}
// syscallMode returns the syscall-specific mode bits from Go's portable mode bits.
// This is a copy of the same helper in Go's os package.
func syscallMode(i os.FileMode) (o uint32) {
o |= uint32(i.Perm())
if i&os.ModeSetuid != 0 {
o |= syscall.S_ISUID
}
if i&os.ModeSetgid != 0 {
o |= syscall.S_ISGID
}
if i&os.ModeSticky != 0 {
o |= syscall.S_ISVTX
}
// No mapping for Go's ModeTemporary (plan9 only).
return o
}
// MkPrefix creates all the missing directories in a given base path and
// returns the file descriptor to the leaf directory as well as the restricted
// flag. This function is a base for secure variants of mkdir, touch and
// symlink. None of the traversed directories can be symbolic links.
func MkPrefix(base string, perm os.FileMode, uid sys.UserID, gid sys.GroupID, rs *Restrictions) (int, error) {
iter, err := strutil.NewPathIterator(base)
if err != nil {
// TODO: Reword the error and adjust the tests.
return -1, fmt.Errorf("cannot split unclean path %q", base)
}
if !filepath.IsAbs(iter.Path()) {
return -1, fmt.Errorf("path %v is not absolute", iter.Path())
}
iter.Next() // Advance iterator to '/'
const openFlags = syscall.O_NOFOLLOW | syscall.O_CLOEXEC | syscall.O_DIRECTORY
// Open the root directory and start there.
//
// We don't have to check for possible trespassing on / here because we are
// going to check for it in sec.MkDir call below which verifies that
// trespassing restrictions are not violated.
fd, err := sysOpen("/", openFlags, 0)
if err != nil {
return -1, fmt.Errorf("cannot open root directory: %v", err)
}
for iter.Next() {
// Keep closing the previous descriptor as we go, so that we have the
// last one handy from the MkDir below.
defer sysClose(fd)
fd, err = MkDir(fd, iter.CurrentDir(), iter.CurrentBase(), perm, uid, gid, rs)
if err != nil {
return -1, err
}
}
return fd, nil
}
// MkDir creates a directory with a given name.
//
// The directory is represented with a file descriptor and its name (for
// convenience). This function is meant to be used to construct subsequent
// elements of some path. The return value contains the newly created file
// descriptor for the new directory or -1 on error.
func MkDir(dirFd int, dirName string, name string, perm os.FileMode, uid sys.UserID, gid sys.GroupID, rs *Restrictions) (int, error) {
if err := rs.Check(dirFd, dirName); err != nil {
return -1, err
}
made := true
const openFlags = syscall.O_NOFOLLOW | syscall.O_CLOEXEC | syscall.O_DIRECTORY
if err := sysMkdirat(dirFd, name, syscallMode(perm)); err != nil {
switch err {
case syscall.EEXIST:
made = false
case syscall.EROFS:
// Treat EROFS specially: this is a hint that we have to poke a
// hole using tmpfs. The path below is the location where we
// need to poke the hole.
return -1, &ReadOnlyFsError{Path: dirName}
default:
return -1, fmt.Errorf("cannot create directory %q: %v", filepath.Join(dirName, name), err)
}
}
newFd, err := sysOpenat(dirFd, name, openFlags, 0)
if err != nil {
return -1, fmt.Errorf("cannot open directory %q: %v", filepath.Join(dirName, name), err)
}
if made {
// Chown each segment that we made.
if err := sysFchown(newFd, uid, gid); err != nil {
// Close the FD we opened if we fail here since the caller will get
// an error and won't assume responsibility for the FD.
sysClose(newFd)
return -1, fmt.Errorf("cannot chown directory %q to %d:%d: %v", filepath.Join(dirName, name), uid, gid, err)
}
// As soon as we find a place that is safe to write we can switch off
// the restricted mode (and thus any subsequent checks). This is
// because we only allow "writing" to read-only filesystems where
// writes fail with EROFS or to a tmpfs that snapd has privately
// mounted inside the per-snap mount namespace. As soon as we start
// walking over such tmpfs any subsequent children are either read-
// only bind mounts from $SNAP, other tmpfs'es (e.g. one explicitly
// constructed for a layout) or writable places that are bind-mounted
// from $SNAP_DATA or similar.
rs.Lift()
}
return newFd, err
}
// MkFile creates a file with a given name.
//
// The directory is represented with a file descriptor and its name (for
// convenience). This function is meant to be used to create the leaf file as
// a preparation for a mount point. Existing files are reused without errors.
// Newly created files have the specified mode and ownership.
func MkFile(dirFd int, dirName string, name string, perm os.FileMode, uid sys.UserID, gid sys.GroupID, rs *Restrictions) error {
if err := rs.Check(dirFd, dirName); err != nil {
return err
}
made := true
// NOTE: Tests don't show O_RDONLY as has a value of 0 and is not
// translated to textual form. It is added here for explicitness.
const openFlags = syscall.O_NOFOLLOW | syscall.O_CLOEXEC | syscall.O_RDONLY
// Open the final path segment as a file. Try to create the file (so that
// we know if we need to chown it) but fall back to just opening an
// existing one.
newFd, err := sysOpenat(dirFd, name, openFlags|syscall.O_CREAT|syscall.O_EXCL, syscallMode(perm))
if err != nil {
switch err {
case syscall.EEXIST:
// If the file exists then just open it without O_CREAT and O_EXCL
newFd, err = sysOpenat(dirFd, name, openFlags, 0)
if err != nil {
return fmt.Errorf("cannot open file %q: %v", filepath.Join(dirName, name), err)
}
made = false
case syscall.EROFS:
// Treat EROFS specially: this is a hint that we have to poke a
// hole using tmpfs. The path below is the location where we
// need to poke the hole.
return &ReadOnlyFsError{Path: dirName}
default:
return fmt.Errorf("cannot open file %q: %v", filepath.Join(dirName, name), err)
}
}
defer sysClose(newFd)
if made {
// Chown the file if we made it.
if err := sysFchown(newFd, uid, gid); err != nil {
return fmt.Errorf("cannot chown file %q to %d:%d: %v", filepath.Join(dirName, name), uid, gid, err)
}
}
return nil
}
// MkSymlink creates a symlink with a given name.
//
// The directory is represented with a file descriptor and its name (for
// convenience). This function is meant to be used to create the leaf symlink.
// Existing and identical symlinks are reused without errors.
func MkSymlink(dirFd int, dirName string, name string, oldname string, rs *Restrictions) error {
if err := rs.Check(dirFd, dirName); err != nil {
return err
}
// Create the final path segment as a symlink.
if err := sysSymlinkat(oldname, dirFd, name); err != nil {
switch err {
case syscall.EEXIST:
var objFd int
// If the file exists then just open it for examination.
// Maybe it's the symlink we were hoping to create.
objFd, err = sysOpenat(dirFd, name, syscall.O_CLOEXEC|sys.O_PATH|syscall.O_NOFOLLOW, 0)
if err != nil {
return fmt.Errorf("cannot open existing file %q: %v", filepath.Join(dirName, name), err)
}
defer sysClose(objFd)
var statBuf syscall.Stat_t
err = sysFstat(objFd, &statBuf)
if err != nil {
return fmt.Errorf("cannot inspect existing file %q: %v", filepath.Join(dirName, name), err)
}
if statBuf.Mode&syscall.S_IFMT != syscall.S_IFLNK {
return fmt.Errorf("cannot create symbolic link %q: existing file in the way", filepath.Join(dirName, name))
}
var n int
buf := make([]byte, len(oldname)+2)
n, err = sysReadlinkat(objFd, "", buf)
if err != nil {
return fmt.Errorf("cannot read symbolic link %q: %v", filepath.Join(dirName, name), err)
}
if string(buf[:n]) != oldname {
return fmt.Errorf("cannot create symbolic link %q: existing symbolic link in the way", filepath.Join(dirName, name))
}
return nil
case syscall.EROFS:
// Treat EROFS specially: this is a hint that we have to poke a
// hole using tmpfs. The path below is the location where we
// need to poke the hole.
return &ReadOnlyFsError{Path: dirName}
default:
return fmt.Errorf("cannot create symlink %q: %v", filepath.Join(dirName, name), err)
}
}
return nil
}
// MkdirAllWithin is the secure variant of os.MkdirAll that creates all the missing directories of the given path within the
// given existing parent directory.
//
// Unlike os.MkdirAll this implementation does not follow any symbolic
// links. At all times the new directory segment is created using mkdirat(2)
// while holding an open file descriptor to the parent directory.
//
// The only handled error is mkdirat(2) that fails with EEXIST. All other
// errors are fatal but there is no attempt to undo anything that was created.
//
// The uid and gid are used for the fchown(2) system call which is performed
// after each segment is created and opened. The special value -1 may be used
// to request that ownership is not changed.
func MkdirAllWithin(path, parent string, perm os.FileMode, uid sys.UserID, gid sys.GroupID, rs *Restrictions) error {
path = filepath.Clean(path)
parent = filepath.Clean(parent)
if !filepath.IsAbs(path) {
return fmt.Errorf("cannot use relative path %q", path)
}
if !filepath.IsAbs(parent) {
return fmt.Errorf("cannot use relative parent path %q", parent)
}
isParent := func(path, parent string) bool {
if path == parent {
return false
}
if parent == "/" {
return true
}
return strings.HasPrefix(path, parent+string(filepath.Separator))
}
if !isParent(path, parent) {
return fmt.Errorf("path %q is not a parent of %q", parent, path)
}
// Check if we need to do anything
fi, err := osLstat(path)
if err == nil {
if !fi.Mode().IsDir() {
return fmt.Errorf("cannot create directory %q: existing file in the way", path)
}
return nil
} else if !os.IsNotExist(err) {
return fmt.Errorf("cannot inspect path %q: %v", path, err)
}
// Check that the parent path exists
fi, err = osLstat(parent)
if err == nil {
if !fi.Mode().IsDir() {
return fmt.Errorf("cannot use parent path %q: not a directory", parent)
}
} else if os.IsNotExist(err) {
return fmt.Errorf("parent directory %q does not exist", parent)
} else {
return fmt.Errorf("cannot inspect parent path %q: %v", parent, err)
}
iter, err := strutil.NewPathIterator(path)
if err != nil {
return fmt.Errorf("cannot iterate over path %q: %v", path, err)
}
// Advance the iterator to the parent. Finding the parent is
// guaranteed by the earlier check isParent.
for iter.Next() {
if iter.CurrentPath() == parent {
break
}
}
// Advance the iterator to the first missing directory
for iter.Next() {
if iter.CurrentPath() == path {
// Already confirmed path does not exist
break
}
fi, err = osLstat(iter.CurrentPath())
if err == nil {
if !fi.Mode().IsDir() {
return fmt.Errorf("cannot create directory %q: existing file in the way", iter.CurrentPath())
}
continue
}
if !os.IsNotExist(err) {
return fmt.Errorf("cannot inspect path %q: %v", iter.CurrentPath(), err)
}
break
}
// Create the first missing directory. From this point onward all file descriptors are kept open
// until all missing directories have been created or failure, and then closed in reverse order.
const openFlags = syscall.O_NOFOLLOW | syscall.O_CLOEXEC | syscall.O_DIRECTORY
fd, err := sysOpen(iter.CurrentDir(), openFlags, 0)
if err != nil {
return fmt.Errorf("cannot open directory %q: %v", iter.CurrentDir(), err)
}
defer sysClose(fd)
fd, err = MkDir(fd, iter.CurrentDir(), iter.CurrentBase(), perm, uid, gid, rs)
if err != nil {
return err
}
defer sysClose(fd)
// Create the remaining missing directories
for iter.Next() {
fd, err = MkDir(fd, iter.CurrentDir(), iter.CurrentBase(), perm, uid, gid, rs)
if err != nil {
return err
}
defer sysClose(fd)
}
return nil
}
// MkdirAll is the secure variant of os.MkdirAll.
//
// Unlike the regular version this implementation does not follow any symbolic
// links. At all times the new directory segment is created using mkdirat(2)
// while holding an open file descriptor to the parent directory.
//
// The only handled error is mkdirat(2) that fails with EEXIST. All other
// errors are fatal but there is no attempt to undo anything that was created.
//
// The uid and gid are used for the fchown(2) system call which is performed
// after each segment is created and opened. The special value -1 may be used
// to request that ownership is not changed.
func MkdirAll(path string, perm os.FileMode, uid sys.UserID, gid sys.GroupID, rs *Restrictions) error {
if path != filepath.Clean(path) {
// TODO: Reword the error and adjust the tests.
return fmt.Errorf("cannot split unclean path %q", path)
}
// Only support absolute paths to avoid bugs in snap-confine when
// called from anywhere.
if !filepath.IsAbs(path) {
return fmt.Errorf("cannot create directory with relative path: %q", path)
}
base, name := filepath.Split(path)
base = filepath.Clean(base) // Needed to chomp the trailing slash.
// Create the prefix.
dirFd, err := MkPrefix(base, perm, uid, gid, rs)
if err != nil {
return err
}
defer sysClose(dirFd)
if name != "" {
// Create the leaf as a directory.
leafFd, err := MkDir(dirFd, base, name, perm, uid, gid, rs)
if err != nil {
return err
}
defer sysClose(leafFd)
}
return nil
}
// MkfileAll is a secure implementation of "mkdir -p $(dirname $1) && touch $1".
//
// This function is like MkdirAll but it creates an empty file instead of
// a directory for the final path component. Each created directory component
// is chowned to the desired user and group.
func MkfileAll(path string, perm os.FileMode, uid sys.UserID, gid sys.GroupID, rs *Restrictions) error {
if path != filepath.Clean(path) {
// TODO: Reword the error and adjust the tests.
return fmt.Errorf("cannot split unclean path %q", path)
}
// Only support absolute paths to avoid bugs in snap-confine when
// called from anywhere.
if !filepath.IsAbs(path) {
return fmt.Errorf("cannot create file with relative path: %q", path)
}
// Only support file names, not directory names.
if strings.HasSuffix(path, "/") {
return fmt.Errorf("cannot create non-file path: %q", path)
}
base, name := filepath.Split(path)
base = filepath.Clean(base) // Needed to chomp the trailing slash.
// Create the prefix.
dirFd, err := MkPrefix(base, perm, uid, gid, rs)
if err != nil {
return err
}
defer sysClose(dirFd)
if name != "" {
// Create the leaf as a file.
err = MkFile(dirFd, base, name, perm, uid, gid, rs)
}
return err
}
// MksymlinkAll is a secure implementation of "ln -s".
func MksymlinkAll(path string, perm os.FileMode, uid sys.UserID, gid sys.GroupID, oldname string, rs *Restrictions) error {
if path != filepath.Clean(path) {
// TODO: Reword the error and adjust the tests.
return fmt.Errorf("cannot split unclean path %q", path)
}
// Only support absolute paths to avoid bugs in snap-confine when
// called from anywhere.
if !filepath.IsAbs(path) {
return fmt.Errorf("cannot create symlink with relative path: %q", path)
}
// Only support file names, not directory names.
if strings.HasSuffix(path, "/") {
return fmt.Errorf("cannot create non-file path: %q", path)
}
if oldname == "" {
return fmt.Errorf("cannot create symlink with empty target: %q", path)
}
base, name := filepath.Split(path)
base = filepath.Clean(base) // Needed to chomp the trailing slash.
// Create the prefix.
dirFd, err := MkPrefix(base, perm, uid, gid, rs)
if err != nil {
return err
}
defer sysClose(dirFd)
if name != "" {
// Create the leaf as a symlink.
err = MkSymlink(dirFd, base, name, oldname, rs)
}
return err
}
// planWritableMimic plans how to transform a given directory from read-only to writable.
//
// The algorithm is designed to be universally reversible so that it can be
// always de-constructed back to the original directory. The original directory
// is hidden by tmpfs and a subset of things that were present there originally
// is bind mounted back on top of empty directories or empty files. Symlinks
// are re-created directly. Devices and all other elements are not supported
// because they are forbidden in snaps for which this function is designed to
// be used with. Since the original directory is hidden the algorithm relies on
// a temporary directory where the original is bind-mounted during the
// progression of the algorithm.
func planWritableMimic(dir, neededBy string) ([]*Change, error) {
// We need a place for "safe keeping" of what is present in the original
// directory as we are about to attach a tmpfs there, which will hide
// everything inside.
logger.Debugf("create-writable-mimic %q", dir)
safeKeepingDir := filepath.Join("/tmp/.snap/", dir)
var changes []*Change
// Stat the original directory to know which mode and ownership to
// replicate on top of the tmpfs we are about to create below.
var sb syscall.Stat_t
if err := sysLstat(dir, &sb); err != nil {
return nil, err
}
// Bind mount the original directory elsewhere for safe-keeping.
changes = append(changes, &Change{
Action: Mount, Entry: osutil.MountEntry{
// NOTE: Here we recursively bind because we realized that not
// doing so doesn't work on core devices which use bind mounts
// extensively to construct writable spaces in /etc and /var and
// elsewhere.
//
// All directories present in the original are also recursively
// bind mounted back to their original location. To unmount this
// contraption we use MNT_DETACH which frees us from having to
// enumerate the mount table, unmount all the things (starting
// with most nested).
//
// The undo logic handles rbind mounts and adds x-snapd.unbind
// flag to them, which in turns translates to MNT_DETACH on
// umount2(2) system call.
Name: dir, Dir: safeKeepingDir, Options: []string{"rbind"}},
})
// Mount tmpfs over the original directory, hiding its contents.
// The mounted tmpfs will mimic the mode and ownership of the original
// directory.
changes = append(changes, &Change{
Action: Mount, Entry: osutil.MountEntry{
Name: "tmpfs", Dir: dir, Type: "tmpfs",
Options: []string{
osutil.XSnapdSynthetic(),
osutil.XSnapdNeededBy(neededBy),
fmt.Sprintf("mode=%#o", sb.Mode&07777),
fmt.Sprintf("uid=%d", sb.Uid),
fmt.Sprintf("gid=%d", sb.Gid),
},
},
})
// Iterate over the items in the original directory (nothing is mounted _yet_).
entries, err := osReadDir(dir)
if err != nil {
return nil, err
}
for _, fi := range entries {
ch := &Change{Action: Mount, Entry: osutil.MountEntry{
Name: filepath.Join(safeKeepingDir, fi.Name()),
Dir: filepath.Join(dir, fi.Name()),
}}
// Bind mount each element from the safe-keeping directory into the
// tmpfs. Our Change.Perform() engine can create the missing
// directories automatically so we don't bother creating those.
m := fi.Type()
switch {
case m.IsDir():
ch.Entry.Options = []string{"rbind"}
case m.IsRegular():
ch.Entry.Options = []string{"bind", osutil.XSnapdKindFile()}
case m&os.ModeSymlink != 0:
if target, err := osReadlink(filepath.Join(dir, fi.Name())); err == nil {
ch.Entry.Options = []string{osutil.XSnapdKindSymlink(), osutil.XSnapdSymlink(target)}
} else {
continue
}
default:
logger.Noticef("skipping unsupported file %s", fi)
continue
}
ch.Entry.Options = append(ch.Entry.Options, osutil.XSnapdSynthetic())
ch.Entry.Options = append(ch.Entry.Options, osutil.XSnapdNeededBy(neededBy))
changes = append(changes, ch)
}
// Finally unbind the safe-keeping directory as we don't need it anymore.
changes = append(changes, &Change{
Action: Unmount, Entry: osutil.MountEntry{Name: "none", Dir: safeKeepingDir, Options: []string{osutil.XSnapdDetach()}},
})
return changes, nil
}
// FatalError is an error that we cannot correct.
type FatalError struct {
error
}
// execWritableMimic executes the plan for a writable mimic.
// The result is a transformed mount namespace and a set of fake mount changes
// that only exist in order to undo the plan.
//
// Certain assumptions are made about the plan, it must closely resemble that
// created by planWritableMimic, in particular the sequence must look like this:
//
// - bind a directory aside into safekeeping location
// - cover the original with tmpfs
// - bind mount something from safekeeping location to an empty file or
// directory in the tmpfs; this step can repeat any number of times
// - unbind the safekeeping location
//
// Apart from merely executing the plan a fake plan is returned for undo. The
// undo plan skips the following elements as compared to the original plan:
//
// - the initial bind mount that constructs the safekeeping directory is gone
// - the final unmount that removes the safekeeping directory
// - the source of each of the bind mounts that re-populate tmpfs.
//
// In the event of a failure the undo plan is executed and an error is
// returned. If the undo plan fails the function returns a FatalError as it
// cannot fix the system from an inconsistent state.
func execWritableMimic(plan []*Change, as *Assumptions) ([]*Change, error) {
undoChanges := make([]*Change, 0, len(plan)-2)
for i, change := range plan {
if _, err := change.Perform(as); err != nil {
// Drat, we failed! Let's undo everything according to our own undo
// plan, by following it in reverse order.
recoveryUndoChanges := make([]*Change, 0, len(undoChanges)+1)
if i > 0 {
// The undo plan doesn't contain the entry for the initial bind
// mount of the safe keeping directory but we have already
// performed it. For this recovery phase we need to insert that
// in front of the undo plan manually.
recoveryUndoChanges = append(recoveryUndoChanges, plan[0])
}
recoveryUndoChanges = append(recoveryUndoChanges, undoChanges...)
for j := len(recoveryUndoChanges) - 1; j >= 0; j-- {
recoveryUndoChange := recoveryUndoChanges[j]
// All the changes mount something, we need to reverse that.
// The "undo plan" is "a plan that can be undone" not "the plan
// for how to undo" so we need to flip the actions.
recoveryUndoChange.Action = Unmount
if recoveryUndoChange.Entry.OptBool("rbind") {
recoveryUndoChange.Entry.Options = append(recoveryUndoChange.Entry.Options, osutil.XSnapdDetach())
}
if _, err2 := recoveryUndoChange.Perform(as); err2 != nil {
// Drat, we failed when trying to recover from an error.
// We cannot do anything at this stage.
return nil, &FatalError{error: fmt.Errorf("cannot undo change %q while recovering from earlier error %v: %v", recoveryUndoChange, err, err2)}
}
}
return nil, err
}
if i == 0 || i == len(plan)-1 {
// Don't represent the initial and final changes in the undo plan.
// The initial change is the safe-keeping bind mount, the final
// change is the safe-keeping unmount.
continue
}
if change.Entry.XSnapdKind() == "symlink" {
// Don't represent symlinks in the undo plan. They are removed when
// the tmpfs is unmounted.
continue
}
// Store an undo change for the change we just performed.
undoOpts := change.Entry.Options
if change.Entry.OptBool("rbind") {
undoOpts = make([]string, 0, len(change.Entry.Options)+1)
undoOpts = append(undoOpts, change.Entry.Options...)
undoOpts = append(undoOpts, "x-snapd.detach")
}
undoChange := &Change{
Action: Mount,
Entry: osutil.MountEntry{Dir: change.Entry.Dir, Name: change.Entry.Name, Type: change.Entry.Type, Options: undoOpts},
}
// Because of the use of a temporary bind mount (aka the safe-keeping
// directory) we cannot represent bind mounts fully (the temporary bind
// mount is unmounted as the last stage of this process). For that
// reason let's hide the original location and overwrite it so to
// appear as if the directory was a bind mount over itself. This is not
// fully true (it is a bind mount from the old self to the new empty
// directory or file in the same path, with the tmpfs in place already)
// but this is closer to the truth and more in line with the idea that
// this is just a plan for undoing the operation.
if undoChange.Entry.OptBool("bind") || undoChange.Entry.OptBool("rbind") {
undoChange.Entry.Name = undoChange.Entry.Dir
}
undoChanges = append(undoChanges, undoChange)
}
return undoChanges, nil
}
func createWritableMimic(dir, neededBy string, as *Assumptions) ([]*Change, error) {
plan, err := planWritableMimic(dir, neededBy)
if err != nil {
return nil, err
}
changes, err := execWritableMimic(plan, as)
if err != nil {
return nil, err
}
return changes, nil
}
|