1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533
|
// -*- Mode: Go; indent-tabs-mode: t -*-
/*
* Copyright (C) 2019-2021 Canonical Ltd
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 3 as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
package gadget
import (
"fmt"
"path/filepath"
"sort"
"strings"
"github.com/snapcore/snapd/kernel"
"github.com/snapcore/snapd/osutil"
"github.com/snapcore/snapd/strutil"
)
// ValidationConstraints carries extra constraints on top of those
// implied by the model to use for gadget validation.
// They might be constraints that are determined only at runtime.
type ValidationConstraints struct {
// EncryptedData when true indicates that the gadget will be used on a
// device where the data partition will be encrypted.
EncryptedData bool
}
// Validate checks that the given gadget metadata matches the
// consistency rules for role usage, labels etc as implied by the
// model and extra constraints that might be known only at runtime.
func Validate(info *Info, model Model, extra *ValidationConstraints) error {
if err := ruleValidateVolumes(info.Volumes, model, extra); err != nil {
return err
}
return nil
}
type roleInstance struct {
volName string
s *VolumeStructure
}
func ruleValidateVolumes(vols map[string]*Volume, model Model, extra *ValidationConstraints) error {
roles := map[string]*roleInstance{
SystemSeed: nil,
SystemSeedNull: nil,
SystemBoot: nil,
SystemData: nil,
SystemSave: nil,
}
xvols := ""
if len(vols) != 1 {
xvols = " across volumes"
}
// TODO: is this too strict for old gadgets?
for name, v := range vols {
for i := range v.Structure {
s := &v.Structure[i]
if inst, ok := roles[s.Role]; ok {
if inst != nil {
return fmt.Errorf("cannot have more than one partition with %s role%s", s.Role, xvols)
}
roles[s.Role] = &roleInstance{
volName: name,
s: s,
}
}
}
}
if roles[SystemSeed] != nil && roles[SystemSeedNull] != nil {
return fmt.Errorf("cannot have more than one partition with %s/%s role%s", SystemSeed, SystemSeedNull, xvols)
}
hasModes := false
// Classic with gadget + kernel snaps
// TODO: do the rules need changing now that we allow to omit
// gadget and kernel?
isClassicWithModes := false
if model != nil {
hasModes = hasGrade(model)
isClassicWithModes = classicOrUndetermined(model) && hasModes
} else {
// if system-seed role is mentioned assume the uc20
// consistency rules
hasModes = roles[SystemSeed] != nil
// if system-seed-null, this is classic with modes
// Note that this will not be true if we use this role in
// the future for UC cloud images.
if roles[SystemSeedNull] != nil {
hasModes = true
isClassicWithModes = true
}
}
for name, v := range vols {
if err := ruleValidateVolume(v, hasModes); err != nil {
return fmt.Errorf("invalid volume %q: %v", name, err)
}
}
if isClassicWithModes {
if err := ensureRolesConsistencyClassicWithModes(roles); err != nil {
return err
}
} else {
// The seed is expected on UC with modes
if err := ensureRolesConsistency(roles, hasModes); err != nil {
return err
}
}
if extra != nil {
if extra.EncryptedData {
if !hasModes {
return fmt.Errorf("internal error: cannot support encrypted data in a system without modes")
}
if roles[SystemSave] == nil {
return fmt.Errorf("gadget does not support encrypted data: required partition with system-save role is missing")
// TODO:UC20: shall we make sure that size of ubuntu-save is reasonable?
}
}
}
return nil
}
func ruleValidateVolume(vol *Volume, hasModes bool) error {
if vol.Schema == schemaEMMC {
if err := ruleValidateEMMCVolume(vol); err != nil {
return err
}
}
for idx, s := range vol.Structure {
if err := ruleValidateVolumeStructure(&s, hasModes); err != nil {
return fmt.Errorf("invalid structure %v: %v", fmtIndexAndName(idx, s.Name), err)
}
}
return nil
}
func ruleValidateEMMCVolume(vol *Volume) error {
// Only content, schema and name can be set currently for eMMC
if vol.Bootloader != "" {
return fmt.Errorf(`cannot set "bootloader" for eMMC schemas`)
}
if vol.ID != "" {
return fmt.Errorf(`cannot set "id" for eMMC schemas`)
}
if len(vol.Partial) != 0 {
return fmt.Errorf(`cannot set "partial" content for eMMC schemas`)
}
return nil
}
func validateEMMCStructureName(vs *VolumeStructure) error {
if vs.EnclosingVolume.Schema != schemaEMMC {
return nil
}
if !strutil.ListContains(validEMMCVolumeNames, vs.Name) {
return fmt.Errorf("cannot use %q as emmc name, only %q is allowed", vs.Name, validEMMCVolumeNames)
}
return nil
}
func ruleValidateVolumeStructure(vs *VolumeStructure, hasModes bool) error {
var reservedLabels []string
if hasModes {
reservedLabels = reservedLabelsWithModes
} else {
reservedLabels = reservedLabelsWithoutModes
}
if err := validateReservedLabels(vs, reservedLabels); err != nil {
return err
}
if err := validateEMMCStructureName(vs); err != nil {
return err
}
return nil
}
var (
reservedLabelsWithModes = []string{
ubuntuBootLabel,
ubuntuSeedLabel,
ubuntuDataLabel,
ubuntuSaveLabel,
}
// labels that we don't expect to be used on a UC16/18 system:
// * seed needs to be the ESP so there's a conflict
// * ubuntu-data is the main data partition which on UC16/18
// is expected to be named writable instead
reservedLabelsWithoutModes = []string{
ubuntuSeedLabel,
ubuntuDataLabel,
}
// valid names for volumes under an eMMC schema
validEMMCVolumeNames = []string{"boot0", "boot1"}
)
func validateReservedLabels(vs *VolumeStructure, reservedLabels []string) error {
if vs.Role != "" {
// structure specifies a role, its labels will be checked later
return nil
}
if vs.Label == "" {
return nil
}
for _, reservedLabel := range reservedLabels {
if vs.HasLabel(reservedLabel) {
return fmt.Errorf("label %q is reserved", vs.Label)
}
}
return nil
}
func ensureRolesConsistency(roles map[string]*roleInstance, seedExpected bool) error {
// TODO: should we validate usage of uc20 specific system-recovery-{image,select}
// roles too? they should only be used on uc20 systems, so models that
// have a grade set and are not classic boot
switch {
case roles[SystemSeed] == nil && roles[SystemData] == nil:
if seedExpected {
return fmt.Errorf("model requires system-seed partition, but no system-seed or system-data partition found")
}
case roles[SystemSeed] != nil && roles[SystemData] == nil:
return fmt.Errorf("the system-seed role requires system-data to be defined")
case roles[SystemSeed] == nil && roles[SystemData] != nil:
// error if we have the SystemSeed constraint but no actual system-seed structure
if seedExpected {
return fmt.Errorf("model requires system-seed structure, but none was found")
}
// without SystemSeed, system-data label must be implicit or writable
if err := checkImplicitLabels(roles,
roleLabel{role: SystemData, label: implicitSystemDataLabel}); err != nil {
return err
}
case roles[SystemSeed] != nil && roles[SystemData] != nil:
// error if we don't have the SystemSeed constraint but we have a system-seed structure
if !seedExpected {
return fmt.Errorf("model does not support the system-seed role")
}
if err := checkImplicitLabels(roles, roleLabelData, roleLabelSeed); err != nil {
return err
}
}
if roles[SystemSave] != nil {
if !seedExpected {
return fmt.Errorf("model does not support the system-save role")
}
if err := ensureSystemSaveRuleConsistency(roles); err != nil {
return err
}
}
if seedExpected {
// make sure that all roles come from the same volume
// TODO:UC20: there is more to do in order to support multi-volume situations
// if SystemSeed is unset we must have failed earlier
seedVolName := roles[SystemSeed].volName
for _, otherRole := range []string{SystemBoot, SystemData, SystemSave} {
ri := roles[otherRole]
if ri != nil && ri.volName != seedVolName {
return fmt.Errorf("system-boot, system-data, and system-save are expected to share the same volume as system-seed")
}
}
}
return nil
}
func ensureRolesConsistencyClassicWithModes(roles map[string]*roleInstance) error {
if roles[SystemBoot] == nil || roles[SystemData] == nil {
return fmt.Errorf("system-boot and system-data roles are needed on classic")
}
// Make sure labels are as expected - save is optional
roleLabelToCheck := []roleLabel{roleLabelBoot, roleLabelData}
roleLabelOptional := []roleLabel{roleLabelSeed, roleLabelSeedNull, roleLabelSave}
for _, rlLb := range roleLabelOptional {
if roles[rlLb.role] != nil {
roleLabelToCheck = append(roleLabelToCheck, rlLb)
}
}
if err := checkImplicitLabels(roles, roleLabelToCheck...); err != nil {
return err
}
// Check that boot/seed/seed-null/save are in the same volume
bootVolName := roles[SystemBoot].volName
for _, role := range []string{SystemSeed, SystemSeedNull, SystemSave} {
if roles[role] != nil && roles[role].volName != bootVolName {
return fmt.Errorf("system-boot and %s are expected to share the same volume", role)
}
}
return nil
}
func ensureSystemSaveRuleConsistency(roles map[string]*roleInstance) error {
if roles[SystemData] == nil || roles[SystemSeed] == nil {
// previous checks should stop reaching here
return fmt.Errorf("internal error: system-save requires system-seed and system-data structures")
}
if err := checkImplicitLabels(roles, roleLabelSave); err != nil {
return err
}
return nil
}
// roleLabel contains a partition role and the default expected label.
type roleLabel struct {
role string
label string
}
var (
roleLabelSeed = roleLabel{role: SystemSeed, label: ubuntuSeedLabel}
roleLabelSeedNull = roleLabel{role: SystemSeedNull, label: ubuntuSeedLabel}
roleLabelBoot = roleLabel{role: SystemBoot, label: ubuntuBootLabel}
roleLabelSave = roleLabel{role: SystemSave, label: ubuntuSaveLabel}
roleLabelData = roleLabel{role: SystemData, label: ubuntuDataLabel}
)
func checkImplicitLabels(roles map[string]*roleInstance, roleLabels ...roleLabel) error {
for _, rlLb := range roleLabels {
volStruct := roles[rlLb.role].s
if volStruct == nil {
return fmt.Errorf("internal error: %q not in volume", rlLb.role)
}
if volStruct.Label != "" && !volStruct.HasLabel(rlLb.label) {
return fmt.Errorf("%s structure must have an implicit label or %q, not %q", rlLb.role, rlLb.label, volStruct.Label)
}
}
return nil
}
// content validation
func splitKernelRef(kernelRef string) (asset, content string, err error) {
// kernel ref has format: $kernel:<asset-name>/<content-path> where
// asset name and content is listed in kernel.yaml, content looks like a
// sane path
if !strings.HasPrefix(kernelRef, "$kernel:") {
return "", "", fmt.Errorf("internal error: splitKernelRef called for non kernel ref %q", kernelRef)
}
assetAndContent := kernelRef[len("$kernel:"):]
l := strings.SplitN(assetAndContent, "/", 2)
if len(l) < 2 {
return "", "", fmt.Errorf("invalid asset and content in kernel ref %q", kernelRef)
}
asset = l[0]
content = l[1]
nonDirContent := content
if strings.HasSuffix(nonDirContent, "/") {
// a single trailing / is allowed to indicate all content under directory
nonDirContent = strings.TrimSuffix(nonDirContent, "/")
}
if len(asset) == 0 || len(content) == 0 {
return "", "", fmt.Errorf("missing asset name or content in kernel ref %q", kernelRef)
}
if filepath.Clean(nonDirContent) != nonDirContent || strings.Contains(content, "..") || nonDirContent == "/" {
return "", "", fmt.Errorf("invalid content in kernel ref %q", kernelRef)
}
if !kernel.ValidAssetName.MatchString(asset) {
return "", "", fmt.Errorf("invalid asset name in kernel ref %q", kernelRef)
}
return asset, content, nil
}
func validateVolumeContentsPresence(gadgetSnapRootDir string, vol *Volume) error {
// bare structure content is checked to exist during layout
// make sure that filesystem content source paths exist as well
for _, s := range vol.Structure {
if !s.HasFilesystem() {
continue
}
for _, c := range s.Content {
// TODO: detect and skip Content with "$kernel:" style
// refs if there is no kernelSnapRootDir passed in as
// well
if strings.HasPrefix(c.UnresolvedSource, "$kernel:") {
// This only validates that the ref is valid.
// Resolving happens with ResolveContentPaths()
if _, _, err := splitKernelRef(c.UnresolvedSource); err != nil {
return fmt.Errorf("cannot use kernel reference %q: %v", c.UnresolvedSource, err)
}
continue
}
realSource := filepath.Join(gadgetSnapRootDir, c.UnresolvedSource)
if !osutil.FileExists(realSource) {
return fmt.Errorf("structure #%d (%q), content %v: source path does not exist", s.YamlIndex, s.Name, c)
}
if strings.HasSuffix(c.UnresolvedSource, "/") {
// expecting a directory
if err := checkSourceIsDir(realSource + "/"); err != nil {
return fmt.Errorf("structure #%d (%q), content %v: %v", s.YamlIndex, s.Name, c, err)
}
}
}
}
return nil
}
// ValidateContent checks whether the given directory contains valid matching content with respect to the given pre-validated gadget metadata.
func ValidateContent(info *Info, gadgetSnapRootDir, kernelSnapRootDir string) error {
// TODO: also validate that only one "<bl-name>.conf" file is
// in the root directory of the gadget snap, because the
// "<bl-name>.conf" file indicates precisely which bootloader
// the gadget uses and as such there cannot be more than one
// such bootloader
var kernelInfo *kernel.Info
if kernelSnapRootDir != "" {
var err error
kernelInfo, err = kernel.ReadInfo(kernelSnapRootDir)
if err != nil {
return err
}
}
for name, vol := range info.Volumes {
// Check that files shipped in the gadget have the expected sizes
for idx := range vol.Structure {
if err := checkGadgetContentImages(gadgetSnapRootDir, &vol.Structure[idx]); err != nil {
return err
}
}
// Make sure that content can be resolved if the kernel snap is known.
if kernelInfo != nil {
for idx := range vol.Structure {
if _, err := resolveVolumeContent(gadgetSnapRootDir, kernelSnapRootDir, kernelInfo, &vol.Structure[idx], nil); err != nil {
return err
}
}
}
if err := validateVolumeContentsPresence(gadgetSnapRootDir, vol); err != nil {
return fmt.Errorf("invalid volume %q: %v", name, err)
}
}
// Ensure that at least one kernel.yaml reference can be resolved
// by the gadget
if kernelInfo != nil {
resolvedOnce := false
for _, vol := range info.Volumes {
err := gadgetVolumeConsumesOneKernelUpdateAsset(vol, kernelInfo)
if err == nil {
resolvedOnce = true
}
}
if !resolvedOnce {
return fmt.Errorf("no asset from the kernel.yaml needing synced update is consumed by the gadget at %q", gadgetSnapRootDir)
}
}
return nil
}
// gadgetVolumeConsumesOneKernelUpdateAsset ensures that at least one kernel
// assets from the kernel.yaml has a reference in the given
// LaidOutVolume.
func gadgetVolumeConsumesOneKernelUpdateAsset(pNew *Volume, kernelInfo *kernel.Info) error {
notFoundAssets, _, err := searchConsumedAssets(pNew, kernelInfo.Assets)
if err != nil {
return err
}
if len(notFoundAssets) > 0 {
sort.Strings(notFoundAssets)
return fmt.Errorf("gadget does not consume any of the kernel assets needing synced update %s", strutil.Quoted(notFoundAssets))
}
return nil
}
func searchConsumedAssets(pNew *Volume, assets map[string]*kernel.Asset) (missingAssets []string, consumedAny bool, err error) {
notFoundAssets := make([]string, 0, len(assets))
for assetName, asset := range assets {
if !asset.Update {
continue
}
for _, ps := range pNew.Structure {
for _, rc := range ps.Content {
pathOrRef := rc.UnresolvedSource
if !strings.HasPrefix(pathOrRef, "$kernel:") {
// regular asset from the gadget snap
continue
}
wantedAsset, _, err := splitKernelRef(pathOrRef)
if err != nil {
return nil, false, err
}
if assetName == wantedAsset {
// found a valid kernel asset,
// that is enough
return nil, true, nil
}
}
}
notFoundAssets = append(notFoundAssets, assetName)
}
return notFoundAssets, false, nil
}
// gadgetVolumeKernelUpdateAssetsConsumed ensures that at least one kernel
// assets from the kernel.yaml has a reference in the given
// LaidOutVolume.
func gadgetVolumeKernelUpdateAssetsConsumed(pNew *Volume, kernelInfo *kernel.Info) (bool, error) {
_, consumedAny, err := searchConsumedAssets(pNew, kernelInfo.Assets)
if err != nil {
return false, err
}
return consumedAny, nil
}
|