1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
|
// -*- Mode: Go; indent-tabs-mode: t -*-
/*
* Copyright (C) 2016 Canonical Ltd
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 3 as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
package builtin_test
import (
. "gopkg.in/check.v1"
"github.com/snapcore/snapd/interfaces"
"github.com/snapcore/snapd/interfaces/apparmor"
"github.com/snapcore/snapd/interfaces/builtin"
"github.com/snapcore/snapd/interfaces/seccomp"
apparmor_sandbox "github.com/snapcore/snapd/sandbox/apparmor"
"github.com/snapcore/snapd/snap"
"github.com/snapcore/snapd/snap/snaptest"
"github.com/snapcore/snapd/testutil"
)
type BrowserSupportInterfaceSuite struct {
iface interfaces.Interface
slot *interfaces.ConnectedSlot
slotInfo *snap.SlotInfo
plug *interfaces.ConnectedPlug
plugInfo *snap.PlugInfo
}
const browserMockPlugSnapInfoYaml = `name: other
version: 1.0
apps:
app2:
command: foo
plugs: [browser-support]
`
const browserMockSlotSnapInfoYaml = `name: core
version: 1.0
type: os
slots:
browser-support:
interface: browser-support
`
var _ = Suite(&BrowserSupportInterfaceSuite{
iface: builtin.MustInterface("browser-support"),
})
func (s *BrowserSupportInterfaceSuite) SetUpTest(c *C) {
s.slot, s.slotInfo = MockConnectedSlot(c, browserMockSlotSnapInfoYaml, nil, "browser-support")
s.plug, s.plugInfo = MockConnectedPlug(c, browserMockPlugSnapInfoYaml, nil, "browser-support")
}
func (s *BrowserSupportInterfaceSuite) TestName(c *C) {
c.Assert(s.iface.Name(), Equals, "browser-support")
}
func (s *BrowserSupportInterfaceSuite) TestSanitizeSlot(c *C) {
c.Assert(interfaces.BeforePrepareSlot(s.iface, s.slotInfo), IsNil)
}
func (s *BrowserSupportInterfaceSuite) TestSanitizePlugNoAttrib(c *C) {
c.Assert(interfaces.BeforePreparePlug(s.iface, s.plugInfo), IsNil)
}
func (s *BrowserSupportInterfaceSuite) TestSanitizePlugWithAttrib(c *C) {
const mockSnapYaml = `name: browser-support-plug-snap
version: 1.0
plugs:
browser-support:
allow-sandbox: true
`
info := snaptest.MockInfo(c, mockSnapYaml, nil)
plug := info.Plugs["browser-support"]
c.Assert(interfaces.BeforePreparePlug(s.iface, plug), IsNil)
}
func (s *BrowserSupportInterfaceSuite) TestSanitizePlugWithBadAttrib(c *C) {
const mockSnapYaml = `name: browser-support-plug-snap
version: 1.0
plugs:
browser-support:
allow-sandbox: bad
`
info := snaptest.MockInfo(c, mockSnapYaml, nil)
plug := info.Plugs["browser-support"]
c.Assert(interfaces.BeforePreparePlug(s.iface, plug), ErrorMatches,
"browser-support plug requires bool with 'allow-sandbox'")
}
func (s *BrowserSupportInterfaceSuite) TestConnectedPlugSnippetWithoutAttrib(c *C) {
apparmorSpec := apparmor.NewSpecification(s.plug.AppSet())
err := apparmorSpec.AddConnectedPlug(s.iface, s.plug, s.slot)
c.Assert(err, IsNil)
c.Assert(apparmorSpec.SecurityTags(), DeepEquals, []string{"snap.other.app2"})
snippet := apparmorSpec.SnippetForTag("snap.other.app2")
c.Assert(string(snippet), testutil.Contains, `# Description: Can access various APIs needed by modern browsers`)
c.Assert(string(snippet), Not(testutil.Contains), `capability sys_admin,`)
seccompSpec := seccomp.NewSpecification(s.plug.AppSet())
err = seccompSpec.AddConnectedPlug(s.iface, s.plug, s.slot)
c.Assert(err, IsNil)
c.Assert(seccompSpec.SecurityTags(), DeepEquals, []string{"snap.other.app2"})
secCompSnippet := seccompSpec.SnippetForTag("snap.other.app2")
c.Assert(secCompSnippet, testutil.Contains, `# Description: Can access various APIs needed by modern browsers`)
c.Assert(secCompSnippet, Not(testutil.Contains), `chroot`)
}
func (s *BrowserSupportInterfaceSuite) TestConnectedPlugSnippetWithAttribFalse(c *C) {
const mockSnapYaml = `name: browser-support-plug-snap
version: 1.0
plugs:
browser-support:
allow-sandbox: false
apps:
app2:
command: foo
plugs: [browser-support]
`
plug, _ := MockConnectedPlug(c, mockSnapYaml, nil, "browser-support")
apparmorSpec := apparmor.NewSpecification(plug.AppSet())
err := apparmorSpec.AddConnectedPlug(s.iface, plug, s.slot)
c.Assert(err, IsNil)
c.Assert(apparmorSpec.SecurityTags(), DeepEquals, []string{"snap.browser-support-plug-snap.app2"})
snippet := apparmorSpec.SnippetForTag("snap.browser-support-plug-snap.app2")
c.Assert(snippet, testutil.Contains, `# Description: Can access various APIs needed by modern browsers`)
c.Assert(snippet, Not(testutil.Contains), `capability sys_admin,`)
c.Assert(snippet, Not(testutil.Contains), `userns,`)
seccompSpec := seccomp.NewSpecification(plug.AppSet())
err = seccompSpec.AddConnectedPlug(s.iface, plug, s.slot)
c.Assert(err, IsNil)
c.Assert(seccompSpec.SecurityTags(), DeepEquals, []string{"snap.browser-support-plug-snap.app2"})
secCompSnippet := seccompSpec.SnippetForTag("snap.browser-support-plug-snap.app2")
c.Assert(secCompSnippet, testutil.Contains, `# Description: Can access various APIs needed by modern browsers`)
c.Assert(secCompSnippet, Not(testutil.Contains), `chroot`)
}
func (s *BrowserSupportInterfaceSuite) TestConnectedPlugSnippetWithAttribTrue(c *C) {
const mockSnapYaml = `name: browser-support-plug-snap
version: 1.0
plugs:
browser-support:
allow-sandbox: true
apps:
app2:
command: foo
plugs: [browser-support]
`
plug, _ := MockConnectedPlug(c, mockSnapYaml, nil, "browser-support")
restore := apparmor_sandbox.MockFeatures(nil, nil, nil, nil)
defer restore()
apparmorSpec := apparmor.NewSpecification(plug.AppSet())
err := apparmorSpec.AddConnectedPlug(s.iface, plug, s.slot)
c.Assert(err, IsNil)
c.Assert(apparmorSpec.SecurityTags(), DeepEquals, []string{"snap.browser-support-plug-snap.app2"})
snippet := apparmorSpec.SnippetForTag("snap.browser-support-plug-snap.app2")
c.Assert(snippet, testutil.Contains, `# Description: Can access various APIs needed by modern browsers`)
c.Assert(snippet, testutil.Contains, `ptrace (trace) peer=snap.@{SNAP_INSTANCE_NAME}.**`)
// we haven't mocked the userns apparmor feature
c.Assert(snippet, Not(testutil.Contains), `userns,`)
seccompSpec := seccomp.NewSpecification(plug.AppSet())
err = seccompSpec.AddConnectedPlug(s.iface, plug, s.slot)
c.Assert(err, IsNil)
c.Assert(seccompSpec.SecurityTags(), DeepEquals, []string{"snap.browser-support-plug-snap.app2"})
secCompSnippet := seccompSpec.SnippetForTag("snap.browser-support-plug-snap.app2")
c.Assert(secCompSnippet, testutil.Contains, `# Description: Can access various APIs needed by modern browsers`)
c.Assert(secCompSnippet, testutil.Contains, `chroot`)
}
func (s *BrowserSupportInterfaceSuite) TestConnectedPlugSnippetWithUserNS(c *C) {
const mockSnapYaml = `name: browser-support-plug-snap
version: 1.0
plugs:
browser-support:
allow-sandbox: true
apps:
app2:
command: foo
plugs: [browser-support]
`
plug, _ := MockConnectedPlug(c, mockSnapYaml, nil, "browser-support")
restore := apparmor_sandbox.MockFeatures(nil, nil, []string{"userns"}, nil)
defer restore()
apparmorSpec := apparmor.NewSpecification(plug.AppSet())
err := apparmorSpec.AddConnectedPlug(s.iface, plug, s.slot)
c.Assert(err, IsNil)
c.Assert(apparmorSpec.SecurityTags(), DeepEquals, []string{"snap.browser-support-plug-snap.app2"})
snippet := apparmorSpec.SnippetForTag("snap.browser-support-plug-snap.app2")
c.Assert(snippet, testutil.Contains, `# Description: Can access various APIs needed by modern browsers`)
c.Assert(snippet, testutil.Contains, `ptrace (trace) peer=snap.@{SNAP_INSTANCE_NAME}.**`)
c.Assert(snippet, testutil.Contains, `userns,`)
}
func (s *BrowserSupportInterfaceSuite) TestUsedSecuritySystems(c *C) {
// connected plugs have a non-nil security snippet for apparmor
apparmorSpec := apparmor.NewSpecification(s.plug.AppSet())
err := apparmorSpec.AddConnectedPlug(s.iface, s.plug, s.slot)
c.Assert(err, IsNil)
c.Assert(apparmorSpec.SecurityTags(), HasLen, 1)
// connected plugs have a non-nil security snippet for apparmor
seccompSpec := seccomp.NewSpecification(s.plug.AppSet())
err = seccompSpec.AddConnectedPlug(s.iface, s.plug, s.slot)
c.Assert(err, IsNil)
c.Assert(seccompSpec.Snippets(), HasLen, 1)
}
func (s *BrowserSupportInterfaceSuite) TestInterfaces(c *C) {
c.Check(builtin.Interfaces(), testutil.DeepContains, s.iface)
}
|
