1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
|
// -*- Mode: Go; indent-tabs-mode: t -*-
/*
* Copyright (C) 2020 Canonical Ltd
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 3 as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
package builtin_test
import (
"os"
"path/filepath"
. "gopkg.in/check.v1"
"github.com/snapcore/snapd/dirs"
"github.com/snapcore/snapd/interfaces"
"github.com/snapcore/snapd/interfaces/apparmor"
"github.com/snapcore/snapd/interfaces/builtin"
"github.com/snapcore/snapd/release"
"github.com/snapcore/snapd/snap"
"github.com/snapcore/snapd/testutil"
)
type cupsControlSuite struct {
iface interfaces.Interface
coreSlotInfo *snap.SlotInfo
coreSlot *interfaces.ConnectedSlot
plugInfo *snap.PlugInfo
plug *interfaces.ConnectedPlug
providerSlotInfo *snap.SlotInfo
providerSlot *interfaces.ConnectedSlot
}
var _ = Suite(&cupsControlSuite{iface: builtin.MustInterface("cups-control")})
const cupsControlConsumerYaml = `name: consumer
version: 0
apps:
app:
plugs: [cups-control]
`
const cupsControlCoreYaml = `name: core
version: 0
type: os
slots:
cups-control:
`
const cupsControlProviderYaml = `name: provider
version: 0
apps:
app:
slots: [cups-control]
`
func (s *cupsControlSuite) SetUpTest(c *C) {
s.plug, s.plugInfo = MockConnectedPlug(c, cupsControlConsumerYaml, nil, "cups-control")
s.coreSlot, s.coreSlotInfo = MockConnectedSlot(c, cupsControlCoreYaml, nil, "cups-control")
s.providerSlot, s.providerSlotInfo = MockConnectedSlot(c, cupsControlProviderYaml, nil, "cups-control")
}
func (s *cupsControlSuite) TestName(c *C) {
c.Assert(s.iface.Name(), Equals, "cups-control")
}
func (s *cupsControlSuite) TestSanitizeSlot(c *C) {
c.Assert(interfaces.BeforePrepareSlot(s.iface, s.coreSlotInfo), IsNil)
}
func (s *cupsControlSuite) TestSanitizePlug(c *C) {
c.Assert(interfaces.BeforePreparePlug(s.iface, s.plugInfo), IsNil)
}
func (s *cupsControlSuite) TestAppArmorSpecCore(c *C) {
restore := release.MockOnClassic(false)
defer restore()
// core to consumer on core is empty for ConnectedPlug
appSet, err := interfaces.NewSnapAppSet(s.plug.Snap(), nil)
c.Assert(err, IsNil)
spec := apparmor.NewSpecification(appSet)
c.Assert(spec.AddConnectedPlug(s.iface, s.plug, s.coreSlot), IsNil)
c.Assert(spec.SecurityTags(), HasLen, 0)
// core to consumer on core is empty for PermanentSlot
appSet, err = interfaces.NewSnapAppSet(s.coreSlotInfo.Snap, nil)
c.Assert(err, IsNil)
spec = apparmor.NewSpecification(appSet)
c.Assert(spec.AddPermanentSlot(s.iface, s.coreSlotInfo), IsNil)
c.Assert(spec.SecurityTags(), HasLen, 0)
// core to consumer on core is empty for ConnectedSlot
appSet, err = interfaces.NewSnapAppSet(s.coreSlot.Snap(), nil)
c.Assert(err, IsNil)
spec = apparmor.NewSpecification(appSet)
c.Assert(spec.AddConnectedSlot(s.iface, s.plug, s.coreSlot), IsNil)
c.Assert(spec.SecurityTags(), HasLen, 0)
// consumer to provider on core for ConnectedPlug
appSet, err = interfaces.NewSnapAppSet(s.plug.Snap(), nil)
c.Assert(err, IsNil)
spec = apparmor.NewSpecification(appSet)
c.Assert(spec.AddConnectedPlug(s.iface, s.plug, s.providerSlot), IsNil)
c.Assert(spec.SecurityTags(), DeepEquals, []string{"snap.consumer.app"})
c.Assert(spec.SnippetForTag("snap.consumer.app"), testutil.Contains, "# Allow communicating with the cups server for printing and configuration.")
c.Assert(spec.SnippetForTag("snap.consumer.app"), testutil.Contains, "#include <abstractions/cups-client>")
c.Assert(spec.SnippetForTag("snap.consumer.app"), testutil.Contains, "peer=(label=\"snap.provider.app\"")
c.Assert(spec.SnippetForTag("snap.provider.app"), Not(testutil.Contains), "# Allow daemon access to create the CUPS socket")
// provider to consumer on core for PermanentSlot
appSet, err = interfaces.NewSnapAppSet(s.providerSlotInfo.Snap, nil)
c.Assert(err, IsNil)
spec = apparmor.NewSpecification(appSet)
c.Assert(spec.AddPermanentSlot(s.iface, s.providerSlotInfo), IsNil)
c.Assert(spec.SecurityTags(), DeepEquals, []string{"snap.provider.app"})
c.Assert(spec.SnippetForTag("snap.provider.app"), testutil.Contains, "# Allow daemon access to create the CUPS socket")
c.Assert(spec.SnippetForTag("snap.provider.app"), Not(testutil.Contains), "label=\"snap.consumer.app\"")
// provider to consumer on core for ConnectedSlot
appSet, err = interfaces.NewSnapAppSet(s.providerSlot.Snap(), nil)
c.Assert(err, IsNil)
spec = apparmor.NewSpecification(appSet)
c.Assert(spec.AddConnectedSlot(s.iface, s.plug, s.providerSlot), IsNil)
c.Assert(spec.SecurityTags(), DeepEquals, []string{"snap.provider.app"})
c.Assert(spec.SnippetForTag("snap.provider.app"), testutil.Contains, "peer=(label=\"snap.consumer.app\"")
}
func (s *cupsControlSuite) TestAppArmorSpecClassic(c *C) {
restore := release.MockOnClassic(true)
defer restore()
// consumer to core on classic for ConnectedPlug
appSet, err := interfaces.NewSnapAppSet(s.plug.Snap(), nil)
c.Assert(err, IsNil)
spec := apparmor.NewSpecification(appSet)
c.Assert(spec.AddConnectedPlug(s.iface, s.plug, s.coreSlot), IsNil)
c.Assert(spec.SecurityTags(), DeepEquals, []string{"snap.consumer.app"})
c.Assert(spec.SnippetForTag("snap.consumer.app"), testutil.Contains, "# Allow communicating with the cups server for printing and configuration.")
c.Assert(spec.SnippetForTag("snap.consumer.app"), testutil.Contains, "#include <abstractions/cups-client>")
c.Assert(spec.SnippetForTag("snap.consumer.app"), testutil.Contains, "peer=(label=\"{unconfined,/usr/sbin/cupsd,cupsd}\"")
c.Assert(spec.SnippetForTag("snap.provider.app"), Not(testutil.Contains), "# Allow daemon access to create the CUPS socket")
// core to consumer on classic is empty for PermanentSlot
appSet, err = interfaces.NewSnapAppSet(s.coreSlotInfo.Snap, nil)
c.Assert(err, IsNil)
spec = apparmor.NewSpecification(appSet)
c.Assert(spec.AddPermanentSlot(s.iface, s.coreSlotInfo), IsNil)
c.Assert(spec.SecurityTags(), HasLen, 0)
// core to consumer on classic is empty for ConnectedSlot
appSet, err = interfaces.NewSnapAppSet(s.coreSlot.Snap(), nil)
c.Assert(err, IsNil)
spec = apparmor.NewSpecification(appSet)
c.Assert(spec.AddConnectedSlot(s.iface, s.plug, s.coreSlot), IsNil)
c.Assert(spec.SecurityTags(), HasLen, 0)
// consumer to provider on classic for ConnectedPlug
appSet, err = interfaces.NewSnapAppSet(s.plug.Snap(), nil)
c.Assert(err, IsNil)
spec = apparmor.NewSpecification(appSet)
c.Assert(spec.AddConnectedPlug(s.iface, s.plug, s.providerSlot), IsNil)
c.Assert(spec.SecurityTags(), DeepEquals, []string{"snap.consumer.app"})
c.Assert(spec.SnippetForTag("snap.consumer.app"), testutil.Contains, "# Allow communicating with the cups server for printing and configuration.")
c.Assert(spec.SnippetForTag("snap.consumer.app"), testutil.Contains, "#include <abstractions/cups-client>")
c.Assert(spec.SnippetForTag("snap.consumer.app"), testutil.Contains, "peer=(label=\"snap.provider.app\"")
c.Assert(spec.SnippetForTag("snap.provider.app"), Not(testutil.Contains), "# Allow daemon access to create the CUPS socket")
// provider to consumer on classic for PermanentSlot
appSet, err = interfaces.NewSnapAppSet(s.providerSlotInfo.Snap, nil)
c.Assert(err, IsNil)
spec = apparmor.NewSpecification(appSet)
c.Assert(spec.AddPermanentSlot(s.iface, s.providerSlotInfo), IsNil)
c.Assert(spec.SecurityTags(), DeepEquals, []string{"snap.provider.app"})
c.Assert(spec.SnippetForTag("snap.provider.app"), testutil.Contains, "# Allow daemon access to create the CUPS socket")
c.Assert(spec.SnippetForTag("snap.provider.app"), Not(testutil.Contains), "label=\"snap.consumer.app\"")
// provider to consumer on classic for ConnectedSlot
appSet, err = interfaces.NewSnapAppSet(s.providerSlot.Snap(), nil)
c.Assert(err, IsNil)
spec = apparmor.NewSpecification(appSet)
c.Assert(spec.AddConnectedSlot(s.iface, s.plug, s.providerSlot), IsNil)
c.Assert(spec.SecurityTags(), DeepEquals, []string{"snap.provider.app"})
c.Assert(spec.SnippetForTag("snap.provider.app"), testutil.Contains, "peer=(label=\"snap.consumer.app\"")
}
func (s *cupsControlSuite) TestAutoConnect(c *C) {
tmpdir := c.MkDir()
dirs.SetRootDir(tmpdir)
defer dirs.SetRootDir("/")
c.Assert(os.MkdirAll(filepath.Join(tmpdir, "/etc/cups"), 0o777), IsNil)
// No cupsd.conf: allow auto-connect to the app slot
c.Check(s.iface.AutoConnect(s.plugInfo, s.coreSlotInfo), Equals, false)
c.Check(s.iface.AutoConnect(s.plugInfo, s.providerSlotInfo), Equals, true)
// cupsd.conf exists: allow auto-connect to the system slot
c.Assert(os.WriteFile(filepath.Join(tmpdir, "/etc/cups/cupsd.conf"), nil, 0o666), IsNil)
c.Check(s.iface.AutoConnect(s.plugInfo, s.coreSlotInfo), Equals, true)
c.Check(s.iface.AutoConnect(s.plugInfo, s.providerSlotInfo), Equals, false)
}
func (s *cupsControlSuite) TestStaticInfo(c *C) {
si := interfaces.StaticInfoOf(s.iface)
c.Assert(si.ImplicitOnCore, Equals, false)
c.Assert(si.ImplicitOnClassic, Equals, true)
c.Assert(si.Summary, Equals, `allows access to the CUPS control socket`)
c.Assert(si.BaseDeclarationSlots, testutil.Contains, "cups-control")
c.Assert(si.BaseDeclarationSlots, testutil.Contains, "deny-auto-connection: true")
}
func (s *cupsControlSuite) TestInterfaces(c *C) {
c.Check(builtin.Interfaces(), testutil.DeepContains, s.iface)
}
|
