1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522
|
// -*- Mode: Go; indent-tabs-mode: t -*-
/*
* Copyright (C) 2022-2024 Canonical Ltd
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 3 as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
package builtin
import (
"bytes"
"errors"
"fmt"
"path/filepath"
"regexp"
"strings"
"github.com/snapcore/snapd/interfaces"
"github.com/snapcore/snapd/interfaces/apparmor"
"github.com/snapcore/snapd/interfaces/udev"
"github.com/snapcore/snapd/interfaces/utils"
"github.com/snapcore/snapd/logger"
"github.com/snapcore/snapd/snap"
"github.com/snapcore/snapd/strutil"
)
const customDeviceSummary = `provides access to custom devices specified via the gadget snap`
const customDeviceBaseDeclarationSlots = `
custom-device:
allow-installation: false
allow-connection:
plug-attributes:
custom-device: $SLOT(custom-device)
deny-auto-connection: true
`
var (
// A cryptic, uninformative error message that we use only on impossible code paths
customDeviceInternalError = errors.New(`custom-device interface internal error`)
// Validating regexp for filesystem paths. @ can appear in paths under
// /sys/devices for devices that are defined in the device tree (of the
// form device@address), so we need to support @ characters in paths.
// However, @{foo} is the format for variables in AppArmor, so we must
// disallow `@{`. For completeness, we allow paths with a trailing @ as
// well. This is not the case for common-files-derived interfaces, since
// these append {,/,/**} pattern to the end of filepath.
customDevicePathRegexp = regexp.MustCompile(`^/([^"@]|@[^{])*@?$`)
// Validating regexp for udev device names.
// We forbid:
// - `|`: it's valid for udev, but more work for us
// - `{}`: have a special meaning for AppArmor
// - `"`: it's just dangerous (both for udev and AppArmor)
// - `\`: also dangerous
customDeviceUDevDeviceRegexp = regexp.MustCompile(`^/dev/[^"|{}\\]+$`)
// Validating regexp for udev tag values (all but kernel devices)
customDeviceUDevValueRegexp = regexp.MustCompile(`^[^"{}\\]+$`)
)
// customDeviceInterface allows sharing customDevice between snaps
type customDeviceInterface struct{}
func (iface *customDeviceInterface) validateFilePath(path string, attrName string) error {
if !customDevicePathRegexp.MatchString(path) {
return fmt.Errorf(`custom-device %q path must start with / and cannot contain special characters: %q`, attrName, path)
}
if !cleanSubPath(path) {
return fmt.Errorf(`custom-device %q path is not clean: %q`, attrName, path)
}
const allowCommas = true
if _, err := utils.NewPathPattern(path, allowCommas); err != nil {
return fmt.Errorf(`custom-device %q path cannot be used: %v`, attrName, err)
}
// We don't allow "**" because that's an AppArmor specific globbing pattern
// which we don't want to expose in our API contract.
if strings.Contains(path, "**") {
return fmt.Errorf(`custom-device %q path contains invalid glob pattern "**"`, attrName)
}
return nil
}
func (iface *customDeviceInterface) validateDevice(path string, attrName string) error {
// The device must satisfy udev's device name rules and generic path rules
if !customDeviceUDevDeviceRegexp.MatchString(path) {
return fmt.Errorf(`custom-device %q path must start with /dev/ and cannot contain special characters: %q`, attrName, path)
}
if err := iface.validateFilePath(path, attrName); err != nil {
return err
}
return nil
}
func (iface *customDeviceInterface) validatePaths(attrName string, paths []string) error {
for _, path := range paths {
if err := iface.validateFilePath(path, attrName); err != nil {
return err
}
}
return nil
}
func (iface *customDeviceInterface) validateUDevValue(value any) error {
stringValue, ok := value.(string)
if !ok {
return fmt.Errorf(`value "%v" is not a string`, value)
}
if !customDeviceUDevValueRegexp.MatchString(stringValue) {
return fmt.Errorf(`value "%v" contains invalid characters`, stringValue)
}
return nil
}
func (iface *customDeviceInterface) validateUDevValueMap(value any) error {
valueMap, ok := value.(map[string]any)
if !ok {
return fmt.Errorf(`value "%v" is not a map`, value)
}
for key, val := range valueMap {
if !customDeviceUDevValueRegexp.MatchString(key) {
return fmt.Errorf(`key "%v" contains invalid characters`, key)
}
if err := iface.validateUDevValue(val); err != nil {
return err
}
}
return nil
}
func (iface *customDeviceInterface) validateKernelMatchesOneDeviceBasename(kernelVal string, devices []string) error {
matches := make([]string, 0)
for _, devicePath := range devices {
if kernelVal != filepath.Base(devicePath) {
continue
}
matches = append(matches, devicePath)
}
switch len(matches) {
case 0:
return fmt.Errorf(`%q does not match any specified device`, kernelVal)
case 1:
return nil
default:
return fmt.Errorf(`%q matches more than one specified device: %q`, kernelVal, matches)
}
}
func (iface *customDeviceInterface) validateUDevTaggingRule(rule map[string]any, devices []string) error {
hasKernelTag := false
kernelVal := ""
deviceOverrideVal := ""
for key, value := range rule {
var err error
switch key {
case "subsystem":
err = iface.validateUDevValue(value)
case "kernel":
hasKernelTag = true
err = iface.validateUDevValue(value)
if err != nil {
break
}
kernelVal = value.(string)
case "attributes", "environment":
err = iface.validateUDevValueMap(value)
case "for-device":
// override of implicit device match
deviceOverrideVal = value.(string)
if !strutil.ListContains(devices, deviceOverrideVal) {
err = fmt.Errorf("cannot find matching device %q", deviceOverrideVal)
}
default:
err = errors.New(`unknown tag`)
}
if err != nil {
return fmt.Errorf(`custom-device "udev-tagging" invalid %q tag: %v`, key, err)
}
}
if !hasKernelTag {
return errors.New(`custom-device udev tagging rule missing mandatory "kernel" key`)
}
if deviceOverrideVal == "" {
// The udev-tagging snippet does not name an explicit device
// pattern it describes, so apply the implicit rules.
// The kernel device name must match the full path of
// one of the given devices, stripped of the leading
// /dev/, or it must be the basename of a device path.
if strutil.ListContains(devices, "/dev/"+kernelVal) {
return nil
}
// Not a full path, so check if it matches the basename
// of a device path, and not more than one.
if err := iface.validateKernelMatchesOneDeviceBasename(kernelVal, devices); err != nil {
return fmt.Errorf(`custom-device "udev-tagging" invalid "kernel" tag: %v`, err)
}
}
return nil
}
func (iface *customDeviceInterface) Name() string {
return "custom-device"
}
func (iface *customDeviceInterface) StaticInfo() interfaces.StaticInfo {
return interfaces.StaticInfo{
Summary: customDeviceSummary,
BaseDeclarationSlots: customDeviceBaseDeclarationSlots,
}
}
func (iface *customDeviceInterface) BeforePrepareSlot(slot *snap.SlotInfo) error {
if slot.Attrs == nil {
slot.Attrs = make(map[string]any)
}
customDeviceAttr, isSet := slot.Attrs["custom-device"]
customDevice, ok := customDeviceAttr.(string)
if isSet && !ok {
return fmt.Errorf(`custom-device "custom-device" attribute must be a string, not %v`,
customDeviceAttr)
}
if customDevice == "" {
// custom-device defaults to "slot" name if unspecified
slot.Attrs["custom-device"] = slot.Name
}
var devices []string
err := slot.Attr("devices", &devices)
if err != nil && !errors.Is(err, snap.AttributeNotFoundError{}) {
return err
}
for _, device := range devices {
if err := iface.validateDevice(device, "devices"); err != nil {
return err
}
}
var readDevices []string
err = slot.Attr("read-devices", &readDevices)
if err != nil && !errors.Is(err, snap.AttributeNotFoundError{}) {
return err
}
for _, device := range readDevices {
if err := iface.validateDevice(device, "read-devices"); err != nil {
return err
}
if strutil.ListContains(devices, device) {
return fmt.Errorf(`cannot specify path %q both in "devices" and "read-devices" attributes`, device)
}
}
allDevices := devices
allDevices = append(allDevices, readDevices...)
// validate files
var filesMap map[string][]string
err = slot.Attr("files", &filesMap)
if err != nil && !errors.Is(err, snap.AttributeNotFoundError{}) {
return err
}
for key, val := range filesMap {
switch key {
case "read":
if err := iface.validatePaths("read", val); err != nil {
return err
}
case "write":
if err := iface.validatePaths("write", val); err != nil {
return err
}
default:
return fmt.Errorf(`cannot specify %q in "files" section, only "read" and "write" allowed`, key)
}
}
if len(allDevices) == 0 && len(filesMap) == 0 {
return fmt.Errorf("cannot use custom-device slot without any files or devices")
}
var udevTaggingRules []map[string]any
err = slot.Attr("udev-tagging", &udevTaggingRules)
if err != nil && !errors.Is(err, snap.AttributeNotFoundError{}) {
return err
}
for _, udevTaggingRule := range udevTaggingRules {
if err := iface.validateUDevTaggingRule(udevTaggingRule, allDevices); err != nil {
return err
}
}
return nil
}
func (iface *customDeviceInterface) BeforePreparePlug(plug *snap.PlugInfo) error {
customDeviceAttr, isSet := plug.Attrs["custom-device"]
customDevice, ok := customDeviceAttr.(string)
if isSet && !ok {
return fmt.Errorf(`custom-device "custom-device" attribute must be a string, not %v`,
plug.Attrs["custom-device"])
}
if customDevice == "" {
if plug.Attrs == nil {
plug.Attrs = make(map[string]any)
}
// custom-device defaults to "plug" name if unspecified
plug.Attrs["custom-device"] = plug.Name
}
return nil
}
func (iface *customDeviceInterface) AppArmorConnectedPlug(spec *apparmor.Specification, plug *interfaces.ConnectedPlug, slot *interfaces.ConnectedSlot) error {
snippet := &bytes.Buffer{}
emitRule := func(paths []string, permissions string) {
for _, path := range paths {
fmt.Fprintf(snippet, "\"%s\" %s,\n", path, permissions)
}
}
// get all attributes without validation, since that was done before;
// should an error occur, we'll simply not write any rule.
var devicePaths []string
_ = slot.Attr("devices", &devicePaths)
emitRule(devicePaths, "rwk")
var readDevicePaths []string
_ = slot.Attr("read-devices", &readDevicePaths)
emitRule(readDevicePaths, "r")
var filesMap map[string][]string
err := slot.Attr("files", &filesMap)
if err != nil && !errors.Is(err, snap.AttributeNotFoundError{}) {
return err
}
for key, val := range filesMap {
perm := ""
switch key {
case "read":
perm = "r"
case "write":
perm = "rw"
default:
return fmt.Errorf(`cannot specify %q in "files" section, only "read" and "write" allowed`, key)
}
emitRule(val, perm)
}
spec.AddSnippet(snippet.String())
return nil
}
// extractStringMapAttribute looks up the given key in the container, and
// returns its value as a map[string]string.
// No validation is performed, since it already occurred before connecting the
// interface.
func (iface *customDeviceInterface) extractStringMapAttribute(container map[string]any, key string) map[string]string {
valueMap, ok := container[key].(map[string]any)
if !ok {
return nil
}
stringMap := make(map[string]string, len(valueMap))
for key, value := range valueMap {
stringMap[key] = value.(string)
}
return stringMap
}
func (iface *customDeviceInterface) UDevConnectedPlug(spec *udev.Specification, plug *interfaces.ConnectedPlug, slot *interfaces.ConnectedSlot) error {
// Collect all the device paths specified in either the "devices" or
// "read-devices" attributes.
var devicePaths []string
_ = slot.Attr("devices", &devicePaths)
var readDevicePaths []string
_ = slot.Attr("read-devices", &readDevicePaths)
allDevicePaths := devicePaths
allDevicePaths = append(allDevicePaths, readDevicePaths...)
// Create a map in which will store udev rules indexed by device name
deviceRules := make(map[string]string, len(allDevicePaths))
const placeholderRule string = "<placeholder>"
// Generate a placeholder udev rule for each device; we put them into a
// map indexed by the device name, so that we can overwrite the entry
// later with a specified rule, or create default rules if no
// "udev-tagging" rules are explicitly given.
for _, devicePath := range allDevicePaths {
if strings.HasPrefix(devicePath, "/dev/") {
deviceName := devicePath[len("/dev/"):]
deviceRules[deviceName] = placeholderRule
}
}
// Generate udev rules from the "udev-tagging" attribute; note that these
// rules might override the simpler KERNEL=="<device>" rules we computed
// above -- that's fine.
var udevTaggingRules []map[string]any
_ = slot.Attr("udev-tagging", &udevTaggingRules)
for _, udevTaggingRule := range udevTaggingRules {
rule := &bytes.Buffer{}
deviceName, ok := udevTaggingRule["kernel"].(string)
if !ok {
return customDeviceInternalError
}
deviceKey := deviceName
if overrideDeviceName, ok := udevTaggingRule["for-device"].(string); ok && overrideDeviceName != "" {
// an override of the implicit kernel device match rule
if strings.HasPrefix(overrideDeviceName, "/dev/") {
overrideDeviceName = overrideDeviceName[len("/dev/"):]
}
deviceKey = overrideDeviceName
}
fmt.Fprintf(rule, `KERNEL=="%s"`, deviceName)
if subsystem, ok := udevTaggingRule["subsystem"].(string); ok {
fmt.Fprintf(rule, `, SUBSYSTEM=="%s"`, subsystem)
}
environment := iface.extractStringMapAttribute(udevTaggingRule, "environment")
for variable, value := range environment {
fmt.Fprintf(rule, `, ENV{%s}=="%s"`, variable, value)
}
attributes := iface.extractStringMapAttribute(udevTaggingRule, "attributes")
for variable, value := range attributes {
fmt.Fprintf(rule, `, ATTR{%s}=="%s"`, variable, value)
}
deviceRules[deviceKey] = rule.String()
}
// Now write all the rules
for deviceName, rule := range deviceRules {
if rule != placeholderRule {
// we have a specific rule based on udev-tagging
spec.TagDevice(rule)
continue
}
baseName := filepath.Base(deviceName)
defaultRule := fmt.Sprintf(`KERNEL=="%s"`, deviceName)
defaultBaseNameRule := fmt.Sprintf(`KERNEL=="%s"`, baseName)
if baseName == deviceName {
spec.TagDevice(defaultRule)
continue
}
baseNameRule, exists := deviceRules[baseName]
if !exists {
// There is no rule for the basename, so emit a default
// rule for both the full path and basename.
spec.TagDevice(defaultRule)
spec.TagDevice(defaultBaseNameRule)
continue
}
if baseNameRule != placeholderRule && !strutil.ListContains(allDevicePaths, "/dev/"+baseName) {
// There is a user-defined rule for the basename of the
// device path, and there is not a device whose path
// is /dev/<basename>, so that rule should apply to
// the device given by this full path. Thus, do not
// emit a default rule for this device name.
// validateUDevTaggingRule() already checked that the
// basename rule only applies to only one device.
logger.Noticef(`custom-device: applying "udev-tagging" rule with kernel "%s" to device "/dev/%s", since no device with path "/dev/%s"`, baseName, deviceName, baseName)
continue
}
spec.TagDevice(defaultRule)
}
return nil
}
func (iface *customDeviceInterface) AutoConnect(plug *snap.PlugInfo, slot *snap.SlotInfo) bool {
// allow what declarations allowed
return true
}
func init() {
registerIface(&customDeviceInterface{})
}
|