1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
|
// -*- Mode: Go; indent-tabs-mode: t -*-
/*
* Copyright (C) 2018 Canonical Ltd
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 3 as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
package builtin_test
import (
"strings"
. "gopkg.in/check.v1"
"github.com/snapcore/snapd/interfaces"
"github.com/snapcore/snapd/interfaces/apparmor"
"github.com/snapcore/snapd/interfaces/builtin"
"github.com/snapcore/snapd/snap"
"github.com/snapcore/snapd/snap/snaptest"
"github.com/snapcore/snapd/testutil"
)
type systemFilesInterfaceSuite struct {
iface interfaces.Interface
slot *interfaces.ConnectedSlot
slotInfo *snap.SlotInfo
plug *interfaces.ConnectedPlug
plugInfo *snap.PlugInfo
}
var _ = Suite(&systemFilesInterfaceSuite{
iface: builtin.MustInterface("system-files"),
})
func (s *systemFilesInterfaceSuite) SetUpTest(c *C) {
const mockPlugSnapInfoYaml = `name: other
version: 1.0
plugs:
system-files:
read: [/etc/read-dir2, /etc/read-file2]
write: [/etc/write-dir2, /etc/write-file2, /dev/foo@bar]
apps:
app:
command: foo
plugs: [system-files]
`
const mockSlotSnapInfoYaml = `name: core
version: 1.0
type: os
slots:
system-files:
interface: system-files
`
s.slot, s.slotInfo = MockConnectedSlot(c, mockSlotSnapInfoYaml, nil, "system-files")
s.plug, s.plugInfo = MockConnectedPlug(c, mockPlugSnapInfoYaml, nil, "system-files")
}
func (s *systemFilesInterfaceSuite) TestName(c *C) {
c.Assert(s.iface.Name(), Equals, "system-files")
}
func (s *systemFilesInterfaceSuite) TestConnectedPlugAppArmor(c *C) {
apparmorSpec := apparmor.NewSpecification(s.plug.AppSet())
err := apparmorSpec.AddConnectedPlug(s.iface, s.plug, s.slot)
c.Assert(err, IsNil)
c.Assert(apparmorSpec.SecurityTags(), DeepEquals, []string{"snap.other.app"})
c.Check(apparmorSpec.SnippetForTag("snap.other.app"), Equals, `
# Description: Can access specific system files or directories.
# This is restricted because it gives file access to arbitrary locations.
"/etc/read-dir2{,/,/**}" rk,
"/etc/read-file2{,/,/**}" rk,
"/etc/write-dir2{,/,/**}" rwkl,
"/etc/write-file2{,/,/**}" rwkl,
"/dev/foo@bar{,/,/**}" rwkl,
`)
}
func (s *systemFilesInterfaceSuite) TestSanitizeSlot(c *C) {
c.Assert(interfaces.BeforePrepareSlot(s.iface, s.slotInfo), IsNil)
}
func (s *systemFilesInterfaceSuite) TestSanitizePlug(c *C) {
c.Assert(interfaces.BeforePreparePlug(s.iface, s.plugInfo), IsNil)
}
func (s *systemFilesInterfaceSuite) TestSanitizePlugHappy(c *C) {
const mockSnapYaml = `name: system-files-plug-snap
version: 1.0
plugs:
system-files:
read: ["/etc/file1"]
write: ["/etc/dir1"]
`
info := snaptest.MockInfo(c, mockSnapYaml, nil)
plug := info.Plugs["system-files"]
c.Assert(interfaces.BeforePreparePlug(s.iface, plug), IsNil)
}
func (s *systemFilesInterfaceSuite) TestSanitizePlugUnhappy(c *C) {
const mockSnapYaml = `name: system-files-plug-snap
version: 1.0
plugs:
system-files:
$t
`
errPrefix := `cannot add system-files plug: `
var testCases = []struct {
inp string
errStr string
}{
{`read: ""`, `"read" must be a list of strings`},
{`read: [ 123 ]`, `"read" must be a list of strings`},
{`read: [ "/foo/./bar" ]`, `cannot use "/foo/./bar": try "/foo/bar"`},
{`read: [ "../foo" ]`, `"../foo" must start with "/"`},
{`read: [ "/foo[" ]`, `"/foo\[" contains a reserved apparmor char from .*`},
{`write: ""`, `"write" must be a list of strings`},
{`write: bar`, `"write" must be a list of strings`},
{`read: [ "~/foo" ]`, `"~/foo" cannot contain "~"`},
{`read: [ "/foo/~/foo" ]`, `"/foo/~/foo" cannot contain "~"`},
{`read: [ "/foo/../foo" ]`, `cannot use "/foo/../foo": try "/foo"`},
{`read: [ "/home/$HOME/foo" ]`, `\$HOME cannot be used in "/home/\$HOME/foo"`},
{`read: [ "$HOME/sweet/$HOME" ]`, `"\$HOME/sweet/\$HOME" must start with "/"`},
{`read: [ "/@{FOO}" ]`, `"/@{FOO}" contains a reserved apparmor char from .*`},
{`read: [ "/home/@{HOME}/foo" ]`, `"/home/@{HOME}/foo" contains a reserved apparmor char from .*`},
{`read: [ "/foo/bar@" ]`, `"/foo/bar@" cannot end with "@"`},
}
for _, t := range testCases {
yml := strings.Replace(mockSnapYaml, "$t", t.inp, -1)
info := snaptest.MockInfo(c, yml, nil)
plug := info.Plugs["system-files"]
c.Check(interfaces.BeforePreparePlug(s.iface, plug), ErrorMatches, errPrefix+t.errStr, Commentf("unexpected error for %q", t.inp))
}
}
func (s *systemFilesInterfaceSuite) TestConnectedPlugAppArmorInternalError(c *C) {
const mockPlugSnapInfoYaml = `name: other
version: 1.0
plugs:
system-files:
read: [ 123 , 345 ]
apps:
app:
command: foo
plugs: [system-files]
`
const mockSlotSnapInfoYaml = `name: core
version: 1.0
type: os
slots:
system-files:
interface: system-files
`
slot, _ := MockConnectedSlot(c, mockSlotSnapInfoYaml, nil, "system-files")
plug, _ := MockConnectedPlug(c, mockPlugSnapInfoYaml, nil, "system-files")
apparmorSpec := apparmor.NewSpecification(plug.AppSet())
err := apparmorSpec.AddConnectedPlug(s.iface, plug, slot)
c.Assert(err, ErrorMatches, `cannot connect plug system-files: 123 \(int64\) is not a string`)
}
func (s *systemFilesInterfaceSuite) TestInterfaces(c *C) {
c.Check(builtin.Interfaces(), testutil.DeepContains, s.iface)
}
|
