1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374
|
// -*- Mode: Go; indent-tabs-mode: t -*-
/*
* Copyright (C) 2021 Canonical Ltd
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 3 as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
package ctlcmd
import (
"errors"
"fmt"
"time"
"gopkg.in/yaml.v2"
"github.com/snapcore/snapd/cmd/snaplock"
"github.com/snapcore/snapd/cmd/snaplock/runinhibit"
"github.com/snapcore/snapd/features"
"github.com/snapcore/snapd/i18n"
"github.com/snapcore/snapd/interfaces"
"github.com/snapcore/snapd/overlord/configstate/config"
"github.com/snapcore/snapd/overlord/hookstate"
"github.com/snapcore/snapd/overlord/ifacestate"
"github.com/snapcore/snapd/overlord/snapstate"
"github.com/snapcore/snapd/overlord/state"
"github.com/snapcore/snapd/snap"
)
var autoRefreshForGatingSnap = snapstate.AutoRefreshForGatingSnap
type refreshCommand struct {
baseCommand
Pending bool `long:"pending" description:"Show pending refreshes of the calling snap"`
// these two options are mutually exclusive
Proceed bool `long:"proceed" description:"Proceed with potentially disruptive refreshes"`
Hold bool `long:"hold" description:"Do not proceed with potentially disruptive refreshes"`
PrintInhibitLock bool `long:"show-lock" description:"Show the value of the run inhibit lock held during refreshes (empty means not held)"`
}
var shortRefreshHelp = i18n.G("The refresh command prints pending refreshes and can hold back disruptive ones.")
var longRefreshHelp = i18n.G(`
The refresh command prints pending refreshes of the calling snap and can hold
back disruptive refreshes of other snaps, such as refreshes of the kernel or
base snaps that can trigger a restart. This command can be used from the
gate-auto-refresh hook which is only run during auto-refresh.
Snap can query pending refreshes with:
$ snapctl refresh --pending
pending: ready
channel: stable
version: 2
revision: 2
base: false
restart: false
The 'pending' flag can be "ready", "none" or "inhibited". It is set to "none"
when a snap has no pending refreshes. It is set to "ready" when there are
pending refreshes and to ”inhibited” when pending refreshes are being
held back because more or more snap applications are running with the
“refresh app awareness” feature enabled.
The "base" and "restart" flags indicate whether the base snap is going to be
updated and/or if a restart will occur, both of which are disruptive. A base
snap update can temporarily disrupt the starting of applications or hooks from
the snap.
To tell snapd to proceed with pending refreshes:
$ snapctl refresh --pending --proceed
Note, a snap using --proceed cannot assume that the updates will occur as they
might be held back by other snaps.
To hold refresh for up to 90 days for the calling snap:
$ snapctl refresh --pending --hold
`)
func init() {
cmd := addCommand("refresh", shortRefreshHelp, longRefreshHelp, func() command {
return &refreshCommand{}
})
cmd.hidden = true
}
func (c *refreshCommand) Execute(args []string) error {
context, err := c.ensureContext()
if err != nil {
return err
}
if !context.IsEphemeral() && context.HookName() != "gate-auto-refresh" {
return fmt.Errorf("can only be used from gate-auto-refresh hook")
}
var which string
for _, opt := range []struct {
val bool
name string
}{
{c.PrintInhibitLock, "--show-lock"},
{c.Hold, "--hold"},
{c.Proceed, "--proceed"},
} {
if opt.val && which != "" {
return fmt.Errorf("cannot use %s and %s together", opt.name, which)
}
if opt.val {
which = opt.name
}
}
// --pending --proceed is a verbose way of saying --proceed, so only
// print pending if proceed wasn't requested.
if c.Pending && !c.Proceed {
if err := c.printPendingInfo(); err != nil {
return err
}
}
switch {
case c.Proceed:
return c.proceed()
case c.Hold:
return c.hold()
case c.PrintInhibitLock:
return c.printInhibitLockHint()
}
return nil
}
type updateDetails struct {
Pending string `yaml:"pending,omitempty"`
Channel string `yaml:"channel,omitempty"`
CohortKey string `yaml:"cohort,omitempty"`
Version string `yaml:"version,omitempty"`
Revision int `yaml:"revision,omitempty"`
// TODO: epoch
Base bool `yaml:"base"`
Restart bool `yaml:"restart"`
}
type holdDetails struct {
Hold string `yaml:"hold"`
}
// refreshCandidate is a subset of refreshCandidate defined by snapstate and
// stored in "refresh-candidates".
type refreshCandidate struct {
Channel string `json:"channel,omitempty"`
Version string `json:"version,omitempty"`
SideInfo *snap.SideInfo `json:"side-info,omitempty"`
InstanceKey string `json:"instance-key,omitempty"`
}
func getUpdateDetails(context *hookstate.Context) (*updateDetails, error) {
context.Lock()
defer context.Unlock()
st := context.State()
affected, err := snapstate.AffectedByRefreshCandidates(st)
if err != nil {
return nil, err
}
var base, restart bool
if affectedInfo, ok := affected[context.InstanceName()]; ok {
base = affectedInfo.Base
restart = affectedInfo.Restart
}
var snapst snapstate.SnapState
if err := snapstate.Get(st, context.InstanceName(), &snapst); err != nil {
return nil, fmt.Errorf("internal error: cannot get snap state for %q: %v", context.InstanceName(), err)
}
var candidates map[string]*refreshCandidate
if err := st.Get("refresh-candidates", &candidates); err != nil && !errors.Is(err, state.ErrNoState) {
return nil, err
}
var pending string
switch {
case snapst.RefreshInhibitedTime != nil:
pending = "inhibited"
case candidates[context.InstanceName()] != nil:
pending = "ready"
default:
pending = "none"
}
up := updateDetails{
Base: base,
Restart: restart,
Pending: pending,
}
hasRefreshControl, err := hasSnapRefreshControlInterface(st, context.InstanceName())
if err != nil {
return nil, err
}
if hasRefreshControl {
up.CohortKey = snapst.CohortKey
}
// try to find revision/version/channel info from refresh-candidates; it
// may be missing if the hook is called for snap that is just affected by
// refresh but not refreshed itself, in such case this data is not
// displayed.
if cand, ok := candidates[context.InstanceName()]; ok {
up.Channel = cand.Channel
up.Revision = cand.SideInfo.Revision.N
up.Version = cand.Version
return &up, nil
}
// refresh-hint not present, look up channel info in snapstate
up.Channel = snapst.TrackingChannel
return &up, nil
}
func (c *refreshCommand) printPendingInfo() error {
details, err := getUpdateDetails(c.context())
if err != nil {
return err
}
out, err := yaml.Marshal(details)
if err != nil {
return err
}
c.printf("%s", string(out))
return nil
}
func (c *refreshCommand) hold() error {
ctx := c.context()
if ctx.IsEphemeral() {
return fmt.Errorf("cannot hold outside of gate-auto-refresh hook")
}
ctx.Lock()
defer ctx.Unlock()
st := ctx.State()
// cache the action so that hook handler can implement default behavior
ctx.Cache("action", snapstate.GateAutoRefreshHold)
affecting, err := snapstate.AffectingSnapsForAffectedByRefreshCandidates(st, ctx.InstanceName())
if err != nil {
return err
}
if len(affecting) == 0 {
// this shouldn't happen because the hook is executed during auto-refresh
// change which conflicts with other changes (if it happens that means
// something changed in the meantime and we didn't handle conflicts
// correctly).
return fmt.Errorf("internal error: snap %q is not affected by any snaps", ctx.InstanceName())
}
// no duration specified, use maximum allowed for this gating snap.
var holdDuration time.Duration
// XXX for now snaps hold other snaps only for auto-refreshes
remaining, err := snapstate.HoldRefresh(st, snapstate.HoldAutoRefresh, ctx.InstanceName(), holdDuration, affecting...)
if err != nil {
// TODO: let a snap hold again once for 1h.
return err
}
var details holdDetails
details.Hold = remaining.String()
out, err := yaml.Marshal(details)
if err != nil {
return err
}
c.printf("%s", string(out))
return nil
}
func (c *refreshCommand) proceed() error {
ctx := c.context()
ctx.Lock()
defer ctx.Unlock()
// running outside of hook
if ctx.IsEphemeral() {
st := ctx.State()
hasRefreshControl, err := hasSnapRefreshControlInterface(st, ctx.InstanceName())
if err != nil {
return err
}
if !hasRefreshControl {
return fmt.Errorf("cannot proceed: requires snap-refresh-control interface")
}
// we need to check if GateAutoRefreshHook feature is enabled when
// running by the snap (we don't need to do this when running from the
// hook because in that case hook task won't be created if not enabled).
tr := config.NewTransaction(st)
gateAutoRefreshHook, err := features.Flag(tr, features.GateAutoRefreshHook)
if err != nil && !config.IsNoOption(err) {
return err
}
if !gateAutoRefreshHook {
return fmt.Errorf("cannot proceed without experimental.gate-auto-refresh feature enabled")
}
return autoRefreshForGatingSnap(st, ctx.InstanceName())
}
// cache the action, hook handler will trigger proceed logic; we cannot
// call snapstate.ProceedWithRefresh() immediately as this would reset
// holdState, allowing the snap to --hold with fresh duration limit.
ctx.Cache("action", snapstate.GateAutoRefreshProceed)
return nil
}
func hasSnapRefreshControlInterface(st *state.State, snapName string) (bool, error) {
conns, err := ifacestate.ConnectionStates(st)
if err != nil {
return false, fmt.Errorf("internal error: cannot get connections: %s", err)
}
for refStr, connState := range conns {
if connState.Undesired || connState.Interface != "snap-refresh-control" {
continue
}
connRef, err := interfaces.ParseConnRef(refStr)
if err != nil {
return false, fmt.Errorf("internal error: %s", err)
}
if connRef.PlugRef.Snap == snapName {
return true, nil
}
}
return false, nil
}
func (c *refreshCommand) printInhibitLockHint() error {
ctx := c.context()
ctx.Lock()
snapName := ctx.InstanceName()
ctx.Unlock()
// obtain snap lock before manipulating runinhibit lock.
lock, err := snaplock.OpenLock(snapName)
if err != nil {
return err
}
if err := lock.Lock(); err != nil {
return err
}
defer lock.Unlock()
hint, _, err := runinhibit.IsLocked(snapName, nil)
if err != nil {
return err
}
c.printf("%s", hint)
return nil
}
|