1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283
|
// -*- Mode: Go; indent-tabs-mode: t -*-
/*
* Copyright (C) 2016 Canonical Ltd
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 3 as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
package ctlcmd
import (
"encoding/json"
"errors"
"fmt"
"strings"
"github.com/snapcore/snapd/client/clientutil"
"github.com/snapcore/snapd/i18n"
"github.com/snapcore/snapd/jsonutil"
"github.com/snapcore/snapd/overlord/confdbstate"
"github.com/snapcore/snapd/overlord/configstate"
"github.com/snapcore/snapd/overlord/configstate/config"
"github.com/snapcore/snapd/overlord/hookstate"
"github.com/snapcore/snapd/snap"
)
var confdbstateTransactionForSet = confdbstate.GetTransactionToSet
type setCommand struct {
baseCommand
View bool `long:"view" description:"return confdb values from the view declared in the plug"`
Positional struct {
PlugOrSlotSpec string `positional-arg-name:":<plug|slot>"`
ConfValues []string `positional-arg-name:"key=value"`
} `positional-args:"yes"`
String bool `short:"s" description:"parse the value as a string"`
Typed bool `short:"t" description:"parse the value strictly as JSON document"`
}
var shortSetHelp = i18n.G("Set either configuration options or interface connection settings")
var longSetHelp = i18n.G(`
The set command sets the provided configuration options as requested.
$ snapctl set username=frank password=$PASSWORD
All configuration changes are persisted at once, and only after the hook
returns successfully.
Nested values may be modified via a dotted path:
$ snapctl set author.name=frank
Configuration option may be unset with exclamation mark:
$ snapctl set author!
Plug and slot attributes may be set in the respective prepare and connect hooks
by naming the respective plug or slot:
$ snapctl set :myplug path=/dev/ttyS0
`)
func init() {
addCommand("set", shortSetHelp, longSetHelp, func() command { return &setCommand{} })
}
func (s *setCommand) Execute(args []string) error {
if s.Positional.PlugOrSlotSpec == "" && len(s.Positional.ConfValues) == 0 {
return errors.New(i18n.G("set which option?"))
}
context, err := s.ensureContext()
if err != nil {
return err
}
if s.Typed && s.String {
return fmt.Errorf("cannot use -t and -s together")
}
// treat PlugOrSlotSpec argument as key=value if it contains '=' or doesn't contain ':' - this is to support
// values such as "device-service.url=192.168.0.1:5555" and error out on invalid key=value if only "key" is given.
if strings.Contains(s.Positional.PlugOrSlotSpec, "=") || !strings.Contains(s.Positional.PlugOrSlotSpec, ":") {
s.Positional.ConfValues = append([]string{s.Positional.PlugOrSlotSpec}, s.Positional.ConfValues[0:]...)
s.Positional.PlugOrSlotSpec = ""
return s.setConfigSetting(context)
}
parts := strings.SplitN(s.Positional.PlugOrSlotSpec, ":", 2)
snap, name := parts[0], parts[1]
if name == "" {
return fmt.Errorf("plug or slot name not provided")
}
if snap != "" {
return fmt.Errorf(`"snapctl set %s" not supported, use "snapctl set :%s" instead`, s.Positional.PlugOrSlotSpec, parts[1])
}
if s.View {
if err := validateConfdbsFeatureFlag(context.State()); err != nil {
return err
}
opts := &clientutil.ParseConfigOptions{String: s.String, Typed: s.Typed}
requests, _, err := clientutil.ParseConfigValues(s.Positional.ConfValues, opts)
if err != nil {
return fmt.Errorf(i18n.G("cannot set %s plug: %w"), s.Positional.PlugOrSlotSpec, err)
}
return setConfdbValues(context, name, requests)
}
return s.setInterfaceSetting(context, name)
}
func (s *setCommand) setConfigSetting(context *hookstate.Context) error {
context.Lock()
tr := configstate.ContextTransaction(context)
context.Unlock()
opts := &clientutil.ParseConfigOptions{String: s.String, Typed: s.Typed}
confValues, confKeys, err := clientutil.ParseConfigValues(s.Positional.ConfValues, opts)
if err != nil {
return err
}
for _, key := range confKeys {
tr.Set(s.context().InstanceName(), key, confValues[key])
}
return nil
}
func setInterfaceAttribute(context *hookstate.Context, staticAttrs map[string]any, dynamicAttrs map[string]any, key string, value any) error {
data, err := json.Marshal(value)
if err != nil {
return fmt.Errorf("cannot marshal snap %q option %q: %s", context.InstanceName(), key, err)
}
raw := json.RawMessage(data)
subkeys, err := config.ParseKey(key)
if err != nil {
return err
}
// We're called from setInterfaceSetting, subkeys is derived from key
// part of key=value argument and is guaranteed to be non-empty at this
// point.
if len(subkeys) == 0 {
return fmt.Errorf("internal error: unexpected empty subkeys for key %q", key)
}
var existing any
err = getAttribute(context.InstanceName(), subkeys[:1], 0, staticAttrs, &existing)
if err == nil {
return fmt.Errorf(i18n.G("attribute %q cannot be overwritten"), key)
}
// we expect NoAttributeError here, any other error is unexpected (a real error)
if !isNoAttribute(err) {
return err
}
_, err = config.PatchConfig(context.InstanceName(), subkeys, 0, dynamicAttrs, &raw)
return err
}
func (s *setCommand) setInterfaceSetting(context *hookstate.Context, plugOrSlot string) error {
// Make sure set :<plug|slot> is only supported during the execution of prepare-[plug|slot] hooks
hookType, _ := interfaceHookType(context.HookName())
if hookType != preparePlugHook && hookType != prepareSlotHook {
return errors.New(i18n.G("interface attributes can only be set during the execution of prepare hooks"))
}
attrsTask, err := attributesTask(context)
if err != nil {
return err
}
// check if the requested plug or slot is correct for this hook.
if err := validatePlugOrSlot(attrsTask, hookType == preparePlugHook, plugOrSlot); err != nil {
return err
}
var which string
if hookType == preparePlugHook {
which = "plug"
} else {
which = "slot"
}
context.Lock()
defer context.Unlock()
var staticAttrs, dynamicAttrs map[string]any
if err = attrsTask.Get(which+"-static", &staticAttrs); err != nil {
return fmt.Errorf(i18n.G("internal error: cannot get %s from appropriate task, %s"), which, err)
}
dynKey := which + "-dynamic"
if err = attrsTask.Get(dynKey, &dynamicAttrs); err != nil {
return fmt.Errorf(i18n.G("internal error: cannot get %s from appropriate task, %s"), which, err)
}
for _, attrValue := range s.Positional.ConfValues {
parts := strings.SplitN(attrValue, "=", 2)
if len(parts) != 2 {
return fmt.Errorf(i18n.G("invalid parameter: %q (want key=value)"), attrValue)
}
var value any
if err := jsonutil.DecodeWithNumber(strings.NewReader(parts[1]), &value); err != nil {
// Not valid JSON, save the string as-is
value = parts[1]
}
err = setInterfaceAttribute(context, staticAttrs, dynamicAttrs, parts[0], value)
if err != nil {
return fmt.Errorf(i18n.G("cannot set attribute: %v"), err)
}
}
attrsTask.Set(dynKey, dynamicAttrs)
return nil
}
func setConfdbValues(ctx *hookstate.Context, plugName string, requests map[string]any) error {
ctx.Lock()
defer ctx.Unlock()
plug, err := checkConfdbPlugConnection(ctx, plugName)
if err != nil {
return err
}
account, dbSchemaName, viewName, err := snap.ConfdbPlugAttrs(plug)
if err != nil {
return fmt.Errorf(i18n.G("invalid plug :%s: %w"), plugName, err)
}
view, err := confdbstateGetView(ctx.State(), account, dbSchemaName, viewName)
if err != nil {
return err
}
if confdbstate.IsConfdbHook(ctx) && !confdbstate.CanHookSetConfdb(ctx) {
return fmt.Errorf("cannot modify confdb in %q hook", ctx.HookName())
}
tx, commitTxFunc, err := confdbstateTransactionForSet(ctx, ctx.State(), view)
if err != nil {
return err
}
err = confdbstate.SetViaView(tx, view, requests)
if err != nil {
return err
}
// if a new transaction was created, commit it
if commitTxFunc != nil {
_, waitChan, err := commitTxFunc()
if err != nil {
return err
}
// wait for the transaction to be committed
ctx.Unlock()
<-waitChan
ctx.Lock()
}
return nil
}
|