1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378
|
// -*- Mode: Go; indent-tabs-mode: t -*-
/*
* Copyright (C) 2017-2020 Canonical Ltd
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 3 as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
package userd
import (
"fmt"
"os/exec"
"path/filepath"
"strings"
"time"
"github.com/godbus/dbus/v5"
"github.com/snapcore/snapd/dirs"
"github.com/snapcore/snapd/i18n"
"github.com/snapcore/snapd/osutil"
"github.com/snapcore/snapd/snap"
"github.com/snapcore/snapd/usersession/userd/ui"
)
// Timeout when the confirmation dialog for an xdg-setging
// automatically closes. Keep in sync with the core snaps
// xdg-settings wrapper which also sets this value to 300.
var defaultConfirmDialogTimeout = 300 * time.Second
const settingsIntrospectionXML = `
<interface name="org.freedesktop.DBus.Peer">
<method name='Ping'>
</method>
<method name='GetMachineId'>
<arg type='s' name='machine_uuid' direction='out'/>
</method>
</interface>
<interface name='io.snapcraft.Settings'>
<method name='Check'>
<arg type='s' name='setting' direction='in'/>
<arg type='s' name='check' direction='in'/>
<arg type='s' name='result' direction='out'/>
</method>
<method name='CheckSub'>
<arg type='s' name='setting' direction='in'/>
<arg type='s' name='subproperty' direction='in'/>
<arg type='s' name='check' direction='in'/>
<arg type='s' name='result' direction='out'/>
</method>
<method name='Get'>
<arg type='s' name='setting' direction='in'/>
<arg type='s' name='result' direction='out'/>
</method>
<method name='GetSub'>
<arg type='s' name='setting' direction='in'/>
<arg type='s' name='subproperty' direction='in'/>
<arg type='s' name='result' direction='out'/>
</method>
<method name='Set'>
<arg type='s' name='setting' direction='in'/>
<arg type='s' name='value' direction='in'/>
</method>
<method name='SetSub'>
<arg type='s' name='setting' direction='in'/>
<arg type='s' name='subproperty' direction='in'/>
<arg type='s' name='value' direction='in'/>
</method>
</interface>`
var validSettings = []string{
"default-web-browser",
"default-url-scheme-handler",
}
func allowedSetting(setting string) bool {
if !strings.HasSuffix(setting, ".desktop") {
return false
}
base := strings.TrimSuffix(setting, ".desktop")
return snap.ValidAppName(base)
}
// settingSpec specifies a setting with an optional subproperty
type settingSpec struct {
setting string
subproperty string
}
func (s *settingSpec) String() string {
if s.subproperty != "" {
return fmt.Sprintf("%q subproperty %q", s.setting, s.subproperty)
} else {
return fmt.Sprintf("%q", s.setting)
}
}
func (s *settingSpec) validate() *dbus.Error {
for _, valid := range validSettings {
if s.setting == valid {
return nil
}
}
return dbus.MakeFailedError(fmt.Errorf("invalid setting %q", s.setting))
}
// Settings implements the 'io.snapcraft.Settings' DBus interface.
type Settings struct {
conn *dbus.Conn
}
// Interface returns the name of the interface this object implements
func (s *Settings) Interface() string {
return "io.snapcraft.Settings"
}
// ObjectPath returns the path that the object is exported as
func (s *Settings) ObjectPath() dbus.ObjectPath {
return "/io/snapcraft/Settings"
}
// IntrospectionData gives the XML formatted introspection description
// of the DBus service.
func (s *Settings) IntrospectionData() string {
return settingsIntrospectionXML
}
// some notes:
// - we only set/get desktop files
// - all desktop files of snaps are prefixed with: ${snap}_
// - on get/check/set we need to add/strip this prefix
func safeSnapFromSender(s *Settings, sender dbus.Sender) (string, *dbus.Error) {
// avoid information leak: see https://github.com/snapcore/snapd/pull/4073#discussion_r146682758
snap, err := snapFromSender(s.conn, sender)
if err != nil {
return "", dbus.MakeFailedError(err)
}
return snap, nil
}
func desktopFileFromValueForSetting(s *Settings, command string, setspec *settingSpec, dotDesktopValue string, sender dbus.Sender) (string, *dbus.Error) {
snap, err := safeSnapFromSender(s, sender)
if err != nil {
return "", err
}
if err := setspec.validate(); err != nil {
return "", err
}
if !allowedSetting(dotDesktopValue) {
return "", dbus.MakeFailedError(fmt.Errorf("cannot %s %s setting to invalid value %q", command, setspec, dotDesktopValue))
}
// FIXME: this works only for desktop files
desktopFile := fmt.Sprintf("%s_%s", snap, dotDesktopValue)
return desktopFile, nil
}
func desktopFileFromOutput(s *Settings, output string, sender dbus.Sender) (string, *dbus.Error) {
snap, err := safeSnapFromSender(s, sender)
if err != nil {
return "", err
}
if !strings.HasPrefix(output, snap+"_") {
return "NOT-THIS-SNAP.desktop", nil
}
desktopFile := strings.SplitN(output, "_", 2)[1]
return strings.TrimSpace(desktopFile), nil
}
func setDialog(s *Settings, setspec *settingSpec, desktopFile string, sender dbus.Sender) *dbus.Error {
df := filepath.Join(dirs.SnapDesktopFilesDir, desktopFile)
if !osutil.FileExists(df) {
return dbus.MakeFailedError(fmt.Errorf("cannot find desktop file %q", df))
}
// FIXME: we need to know the parent PID or our dialog may pop under
// the existing windows. We might get it with the help of
// the xdg-settings tool inside the core snap. It would have
// to get the PID of the process asking for the settings
// then xdg-settings can sent this to us and we can intospect
// the X windows for _NET_WM_PID and use the windowID to
// attach to zenity - not sure how this translate to the
// wayland world though :/
dialog, uiErr := ui.New()
if uiErr != nil {
return dbus.MakeFailedError(fmt.Errorf("cannot ask for settings change: %v", uiErr))
}
snap, err := safeSnapFromSender(s, sender)
if err != nil {
return err
}
answeredYes := dialog.YesNo(
i18n.G("Allow settings change?"),
fmt.Sprintf(i18n.G("Allow snap %q to change %s to %q ?"), snap, setspec, desktopFile),
&ui.DialogOptions{
Timeout: defaultConfirmDialogTimeout,
Footer: i18n.G("This dialog will close automatically after 5 minutes of inactivity."),
},
)
if !answeredYes {
return dbus.MakeFailedError(fmt.Errorf("cannot change configuration: user declined change"))
}
return nil
}
func checkOutput(cmd *exec.Cmd, command string, setspec *settingSpec) (string, *dbus.Error) {
output, stderr, err := osutil.RunCmd(cmd)
if err != nil {
return "", dbus.MakeFailedError(fmt.Errorf("cannot %s %s setting: %s", command, setspec, osutil.OutputErrCombine(output, stderr, err)))
}
return string(output), nil
}
// Check implements the 'Check' method of the 'io.snapcraft.Settings'
// DBus interface.
//
// Example usage: dbus-send --session --dest=io.snapcraft.Settings --type=method_call --print-reply /io/snapcraft/Settings io.snapcraft.Settings.Check string:'default-web-browser' string:'firefox.desktop'
func (s *Settings) Check(setting string, check string, sender dbus.Sender) (string, *dbus.Error) {
if err := checkOnClassic(); err != nil {
return "", err
}
settingMain := &settingSpec{setting: setting}
desktopFile, err := desktopFileFromValueForSetting(s, "check", settingMain, check, sender)
if err != nil {
return "", err
}
cmd := exec.Command("xdg-settings", "check", setting, desktopFile)
output, err := checkOutput(cmd, "check", settingMain)
if err != nil {
return "", err
}
return strings.TrimSpace(output), nil
}
// CheckSub implements the 'CheckSub' method of the 'io.snapcraft.Settings'
// DBus interface.
//
// Example usage: dbus-send --session --dest=io.snapcraft.Settings --type=method_call --print-reply /io/snapcraft/Settings io.snapcraft.Settings.CheckSub string:'default-url-scheme-handler' string:'irc' string:'ircclient.desktop'
func (s *Settings) CheckSub(setting string, subproperty string, check string, sender dbus.Sender) (string, *dbus.Error) {
if err := checkOnClassic(); err != nil {
return "", err
}
settingSub := &settingSpec{setting: setting, subproperty: subproperty}
desktopFile, err := desktopFileFromValueForSetting(s, "check", settingSub, check, sender)
if err != nil {
return "", err
}
cmd := exec.Command("xdg-settings", "check", setting, subproperty, desktopFile)
output, err := checkOutput(cmd, "check", settingSub)
if err != nil {
return "", err
}
return strings.TrimSpace(output), nil
}
// Get implements the 'Get' method of the 'io.snapcraft.Settings'
// DBus interface.
//
// Example usage: dbus-send --session --dest=io.snapcraft.Settings --type=method_call --print-reply /io/snapcraft/Settings io.snapcraft.Settings.Get string:'default-web-browser'
func (s *Settings) Get(setting string, sender dbus.Sender) (string, *dbus.Error) {
if err := checkOnClassic(); err != nil {
return "", err
}
settingMain := &settingSpec{setting: setting}
if err := settingMain.validate(); err != nil {
return "", err
}
cmd := exec.Command("xdg-settings", "get", setting)
output, err := checkOutput(cmd, "get", settingMain)
if err != nil {
return "", err
}
return desktopFileFromOutput(s, output, sender)
}
// GetSub implements the 'GetSub' method of the 'io.snapcraft.Settings'
// DBus interface.
//
// Example usage: dbus-send --session --dest=io.snapcraft.Settings --type=method_call --print-reply /io/snapcraft/Settings io.snapcraft.Settings.GetSub string:'default-url-scheme-handler' string:'irc'
func (s *Settings) GetSub(setting string, subproperty string, sender dbus.Sender) (string, *dbus.Error) {
if err := checkOnClassic(); err != nil {
return "", err
}
settingSub := &settingSpec{setting: setting, subproperty: subproperty}
if err := settingSub.validate(); err != nil {
return "", err
}
cmd := exec.Command("xdg-settings", "get", setting, subproperty)
output, err := checkOutput(cmd, "get", settingSub)
if err != nil {
return "", err
}
return desktopFileFromOutput(s, output, sender)
}
// Set implements the 'Set' method of the 'io.snapcraft.Settings'
// DBus interface.
//
// Example usage: dbus-send --session --dest=io.snapcraft.Settings --type=method_call --print-reply /io/snapcraft/Settings io.snapcraft.Settings.Set string:'default-web-browser' string:'chromium-browser.desktop'
func (s *Settings) Set(setting string, new string, sender dbus.Sender) *dbus.Error {
if err := checkOnClassic(); err != nil {
return err
}
settingMain := &settingSpec{setting: setting}
desktopFile, err := desktopFileFromValueForSetting(s, "set", settingMain, new, sender)
if err != nil {
return err
}
if err := setDialog(s, settingMain, desktopFile, sender); err != nil {
return err
}
cmd := exec.Command("xdg-settings", "set", setting, desktopFile)
if _, err := checkOutput(cmd, "set", settingMain); err != nil {
return err
}
return nil
}
// SetSub implements the 'SetSub' method of the 'io.snapcraft.Settings'
// DBus interface.
//
// Example usage: dbus-send --session --dest=io.snapcraft.Settings --type=method_call --print-reply /io/snapcraft/Settings io.snapcraft.Settings.SetSub string:'default-url-scheme-handler' string:'irc' string:'ircclient.desktop'
func (s *Settings) SetSub(setting string, subproperty string, new string, sender dbus.Sender) *dbus.Error {
if err := checkOnClassic(); err != nil {
return err
}
settingSub := &settingSpec{setting: setting, subproperty: subproperty}
desktopFile, err := desktopFileFromValueForSetting(s, "set", settingSub, new, sender)
if err != nil {
return err
}
if err := setDialog(s, settingSub, desktopFile, sender); err != nil {
return err
}
cmd := exec.Command("xdg-settings", "set", setting, subproperty, desktopFile)
if _, err := checkOutput(cmd, "set", settingSub); err != nil {
return err
}
return nil
}
|