1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
|
// -*- Mode: Go; indent-tabs-mode: t -*-
/*
* Copyright (C) 2014-2017 Canonical Ltd
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 3 as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
package mount_test
import (
"os"
"path/filepath"
. "gopkg.in/check.v1"
"github.com/snapcore/snapd/dirs"
"github.com/snapcore/snapd/interfaces/mount"
"github.com/snapcore/snapd/release"
"github.com/snapcore/snapd/testutil"
)
type nsSuite struct {
testutil.BaseTest
}
var _ = Suite(&nsSuite{})
func (s *nsSuite) SetUpTest(c *C) {
s.BaseTest.SetUpTest(c)
dirs.SetRootDir(c.MkDir())
s.AddCleanup(func() { dirs.SetRootDir("") })
s.AddCleanup(release.MockOnClassic(true))
// Anything that just gives us no-reexec.
s.AddCleanup(release.MockReleaseInfo(&release.OS{ID: "fedora"}))
}
func (s *nsSuite) TestDiscardNamespaceMnt(c *C) {
for _, t := range []struct {
cmd string
mnt bool
locked bool
errStr string
res [][]string
}{
// The mnt file present so we use snap-discard-ns;
// The command doesn't fail and there's no error.
{cmd: "", mnt: true, locked: false, errStr: "", res: [][]string{{"snap-discard-ns", "snap-name"}}},
// The mnt file is not present so we don't do anything.
{cmd: "", mnt: false, locked: false, errStr: "", res: nil},
// The mnt file is present so we use snap-discard-ns;
// The command fails and we forward the error along with the output.
{
cmd: "echo failure; exit 1;",
mnt: true,
locked: false,
errStr: `cannot discard preserved mount namespace of snap "snap-name": failure`,
res: [][]string{{"snap-discard-ns", "snap-name"}}},
// The mnt file is present so we use snap-discard-ns;
// The command fails silently and we forward this fact using a generic message.
{
cmd: "exit 1;",
mnt: true,
locked: false,
errStr: `cannot discard preserved mount namespace of snap "snap-name": exit status 1`,
res: [][]string{{"snap-discard-ns", "snap-name"}}},
// use snap-discard-ns with --snap-already-locked
{cmd: "", mnt: true, locked: true, errStr: "", res: [][]string{{"snap-discard-ns", "--snap-already-locked", "snap-name"}}},
// and an error variant of it
{
cmd: "echo 'locked variant, failure'; exit 1;",
mnt: true,
locked: true,
errStr: `cannot discard preserved mount namespace of snap "snap-name": locked variant, failure`,
res: [][]string{{"snap-discard-ns", "--snap-already-locked", "snap-name"}}},
} {
cmd := testutil.MockCommand(c, "snap-discard-ns", t.cmd)
dirs.DistroLibExecDir = cmd.BinDir()
defer cmd.Restore()
if t.mnt {
c.Assert(os.MkdirAll(dirs.SnapRunNsDir, 0755), IsNil)
c.Assert(os.WriteFile(filepath.Join(dirs.SnapRunNsDir, "snap-name.mnt"), nil, 0644), IsNil)
} else {
c.Assert(os.RemoveAll(dirs.SnapRunNsDir), IsNil)
}
var err error
if t.locked {
err = mount.DiscardLockedSnapNamespace("snap-name")
} else {
err = mount.DiscardSnapNamespace("snap-name")
}
if t.errStr != "" {
c.Check(err, ErrorMatches, t.errStr)
} else {
c.Check(err, IsNil)
c.Check(cmd.Calls(), DeepEquals, t.res)
}
}
}
func (s *nsSuite) TestUpdateNamespaceMnt(c *C) {
for _, t := range []struct {
cmd string
mnt bool
errStr string
res [][]string
}{
// The mnt file present so we use snap-update-ns;
// The command doesn't fail and there's no error.
{cmd: "", mnt: true, errStr: "", res: [][]string{{"snap-update-ns", "snap-name"}}},
// The mnt file is not present so we don't do anything.
{cmd: "", mnt: false, errStr: "", res: nil},
// The mnt file is present so we use snap-update-ns;
// The command fails and we forward the error along with the output.
{
cmd: "echo failure; exit 1;",
mnt: true,
errStr: `cannot update preserved mount namespace of snap "snap-name": failure`,
res: [][]string{{"snap-update-ns", "snap-name"}}},
// The mnt file is present so we use snap-update-ns;
// The command fails silently and we forward this fact using a generic message.
{
cmd: "exit 1;",
mnt: true,
errStr: `cannot update preserved mount namespace of snap "snap-name": exit status 1`,
res: [][]string{{"snap-update-ns", "snap-name"}}},
} {
cmd := testutil.MockCommand(c, "snap-update-ns", t.cmd)
dirs.DistroLibExecDir = cmd.BinDir()
defer cmd.Restore()
if t.mnt {
c.Assert(os.MkdirAll(dirs.SnapRunNsDir, 0755), IsNil)
c.Assert(os.WriteFile(filepath.Join(dirs.SnapRunNsDir, "snap-name.mnt"), nil, 0644), IsNil)
} else {
c.Assert(os.RemoveAll(dirs.SnapRunNsDir), IsNil)
}
err := mount.UpdateSnapNamespace("snap-name")
if t.errStr != "" {
c.Check(err, ErrorMatches, t.errStr)
} else {
c.Check(err, IsNil)
c.Check(cmd.Calls(), DeepEquals, t.res)
}
}
}
|
