1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71
|
Description: goconvey does not work with ShouldEqual in slices
This is mentioned in https://github.com/smartystreets/goconvey/issues/128#issuecomment-33227844 along
with a hint to instead use `ShouldResemble`
Author: Nilesh Patra <nilesh@debian.org>
Last-Update: 2025-10-06
--- a/client/lib/rendezvous_test.go
+++ b/client/lib/rendezvous_test.go
@@ -83,7 +83,7 @@
So(err, ShouldBeNil)
So(rend.brokerURL, ShouldNotBeNil)
So(rend.brokerURL.Host, ShouldResemble, "test.broker")
- So(rend.fronts, ShouldEqual, []string{})
+ So(rend.fronts, ShouldResemble, []string{})
So(rend.transport, ShouldEqual, transport)
})
@@ -334,7 +334,7 @@
answer, err := sqsRendezvous.Exchange(fakeEncPollResp)
- So(answer, ShouldEqual, []byte("answer"))
+ So(answer, ShouldResemble, []byte("answer"))
So(err, ShouldBeNil)
})
@@ -356,7 +356,7 @@
So(answer, ShouldBeNil)
So(err, ShouldNotBeNil)
- So(err, ShouldEqual, errors.New("test error"))
+ So(err, ShouldResemble, errors.New("test error"))
})
Convey("sqsRendezvous.Exchange does not receive answer", func() {
@@ -384,7 +384,7 @@
answer, err := sqsRendezvous.Exchange(fakeEncPollResp)
- So(answer, ShouldEqual, []byte{})
+ So(answer, ShouldResemble, []byte{})
So(err, ShouldBeNil)
})
})
@@ -425,7 +425,7 @@
answerSdpReturned, err := brokerChannel.Negotiate(offerSdp)
So(err, ShouldBeNil)
- So(answerSdpReturned, ShouldEqual, answerSdp)
+ So(answerSdpReturned, ShouldResemble, answerSdp)
body := <-requestBodyChan
pollReq, err := messages.DecodeClientPollRequest(body)
@@ -434,6 +434,6 @@
So(pollReq.NAT, ShouldEqual, nat.NATRestricted)
requestSdp, err := util.DeserializeSessionDescription(pollReq.Offer)
So(err, ShouldBeNil)
- So(requestSdp, ShouldEqual, offerSdp)
+ So(requestSdp, ShouldResemble, offerSdp)
})
}
--- a/common/util/util_test.go
+++ b/common/util/util_test.go
@@ -64,7 +64,7 @@
"a=candidate:3769337065 1 udp 2122260223 129.97.124.15 56688 typ host\r\n" +
"a=candidate:3769337065 1 udp 2122260224 129.97.124.16 56688 typ host\r\n" + offerEnd
- So(GetCandidateAddrs(sdp), ShouldEqual, []net.IP{
+ So(GetCandidateAddrs(sdp), ShouldResemble, []net.IP{
net.ParseIP("129.97.124.16"),
net.ParseIP("129.97.124.15"),
net.ParseIP("8.8.8.8"),
|