1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
|
// Copyright (c) 2025 Google LLC.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#include <iostream>
#include <unordered_map>
#include <unordered_set>
#include "source/opcode.h"
#include "source/val/validate.h"
#include "source/val/validation_state.h"
namespace spvtools {
namespace val {
namespace {
// Returns true if inst is a logical pointer.
bool IsLogicalPointer(const ValidationState_t& _, const Instruction* inst) {
if (!_.IsPointerType(inst->type_id())) {
return false;
}
// Physical storage buffer pointers are not logical pointers.
auto type_inst = _.FindDef(inst->type_id());
auto sc = type_inst->GetOperandAs<spv::StorageClass>(1);
if (sc == spv::StorageClass::PhysicalStorageBuffer) {
return false;
}
return true;
}
// Returns true if inst is a variable pointer.
// Caches the result in variable_pointers.
bool IsVariablePointer(const ValidationState_t& _,
std::unordered_map<uint32_t, bool>& variable_pointers,
const Instruction* inst) {
const auto iter = variable_pointers.find(inst->id());
if (iter != variable_pointers.end()) {
return iter->second;
}
bool is_var_ptr = false;
switch (inst->opcode()) {
case spv::Op::OpPtrAccessChain:
case spv::Op::OpUntypedPtrAccessChainKHR:
case spv::Op::OpUntypedInBoundsPtrAccessChainKHR:
case spv::Op::OpLoad:
case spv::Op::OpSelect:
case spv::Op::OpPhi:
case spv::Op::OpFunctionCall:
case spv::Op::OpConstantNull:
is_var_ptr = true;
break;
case spv::Op::OpFunctionParameter:
// Special case: skip to function calls.
if (IsLogicalPointer(_, inst)) {
auto func = inst->function();
auto func_inst = _.FindDef(func->id());
const auto param_inst_num = inst - &_.ordered_instructions()[0];
uint32_t param_index = 0;
uint32_t inst_index = 1;
while (_.ordered_instructions()[param_inst_num - inst_index].opcode() !=
spv::Op::OpFunction) {
if (_.ordered_instructions()[param_inst_num - inst_index].opcode() ==
spv::Op::OpFunctionParameter) {
param_index++;
}
++inst_index;
}
for (const auto& use_pair : func_inst->uses()) {
const auto use_inst = use_pair.first;
if (use_inst->opcode() == spv::Op::OpFunctionCall) {
const auto arg_id =
use_inst->GetOperandAs<uint32_t>(3 + param_index);
const auto arg_inst = _.FindDef(arg_id);
is_var_ptr |= IsVariablePointer(_, variable_pointers, arg_inst);
}
}
}
break;
default: {
for (uint32_t i = 0; i < inst->operands().size(); ++i) {
if (inst->operands()[i].type != SPV_OPERAND_TYPE_ID) {
continue;
}
auto op_inst = _.FindDef(inst->GetOperandAs<uint32_t>(i));
if (IsLogicalPointer(_, op_inst)) {
is_var_ptr |= IsVariablePointer(_, variable_pointers, op_inst);
}
}
break;
}
}
variable_pointers[inst->id()] = is_var_ptr;
return is_var_ptr;
}
spv_result_t ValidateLogicalPointerOperands(ValidationState_t& _,
const Instruction* inst) {
bool has_pointer_operand = false;
spv::StorageClass sc = spv::StorageClass::Function;
for (uint32_t i = 0; i < inst->operands().size(); ++i) {
if (inst->operands()[i].type != SPV_OPERAND_TYPE_ID) {
continue;
}
auto op_inst = _.FindDef(inst->GetOperandAs<uint32_t>(i));
if (IsLogicalPointer(_, op_inst)) {
has_pointer_operand = true;
// Assume that there are not mixed storage classes in the instruction.
// This is not true for OpCopyMemory and OpCopyMemorySized, but they allow
// all storage classes.
auto type_inst = _.FindDef(op_inst->type_id());
sc = type_inst->GetOperandAs<spv::StorageClass>(1);
break;
}
}
if (!has_pointer_operand) {
return SPV_SUCCESS;
}
switch (inst->opcode()) {
// The following instructions allow logical pointer operands in all cases
// without capabilities.
case spv::Op::OpLoad:
case spv::Op::OpStore:
case spv::Op::OpAccessChain:
case spv::Op::OpInBoundsAccessChain:
case spv::Op::OpFunctionCall:
case spv::Op::OpImageTexelPointer:
case spv::Op::OpCopyMemory:
case spv::Op::OpCopyObject:
case spv::Op::OpArrayLength:
case spv::Op::OpExtInst:
// Core spec bugs
case spv::Op::OpDecorate:
case spv::Op::OpDecorateId:
case spv::Op::OpGroupDecorate:
case spv::Op::OpEntryPoint:
case spv::Op::OpName:
case spv::Op::OpDecorateString:
// SPV_KHR_untyped_pointers
case spv::Op::OpUntypedArrayLengthKHR:
case spv::Op::OpUntypedAccessChainKHR:
case spv::Op::OpUntypedInBoundsAccessChainKHR:
case spv::Op::OpCopyMemorySized:
// Cooperative matrix KHR/NV
case spv::Op::OpCooperativeMatrixLoadKHR:
case spv::Op::OpCooperativeMatrixLoadNV:
case spv::Op::OpCooperativeMatrixStoreKHR:
case spv::Op::OpCooperativeMatrixStoreNV:
// SPV_KHR_ray_tracing
case spv::Op::OpTraceRayKHR:
case spv::Op::OpExecuteCallableKHR:
// SPV_KHR_ray_query
case spv::Op::OpRayQueryConfirmIntersectionKHR:
case spv::Op::OpRayQueryInitializeKHR:
case spv::Op::OpRayQueryTerminateKHR:
case spv::Op::OpRayQueryGenerateIntersectionKHR:
case spv::Op::OpRayQueryProceedKHR:
case spv::Op::OpRayQueryGetIntersectionTypeKHR:
case spv::Op::OpRayQueryGetRayTMinKHR:
case spv::Op::OpRayQueryGetRayFlagsKHR:
case spv::Op::OpRayQueryGetIntersectionTKHR:
case spv::Op::OpRayQueryGetIntersectionInstanceCustomIndexKHR:
case spv::Op::OpRayQueryGetIntersectionInstanceIdKHR:
case spv::Op::
OpRayQueryGetIntersectionInstanceShaderBindingTableRecordOffsetKHR:
case spv::Op::OpRayQueryGetIntersectionGeometryIndexKHR:
case spv::Op::OpRayQueryGetIntersectionPrimitiveIndexKHR:
case spv::Op::OpRayQueryGetIntersectionBarycentricsKHR:
case spv::Op::OpRayQueryGetIntersectionFrontFaceKHR:
case spv::Op::OpRayQueryGetIntersectionCandidateAABBOpaqueKHR:
case spv::Op::OpRayQueryGetIntersectionObjectRayDirectionKHR:
case spv::Op::OpRayQueryGetIntersectionObjectRayOriginKHR:
case spv::Op::OpRayQueryGetWorldRayDirectionKHR:
case spv::Op::OpRayQueryGetWorldRayOriginKHR:
case spv::Op::OpRayQueryGetIntersectionObjectToWorldKHR:
case spv::Op::OpRayQueryGetIntersectionWorldToObjectKHR:
// SPV_KHR_ray_tracing_position_fetch
case spv::Op::OpRayQueryGetIntersectionTriangleVertexPositionsKHR:
// SPV_NV_cluster_acceleration_structure
case spv::Op::OpRayQueryGetClusterIdNV:
case spv::Op::OpHitObjectGetClusterIdNV:
// SPV_NV_ray_tracing_motion_blur
case spv::Op::OpTraceMotionNV:
case spv::Op::OpTraceRayMotionNV:
// SPV_NV_linear_swept_spheres
case spv::Op::OpRayQueryGetIntersectionSpherePositionNV:
case spv::Op::OpRayQueryGetIntersectionSphereRadiusNV:
case spv::Op::OpRayQueryGetIntersectionLSSPositionsNV:
case spv::Op::OpRayQueryGetIntersectionLSSRadiiNV:
case spv::Op::OpRayQueryGetIntersectionLSSHitValueNV:
case spv::Op::OpRayQueryIsSphereHitNV:
case spv::Op::OpRayQueryIsLSSHitNV:
case spv::Op::OpHitObjectGetSpherePositionNV:
case spv::Op::OpHitObjectGetSphereRadiusNV:
case spv::Op::OpHitObjectGetLSSPositionsNV:
case spv::Op::OpHitObjectGetLSSRadiiNV:
case spv::Op::OpHitObjectIsSphereHitNV:
case spv::Op::OpHitObjectIsLSSHitNV:
// SPV_NV_shader_invocation_reorder
case spv::Op::OpReorderThreadWithHitObjectNV:
case spv::Op::OpHitObjectTraceRayNV:
case spv::Op::OpHitObjectTraceRayMotionNV:
case spv::Op::OpHitObjectRecordHitNV:
case spv::Op::OpHitObjectRecordHitMotionNV:
case spv::Op::OpHitObjectRecordHitWithIndexNV:
case spv::Op::OpHitObjectRecordHitWithIndexMotionNV:
case spv::Op::OpHitObjectRecordMissNV:
case spv::Op::OpHitObjectRecordMissMotionNV:
case spv::Op::OpHitObjectRecordEmptyNV:
case spv::Op::OpHitObjectExecuteShaderNV:
case spv::Op::OpHitObjectGetCurrentTimeNV:
case spv::Op::OpHitObjectGetAttributesNV:
case spv::Op::OpHitObjectGetHitKindNV:
case spv::Op::OpHitObjectGetPrimitiveIndexNV:
case spv::Op::OpHitObjectGetGeometryIndexNV:
case spv::Op::OpHitObjectGetInstanceIdNV:
case spv::Op::OpHitObjectGetInstanceCustomIndexNV:
case spv::Op::OpHitObjectGetObjectRayOriginNV:
case spv::Op::OpHitObjectGetObjectRayDirectionNV:
case spv::Op::OpHitObjectGetWorldRayDirectionNV:
case spv::Op::OpHitObjectGetWorldRayOriginNV:
case spv::Op::OpHitObjectGetObjectToWorldNV:
case spv::Op::OpHitObjectGetWorldToObjectNV:
case spv::Op::OpHitObjectGetRayTMaxNV:
case spv::Op::OpHitObjectGetRayTMinNV:
case spv::Op::OpHitObjectGetShaderBindingTableRecordIndexNV:
case spv::Op::OpHitObjectGetShaderRecordBufferHandleNV:
case spv::Op::OpHitObjectIsEmptyNV:
case spv::Op::OpHitObjectIsHitNV:
case spv::Op::OpHitObjectIsMissNV:
// SPV_EXT_shader_invocation_reorder
case spv::Op::OpHitObjectRecordFromQueryEXT:
case spv::Op::OpHitObjectRecordMissEXT:
case spv::Op::OpHitObjectRecordMissMotionEXT:
case spv::Op::OpHitObjectGetIntersectionTriangleVertexPositionsEXT:
case spv::Op::OpHitObjectGetRayFlagsEXT:
case spv::Op::OpHitObjectSetShaderBindingTableRecordIndexEXT:
case spv::Op::OpHitObjectReorderExecuteShaderEXT:
case spv::Op::OpHitObjectTraceReorderExecuteEXT:
case spv::Op::OpHitObjectTraceMotionReorderExecuteEXT:
case spv::Op::OpReorderThreadWithHintEXT:
case spv::Op::OpReorderThreadWithHitObjectEXT:
case spv::Op::OpHitObjectTraceRayEXT:
case spv::Op::OpHitObjectTraceRayMotionEXT:
case spv::Op::OpHitObjectRecordEmptyEXT:
case spv::Op::OpHitObjectExecuteShaderEXT:
case spv::Op::OpHitObjectGetCurrentTimeEXT:
case spv::Op::OpHitObjectGetAttributesEXT:
case spv::Op::OpHitObjectGetHitKindEXT:
case spv::Op::OpHitObjectGetPrimitiveIndexEXT:
case spv::Op::OpHitObjectGetGeometryIndexEXT:
case spv::Op::OpHitObjectGetInstanceIdEXT:
case spv::Op::OpHitObjectGetInstanceCustomIndexEXT:
case spv::Op::OpHitObjectGetObjectRayOriginEXT:
case spv::Op::OpHitObjectGetObjectRayDirectionEXT:
case spv::Op::OpHitObjectGetWorldRayDirectionEXT:
case spv::Op::OpHitObjectGetWorldRayOriginEXT:
case spv::Op::OpHitObjectGetObjectToWorldEXT:
case spv::Op::OpHitObjectGetWorldToObjectEXT:
case spv::Op::OpHitObjectGetRayTMaxEXT:
case spv::Op::OpHitObjectGetRayTMinEXT:
case spv::Op::OpHitObjectGetShaderBindingTableRecordIndexEXT:
case spv::Op::OpHitObjectGetShaderRecordBufferHandleEXT:
case spv::Op::OpHitObjectIsEmptyEXT:
case spv::Op::OpHitObjectIsHitEXT:
case spv::Op::OpHitObjectIsMissEXT:
// SPV_NV_raw_access_chains
case spv::Op::OpRawAccessChainNV:
// SPV_NV_cooperative_matrix2
case spv::Op::OpCooperativeMatrixLoadTensorNV:
case spv::Op::OpCooperativeMatrixStoreTensorNV:
// SPV_NV_cooperative_vector
case spv::Op::OpCooperativeVectorLoadNV:
case spv::Op::OpCooperativeVectorStoreNV:
case spv::Op::OpCooperativeVectorMatrixMulNV:
case spv::Op::OpCooperativeVectorMatrixMulAddNV:
case spv::Op::OpCooperativeVectorOuterProductAccumulateNV:
case spv::Op::OpCooperativeVectorReduceSumAccumulateNV:
// SPV_EXT_mesh_shader
case spv::Op::OpEmitMeshTasksEXT:
// SPV_AMD_shader_enqueue (spec bugs)
case spv::Op::OpEnqueueNodePayloadsAMDX:
case spv::Op::OpNodePayloadArrayLengthAMDX:
case spv::Op::OpIsNodePayloadValidAMDX:
case spv::Op::OpFinishWritingNodePayloadAMDX:
// SPV_ARM_graph
case spv::Op::OpGraphEntryPointARM:
return SPV_SUCCESS;
// The following cases require a variable pointer capability. Since all
// instructions are for variable pointers, the storage class and capability
// are also checked.
case spv::Op::OpReturnValue:
case spv::Op::OpPtrAccessChain:
case spv::Op::OpPtrEqual:
case spv::Op::OpPtrNotEqual:
case spv::Op::OpPtrDiff:
// Core spec bugs
case spv::Op::OpSelect:
case spv::Op::OpPhi:
case spv::Op::OpVariable:
// SPV_KHR_untyped_pointers
case spv::Op::OpUntypedPtrAccessChainKHR:
if ((_.HasCapability(spv::Capability::VariablePointersStorageBuffer) &&
sc == spv::StorageClass ::StorageBuffer) ||
(_.HasCapability(spv::Capability::VariablePointers) &&
sc == spv::StorageClass::Workgroup)) {
return SPV_SUCCESS;
}
return _.diag(SPV_ERROR_INVALID_DATA, inst)
<< "Instruction may only have a logical pointer operand in the "
"StorageBuffer or Workgroup storage classes with appropriate "
"variable pointers capability";
default:
if (spvOpcodeIsAtomicOp(inst->opcode())) {
return SPV_SUCCESS;
}
return _.diag(SPV_ERROR_INVALID_DATA, inst)
<< "Instruction may not have a logical pointer operand";
}
return SPV_SUCCESS;
}
spv_result_t ValidateLogicalPointerReturns(ValidationState_t& _,
const Instruction* inst) {
if (!IsLogicalPointer(_, inst)) {
return SPV_SUCCESS;
}
const auto type_inst = _.FindDef(inst->type_id());
const auto sc = type_inst->GetOperandAs<spv::StorageClass>(1u);
switch (inst->opcode()) {
// Core spec without an variable pointer capability.
case spv::Op::OpVariable:
case spv::Op::OpAccessChain:
case spv::Op::OpInBoundsAccessChain:
case spv::Op::OpFunctionParameter:
case spv::Op::OpImageTexelPointer:
case spv::Op::OpCopyObject:
// Core spec bugs
case spv::Op::OpUndef:
// SPV_KHR_untyped_pointers
case spv::Op::OpUntypedAccessChainKHR:
case spv::Op::OpUntypedInBoundsAccessChainKHR:
case spv::Op::OpUntypedVariableKHR:
// SPV_NV_raw_access_chains
case spv::Op::OpRawAccessChainNV:
// SPV_AMD_shader_enqueue (spec bugs)
case spv::Op::OpAllocateNodePayloadsAMDX:
return SPV_SUCCESS;
// Core spec with variable pointer capability. Check storage classes since
// variable pointers can only be in certain storage classes.
case spv::Op::OpSelect:
case spv::Op::OpPhi:
case spv::Op::OpFunctionCall:
case spv::Op::OpPtrAccessChain:
case spv::Op::OpLoad:
case spv::Op::OpConstantNull:
case spv::Op::OpFunction:
// SPV_KHR_untyped_pointers
case spv::Op::OpUntypedPtrAccessChainKHR:
if ((_.HasCapability(spv::Capability::VariablePointersStorageBuffer) &&
sc == spv::StorageClass ::StorageBuffer) ||
(_.HasCapability(spv::Capability::VariablePointers) &&
sc == spv::StorageClass::Workgroup)) {
return SPV_SUCCESS;
}
return _.diag(SPV_ERROR_INVALID_DATA, inst)
<< "Instruction may only return a logical pointer in the "
"StorageBuffer or Workgroup storage classes with appropriate "
"variable pointers capability";
default:
return _.diag(SPV_ERROR_INVALID_DATA, inst)
<< "Instruction may not return a logical pointer";
}
return SPV_SUCCESS;
}
spv_result_t IsBlockArray(ValidationState_t& _, const Instruction* type) {
if (type->opcode() == spv::Op::OpTypeArray ||
type->opcode() == spv::Op::OpTypeRuntimeArray) {
const auto element_type = _.FindDef(type->GetOperandAs<uint32_t>(1));
if (element_type->opcode() == spv::Op::OpTypeStruct &&
(_.HasDecoration(element_type->id(), spv::Decoration::Block) ||
_.HasDecoration(element_type->id(), spv::Decoration::BufferBlock))) {
return SPV_ERROR_INVALID_DATA;
}
}
return SPV_SUCCESS;
}
spv_result_t CheckMatrixElementTyped(ValidationState_t& _,
const Instruction* inst) {
switch (inst->opcode()) {
case spv::Op::OpAccessChain:
case spv::Op::OpInBoundsAccessChain:
case spv::Op::OpPtrAccessChain: {
// Get the type of the base operand.
uint32_t start_index =
inst->opcode() == spv::Op::OpPtrAccessChain ? 4 : 3;
const auto access_type_id = _.GetOperandTypeId(inst, 2);
auto access_type = _.FindDef(access_type_id);
access_type = _.FindDef(access_type->GetOperandAs<uint32_t>(2));
// If the base operand is a matrix, then it was definitely pointing to a
// sub-component.
if (access_type->opcode() == spv::Op::OpTypeMatrix) {
return _.diag(SPV_ERROR_INVALID_DATA, inst)
<< "Variable pointer must not point to a column or a "
"component of a column of a matrix";
}
// Otherwise, step through the indices to see if we pass a matrix.
for (uint32_t i = start_index; i < inst->operands().size(); ++i) {
const auto index = inst->GetOperandAs<uint32_t>(i);
if (access_type->opcode() == spv::Op::OpTypeStruct) {
uint64_t val = 0;
_.EvalConstantValUint64(index, &val);
access_type = _.FindDef(access_type->GetOperandAs<uint32_t>(
1 + static_cast<uint32_t>(val)));
} else {
access_type = _.FindDef(_.GetComponentType(access_type->id()));
}
if (access_type->opcode() == spv::Op::OpTypeMatrix) {
return _.diag(SPV_ERROR_INVALID_DATA, inst)
<< "Variable pointer must not point to a column or a "
"component of a column of a matrix";
}
}
break;
}
default:
break;
}
return SPV_SUCCESS;
}
spv_result_t CheckMatrixElementUntyped(ValidationState_t& _,
const Instruction* inst) {
switch (inst->opcode()) {
case spv::Op::OpAccessChain:
case spv::Op::OpInBoundsAccessChain:
case spv::Op::OpPtrAccessChain:
case spv::Op::OpUntypedAccessChainKHR:
case spv::Op::OpUntypedInBoundsAccessChainKHR:
case spv::Op::OpUntypedPtrAccessChainKHR: {
const bool untyped = spvOpcodeGeneratesUntypedPointer(inst->opcode());
uint32_t start_index;
Instruction* access_type = nullptr;
if (untyped) {
// Get the type of the base operand.
start_index =
inst->opcode() == spv::Op::OpUntypedPtrAccessChainKHR ? 5 : 4;
const auto access_type_id = inst->GetOperandAs<uint32_t>(2);
access_type = _.FindDef(access_type_id);
} else {
start_index = inst->opcode() == spv::Op::OpPtrAccessChain ? 4 : 3;
const auto access_type_id = _.GetOperandTypeId(inst, 2);
access_type = _.FindDef(access_type_id);
access_type = _.FindDef(access_type->GetOperandAs<uint32_t>(2));
}
// If the base operand is a matrix, then it was definitely pointing to a
// sub-component.
if (access_type->opcode() == spv::Op::OpTypeMatrix) {
return _.diag(SPV_ERROR_INVALID_DATA, inst)
<< "Variable pointer must not point to a column or a "
"component of a column of a matrix.";
}
// Otherwise, step through the indices to see if we pass a matrix.
for (uint32_t i = start_index; i < inst->operands().size(); ++i) {
const auto index = inst->GetOperandAs<uint32_t>(i);
if (access_type->opcode() == spv::Op::OpTypeStruct) {
uint64_t val = 0;
_.EvalConstantValUint64(index, &val);
access_type = _.FindDef(access_type->GetOperandAs<uint32_t>(
1 + static_cast<uint32_t>(val)));
} else {
access_type = _.FindDef(_.GetComponentType(access_type->id()));
}
if (access_type->opcode() == spv::Op::OpTypeMatrix) {
return _.diag(SPV_ERROR_INVALID_DATA, inst)
<< "Variable pointer must not point to a column or a "
"component of a column of a matrix.";
}
}
break;
}
default:
break;
}
return SPV_SUCCESS;
}
// Traces the variable pointer inst backwards.
// checker is called on each visited instruction.
spv_result_t TraceVariablePointers(
ValidationState_t& _, const Instruction* inst,
const std::function<spv_result_t(ValidationState_t&, const Instruction*)>&
checker) {
std::vector<const Instruction*> stack;
std::unordered_set<const Instruction*> seen;
stack.push_back(inst);
while (!stack.empty()) {
const Instruction* trace_inst = stack.back();
stack.pop_back();
if (!seen.insert(trace_inst).second) {
continue;
}
if (auto error = checker(_, trace_inst)) {
return error;
}
const auto untyped = spvOpcodeGeneratesUntypedPointer(trace_inst->opcode());
switch (trace_inst->opcode()) {
case spv::Op::OpAccessChain:
case spv::Op::OpInBoundsAccessChain:
case spv::Op::OpPtrAccessChain:
stack.push_back(_.FindDef(trace_inst->GetOperandAs<uint32_t>(2)));
break;
case spv::Op::OpUntypedAccessChainKHR:
case spv::Op::OpUntypedInBoundsAccessChainKHR:
case spv::Op::OpUntypedPtrAccessChainKHR:
stack.push_back(_.FindDef(trace_inst->GetOperandAs<uint32_t>(3)));
break;
case spv::Op::OpPhi:
for (uint32_t i = 2; i < trace_inst->operands().size(); i += 2) {
stack.push_back(_.FindDef(trace_inst->GetOperandAs<uint32_t>(i)));
}
break;
case spv::Op::OpSelect:
stack.push_back(_.FindDef(trace_inst->GetOperandAs<uint32_t>(3)));
stack.push_back(_.FindDef(trace_inst->GetOperandAs<uint32_t>(4)));
break;
case spv::Op::OpFunctionParameter: {
// Jump to function calls
auto func = trace_inst->function();
auto func_inst = _.FindDef(func->id());
const auto param_inst_num = trace_inst - &_.ordered_instructions()[0];
uint32_t param_index = 0;
uint32_t inst_index = 1;
while (_.ordered_instructions()[param_inst_num - inst_index].opcode() !=
spv::Op::OpFunction) {
if (_.ordered_instructions()[param_inst_num - inst_index].opcode() ==
spv::Op::OpFunctionParameter) {
param_index++;
}
++inst_index;
}
for (const auto& use_pair : func_inst->uses()) {
const auto use_inst = use_pair.first;
if (use_inst->opcode() == spv::Op::OpFunctionCall) {
const auto arg_id =
use_inst->GetOperandAs<uint32_t>(3 + param_index);
const auto arg_inst = _.FindDef(arg_id);
stack.push_back(arg_inst);
}
}
break;
}
case spv::Op::OpFunctionCall: {
// Jump to return values.
const auto* func = _.function(trace_inst->GetOperandAs<uint32_t>(2));
for (auto* bb : func->ordered_blocks()) {
const auto* terminator = bb->terminator();
if (terminator->opcode() == spv::Op::OpReturnValue) {
stack.push_back(terminator);
}
}
break;
}
case spv::Op::OpReturnValue:
stack.push_back(_.FindDef(trace_inst->GetOperandAs<uint32_t>(0)));
break;
case spv::Op::OpCopyObject:
stack.push_back(_.FindDef(trace_inst->GetOperandAs<uint32_t>(2)));
break;
case spv::Op::OpLoad:
stack.push_back(_.FindDef(trace_inst->GetOperandAs<uint32_t>(2)));
break;
case spv::Op::OpStore:
stack.push_back(_.FindDef(trace_inst->GetOperandAs<uint32_t>(0)));
break;
case spv::Op::OpVariable:
case spv::Op::OpUntypedVariableKHR: {
const auto sc = trace_inst->GetOperandAs<spv::StorageClass>(2);
if (sc == spv::StorageClass::Function ||
sc == spv::StorageClass::Private) {
// Add the initializer
const uint32_t init_operand = untyped ? 4 : 3;
if (trace_inst->operands().size() > init_operand) {
stack.push_back(
_.FindDef(trace_inst->GetOperandAs<uint32_t>(init_operand)));
}
// Jump to stores
std::vector<std::pair<const Instruction*, uint32_t>> store_stack(
trace_inst->uses());
std::unordered_set<const Instruction*> store_seen;
while (!store_stack.empty()) {
const auto& use = store_stack.back();
store_stack.pop_back();
if (!store_seen.insert(use.first).second) {
continue;
}
// If the use is a store pointer, trace the store object.
// Note: use.second is a word index.
if (use.first->opcode() == spv::Op::OpStore && use.second == 1) {
stack.push_back(_.FindDef(use.first->GetOperandAs<uint32_t>(1)));
} else {
// Most likely a gep so keep tracing.
for (auto& next_use : use.first->uses()) {
store_stack.push_back(next_use);
}
}
}
}
break;
}
default:
break;
}
}
return SPV_SUCCESS;
}
// Traces the variable pointer inst backwards, but only unmodified pointers.
// checker is called on each visited instruction.
spv_result_t TraceUnmodifiedVariablePointers(
ValidationState_t& _, const Instruction* inst,
const std::function<spv_result_t(ValidationState_t&, const Instruction*)>&
checker) {
std::vector<const Instruction*> stack;
std::unordered_set<const Instruction*> seen;
stack.push_back(inst);
while (!stack.empty()) {
const Instruction* trace_inst = stack.back();
stack.pop_back();
if (!seen.insert(trace_inst).second) {
continue;
}
if (auto error = checker(_, trace_inst)) {
return error;
}
const auto untyped = spvOpcodeGeneratesUntypedPointer(trace_inst->opcode());
switch (trace_inst->opcode()) {
case spv::Op::OpAccessChain:
case spv::Op::OpInBoundsAccessChain:
if (trace_inst->operands().size() == 2) {
stack.push_back(_.FindDef(trace_inst->GetOperandAs<uint32_t>(2)));
}
break;
case spv::Op::OpUntypedAccessChainKHR:
case spv::Op::OpUntypedInBoundsAccessChainKHR:
case spv::Op::OpUntypedPtrAccessChainKHR:
if (trace_inst->operands().size() == 3) {
stack.push_back(_.FindDef(trace_inst->GetOperandAs<uint32_t>(3)));
}
break;
case spv::Op::OpPhi:
for (uint32_t i = 2; i < trace_inst->operands().size(); i += 2) {
stack.push_back(_.FindDef(trace_inst->GetOperandAs<uint32_t>(i)));
}
break;
case spv::Op::OpSelect:
stack.push_back(_.FindDef(trace_inst->GetOperandAs<uint32_t>(3)));
stack.push_back(_.FindDef(trace_inst->GetOperandAs<uint32_t>(4)));
break;
case spv::Op::OpFunctionParameter: {
// Jump to function calls
auto func = trace_inst->function();
auto func_inst = _.FindDef(func->id());
const auto param_inst_num = trace_inst - &_.ordered_instructions()[0];
uint32_t param_index = 0;
uint32_t inst_index = 1;
while (_.ordered_instructions()[param_inst_num - inst_index].opcode() !=
spv::Op::OpFunction) {
if (_.ordered_instructions()[param_inst_num - inst_index].opcode() ==
spv::Op::OpFunctionParameter) {
param_index++;
}
++inst_index;
}
for (const auto& use_pair : func_inst->uses()) {
const auto use_inst = use_pair.first;
if (use_inst->opcode() == spv::Op::OpFunctionCall) {
const auto arg_id =
use_inst->GetOperandAs<uint32_t>(3 + param_index);
const auto arg_inst = _.FindDef(arg_id);
stack.push_back(arg_inst);
}
}
break;
}
case spv::Op::OpFunctionCall: {
// Jump to return values.
const auto* func = _.function(trace_inst->GetOperandAs<uint32_t>(2));
for (auto* bb : func->ordered_blocks()) {
const auto* terminator = bb->terminator();
if (terminator->opcode() == spv::Op::OpReturnValue) {
stack.push_back(terminator);
}
}
break;
}
case spv::Op::OpReturnValue:
stack.push_back(_.FindDef(trace_inst->GetOperandAs<uint32_t>(0)));
break;
case spv::Op::OpCopyObject:
stack.push_back(_.FindDef(trace_inst->GetOperandAs<uint32_t>(2)));
break;
case spv::Op::OpLoad:
stack.push_back(_.FindDef(trace_inst->GetOperandAs<uint32_t>(2)));
break;
case spv::Op::OpStore:
stack.push_back(_.FindDef(trace_inst->GetOperandAs<uint32_t>(0)));
break;
case spv::Op::OpVariable:
case spv::Op::OpUntypedVariableKHR: {
const auto sc = trace_inst->GetOperandAs<spv::StorageClass>(2);
if (sc == spv::StorageClass::Function ||
sc == spv::StorageClass::Private) {
// Add the initializer
const uint32_t init_operand = untyped ? 4 : 3;
if (trace_inst->operands().size() > init_operand) {
stack.push_back(
_.FindDef(trace_inst->GetOperandAs<uint32_t>(init_operand)));
}
// Jump to stores
std::vector<std::pair<const Instruction*, uint32_t>> store_stack(
trace_inst->uses());
std::unordered_set<const Instruction*> store_seen;
while (!store_stack.empty()) {
const auto& use = store_stack.back();
store_stack.pop_back();
if (!store_seen.insert(use.first).second) {
continue;
}
// If the use is a store pointer, trace the store object.
// Note: use.second is a word index.
if (use.first->opcode() == spv::Op::OpStore && use.second == 1) {
stack.push_back(_.FindDef(use.first->GetOperandAs<uint32_t>(1)));
} else {
// Most likely a gep so keep tracing.
for (auto& next_use : use.first->uses()) {
store_stack.push_back(next_use);
}
}
}
}
break;
}
default:
break;
}
}
return SPV_SUCCESS;
}
spv_result_t ValidateVariablePointers(
ValidationState_t& _, std::unordered_map<uint32_t, bool>& variable_pointers,
const Instruction* inst) {
// Variable pointers cannot be operands to array length.
if (inst->opcode() == spv::Op::OpArrayLength ||
inst->opcode() == spv::Op::OpUntypedArrayLengthKHR) {
const auto ptr_index = inst->opcode() == spv::Op::OpArrayLength ? 2 : 3;
const auto ptr_id = inst->GetOperandAs<uint32_t>(ptr_index);
const auto ptr_inst = _.FindDef(ptr_id);
if (IsVariablePointer(_, variable_pointers, ptr_inst)) {
return _.diag(SPV_ERROR_INVALID_DATA, inst)
<< "Pointer operand must not be a variable pointer";
}
return SPV_SUCCESS;
}
// Check untyped loads and stores of variable pointers for matrix types.
// Neither instruction would be a variable pointer in a such a case.
if (inst->opcode() == spv::Op::OpLoad) {
const auto pointer = _.FindDef(inst->GetOperandAs<uint32_t>(2));
const auto pointer_type = _.FindDef(pointer->type_id());
if (pointer_type->opcode() == spv::Op::OpTypeUntypedPointerKHR &&
IsVariablePointer(_, variable_pointers, pointer)) {
const auto data_type = _.FindDef(inst->type_id());
if (_.ContainsType(
data_type->id(),
[](const Instruction* type_inst) {
return type_inst->opcode() == spv::Op::OpTypeMatrix;
},
/* traverse_all_types = */ false)) {
return _.diag(SPV_ERROR_INVALID_DATA, inst)
<< "Variable pointer must not point to an object that is or "
"contains a matrix";
}
}
} else if (inst->opcode() == spv::Op::OpStore) {
const auto pointer = _.FindDef(inst->GetOperandAs<uint32_t>(0));
const auto pointer_type = _.FindDef(pointer->type_id());
if (pointer_type->opcode() == spv::Op::OpTypeUntypedPointerKHR &&
IsVariablePointer(_, variable_pointers, pointer)) {
const auto data_type_id = _.GetOperandTypeId(inst, 1);
const auto data_type = _.FindDef(data_type_id);
if (_.ContainsType(
data_type->id(),
[](const Instruction* type_inst) {
return type_inst->opcode() == spv::Op::OpTypeMatrix;
},
/* traverse_all_types = */ false)) {
return _.diag(SPV_ERROR_INVALID_DATA, inst)
<< "Variable pointer must not point to an object that is or "
"contains a matrix";
}
}
}
if (!IsLogicalPointer(_, inst) ||
!IsVariablePointer(_, variable_pointers, inst)) {
return SPV_SUCCESS;
}
const auto result_type = _.FindDef(inst->type_id());
const auto untyped =
result_type->opcode() == spv::Op::OpTypeUntypedPointerKHR;
// Pointers must be selected from the same buffer unless the VariablePointers
// capability is declared.
if (!_.HasCapability(spv::Capability::VariablePointers) &&
(inst->opcode() == spv::Op::OpSelect ||
inst->opcode() == spv::Op::OpPhi)) {
std::unordered_set<const Instruction*> sources;
const auto checker = [&sources, &inst](
ValidationState_t& vstate,
const Instruction* check_inst) -> spv_result_t {
switch (check_inst->opcode()) {
case spv::Op::OpVariable:
case spv::Op::OpUntypedVariableKHR:
if (check_inst->GetOperandAs<spv::StorageClass>(2) ==
spv::StorageClass::StorageBuffer ||
check_inst->GetOperandAs<spv::StorageClass>(2) ==
spv::StorageClass::Workgroup) {
sources.insert(check_inst);
}
if (sources.size() > 1) {
return vstate.diag(SPV_ERROR_INVALID_DATA, inst)
<< "Variable pointers must point into the same structure "
"(or OpConstantNull)";
}
break;
default:
break;
}
return SPV_SUCCESS;
};
if (auto error = TraceVariablePointers(_, inst, checker)) {
return error;
}
}
// Variable pointers must not:
// * point to array of Block- or BufferBlock-decorated structs
// * point to an object that is or contains a matrix
// * point to a column, or component in a column, of a matrix
if (untyped) {
if (auto error =
TraceVariablePointers(_, inst, CheckMatrixElementUntyped)) {
return error;
}
// Block arrays can only really appear as the top most type so only look at
// unmodified pointers to determine if one is used.
const auto num_operands = inst->operands().size();
if (!(num_operands == 3 &&
(inst->opcode() == spv::Op::OpUntypedAccessChainKHR ||
inst->opcode() == spv::Op::OpUntypedInBoundsAccessChainKHR ||
inst->opcode() == spv::Op::OpUntypedPtrAccessChainKHR))) {
const auto checker = [&inst](
ValidationState_t& vstate,
const Instruction* check_inst) -> spv_result_t {
bool fail = false;
if (check_inst->opcode() == spv::Op::OpUntypedVariableKHR) {
if (check_inst->operands().size() > 3) {
const auto type =
vstate.FindDef(check_inst->GetOperandAs<uint32_t>(3));
fail = IsBlockArray(vstate, type);
}
} else if (check_inst->opcode() == spv::Op::OpVariable) {
const auto res_type = vstate.FindDef(check_inst->type_id());
const auto pointee_type =
vstate.FindDef(res_type->GetOperandAs<uint32_t>(2));
fail = IsBlockArray(vstate, pointee_type);
}
if (fail) {
return vstate.diag(SPV_ERROR_INVALID_DATA, inst)
<< "Variable pointer must not point to an array of Block- or "
"BufferBlock-decorated structs";
}
return SPV_SUCCESS;
};
if (auto error = TraceUnmodifiedVariablePointers(_, inst, checker)) {
return error;
}
}
} else {
const auto pointee_type = _.FindDef(result_type->GetOperandAs<uint32_t>(2));
if (IsBlockArray(_, pointee_type)) {
return _.diag(SPV_ERROR_INVALID_DATA, inst)
<< "Variable pointer must not point to an array of Block- or "
"BufferBlock-decorated structs";
} else if (_.ContainsType(
pointee_type->id(),
[](const Instruction* type_inst) {
return type_inst->opcode() == spv::Op::OpTypeMatrix;
},
/* traverse_all_types = */ false)) {
return _.diag(SPV_ERROR_INVALID_DATA, inst)
<< "Variable pointer must not point to an object that is or "
"contains a matrix";
} else if (_.IsFloatScalarOrVectorType(pointee_type->id())) {
// Pointing to a column or component in a column is trickier to detect.
// Trace backwards and check encountered access chains to determine if
// this pointer is pointing into a matrix.
if (auto error =
TraceVariablePointers(_, inst, CheckMatrixElementTyped)) {
return error;
}
}
}
return SPV_SUCCESS;
}
} // namespace
spv_result_t ValidateLogicalPointers(ValidationState_t& _) {
// Only the following addressing models have logical pointers.
if (_.addressing_model() != spv::AddressingModel::Logical &&
_.addressing_model() != spv::AddressingModel::PhysicalStorageBuffer64) {
return SPV_SUCCESS;
}
if (_.options()->relax_logical_pointer) {
return SPV_SUCCESS;
}
// Cache all variable pointers
std::unordered_map<uint32_t, bool> variable_pointers;
for (auto& inst : _.ordered_instructions()) {
if (!IsLogicalPointer(_, &inst)) {
continue;
}
IsVariablePointer(_, variable_pointers, &inst);
}
for (auto& inst : _.ordered_instructions()) {
if (auto error = ValidateLogicalPointerOperands(_, &inst)) {
return error;
}
if (auto error = ValidateLogicalPointerReturns(_, &inst)) {
return error;
}
if (auto error = ValidateVariablePointers(_, variable_pointers, &inst)) {
return error;
}
}
return SPV_SUCCESS;
}
} // namespace val
} // namespace spvtools
|
