1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511
|
"""The Test file for CLI (General)."""
import json
import logging
import os
import pathlib
import re
import shutil
import stat
import subprocess
import sys
import tempfile
import textwrap
from unittest.mock import MagicMock, patch
import chardet
# Testing libraries
import pytest
import yaml
from click.testing import CliRunner
# We import the library directly here to get the version
import sqlfluff
from sqlfluff.cli.commands import (
cli_format,
dialects,
fix,
get_config,
lint,
parse,
render,
rules,
version,
)
from sqlfluff.utils.testing.cli import invoke_assert_code
# tomllib is only in the stdlib from 3.11+
if sys.version_info >= (3, 11):
import tomllib
else: # pragma: no cover
import tomli as tomllib
re_ansi_escape = re.compile(r"\x1b[^m]*m")
@pytest.fixture(autouse=True)
def logging_cleanup():
"""This gracefully handles logging issues at session teardown.
Removes handlers from all loggers. Autouse applies this to all
tests in this file (i.e. all the cli command tests), which should
be all of the test cases where `set_logging_level` is called.
https://github.com/sqlfluff/sqlfluff/issues/3702
https://github.com/pytest-dev/pytest/issues/5502#issuecomment-1190557648
"""
yield
# NOTE: This is a teardown function so the clearup code
# comes _after_ the yield.
# Get only the sqlfluff loggers (which we set in set_logging_level)
loggers = [
logger
for logger in logging.Logger.manager.loggerDict.values()
if isinstance(logger, logging.Logger) and logger.name.startswith("sqlfluff")
]
for logger in loggers:
if not hasattr(logger, "handlers"):
continue
for handler in logger.handlers[:]:
logger.removeHandler(handler)
def contains_ansi_escape(s: str) -> bool:
"""Does the string contain ANSI escape codes (e.g. color)?"""
return re_ansi_escape.search(s) is not None
expected_output = """== [test/fixtures/linter/indentation_error_simple.sql] FAIL
L: 2 | P: 1 | LT02 | Expected indent of 4 spaces. [layout.indent]
L: 5 | P: 10 | CP01 | Keywords must be consistently upper case.
| [capitalisation.keywords]
"""
def test__cli__command_directed():
"""Basic checking of lint functionality."""
result = invoke_assert_code(
ret_code=1,
args=[
lint,
[
"--disable-progress-bar",
"test/fixtures/linter/indentation_error_simple.sql",
],
],
)
# We should get a readout of what the error was
check_a = "L: 2 | P: 1 | LT02"
# NB: Skip the number at the end because it's configurable
check_b = "ndentation"
assert check_a in result.stdout
assert check_b in result.stdout
# Finally check the WHOLE output to make sure that unexpected newlines are not
# added. The replace command just accounts for cross platform testing.
assert result.stdout.replace("\\", "/").startswith(expected_output)
def test__cli__command_dialect():
"""Check the script raises the right exception on an unknown dialect."""
# The dialect is unknown should be a non-zero exit code
invoke_assert_code(
ret_code=2,
args=[
lint,
[
"-n",
"--dialect",
"faslkjh",
"test/fixtures/linter/indentation_error_simple.sql",
],
],
)
@pytest.mark.parametrize(
"command",
[
render,
parse,
lint,
cli_format,
fix,
],
)
def test__cli__command_no_dialect(command):
"""Check the script raises the right exception no dialect."""
# The dialect is unknown should be a non-zero exit code
result = invoke_assert_code(
ret_code=2,
args=[
command,
["-"],
],
cli_input="SELECT 1",
)
assert "User Error" in result.stderr
assert "No dialect was specified" in result.stderr
# No traceback should be in the output
assert "Traceback (most recent call last)" not in result.stderr
@pytest.mark.parametrize(
"command",
[
parse,
lint,
cli_format,
fix,
],
)
def test__cli__command_no_dialect_stdin_filename_inline_dialect(command):
"""Check the script runs with no dialect but has an inline configuration."""
# The dialect is unknown should be a non-zero exit code
result = invoke_assert_code(
ret_code=0,
args=[
command,
["--stdin-filename", "test.sql", "-"],
],
cli_input="-- sqlfluff:dialect:ansi\nSELECT 1\n",
)
assert "User Error" not in result.stderr
assert "No dialect was specified" not in result.stderr
# No traceback should be in the output
assert "Traceback (most recent call last)" not in result.stderr
def test__cli__command_parse_error_dialect_explicit_warning():
"""Check parsing error raises the right warning."""
# For any parsing error there should be a non-zero exit code
# and a human-readable warning should be displayed.
# Dialect specified as commandline option.
invoke_assert_code(
ret_code=1,
args=[
parse,
[
"-n",
"--dialect",
"postgres",
"test/fixtures/cli/fail_many.sql",
],
],
assert_stdout_contains=(
"WARNING: Parsing errors found and dialect is set to 'postgres'. "
"Have you configured your dialect correctly?"
),
)
def test__cli__command_parse_error_dialect_implicit_warning():
"""Check parsing error raises the right warning."""
# For any parsing error there should be a non-zero exit code
# and a human-readable warning should be displayed.
# Dialect specified in .sqlfluff config.
invoke_assert_code(
ret_code=1,
args=[
# Config sets dialect to tsql
parse,
[
"-n",
"--config",
"test/fixtures/cli/extra_configs/.sqlfluff",
"test/fixtures/cli/fail_many.sql",
],
],
assert_stdout_contains=(
"WARNING: Parsing errors found and dialect is set to 'tsql'. "
"Have you configured your dialect correctly?"
),
)
def test__cli__command_dialect_legacy():
"""Check the script raises the right exception on a legacy dialect."""
invoke_assert_code(
ret_code=2,
args=[
lint,
[
"-n",
"--dialect",
"exasol_fs",
"test/fixtures/linter/indentation_error_simple.sql",
],
],
assert_stdout_contains="Please use the 'exasol' dialect instead.",
)
def test__cli__command_extra_config_fail():
"""Check the script raises the right exception non-existent extra config path."""
invoke_assert_code(
ret_code=2,
args=[
lint,
[
"--config",
"test/fixtures/cli/extra_configs/.sqlfluffsdfdfdfsfd",
"test/fixtures/cli/extra_config_tsql.sql",
],
],
assert_stdout_contains=(
"Extra config path 'test/fixtures/cli/extra_configs/.sqlfluffsdfdfdfsfd' "
"does not exist."
),
)
stdin_cli_input = (
"SELECT\n A.COL1,\n B.COL2\nFROM TABA AS A\nPOSITIONAL JOIN TABB AS B;\n"
)
@pytest.mark.parametrize(
("command", "stdin_filepath", "ret_code", "stdout", "stderr"),
[
(
parse,
"test/fixtures/cli/stdin_filename/without_config/stdin_filename.sql",
0,
(
"[L: 5, P: 1] | join_clause:\n"
"[L: 5, P: 1] | keyword:"
" 'POSITIONAL'"
),
"",
),
(
parse,
"test/fixtures/an_ansi_config_here.sql",
1,
"Parsing errors found and dialect is set to 'ansi'.",
"",
),
(
lint,
"test/fixtures/cli/stdin_filename/stdin_filename.sql",
0,
"All Finished!",
"",
),
(
lint,
"test/fixtures/cli/stdin_filename/without_config/stdin_filename.sql",
0,
"All Finished!",
"",
),
(
lint,
"test/fixtures/an_ansi_config_here.sql",
1,
"Parsing errors found and dialect is set to 'ansi'.",
"",
),
(
lint,
"test/fixtures/cli/stdin_filename/ignored.sql",
0,
"re-run with `--disregard-sqlfluffignores`",
"",
),
(
cli_format,
"test/fixtures/cli/stdin_filename/stdin_filename.sql",
0,
stdin_cli_input,
"",
),
(
cli_format,
"test/fixtures/cli/stdin_filename/without_config/stdin_filename.sql",
0,
stdin_cli_input,
"",
),
(
cli_format,
"test/fixtures/an_ansi_config_here.sql",
1,
"",
"[1 templating/parsing errors found]",
),
(
cli_format,
"test/fixtures/cli/stdin_filename/ignored.sql",
0,
stdin_cli_input,
"re-run with `--disregard-sqlfluffignores`",
),
(
fix,
"test/fixtures/cli/stdin_filename/stdin_filename.sql",
0,
stdin_cli_input,
"",
),
(
fix,
"test/fixtures/cli/stdin_filename/without_config/stdin_filename.sql",
0,
stdin_cli_input,
"",
),
(
fix,
"test/fixtures/an_ansi_config_here.sql",
1,
"",
"Unfixable violations detected.",
),
(
fix,
"test/fixtures/cli/stdin_filename/ignored.sql",
0,
stdin_cli_input,
"re-run with `--disregard-sqlfluffignores`",
),
],
)
def test__cli__command_stdin_filename_config(
command, stdin_filepath, ret_code, stdout, stderr
):
"""Check the script picks up the config from the indicated path."""
invoke_assert_code(
ret_code=ret_code,
args=[
command,
[
"--stdin-filename",
stdin_filepath,
"-",
],
],
cli_input=stdin_cli_input,
assert_stdout_contains=stdout,
assert_stderr_contains=stderr,
)
@pytest.mark.parametrize(
"command",
[
(
"-",
"-n",
),
(
"-",
"-n",
"-v",
),
(
"-",
"-n",
"-vv",
),
(
"-",
"-vv",
),
],
)
def test__cli__command_lint_stdin(command):
"""Check basic commands on a simple script using stdin.
The subprocess command should exit without errors, as no issues should be found.
"""
with open("test/fixtures/cli/passing_a.sql") as test_file:
sql = test_file.read()
invoke_assert_code(args=[lint, ("--dialect=ansi",) + command], cli_input=sql)
def test__cli__command_lint_empty_stdin():
"""Check linting an empty file raises no exceptions.
https://github.com/sqlfluff/sqlfluff/issues/4807
"""
invoke_assert_code(args=[lint, ("-d", "ansi", "-")], cli_input="")
def test__cli__command_render_stdin():
"""Check render on a simple script using stdin."""
with open("test/fixtures/cli/passing_a.sql") as test_file:
sql = test_file.read()
invoke_assert_code(
args=[render, ("--dialect=ansi", "-")],
cli_input=sql,
# Check we get back out the same file we input.
assert_stdout_contains=sql,
)
@pytest.mark.parametrize(
"command",
[
# Test basic linting
(
lint,
[
"-n",
"test/fixtures/cli/passing_b.sql",
"--exclude-rules",
"AM05",
],
),
# Basic render
(
render,
[
"test/fixtures/cli/passing_b.sql",
],
),
# Render with variants
(
render,
[
"test/fixtures/cli/jinja_variants.sql",
],
),
# Original tests from test__cli__command_lint
(lint, ["-n", "test/fixtures/cli/passing_a.sql"]),
(lint, ["-n", "-v", "test/fixtures/cli/passing_a.sql"]),
(lint, ["-n", "-vvvv", "test/fixtures/cli/passing_a.sql"]),
(lint, ["-vvvv", "test/fixtures/cli/passing_a.sql"]),
# Test basic linting with very high verbosity
(
lint,
[
"-n",
"test/fixtures/cli/passing_b.sql",
"-vvvvvvvvvvv",
"--exclude-rules",
"AM05",
],
),
# Test basic linting with specific logger.
# Also test short rule exclusion.
(
lint,
[
"-n",
"test/fixtures/cli/passing_b.sql",
"-vvv",
"--logger",
"parser",
"-e",
"AM05",
],
),
# Check basic parsing
(
parse,
[
"-n",
"test/fixtures/cli/passing_b.sql",
"--exclude-rules",
"AM05",
],
),
# Test basic parsing with very high verbosity
(
parse,
[
"-n",
"test/fixtures/cli/passing_b.sql",
"-vvvvvvvvvvv",
"-e",
"AM05",
],
),
# Check basic parsing, with the code only option
(parse, ["-n", "test/fixtures/cli/passing_b.sql", "-c"]),
# Check basic parsing, with the yaml output
(parse, ["-n", "test/fixtures/cli/passing_b.sql", "-c", "--format", "yaml"]),
(parse, ["-n", "test/fixtures/cli/passing_b.sql", "--format", "yaml"]),
# Check parsing with no output (used mostly for testing)
(parse, ["-n", "test/fixtures/cli/passing_b.sql", "--format", "none"]),
# Parsing with variants
(
parse,
[
"test/fixtures/cli/jinja_variants.sql",
],
),
# Check the benching commands
(parse, ["-n", "test/fixtures/cli/passing_timing.sql", "--bench"]),
(lint, ["-n", "test/fixtures/cli/passing_timing.sql", "--bench"]),
(fix, ["-n", "test/fixtures/cli/passing_timing.sql", "--bench"]),
# Check linting works in specifying rules
(
lint,
[
"-n",
"--rules",
"CP01",
"test/fixtures/linter/operator_errors.sql",
],
),
# Check ignoring linting (multiprocess)
# https://github.com/sqlfluff/sqlfluff/issues/5066
(
lint,
[
"-n",
"--ignore",
"linting",
"-p",
"2",
"test/fixtures/linter/operator_errors.sql",
"test/fixtures/linter/comma_errors.sql",
],
),
# Check linting works in specifying multiple rules
(
lint,
[
"-n",
"--rules",
"CP01,LT02",
"test/fixtures/linter/operator_errors.sql",
],
),
# Check linting works with both included and excluded rules
(
lint,
[
"-n",
"--rules",
"CP01,LT01",
"--exclude-rules",
"LT01,AL07",
"test/fixtures/linter/operator_errors.sql",
],
),
# Check linting works with just excluded rules
(
lint,
[
"-n",
"--exclude-rules",
"LT01,LT03,AL07",
"test/fixtures/linter/operator_errors.sql",
],
),
# Check that ignoring works (also checks that unicode files parse).
(
lint,
[
"-n",
"--exclude-rules",
"LT02,LT12,AL07",
"--ignore",
"parsing,lexing",
"test/fixtures/linter/parse_lex_error.sql",
],
),
# Check nofail works
(lint, ["--nofail", "test/fixtures/linter/parse_lex_error.sql"]),
# Check config works (sets dialect to tsql)
(
lint,
[
"--config",
"test/fixtures/cli/extra_configs/.sqlfluff",
"test/fixtures/cli/extra_config_tsql.sql",
],
),
(
lint,
[
"--config",
"test/fixtures/cli/extra_configs/pyproject.toml",
"test/fixtures/cli/extra_config_tsql.sql",
],
),
# Check timing outputs doesn't raise exceptions
(lint, ["test/fixtures/cli/passing_a.sql", "--persist-timing", "test.csv"]),
# Check lint --help command doesn't raise exception.
# NOTE: This tests the LazySequence in action.
(lint, ["--help"]),
],
)
def test__cli__command_lint_parse(command):
"""Check basic commands on a more complicated script."""
invoke_assert_code(args=command)
@pytest.mark.parametrize(
"command, ret_code",
[
# Check the script doesn't raise an unexpected exception with badly formed
# files.
(
(
fix,
[
"--rules",
"LT01",
"test/fixtures/cli/fail_many.sql",
"-vvvvvvv",
],
),
1,
),
# Fix with a suffixs
(
(
fix,
[
"--rules",
"LT01",
"--fixed-suffix",
"_fix",
"test/fixtures/cli/fail_many.sql",
],
),
1,
),
# Fix without specifying rules
(
(
fix,
[
"--fixed-suffix",
"_fix",
"test/fixtures/cli/fail_many.sql",
],
),
1,
),
# Format
(
(
cli_format,
[
"--fixed-suffix",
"_fix",
"test/fixtures/linter/whitespace_errors.sql",
],
),
0,
),
# Format with --persist-timing
(
(
cli_format,
[
"--fixed-suffix",
"_fix",
"test/fixtures/linter/whitespace_errors.sql",
"--persist-timing",
"test.csv",
],
),
0,
),
# Format (specifying rules)
(
(
cli_format,
[
"--rules",
"LT01",
"--fixed-suffix",
"_fix",
"test/fixtures/linter/whitespace_errors.sql",
],
),
2,
),
# Template syntax error in macro file
(
(
lint,
["test/fixtures/cli/unknown_jinja_tag/test.sql"],
),
1,
),
# Test overriding library path when it doesn't cause an issue
(
(
lint,
["test/fixtures/cli/passing_a.sql", "--library-path", "none"],
),
0,
),
# Test overriding library path when it DOES cause an issue
# (because macros won't be found).
(
(
# Render because that's the step where the issue will
# occur.
render,
[
"test/fixtures/templater/jinja_r_library_in_macro/jinja.sql",
"--library-path",
"none",
],
),
1,
),
# Test render fail
(
(
render,
["test/fixtures/cli/fail_many.sql"],
),
1,
),
# Test a longer lint fail with --bench
# This tests the threshold rules clause
(
(
lint,
[
"test/fixtures/linter/autofix/bigquery/004_templating/before.sql",
"--bench",
],
),
1,
),
# Test that setting --quiet with --verbose raises an error.
(
(
fix,
[
"--quiet",
"--verbose",
"test/fixtures/cli/fail_many.sql",
],
),
2,
),
# Test machine format parse command with an unparsable file.
(
(
parse,
["test/fixtures/linter/parse_lex_error.sql", "-f", "yaml"],
),
1,
),
# Test machine format parse command with a fatal templating error.
(
(
parse,
["test/fixtures/cli/jinja_fatal_fail.sql", "-f", "yaml"],
),
1,
),
],
)
def test__cli__command_lint_parse_with_retcode(command, ret_code):
"""Check commands expecting a non-zero ret code."""
invoke_assert_code(ret_code=ret_code, args=command)
def test__cli__command_lint_warning_explicit_file_ignored():
"""Check ignoring file works when file is in an ignore directory."""
runner = CliRunner()
result = runner.invoke(
lint, ["test/fixtures/linter/sqlfluffignore/path_b/query_c.sql"]
)
assert result.exit_code == 0
assert (
"Exact file path test/fixtures/linter/sqlfluffignore/path_b/query_c.sql "
"was given but it was ignored"
) in result.stdout.strip()
def test__cli__command_lint_skip_ignore_files():
"""Check "ignore file" is skipped when --disregard-sqlfluffignores flag is set."""
runner = CliRunner()
result = runner.invoke(
lint,
[
"test/fixtures/linter/sqlfluffignore/path_b/query_c.sql",
"--disregard-sqlfluffignores",
],
)
assert result.exit_code == 1
assert "LT12" in result.stdout.strip()
@pytest.mark.parametrize(
"command",
[
(fix),
(cli_format),
],
)
def test__cli__command_fix_skip_ignore_files(command):
"""Check "ignore file" is skipped when --disregard-sqlfluffignores flag is set."""
runner = CliRunner()
result = runner.invoke(
command,
[
"test/fixtures/linter/sqlfluffignore/path_b/query_c.sql",
"--disregard-sqlfluffignores",
"-x",
"_fix",
],
)
assert result.exit_code == 0
assert "LT12" in result.stdout.strip()
def test__cli__command_lint_ignore_local_config():
"""Test that --ignore-local_config ignores .sqlfluff file as expected."""
runner = CliRunner()
# First we test that not including the --ignore-local-config includes
# .sqlfluff file, and therefore the lint doesn't raise AL02
result = runner.invoke(
lint,
[
"test/fixtures/cli/ignore_local_config/ignore_local_config_test.sql",
],
)
assert result.exit_code == 0
assert "AL02" not in result.stdout.strip()
# Then repeat the same lint but this time ignoring the .sqlfluff file.
# We should see AL02 raised.
result = runner.invoke(
lint,
[
"--ignore-local-config",
"--dialect=ansi",
"test/fixtures/cli/ignore_local_config/ignore_local_config_test.sql",
],
)
assert result.exit_code == 1
assert "AL02" in result.stdout.strip()
def test__cli__command_lint_warning():
"""Test that configuring warnings works.
For this test the warnings are configured using
inline config in the file. That's more for simplicity
however the code paths should be the same if it's
configured in a file.
"""
runner = CliRunner()
result = runner.invoke(
lint,
[
"test/fixtures/cli/warning_a.sql",
],
)
# Because we're only warning. The command should pass.
assert result.exit_code == 0
# The output should still say PASS.
assert "PASS" in result.stdout.strip()
# But should also contain the warnings.
# NOTE: Not including the whole description because it's too long.
assert (
"L: 4 | P: 9 | LT01 | WARNING: Expected single whitespace"
in result.stdout.strip()
)
def test__cli__command_lint_warning_name_rule():
"""Test that configuring warnings works.
For this test the warnings are configured using
inline config in the file. That's more for simplicity
however the code paths should be the same if it's
configured in a file.
"""
runner = CliRunner()
result = runner.invoke(
lint,
[
"test/fixtures/cli/warning_name_a.sql",
],
)
# Because we're only warning. The command should pass.
assert result.exit_code == 0
# The output should still say PASS.
assert "PASS" in result.stdout.strip()
# But should also contain the warnings.
# NOTE: Not including the whole description because it's too long.
assert (
"L: 4 | P: 9 | LT01 | WARNING: Expected single whitespace"
in result.stdout.strip()
)
def test__cli__command_versioning():
"""Check version command."""
# Get the package version info
pkg_version = sqlfluff.__version__
# Get the version info from the config file.
# NOTE: Toml files are always encoded in UTF-8.
with open("pyproject.toml", "r", encoding="utf-8") as config_file:
config = tomllib.loads(config_file.read())
config_version = config["project"]["version"]
assert pkg_version == config_version
# Get the version from the cli
runner = CliRunner()
result = runner.invoke(version)
assert result.exit_code == 0
# We need to strip to remove the newline characters
assert result.stdout.strip() == pkg_version
def test__cli__command_version():
"""Just check version command for exceptions."""
# Get the package version info
pkg_version = sqlfluff.__version__
runner = CliRunner()
result = runner.invoke(version)
assert result.exit_code == 0
assert pkg_version in result.stdout
# Check a verbose version
result = runner.invoke(version, ["-v"])
assert result.exit_code == 0
assert pkg_version in result.stdout
def test__cli__command_rules():
"""Check rules command for exceptions."""
invoke_assert_code(args=[rules])
def test__cli__command_dialects():
"""Check dialects command for exceptions."""
invoke_assert_code(args=[dialects])
def generic_roundtrip_test(
source_file,
rulestring,
final_exit_code=0,
check=False,
fix_input=None,
fix_exit_code=0,
input_file_encoding="utf-8",
output_file_encoding=None,
):
"""A test for roundtrip testing, take a file buffer, lint, fix and lint.
This is explicitly different from the linter version of this, in that
it uses the command line rather than the direct api.
"""
filename = "testing.sql"
# Lets get the path of a file to use
tempdir_path = tempfile.mkdtemp()
filepath = os.path.join(tempdir_path, filename)
# Open the example file and write the content to it
with open(filepath, mode="w", encoding=input_file_encoding) as dest_file:
for line in source_file:
dest_file.write(line)
status = os.stat(filepath)
assert stat.S_ISREG(status.st_mode)
old_mode = stat.S_IMODE(status.st_mode)
# Check that we first detect the issue
invoke_assert_code(
ret_code=1,
args=[lint, ["--dialect=ansi", "--rules", rulestring, filepath]],
)
# Fix the file (in force mode)
if check:
fix_args = ["--rules", rulestring, "--check", filepath]
else:
fix_args = ["--rules", rulestring, filepath]
fix_args.append("--dialect=ansi")
invoke_assert_code(
ret_code=fix_exit_code, args=[fix, fix_args], cli_input=fix_input
)
# Now lint the file and check for exceptions
invoke_assert_code(
ret_code=final_exit_code,
args=[lint, ["--dialect=ansi", "--rules", rulestring, filepath]],
)
# Check the output file has the correct encoding after fix
if output_file_encoding:
with open(filepath, mode="rb") as f:
data = f.read()
assert chardet.detect(data)["encoding"] == output_file_encoding
# Also check the file mode was preserved.
status = os.stat(filepath)
assert stat.S_ISREG(status.st_mode)
new_mode = stat.S_IMODE(status.st_mode)
assert new_mode == old_mode
shutil.rmtree(tempdir_path)
@pytest.mark.parametrize(
"rule,fname",
[
("LT01", "test/fixtures/linter/indentation_errors.sql"),
("LT01", "test/fixtures/linter/whitespace_errors.sql"),
("LT01", "test/fixtures/linter/indentation_errors.sql"),
# Really stretching the ability of the fixer to re-indent a file
("LT02", "test/fixtures/linter/indentation_error_hard.sql"),
],
)
def test__cli__command__fix(rule, fname):
"""Test the round trip of detecting, fixing and then not detecting the rule."""
with open(fname) as test_file:
generic_roundtrip_test(test_file, rule)
@pytest.mark.parametrize(
"sql,fix_args,fixed,exit_code",
[
(
# - One lint error: "where" is lower case
# - Not fixable because of parse error, hence error exit
"""
SELECT my_col
FROM my_schema.my_table
where processdate ! 3
""",
["--fixed-suffix", "FIXED", "--rules", "CP01"],
None,
1,
),
(
# - One lint error: "where" is lower case
# - Not fixable because of templater error, hence error exit
"""
SELECT my_col
FROM my_schema.my_table
where processdate {{ condition }}
""",
# Test the short versions of the options.
["-x", "FIXED", "-r", "CP01"],
None,
1,
),
(
# - One lint error: "where" is lower case
# - Not fixable because of parse error (even though "noqa"), hence
# error exit
"""
SELECT my_col
FROM my_schema.my_table
where processdate ! 3 -- noqa: PRS
""",
# Test the short versions of the options.
["-x", "FIXED", "-r", "CP01"],
None,
1,
),
(
# - No lint errors
# - Parse error not suppressed, hence error exit
"""
SELECT my_col
FROM my_schema.my_table
WHERE processdate ! 3
""",
["--fixed-suffix", "FIXED", "--rules", "CP01"],
None,
1,
),
(
# - No lint errors
# - Parse error suppressed, hence success exit
"""
SELECT my_col
FROM my_schema.my_table
WHERE processdate ! 3 --noqa: PRS
""",
["--fixed-suffix", "FIXED", "--rules", "CP01"],
None,
0,
),
(
# - One lint error: "where" is lower case
# - Parse error not suppressed
# - "--FIX-EVEN-UNPARSABLE", hence fix anyway & success exit
"""
SELECT my_col
FROM my_schema.my_table
where processdate ! 3
""",
[
"--fixed-suffix",
"FIXED",
"--rules",
"CP01",
"--FIX-EVEN-UNPARSABLE",
],
"""
SELECT my_col
FROM my_schema.my_table
WHERE processdate ! 3
""",
0,
),
(
# Two files:
# File #1:
# - One lint error: "where" is lower case
# - Not fixable because of parse error
# File #2:
# - One lint error: "where" is lower case
# - No parse error, thus fixable
# Should fix the second file but not the first, and exit with an
# error.
[
"""
SELECT my_col
FROM my_schema.my_table
where processdate ! 3
""",
"""SELECT my_col
FROM my_schema.my_table
where processdate != 3""",
],
["--fixed-suffix", "FIXED", "--rules", "CP01"],
[
None,
"""SELECT my_col
FROM my_schema.my_table
WHERE processdate != 3""",
],
1,
),
],
ids=[
"1_lint_error_1_unsuppressed_parse_error",
"1_lint_error_1_unsuppressed_templating_error",
"1_lint_error_1_suppressed_parse_error",
"0_lint_errors_1_unsuppressed_parse_error",
"0_lint_errors_1_suppressed_parse_error",
"1_lint_error_1_unsuppressed_parse_error_FIX_EVEN_UNPARSABLE",
"2_files_with_lint_errors_1_unsuppressed_parse_error",
],
)
def test__cli__fix_error_handling_behavior(sql, fix_args, fixed, exit_code, tmpdir):
"""Tests how "fix" behaves wrt parse errors, exit code, etc."""
if not isinstance(sql, list):
sql = [sql]
if not isinstance(fixed, list):
fixed = [fixed]
assert len(sql) == len(fixed)
tmp_path = pathlib.Path(str(tmpdir))
for idx, this_sql in enumerate(sql):
filepath = tmp_path / f"testing{idx + 1}.sql"
filepath.write_text(textwrap.dedent(this_sql))
with tmpdir.as_cwd():
with pytest.raises(SystemExit) as e:
fix(
fix_args
# Use the short dialect option
+ ["-d", "ansi"]
)
assert exit_code == e.value.code
for idx, this_fixed in enumerate(fixed):
fixed_path = tmp_path / f"testing{idx + 1}FIXED.sql"
if this_fixed is not None:
assert textwrap.dedent(this_fixed) == fixed_path.read_text()
else:
# A None value indicates "sqlfluff fix" should have skipped any
# fixes for this file. To confirm this, we verify that the output
# file WAS NOT EVEN CREATED.
assert not fixed_path.is_file()
@pytest.mark.parametrize(
"method,fix_even_unparsable",
[
("command-line", False),
("command-line", True),
("config-file", False),
("config-file", True),
],
)
def test_cli_fix_even_unparsable(
method: str, fix_even_unparsable: bool, monkeypatch, tmpdir
):
"""Test the fix_even_unparsable option works from cmd line and config."""
sql_filename = "fix_even_unparsable.sql"
sql_path = str(tmpdir / sql_filename)
with open(sql_path, "w") as f:
print(
"""SELECT my_col
FROM my_schema.my_table
where processdate ! 3
""",
file=f,
)
options = [
"--dialect",
"ansi",
"--fixed-suffix=FIXED",
sql_path,
]
if method == "command-line":
if fix_even_unparsable:
options.append("--FIX-EVEN-UNPARSABLE")
else:
assert method == "config-file"
with open(str(tmpdir / ".sqlfluff"), "w") as f:
print(
f"[sqlfluff]\nfix_even_unparsable = {fix_even_unparsable}",
file=f,
)
# TRICKY: Switch current directory to the one with the SQL file. Otherwise,
# the setting doesn't work. That's because SQLFluff reads it in
# sqlfluff.cli.commands.fix(), prior to reading any file-specific settings
# (down in sqlfluff.core.linter.Linter._load_raw_file_and_config()).
monkeypatch.chdir(str(tmpdir))
invoke_assert_code(
ret_code=0 if fix_even_unparsable else 1,
args=[
fix,
options,
],
)
fixed_path = str(tmpdir / "fix_even_unparsableFIXED.sql")
if fix_even_unparsable:
with open(fixed_path, "r") as f:
fixed_sql = f.read()
assert (
fixed_sql
== """SELECT my_col
FROM my_schema.my_table
WHERE processdate ! 3
"""
)
else:
assert not os.path.isfile(fixed_path)
@pytest.mark.parametrize(
"stdin,rules,stdout",
[
("select * from t", "LT02", "select * from t"), # no change
(
" select * from t",
"LT02",
"select * from t",
), # fix preceding whitespace
],
)
def test__cli__command_fix_stdin(stdin, rules, stdout):
"""Check stdin input for fix works."""
result = invoke_assert_code(
args=[
fix,
("-", "--rules", rules, "--disable-progress-bar", "--dialect=ansi"),
],
cli_input=stdin,
)
assert result.stdout == stdout
assert result.stderr == ""
@pytest.mark.parametrize(
"stdin,stdout",
[
("select * from t\n", "select * from t\n"), # no change
(
" select * FRoM t ",
"select * from t\n",
),
(
# Check that warnings related to parsing errors on input don't
# go to stdout. This query shouldn't change, but stdout should
# remain clean.
# https://github.com/sqlfluff/sqlfluff/issues/5327
"select\n"
" count(*) over (\n"
" order by a desc \n"
" range between b row and '10 seconds' following -- noqa: PRS\n"
" ) as c\n"
"from d\n",
"select\n"
" count(*) over (\n"
" order by a desc \n"
" range between b row and '10 seconds' following -- noqa: PRS\n"
" ) as c\n"
"from d\n",
),
],
)
def test__cli__command_format_stdin(stdin, stdout):
"""Check stdin input for fix works."""
result = invoke_assert_code(
args=[
cli_format,
("-", "--disable-progress-bar", "--dialect=ansi"),
],
cli_input=stdin,
)
assert result.stdout == stdout
def test__cli__command_fix_stdin_logging_to_stderr(monkeypatch):
"""Check that logging goes to stderr when stdin is passed to fix."""
perfect_sql = "select col from table"
class MockLinter(sqlfluff.core.Linter):
@classmethod
def lint_fix_parsed(cls, *args, **kwargs):
cls._warn_unfixable("<FAKE CODE>")
return super().lint_fix_parsed(*args, **kwargs)
monkeypatch.setattr(sqlfluff.cli.commands, "Linter", MockLinter)
result = invoke_assert_code(
args=[fix, ("-", "--rules=LT02", "--dialect=ansi")],
cli_input=perfect_sql,
)
assert result.stdout == perfect_sql
assert "<FAKE CODE>" in result.stderr
def test__cli__command_fix_stdin_safety():
"""Check edge cases regarding safety when fixing stdin."""
perfect_sql = "select col from table"
# just prints the very same thing
result = invoke_assert_code(
args=[fix, ("-", "--disable-progress-bar", "--dialect=ansi")],
cli_input=perfect_sql,
)
assert result.stdout.strip() == perfect_sql
assert result.stderr == ""
@pytest.mark.parametrize(
"sql,exit_code,params,assert_stderr_contains",
[
(
"create TABLE {{ params.dsfsdfds }}.t (a int)",
1,
"-v",
"Fix aborted due to unparsable template variables.",
), # template error
("create TABLE a.t (a int)", 0, "", ""), # fixable error
("create table a.t (a int)", 0, "", ""), # perfection
(
"select col from a join b using (c)",
1,
"-v",
"Unfixable violations detected.",
), # unfixable error (using)
],
)
def test__cli__command_fix_stdin_error_exit_code(
sql, exit_code, params, assert_stderr_contains
):
"""Check that the CLI fails nicely if fixing a templated stdin."""
invoke_assert_code(
ret_code=exit_code,
args=[fix, ((params,) if params else ()) + ("--dialect=ansi", "-")],
cli_input=sql,
assert_stderr_contains=assert_stderr_contains,
)
@pytest.mark.parametrize(
"rule,fname,prompt,exit_code,fix_exit_code",
[
("LT01", "test/fixtures/linter/indentation_errors.sql", "y", 0, 0),
("LT01", "test/fixtures/linter/indentation_errors.sql", "n", 1, 1),
],
)
def test__cli__command__fix_check(rule, fname, prompt, exit_code, fix_exit_code):
"""Round trip test, using the prompts."""
with open(fname) as test_file:
generic_roundtrip_test(
test_file,
rule,
check=True,
final_exit_code=exit_code,
fix_input=prompt,
fix_exit_code=fix_exit_code,
)
@pytest.mark.parametrize("serialize", ["yaml", "json"])
@pytest.mark.parametrize("write_file", [None, "outfile"])
def test__cli__command_parse_serialize_from_stdin(serialize, write_file, tmp_path):
"""Check that the parser serialized output option is working.
This tests both output to stdout and output to file.
Not going to test for the content of the output as that is subject to change.
"""
cmd_args = ("-", "--format", serialize, "--dialect=ansi")
if write_file:
target_file = os.path.join(tmp_path, write_file + "." + serialize)
cmd_args += ("--write-output", target_file)
result = invoke_assert_code(
args=[parse, cmd_args],
cli_input="select * from tbl",
)
if write_file:
with open(target_file, "r") as payload_file:
result_payload = payload_file.read()
else:
result_payload = result.stdout
if serialize == "json":
result = json.loads(result_payload)
elif serialize == "yaml":
result = yaml.safe_load(result_payload)
else:
raise Exception
result = result[0] # only one file
assert result["filepath"] == "stdin"
@pytest.mark.parametrize("serialize", ["yaml", "json", "none"])
@pytest.mark.parametrize(
"sql,rules,expected,exit_code",
[
(
"select * from tbl",
"CP01",
[
{
"filepath": "stdin",
"statistics": {
"raw_segments": 12,
"segments": 24,
"source_chars": 17,
"templated_chars": 17,
},
# Empty list because no violations.
"violations": [],
}
],
0,
),
(
"SElect * from tbl",
"CP01",
[
{
"filepath": "stdin",
"violations": [
{
"code": "CP01",
"start_line_no": 1,
"start_line_pos": 1,
"start_file_pos": 0,
"end_line_no": 1,
"end_line_pos": 7,
"end_file_pos": 6,
"description": "Keywords must be consistently upper case.",
"name": "capitalisation.keywords",
"warning": False,
"fixes": [
{
"type": "replace",
"edit": "SELECT",
"start_line_no": 1,
"start_line_pos": 1,
"start_file_pos": 0,
"end_line_no": 1,
"end_line_pos": 7,
"end_file_pos": 6,
}
],
},
{
"code": "CP01",
"start_line_no": 1,
"start_line_pos": 10,
"start_file_pos": 9,
"end_line_no": 1,
"end_line_pos": 14,
"end_file_pos": 13,
"description": "Keywords must be consistently upper case.",
"name": "capitalisation.keywords",
"warning": False,
"fixes": [
{
"type": "replace",
"edit": "FROM",
"start_line_no": 1,
"start_line_pos": 10,
"start_file_pos": 9,
"end_line_no": 1,
"end_line_pos": 14,
"end_file_pos": 13,
}
],
},
],
"statistics": {
"raw_segments": 12,
"segments": 24,
"source_chars": 17,
"templated_chars": 17,
},
# NOTE: There will be a timings section too, but we're not
# going to test that.
}
],
1,
),
# Test serialisation with a source only fix.
(
"SELECT {{1}}",
"JJ01",
[
{
"filepath": "stdin",
"violations": [
{
"code": "JJ01",
"start_line_no": 1,
"start_line_pos": 8,
"start_file_pos": 7,
"end_line_no": 1,
"end_line_pos": 13,
"end_file_pos": 12,
"description": (
"Jinja tags should have a single whitespace on "
"either side: {{1}}"
),
"name": "jinja.padding",
"warning": False,
"fixes": [
{
"type": "replace",
"edit": "{{ 1 }}",
"start_line_no": 1,
"start_line_pos": 8,
"start_file_pos": 7,
"end_line_no": 1,
"end_line_pos": 13,
"end_file_pos": 12,
}
],
},
],
"statistics": {
"raw_segments": 6,
"segments": 11,
"source_chars": 12,
"templated_chars": 8,
},
# NOTE: There will be a timings section too, but we're not
# going to test that.
}
],
1,
),
],
)
def test__cli__command_lint_serialize_from_stdin(
serialize, sql, rules, expected, exit_code
):
"""Check an explicit serialized return value for a single error."""
result = invoke_assert_code(
args=[
lint,
(
"-",
"--rules",
rules,
"--format",
serialize,
"--disable-progress-bar",
"--dialect=ansi",
),
],
cli_input=sql,
ret_code=exit_code,
)
if serialize == "json":
result = json.loads(result.stdout)
# Drop any timing section (because it's less determinate)
for record in result:
if "timings" in record:
del record["timings"]
assert result == expected
elif serialize == "yaml":
result = yaml.safe_load(result.stdout)
# Drop any timing section (because it's less determinate)
for record in result:
if "timings" in record:
del record["timings"]
assert result == expected
elif serialize == "none":
assert result.stdout == ""
else:
raise Exception
@pytest.mark.parametrize(
"command",
[
[lint, ("this_file_does_not_exist.sql")],
[fix, ("this_file_does_not_exist.sql")],
],
)
def test__cli__command_fail_nice_not_found(command):
"""Check commands fail as expected when then don't find files."""
invoke_assert_code(
args=command,
ret_code=2,
assert_stderr_contains=(
"User Error: Specified path does not exist. Check it/they "
"exist(s): this_file_does_not_exist.sql"
),
)
@patch("click.utils.should_strip_ansi")
@patch("sys.stdout.isatty")
@pytest.mark.parametrize(
"flag, env_var, has_color",
[
(None, None, True),
("--nocolor", None, False),
("--color", None, True),
(None, "1", False),
(None, "true", False),
(None, "True", False),
(None, "False", False),
(None, "anything", False),
(None, "", True),
("--color", "1", True),
],
)
def test__cli__command_lint_nocolor(
isatty, should_strip_ansi, capsys, tmpdir, flag, env_var, has_color
):
"""Test the --nocolor option prevents color output."""
# Patch these two functions to make it think every output stream is a TTY.
# In spite of this, the output should not contain ANSI color codes because
# we specify "--nocolor" below.
no_color_flag = [flag] if flag else []
if env_var is not None:
os.environ["NO_COLOR"] = env_var
elif "NO_COLOR" in os.environ:
os.environ.pop("NO_COLOR")
isatty.return_value = True
should_strip_ansi.return_value = False
fpath = "test/fixtures/linter/indentation_errors.sql"
output_file = str(tmpdir / "result.txt")
cmd_args = [
"--verbose",
*no_color_flag,
"--dialect",
"ansi",
"--disable-progress-bar",
fpath,
"--write-output",
output_file,
]
with pytest.raises(SystemExit):
lint(cmd_args)
out = capsys.readouterr()[0]
with open(output_file, "r") as f:
file_contents = f.read()
assert contains_ansi_escape(out + file_contents) == has_color
@pytest.mark.parametrize(
"serialize",
["human", "yaml", "json", "github-annotation", "github-annotation-native", "none"],
)
@pytest.mark.parametrize("write_file", [None, "outfile"])
def test__cli__command_lint_serialize_multiple_files(serialize, write_file, tmp_path):
"""Test the output formats for multiple files.
This tests runs both stdout checking and file checking.
"""
fpath1 = "test/fixtures/linter/indentation_errors.sql"
fpath2 = "test/fixtures/linter/multiple_sql_errors.sql"
cmd_args = (
fpath1,
fpath2,
"--format",
serialize,
"--disable-progress-bar",
)
if write_file:
ext = {
"human": ".txt",
"yaml": ".yaml",
}
target_file = os.path.join(tmp_path, write_file + ext.get(serialize, ".json"))
cmd_args += ("--write-output", target_file)
# note the file is in here twice. two files = two payloads.
result = invoke_assert_code(
args=[lint, cmd_args],
ret_code=1,
)
# NOTE: The "none" serializer doesn't write a file even if specified.
if write_file and serialize != "none":
with open(target_file, "r") as payload_file:
result_payload = payload_file.read()
else:
result_payload = result.stdout
# Print for debugging.
payload_length = len(result_payload.split("\n"))
print("=== BEGIN RESULT OUTPUT")
print(result_payload)
print("=== END RESULT OUTPUT")
print("Result length:", payload_length)
if serialize == "human":
assert payload_length == 25 if write_file else 34
elif serialize == "none":
assert payload_length == 1 # There will be a single newline.
elif serialize == "json":
result = json.loads(result_payload)
assert len(result) == 2
elif serialize == "yaml":
result = yaml.safe_load(result_payload)
assert len(result) == 2
elif serialize == "github-annotation":
result = json.loads(result_payload)
filepaths = {r["file"] for r in result}
assert len(filepaths) == 2
elif serialize == "github-annotation-native":
result = result_payload.split("\n")
# SQLFluff produces trailing newline
if result[-1] == "":
del result[-1]
assert len(result) == 16
else:
raise Exception
def test__cli__command_lint_serialize_github_annotation():
"""Test format of github-annotation output."""
fpath = "test/fixtures/linter/identifier_capitalisation.sql"
result = invoke_assert_code(
args=[
lint,
(
fpath,
"--format",
"github-annotation",
"--annotation-level",
"warning",
"--disable-progress-bar",
),
],
ret_code=1,
)
result = json.loads(result.stdout)
assert result == [
{
"annotation_level": "warning",
# Normalise paths to control for OS variance
"file": os.path.normpath(
"test/fixtures/linter/identifier_capitalisation.sql"
),
"start_line": 3,
"end_line": 3,
"message": "RF02: Unqualified reference 'foo' found in select with more "
"than one referenced table/view.",
"start_column": 5,
"end_column": 8,
"title": "SQLFluff",
},
{
"annotation_level": "warning",
# Normalise paths to control for OS variance
"file": os.path.normpath(
"test/fixtures/linter/identifier_capitalisation.sql"
),
"start_line": 4,
"end_line": 4,
"message": "LT02: Expected indent of 8 spaces.",
"start_column": 1,
"end_column": 5,
"title": "SQLFluff",
},
{
"annotation_level": "warning",
# Normalise paths to control for OS variance
"file": os.path.normpath(
"test/fixtures/linter/identifier_capitalisation.sql"
),
"start_line": 4,
"end_line": 4,
"message": "AL02: Implicit/explicit aliasing of columns.",
"start_column": 5,
"end_column": 8,
"title": "SQLFluff",
},
{
"annotation_level": "warning",
# Normalise paths to control for OS variance
"file": os.path.normpath(
"test/fixtures/linter/identifier_capitalisation.sql"
),
"start_line": 4,
"end_line": 4,
"message": "CP02: Unquoted identifiers must be consistently lower case.",
"start_column": 5,
"end_column": 8,
"title": "SQLFluff",
},
{
# Warnings should come through as notices.
"annotation_level": "notice",
# Normalise paths to control for OS variance
"file": os.path.normpath(
"test/fixtures/linter/identifier_capitalisation.sql"
),
"start_line": 5,
"end_line": 5,
"message": "CP01: Keywords must be consistently lower case.",
"start_column": 1,
"end_column": 5,
"title": "SQLFluff",
},
{
"annotation_level": "warning",
# Normalise paths to control for OS variance
"file": os.path.normpath(
"test/fixtures/linter/identifier_capitalisation.sql"
),
"start_line": 5,
"end_line": 5,
"message": "CP02: Unquoted identifiers must be consistently lower case.",
"start_column": 12,
"end_column": 16,
"title": "SQLFluff",
},
{
"annotation_level": "warning",
# Normalise paths to control for OS variance
"file": os.path.normpath(
"test/fixtures/linter/identifier_capitalisation.sql"
),
"start_line": 5,
"end_line": 5,
"message": "CP02: Unquoted identifiers must be consistently lower case.",
"start_column": 18,
"end_column": 22,
"title": "SQLFluff",
},
]
@pytest.mark.parametrize(
"filename,expected_output",
[
(
"test/fixtures/linter/identifier_capitalisation.sql",
(
"::group::{filename}\n"
"::error title=SQLFluff,file={filename},"
"line=3,col=5,endLine=3,endColumn=8::"
"RF02: Unqualified reference 'foo' found in select with more than one "
"referenced table/view. [references.qualification]\n"
"::error title=SQLFluff,file={filename},"
"line=4,col=1,endLine=4,endColumn=5::"
"LT02: Expected indent of 8 spaces. [layout.indent]\n"
"::error title=SQLFluff,file={filename},"
"line=4,col=5,endLine=4,endColumn=8::"
"AL02: Implicit/explicit aliasing of columns. [aliasing.column]\n"
"::error title=SQLFluff,file={filename},"
"line=4,col=5,endLine=4,endColumn=8::"
"CP02: Unquoted identifiers must be consistently lower case. "
"[capitalisation.identifiers]\n"
# Warnings should always come through as notices.
"::notice title=SQLFluff,file={filename},"
"line=5,col=1,endLine=5,endColumn=5::"
"CP01: Keywords must be consistently lower case. "
"[capitalisation.keywords]\n"
"::error title=SQLFluff,file={filename},"
"line=5,col=12,endLine=5,endColumn=16::"
"CP02: Unquoted identifiers must be consistently lower case. "
"[capitalisation.identifiers]\n"
"::error title=SQLFluff,file={filename},"
"line=5,col=18,endLine=5,endColumn=22::"
"CP02: Unquoted identifiers must be consistently lower case. "
"[capitalisation.identifiers]\n"
"::endgroup::\n"
# SQLFluff produces trailing newline
),
),
(
"test/fixtures/linter/jinja_spacing.sql",
(
"::group::{filename}\n"
"::error title=SQLFluff,file={filename},"
"line=3,col=15,endLine=3,endColumn=22::JJ01: "
"Jinja tags should have a single whitespace on either "
# NOTE: Double escaping, because we're going to pass this through a
# .format() method.
"side: {{{{foo}}}} "
"[jinja.padding]\n"
"::endgroup::\n"
),
),
],
)
def test__cli__command_lint_serialize_github_annotation_native(
filename, expected_output
):
"""Test format of github-annotation output."""
# Normalise paths to control for OS variance
fpath_normalised = os.path.normpath(filename)
result = invoke_assert_code(
args=[
lint,
(
filename,
"--format",
"github-annotation-native",
"--annotation-level",
"error",
"--disable-progress-bar",
),
],
ret_code=1,
)
assert result.stdout == expected_output.format(filename=fpath_normalised)
@pytest.mark.parametrize("serialize", ["github-annotation", "github-annotation-native"])
def test__cli__command_lint_serialize_annotation_level_error_failure_equivalent(
serialize,
):
"""Test format of github-annotation output."""
fpath = "test/fixtures/linter/identifier_capitalisation.sql"
result_error = invoke_assert_code(
args=[
lint,
(
fpath,
"--format",
serialize,
"--annotation-level",
"error",
"--disable-progress-bar",
),
],
ret_code=1,
)
result_failure = invoke_assert_code(
args=[
lint,
(
fpath,
"--format",
serialize,
"--annotation-level",
"failure",
"--disable-progress-bar",
),
],
ret_code=1,
)
assert result_error.stdout == result_failure.stdout
def test___main___help():
"""Test that the CLI can be access via __main__."""
# nonzero exit is good enough
subprocess.check_output(
[sys.executable, "-m", "sqlfluff", "--help"], env=os.environ
)
@pytest.mark.parametrize(
"encoding_in,encoding_out",
[
("utf-8", "ascii"), # chardet will detect ascii as a subset of utf-8
("utf-8-sig", "UTF-8-SIG"),
("utf-32", "UTF-32"),
],
)
def test_encoding(encoding_in, encoding_out):
"""Check the encoding of the test file remains the same after fix is applied."""
with open("test/fixtures/linter/indentation_errors.sql", "r") as testfile:
generic_roundtrip_test(
testfile,
"LT01",
input_file_encoding=encoding_in,
output_file_encoding=encoding_out,
)
@pytest.mark.parametrize(
"encoding,method,expect_success",
[
("utf-8", "command-line", False),
("utf-8-SIG", "command-line", True),
("utf-8", "config-file", False),
("utf-8-SIG", "config-file", True),
],
)
def test_cli_encoding(encoding, method, expect_success, tmpdir):
"""Try loading a utf-8-SIG encoded file using the correct encoding via the cli."""
sql_path = "test/fixtures/cli/encoding_test.sql"
if method == "command-line":
options = [sql_path, "--encoding", encoding]
else:
assert method == "config-file"
with open(str(tmpdir / ".sqlfluff"), "w") as f:
print(f"[sqlfluff]\ndialect=ansi\nencoding = {encoding}", file=f)
shutil.copy(sql_path, tmpdir)
options = [str(tmpdir / "encoding_test.sql")]
result = invoke_assert_code(
ret_code=1,
args=[
lint,
options,
],
)
raw_stdout = repr(result.stdout)
# Incorrect encoding raises parsing and lexer errors.
success1 = r"L: 1 | P: 1 | LXR |" not in raw_stdout
success2 = r"L: 1 | P: 1 | PRS |" not in raw_stdout
assert success1 == expect_success
assert success2 == expect_success
def test_cli_no_disable_noqa_flag():
"""Test that unset --disable-noqa flag respects inline noqa comments."""
invoke_assert_code(
ret_code=0,
args=[
lint,
["test/fixtures/cli/disable_noqa_test.sql"],
],
)
def test_cli_disable_noqa_flag():
"""Test that --disable-noqa flag ignores inline noqa comments."""
invoke_assert_code(
ret_code=1,
args=[
lint,
[
"test/fixtures/cli/disable_noqa_test.sql",
"--disable-noqa",
],
],
# Linting error is raised even though it is inline ignored.
assert_stdout_contains=r"L: 6 | P: 11 | CP01 |",
)
def test_cli_disable_noqa_except_flag():
"""Test that --disable-noqa-except flag ignores inline noqa comments."""
result = invoke_assert_code(
ret_code=1,
args=[
lint,
[
"test/fixtures/cli/disable_noqa_test.sql",
"--disable-noqa-except",
"CP01",
],
],
# Linting error is raised even though it is inline ignored.
assert_stdout_contains=r"L: 8 | P: 5 | CP03 |",
)
assert r"L: 6 | P: 11 | CP01 |" not in result.stdout
def test_cli_disable_noqa_except_non_rules_flag():
"""Test that --disable-noqa-except flag ignores all inline noqa comments."""
invoke_assert_code(
ret_code=1,
args=[
lint,
[
"test/fixtures/cli/disable_noqa_test.sql",
"--disable-noqa-except",
"None",
],
],
# Linting error is raised even though it is inline ignored.
assert_stdout_contains=r"L: 6 | P: 11 | CP01 |",
)
def test_cli_warn_unused_noqa_flag():
"""Test that --warn-unused-ignores flag works."""
invoke_assert_code(
# Return value should still be success.
ret_code=0,
args=[
lint,
[
"test/fixtures/cli/disable_noqa_test.sql",
"--warn-unused-ignores",
],
],
# Warning shown.
assert_stdout_contains=(
r"L: 5 | P: 18 | NOQA | WARNING: Unused noqa: 'noqa: CP01'"
),
)
def test_cli_get_default_config():
"""`nocolor` and `verbose` values loaded from config if not specified via CLI."""
config = get_config(
"test/fixtures/config/toml/pyproject.toml",
True,
nocolor=None,
verbose=None,
require_dialect=False,
)
assert config.get("nocolor") is True
assert config.get("verbose") == 2
@patch(
"sqlfluff.core.linter.linter.progress_bar_configuration",
disable_progress_bar=False,
)
class TestProgressBars:
"""Progress bars test cases.
The tqdm package, used for handling progress bars, is able to tell when it is used
in a not tty terminal (when `disable` is set to None). In such cases, it just does
not render anything. To suppress that for testing purposes, we need to set
implicitly that we don't want to disable it.
Probably it would be better - cleaner - just to patch `isatty` at some point,
but I didn't find a way how to do that properly.
"""
def test_cli_lint_disabled_progress_bar(
self, mock_disable_progress_bar: MagicMock
) -> None:
"""When progress bar is disabled, nothing should be printed into output."""
result = invoke_assert_code(
args=[
lint,
[
"--disable-progress-bar",
"test/fixtures/linter/passing.sql",
],
],
)
raw_stderr = repr(result.stderr)
assert "\rpath test/fixtures/linter/passing.sql:" not in raw_stderr
assert "\rparsing: 0it" not in raw_stderr
assert "\r\rlint by rules:" not in raw_stderr
def test_cli_lint_enabled_progress_bar(
self, mock_disable_progress_bar: MagicMock
) -> None:
"""When progress bar is enabled, there should be some tracks in output."""
result = invoke_assert_code(
args=[
lint,
[
"test/fixtures/linter/passing.sql",
],
],
)
raw_stderr = repr(result.stderr)
assert r"\rlint by rules:" in raw_stderr
assert r"\rrule LT01:" in raw_stderr
assert r"\rrule CV05:" in raw_stderr
def test_cli_lint_enabled_progress_bar_multiple_paths(
self, mock_disable_progress_bar: MagicMock
) -> None:
"""When progress bar is enabled, there should be some tracks in output."""
result = invoke_assert_code(
ret_code=1,
args=[
lint,
[
"test/fixtures/linter/passing.sql",
"test/fixtures/linter/indentation_errors.sql",
],
],
)
normalised_stderr = repr(result.stderr.replace("\\", "/"))
assert r"\rfile test/fixtures/linter/passing.sql:" in normalised_stderr
assert (
r"\rfile test/fixtures/linter/indentation_errors.sql:" in normalised_stderr
)
assert r"\rlint by rules:" in normalised_stderr
assert r"\rrule LT01:" in normalised_stderr
assert r"\rrule CV05:" in normalised_stderr
def test_cli_lint_enabled_progress_bar_multiple_files(
self, mock_disable_progress_bar: MagicMock
) -> None:
"""When progress bar is enabled, there should be some tracks in output."""
result = invoke_assert_code(
args=[
lint,
[
"test/fixtures/linter/multiple_files",
],
],
)
raw_stderr = repr(result.stderr)
sep = os.sep
if sys.platform == "win32":
sep *= 2
assert (
r"\rfile test/fixtures/linter/multiple_files/passing.1.sql:".replace(
"/", sep
)
in raw_stderr
)
assert (
r"\rfile test/fixtures/linter/multiple_files/passing.2.sql:".replace(
"/", sep
)
in raw_stderr
)
assert (
r"\rfile test/fixtures/linter/multiple_files/passing.3.sql:".replace(
"/", sep
)
in raw_stderr
)
assert r"\rlint by rules:" in raw_stderr
assert r"\rrule LT01:" in raw_stderr
assert r"\rrule CV05:" in raw_stderr
multiple_expected_output = """==== finding fixable violations ====
== [test/fixtures/linter/multiple_sql_errors.sql] FAIL
L: 12 | P: 1 | LT02 | Expected indent of 4 spaces. [layout.indent]
L: 44 | P: 12 | ST09 | Joins should list the table referenced earlier first.
| [structure.join_condition_order]
==== fixing violations ====
2 fixable linting violations found
Are you sure you wish to attempt to fix these? [Y/n] ...
Invalid input, please enter 'Y' or 'N'
Aborting...
[4 unfixable linting violations found]
"""
def test__cli__fix_multiple_errors_no_show_errors():
"""Test the fix output."""
invoke_assert_code(
ret_code=1,
args=[
fix,
[
"--check", # Run in check mode to get the confirmation.
"--disable-progress-bar",
"test/fixtures/linter/multiple_sql_errors.sql",
],
],
assert_stdout_contains=multiple_expected_output,
)
def test__cli__fix_multiple_errors_quiet_force():
"""Test the fix --quiet option with --force."""
invoke_assert_code(
ret_code=0,
args=[
fix,
[
"--disable-progress-bar",
"test/fixtures/linter/multiple_sql_errors.sql",
"--quiet",
"-x",
"_fix",
],
],
assert_stdout_contains=(
"""== [test/fixtures/linter/multiple_sql_errors.sql] FIXED
2 fixable linting violations found"""
),
)
def test__cli__fix_multiple_errors_quiet_check():
"""Test the fix --quiet option without --force."""
invoke_assert_code(
ret_code=0,
args=[
fix,
[
"--disable-progress-bar",
"test/fixtures/linter/multiple_sql_errors.sql",
"--check", # Run in check mode to get the confirmation.
"--quiet",
"-x",
"_fix",
],
# Test with the confirmation step.
"y",
],
assert_stdout_contains=(
"""2 fixable linting violations found
Are you sure you wish to attempt to fix these? [Y/n] ...
== [test/fixtures/linter/multiple_sql_errors.sql] FIXED
All Finished"""
),
)
def test__cli__fix_multiple_errors_show_errors():
"""Test the fix --show-lint-violations option."""
result = invoke_assert_code(
ret_code=1,
args=[
fix,
[
"--disable-progress-bar",
"--show-lint-violations",
"test/fixtures/linter/multiple_sql_errors.sql",
"--check", # Run in check mode to get the confirmation.
],
],
)
# We should get a readout of what the error was
check_a = "4 unfixable linting violations found"
assert check_a in result.stdout
# Finally check the WHOLE output to make sure that unexpected newlines are not
# added. The replace command just accounts for cross platform testing.
assert "L: 12 | P: 1 | LT02 | Expected indent of 4 spaces." in result.stdout
assert (
"L: 36 | P: 9 | RF02 | Unqualified reference 'package_id' found in "
"select with more than" in result.stdout
)
assert (
"L: 45 | P: 17 | RF02 | Unqualified reference 'owner_type' found in "
"select with more than" in result.stdout
)
assert (
"L: 45 | P: 50 | RF02 | Unqualified reference 'app_key' found in "
"select with more than one" in result.stdout
)
assert (
"L: 42 | P: 45 | RF02 | Unqualified reference 'owner_id' found in "
"select with more than" in result.stdout
)
def test__cli__fix_show_parse_errors():
"""Test the fix --show-lint-violations option with parser error."""
result = invoke_assert_code(
ret_code=1,
args=[
fix,
[
"--show-lint-violations",
"test/fixtures/linter/parse_lex_error.sql",
],
],
)
check_a = "1 templating/parsing errors found"
assert check_a not in result.stderr
assert (
"L: 9 | P: 21 | PRS | Couldn't find closing bracket for opening bracket."
in result.stdout
)
assert "L: 9 | P: 22 | LXR | Unable to lex characters: " in result.stdout
# Calling without show-lint-violations
result = invoke_assert_code(
ret_code=1,
args=[
fix,
[
"test/fixtures/linter/parse_lex_error.sql",
],
],
)
assert check_a in result.stderr
assert (
"L: 9 | P: 21 | PRS | Couldn't find closing bracket for opening bracket."
not in result.stdout
)
assert "L: 9 | P: 22 | LXR | Unable to lex characters: " not in result.stdout
def test__cli__multiple_files__fix_multiple_errors_show_errors():
"""Basic check of lint ensures with multiple files, filenames are listed."""
sql_path = "test/fixtures/linter/multiple_sql_errors.sql"
indent_path = "test/fixtures/linter/indentation_errors.sql"
result = invoke_assert_code(
ret_code=1,
args=[
fix,
[
"--disable-progress-bar",
"--check", # Run in check mode to get the confirmation.
"--show-lint-violations",
sql_path,
indent_path,
],
],
)
unfixable_error_msg = "==== lint for unfixable violations ===="
assert unfixable_error_msg in result.stdout
indent_pass_msg = f"== [{os.path.normpath(indent_path)}] PASS"
multi_fail_msg = f"== [{os.path.normpath(sql_path)}] FAIL"
unfix_err_log = result.stdout[result.stdout.index(unfixable_error_msg) :]
assert indent_pass_msg in unfix_err_log
assert multi_fail_msg in unfix_err_log
# Assert that they are sorted in alphabetical order
assert unfix_err_log.index(indent_pass_msg) < unfix_err_log.index(multi_fail_msg)
def test__cli__render_fail():
"""Basic how render fails."""
invoke_assert_code(
ret_code=1,
args=[
render,
[
"test/fixtures/cli/fail_many.sql",
],
],
assert_stdout_contains=(
"L: 3 | P: 8 | TMP | Undefined jinja template variable: 'something'"
),
)
def test__cli__render_pass():
"""Basic how render works."""
invoke_assert_code(
ret_code=0,
args=[
render,
[
"test/fixtures/templater/jinja_a/jinja.sql",
],
],
assert_stdout_contains="SELECT 56 FROM sch1.tbl2",
)
|