1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
|
"""Tests for the config validation routines."""
import pytest
from sqlfluff.core.config.removed import (
REMOVED_CONFIGS,
validate_config_dict_for_removed,
)
from sqlfluff.core.config.validate import _validate_layout_config
from sqlfluff.core.errors import SQLFluffUserError
from sqlfluff.core.helpers.dict import (
iter_records_from_nested_dict,
records_to_nested_dict,
)
def test__validate_configs_direct():
"""Test validate methods directly."""
# Make sure there _are_ removed configs.
assert REMOVED_CONFIGS
# Make sure all raise an error if validated
for k in REMOVED_CONFIGS:
print(k)
if k.translation_func and k.new_path:
config = records_to_nested_dict([(k.old_path, "foo")])
validate_config_dict_for_removed(config, "<test>")
print(config)
new_records = list(iter_records_from_nested_dict(config))
# There should only be one
assert len(new_records) == 1
# And it should be the reassigned one
assert new_records[0][0] == k.new_path
# Really we should check that it's output here, but logging config
# seems to make that hard.
else:
config = records_to_nested_dict([(k.old_path, "foo")])
with pytest.raises(SQLFluffUserError) as excinfo:
validate_config_dict_for_removed(config, "<test>")
assert "set an outdated config" in str(excinfo.value)
assert k.warning in str(excinfo.value)
def test__validate_configs_precedence_same_file():
"""Test _validate_configs method of FluffConfig where there's a conflict."""
# Check with a known conflicted value
old_key = ("rules", "LT03", "operator_new_lines")
new_key = ("layout", "type", "binary_operator", "line_position")
# Check it's still conflicted.
assert any(
k.old_path == old_key and k.new_path == new_key for k in REMOVED_CONFIGS
), (
"This test depends on this key still being removed. Update the test to "
"one that is if this one isn't."
)
# Test config
config = records_to_nested_dict([(new_key, "foo"), (old_key, "foo")])
# Before validation
assert config == {
"rules": {"LT03": {"operator_new_lines": "foo"}},
"layout": {"type": {"binary_operator": {"line_position": "foo"}}},
}
validate_config_dict_for_removed(config, "<test>")
# Check we only get the new key after validation
assert config == {"layout": {"type": {"binary_operator": {"line_position": "foo"}}}}
@pytest.mark.parametrize(
"config_dict,config_warning",
[
({"layout": "foo"}, "Found value 'foo' instead of a valid layout section"),
(
{"layout": {"invalid": "foo"}},
"Only sections of the form `sqlfluff:layout:type:...` are valid",
),
(
{"layout": {"type": {"foo": "bar"}}},
"Expected a section",
),
(
{"layout": {"type": {"foo": {"bar": "baz"}}}},
"Found the following invalid keys: {'bar'}",
),
(
{"layout": {"type": {"foo": {"spacing_before": {"a": "b"}}}}},
"Found the an unexpected section rather than value",
),
],
)
def test__validate_layouts(config_dict, config_warning):
"""Test the layout validation checks."""
with pytest.raises(SQLFluffUserError) as excinfo:
_validate_layout_config(config_dict, "<test>")
assert "set an invalid `layout` option" in str(excinfo.value)
assert config_warning in str(excinfo.value)
|
