File: RemoveInvalid.cpp

package info (click to toggle)
storm-lang 0.7.4-1
  • links: PTS, VCS
  • area: main
  • in suites: forky
  • size: 52,004 kB
  • sloc: ansic: 261,462; cpp: 140,405; sh: 14,891; perl: 9,846; python: 2,525; lisp: 2,504; asm: 860; makefile: 678; pascal: 70; java: 52; xml: 37; awk: 12
file content (918 lines) | stat: -rw-r--r-- 25,647 bytes parent folder | download | duplicates (2)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
#include "stdafx.h"
#include "RemoveInvalid.h"
#include "Asm.h"
#include "Utils/Bitmask.h"
#include "../Listing.h"
#include "../UsedRegs.h"
#include "../Exception.h"
#include "../Binary.h"
#include "Gc/DwarfTable.h"

namespace code {
	namespace arm64 {

		/**
		 * Table of operations to transform individual instructions.
		 */

#define TRANSFORM(x) { op::x, &RemoveInvalid::x ## Tfm }
#define DATA12(x) { op::x, &RemoveInvalid::dataInstr12Tfm }
#define BITMASK(x) { op::x, &RemoveInvalid::bitmaskInstrTfm }
#define DATA4REG(x) { op::x, &RemoveInvalid::dataInstr4RegTfm }
#define SHIFT(x) { op::x, &RemoveInvalid::shiftInstrTfm }
#define FP_OP(x) { op::x, &RemoveInvalid::fpInstrTfm }

		const OpEntry<RemoveInvalid::TransformFn> RemoveInvalid::transformMap[] = {
			TRANSFORM(prolog),
			TRANSFORM(epilog),
			TRANSFORM(beginBlock),
			TRANSFORM(endBlock),

			TRANSFORM(fnCall),
			TRANSFORM(fnCallRef),
			TRANSFORM(fnParam),
			TRANSFORM(fnParamRef),
			TRANSFORM(mov),
			TRANSFORM(lea),
			TRANSFORM(swap),
			TRANSFORM(test),
			TRANSFORM(cmp),
			TRANSFORM(setCond),
			TRANSFORM(icast),
			TRANSFORM(ucast),

			DATA12(add),
			DATA12(sub),
			DATA4REG(mul),
			TRANSFORM(idiv),
			TRANSFORM(udiv),
			TRANSFORM(umod),
			TRANSFORM(imod),

			BITMASK(band),
			BITMASK(bor),
			BITMASK(bxor),
			BITMASK(bnot),

			SHIFT(shl),
			SHIFT(shr),
			SHIFT(sar),

			FP_OP(fadd),
			FP_OP(fsub),
			FP_OP(fneg),
			FP_OP(fmul),
			FP_OP(fdiv),
			FP_OP(fcmp),

			TRANSFORM(fcast),
			TRANSFORM(fcasti),
			TRANSFORM(fcastu),
			TRANSFORM(icastf),
			TRANSFORM(ucastf),
		};


		/**
		 * Table with information on how to handle byte-sized operands for instructions.
		 *
		 * ARM only has 32- and 64-bit variants of certain operations. So we need to compensate in
		 * certain cases when working with bytes to ensure that garbage in the upper-parts of the
		 * 32-bit register will not be visible.
		 */

		enum ByteTransform {
			none = 0x00,
			extendSrc = 0x01,
			signedSrc = 0x02,
			extendDest = 0x10,
			signedDest = 0x20,
		};

		BITMASK_OPERATORS(ByteTransform);

		static const OpEntry<ByteTransform> byteTransformMap[] = {
			{ op::cmp, extendSrc | extendDest }, // Bytes are always unsigned in Storm (correct
												 // impl. would need to know sign...)
			{ op::udiv, extendSrc | extendDest },
			{ op::umod, extendSrc | extendDest },
			{ op::idiv, extendSrc | extendDest | signedSrc | signedDest },
			{ op::idiv, extendSrc | extendDest | signedSrc | signedDest },
			{ op::shr, extendDest },
			{ op::shl, extendDest | signedDest },
		};


		RemoveInvalid::RemoveInvalid() {}

		static bool isComplexParam(Listing *l, Var v) {
			TypeDesc *t = l->paramDesc(v);
			if (!t)
				return false;

			return as<ComplexDesc>(t) != null;
		}

		static bool isComplexParam(Listing *l, Operand op) {
			if (op.type() != opVariable)
				return false;

			return isComplexParam(l, op.var());
		}

		void RemoveInvalid::before(Listing *dest, Listing *src) {
			currentBlock = Block();
			used = usedRegs(dest->arena, src).used;
			params = new (this) Array<ParamInfo>();
			large = new (this) Array<Operand>();
			lblLarge = dest->label();

			// Set the 'freeIndirect' flag on all complex parameters.
			Array<Var> *vars = dest->allParams();
			for (Nat i = 0; i < vars->count(); i++) {
				Var v = vars->at(i);
				if (isComplexParam(dest, v)) {
					FreeOpt flags = dest->freeOpt(v);
					// Complex parameters are freed by the caller.
					flags &= ~freeOnException;
					flags &= ~freeOnBlockExit;
					flags |= freeIndirection;
					dest->freeOpt(v, flags);
				}
			}
		}

		void RemoveInvalid::during(Listing *dest, Listing *src, Nat line) {
			static OpTable<TransformFn> t(transformMap, ARRAY_COUNT(transformMap));

			Instr *original = src->at(line);

			Instr *i = modifyByte(dest, original, line);

			TransformFn f = t[i->op()];
			if (f) {
				(this->*f)(dest, i, line);
			} else {
				*dest << i;
			}

			// If the byte transform had to modify the destination, make sure to store it back where it belongs.
			if (i != original && i->dest() != original->dest()) {
				*dest << mov(original->dest(), i->dest());
			}
		}

		static Engine *findEngine() {
#ifdef ARM64
			void **fp;
			__asm__ ( "mov %0, x29"
					: "=r" (fp)
					: : );
			void *pc = fp[1];
			storm::FDE *fde = storm::dwarfTable().find(pc);
			if (!fde)
				return null;

			Binary *b = codeBinary(fde->codeStart());
			if (!b)
				return null;

			return &b->engine();
#else
			return null;
#endif
		}

		// Note: We use EXCEPTION_EXPORT to make the symbol visible on Linux.
		void EXCEPTION_EXPORT throwDivisionException() {
			Engine *e = findEngine();
			if (!e)
				e = runtime::someEngineUnsafe();
			throw new (*e) DivisionByZero();
		}

		void RemoveInvalid::after(Listing *dest, Listing *src) {
			if (lblDivZero != Label()) {
				*dest << lblDivZero;
				const void *errorFn = address(&throwDivisionException);
				*dest << mov(ptrr(16), largeConstant(xConst(Size::sPtr, (Word)errorFn)));
				*dest << call(ptrr(16), Size());
			}

			for (Nat i = 0; i < large->count(); i++) {
				*dest << alignAs(Size::sPtr);
				if (i == 0)
					*dest << lblLarge;
				*dest << dat(large->at(i));
			}
		}

		Label RemoveInvalid::divZeroLabel(Listing *dest) {
			if (lblDivZero == Label())
				lblDivZero = dest->label();
			return lblDivZero;
		}

		/**
		 * Byte operands.
		 */

		Instr *RemoveInvalid::modifyByte(Listing *to, Instr *instr, Nat line) {
			static OpTable<ByteTransform> t(byteTransformMap, ARRAY_COUNT(byteTransformMap));

			ByteTransform tfm = t[instr->op()];

			if (tfm & extendSrc) {
				Operand src = instr->src();
				if (src.size() == Size::sByte) {
					instr = instr->alterSrc(modifyByte(to, src, line, (tfm & signedSrc) != 0));
				}
			}

			if (tfm & extendDest) {
				Operand dest = instr->dest();
				if (dest.size() == Size::sByte) {
					instr = instr->alterDest(modifyByte(to, dest, line, (tfm & signedDest) != 0));
				}
			}

			return instr;
		}

		Operand RemoveInvalid::modifyByte(Listing *to, const Operand &op, Nat line, Bool opSigned) {
			if (op.type() == opRegister) {
				// If it was already in a register, we need to insert a suitable cast to a 32-bit register first.
				Reg r = op.reg();
				if (opSigned) {
					*to << icast(asSize(r, Size::sInt), r);
				} else {
					*to << ucast(asSize(r, Size::sInt), r);
				}
				return op;

			} else if (opSigned) {
				// In other cases, we only need to worry if signed operations are used. For
				// unsigned, we can simply load bytes from memory with the proper semantics. For
				// signed, we need to sign-extend.
				Reg r = unusedReg(used->at(line), op.size());
				used->at(line)->put(r);

				// Note: icast supports these addressing modes!
				*to << icast(r, op);

				return Operand(r);
			} else {
				return op;
			}
		}


		/**
		 * Helpers.
		 */

		Operand RemoveInvalid::largeConstant(const Operand &data) {
			Nat offset = large->count();
			large->push(data);
			return xRel(data.size(), lblLarge, Offset::sWord * offset);
		}

		Operand RemoveInvalid::limitImm(Listing *to, const Operand &op, Nat line, Nat immBits, Bool immSigned) {
			if (op.type() == opRegister) {
				return op;
			} else if (op.type() == opConstant) {
				Bool ok = false;
				if (immSigned) {
					Long v = op.constant();
					Long maxVal = Long(1) << (immBits - 1);
					ok = (v >= -maxVal) & (v < maxVal);
				} else {
					Word maxVal = Word(1) << immBits;
					ok = op.constant() < maxVal;
				}

				if (ok)
					return op;
			} else if (op.type() == opOffReference) {
				// Accept truncation for 12 bits or less.
				if (immBits >= 12)
					return op;
			}

			Reg r = unusedReg(used->at(line), op.size());
			used->at(line)->put(r);
			loadRegister(to, r, op);
			return Operand(r);
		}

		Instr *RemoveInvalid::limitImmSrc(Listing *to, Instr *instr, Nat line, Nat immBits, Bool immSigned) {
			Operand src = limitImm(to, instr->src(), line, immBits, immSigned);
			if (src != instr->src())
				return instr->alterSrc(src);
			else
				return instr;
		}

		Operand RemoveInvalid::regOrImm(Listing *to, const Operand &op, Nat line, Nat immBits, Bool immSigned) {
			switch (op.type()) {
			case opRegister:
				return op;

			case opConstant:
			case opOffReference:
				return limitImm(to, op, line, immBits, immSigned);

			// TODO: Maybe exclude other types here as well?

			default:
				// Otherwise, try to load it into a register.
				Reg r = unusedReg(used->at(line), op.size());
				used->at(line)->put(r);
				loadRegister(to, r, op);
				return Operand(r);
			}
		}

		void RemoveInvalid::loadRegister(Listing *to, Reg reg, const Operand &load) {
			switch (load.type()) {
			case opConstant: {
				Word constant = load.constant();
				// Note: We can use MOVN for negative numbers.
				Bool in16bits = (constant <= 0xFFFF) || (~constant <= 0xFFFF);
				if (in16bits && isIntReg(reg)) // No load literal for fp registers.
					*to << mov(reg, load);
				else
					*to << mov(reg, largeConstant(load));
				break;
			}
			case opRegister:
				if (!same(reg, load.reg()))
					*to << mov(reg, load);
				break;

			case opOffReference:
				// We assume that the offset is small enough. Note, we can use MOVN to store
				// negative numbers.
				*to << mov(reg, load);
				break;

				// TODO: Maybe others?
			default:
				*to << mov(reg, load);
				break;
			}
		}

		void RemoveInvalid::removeMemoryRefs(Listing *to, Instr *instr, Nat line) {
			Operand src = instr->src();

			switch (src.type()) {
			case opRegister:
			case opConstant:
			case opNone:
				// TODO: More things to ignore here!
				break;
			default:
				// Emit a load first.
				Reg t = unusedReg(used->at(line), src.size());
				used->at(line)->put(t);
				loadRegister(to, t, src);
				src = t;
				break;
			}

			Operand dest = instr->dest();
			if (dest.type() != opRegister) {
				// Load and store the destination.
				Reg t = unusedReg(used->at(line), dest.size());
				loadRegister(to, t, dest);
				*to << instr->alter(t, src);
				*to << mov(dest, t);
			} else {
				*to << instr->alterSrc(src);
			}
		}


		/**
		 * Bookkeeping
		 */

		void RemoveInvalid::prologTfm(Listing *to, Instr *instr, Nat line) {
			currentBlock = to->root();
			*to << instr;
		}

		void RemoveInvalid::epilogTfm(Listing *to, Instr *instr, Nat line) {
			currentBlock = Block();
			*to << instr;
		}

		void RemoveInvalid::beginBlockTfm(Listing *to, Instr *instr, Nat line) {
			currentBlock = instr->src().block();
			*to << instr;
		}

		void RemoveInvalid::endBlockTfm(Listing *to, Instr *instr, Nat line) {
			Block ended = instr->src().block();
			currentBlock = to->parent(ended);
			*to << instr;
		}


		/**
		 * Function calls.
		 */

		void RemoveInvalid::fnParamTfm(Listing *to, Instr *instr, Nat line) {
			TypeInstr *i = as<TypeInstr>(instr);
			if (!i) {
				throw new (this) InvalidValue(S("Expected a TypeInstr for 'fnParam'."));
			}

			params->push(ParamInfo(i->type, i->src(), false));
		}

		void RemoveInvalid::fnParamRefTfm(Listing *to, Instr *instr, Nat line) {
			TypeInstr *i = as<TypeInstr>(instr);
			if (!i) {
				throw new (this) InvalidValue(S("Expected a TypeInstr for 'fnParamRef'."));
			}

			params->push(ParamInfo(i->type, i->src(), true));
		}

		void RemoveInvalid::fnCallTfm(Listing *to, Instr *instr, Nat line) {
			TypeInstr *t = as<TypeInstr>(instr);
			if (!t) {
				throw new (this) InvalidValue(S("Using a fnCall that was not created properly."));
			}
			emitFnCall(this, to, t->src(), t->dest(), t->type, false, currentBlock, used->at(line), params);
			params->clear();
		}

		void RemoveInvalid::fnCallRefTfm(Listing *to, Instr *instr, Nat line) {
			TypeInstr *t = as<TypeInstr>(instr);
			if (!t) {
				throw new (this) InvalidValue(S("Using a fnCall that was not created properly."));
			}
			emitFnCall(this, to, t->src(), t->dest(), t->type, true, currentBlock, used->at(line), params);
			params->clear();
		}


		/**
		 * Other instructions.
		 */

		void RemoveInvalid::movTfm(Listing *to, Instr *instr, Nat line) {
			// We need to ensure that at most one operand is a memory operand. Large constants are
			// counted as a memory operand since they need to be loaded separately.

			Operand dest = instr->dest();
			// If dest is a register, we can just load that register.
			if (dest.type() == opRegister) {
				loadRegister(to, dest.reg(), instr->src());
				return;
			}

			// If the source is a register, we can just emit a single store operation regardless.
			Operand src = instr->src();
			if (src.type() == opRegister) {
				*to << instr;
				return;
			}

			// Otherwise, we need to break the instruction into two pieces.
			Reg tmpReg = unusedReg(used->at(line), src.size());
			loadRegister(to, tmpReg, src);
			*to << mov(dest, tmpReg);
		}

		void RemoveInvalid::shadowMovTfm(Listing *to, Instr *instr, Nat line) {
			Operand dest = instr->dest();
			// If dest is a register, we can just load that register.
			if (dest.type() == opRegister) {
				// Note: This is a copy of 'RemoveInvalid::loadRegister', but that emits 'shadowMov'
				// instead of a plain 'mov'.
				Operand load = instr->src();
				Reg reg = dest.reg();
				switch (load.type()) {
				case opConstant: {
					Word constant = load.constant();
					// Note: We can use MOVN for negative numbers.
					Bool in16bits = (constant <= 0xFFFF) || (~constant <= 0xFFFF);
					if (in16bits && isIntReg(reg)) // No load literal for fp registers.
						*to << mov(reg, load);
					else
						*to << mov(reg, largeConstant(load));
					break;
				}
				case opRegister:
					if (!same(reg, load.reg()))
						*to << mov(reg, load);
					break;

				case opOffReference:
					// We assume that the offset is small enough. Note, we can use MOVN to store
					// negative numbers.
					*to << mov(reg, load);
					break;

					// TODO: Maybe others?
				default:
					*to << mov(reg, load);
					break;
				}
				return;
			}

			// If the source is a register, we can just emit a single store operation regardless.
			Operand src = instr->src();
			if (src.type() == opRegister) {
				*to << instr;
				return;
			}

			// Otherwise, we need to break the instruction into two pieces.
			Reg tmpReg = unusedReg(used->at(line), src.size());
			loadRegister(to, tmpReg, src);
			*to << shadowMov(dest, tmpReg);
		}

		void RemoveInvalid::leaTfm(Listing *to, Instr *instr, Nat line) {
			Operand dest = instr->dest();
			if (dest.type() == opRegister) {
				*to << instr;
				return;
			}

			Reg tmp = unusedReg(used->at(line), dest.size());
			*to << instr->alterDest(tmp);
			*to << mov(dest, tmp);
		}

		void RemoveInvalid::swapTfm(Listing *to, Instr *instr, Nat line) {
			// Note: This is really only needed in the X64 backend, so it is not too important to
			// implement it extremely efficiently here. I think this implementation supports more
			// cases than what is supported on X86 and X64 (there, it is needed to avoid using extra
			// registers, but we don't really have that problem here).

			Operand src = instr->src();
			Operand dest = instr->dest();
			Reg tmp = unusedReg(used->at(line), src.size());
			*to << mov(tmp, src);
			if (src.type() == opRegister || dest.type() == opRegister) {
				*to << mov(src, dest);
			} else {
				used->at(line)->put(tmp);
				Reg tmp2 = unusedReg(used->at(line), src.size());
				*to << mov(tmp2, dest);
				*to << mov(src, tmp2);
			}
			*to << mov(dest, tmp);
		}

		void RemoveInvalid::cmpTfm(Listing *to, Instr *instr, Nat line) {
			// This is like "dataInstr12Tfm" below, but does not attempt to save the result back to
			// memory.

			Operand src = regOrImm(to, instr->src(), line, 12, false);
			Operand dest = instr->dest();
			if (dest.type() != opRegister) {
				// Load the destination.
				Reg t = unusedReg(used->at(line), dest.size());
				loadRegister(to, t, dest);
				*to << instr->alter(t, src);
			} else {
				*to << instr->alterSrc(src);
			}
		}

		void RemoveInvalid::testTfm(Listing *to, Instr *instr, Nat line) {
			// Similar to "bitmaskTfm" but does not attempt to save result back to memory.

			Operand src = instr->src();
			if (src.type() == opConstant) {
				bool large = src.size().size64() > 4;
				if (encodeBitmask(src.constant(), large) == 0) {
					// Not supported, read from memory.
					src = largeConstant(src);
				}
			}

			if (src.type() != opRegister) {
				Reg t = unusedReg(used->at(line), src.size());
				used->at(line)->put(t);
				loadRegister(to, t, src);
				src = t;
			}

			Operand dest = instr->dest();
			if (dest.type() != opRegister) {
				Reg t = unusedReg(used->at(line), dest.size());
				loadRegister(to, t, dest);
				*to << instr->alter(t, src);
			} else {
				*to << instr->alterSrc(src);
			}
		}

		void RemoveInvalid::setCondTfm(Listing *to, Instr *instr, Nat line) {
			Operand dest = instr->dest();
			if (dest.type() == opRegister) {
				*to << instr;
			} else {
				Reg tmp = unusedReg(used->at(line), Size::sByte);
				*to << instr->alterDest(tmp);
				*to << mov(dest, tmp);
			}
		}

		void RemoveInvalid::icastTfm(Listing *to, Instr *instr, Nat line) {
			// These work the same.
			ucastTfm(to, instr, line);
		}

		void RemoveInvalid::ucastTfm(Listing *to, Instr *instr, Nat line) {
			// For icast and ucast we allow source operands in memory since there are special
			// instructions that load from memory. Offsets are the same size as for regular loads
			// and stores, so we don't handle them in a special way. We do, however, need to be
			// careful if the offset is a reference. We don't handle them in codegen (even though we
			// could do), so those are treated as if they are not real relative offsets.

			Operand src = instr->src();
			switch (src.type()) {
			case opRegister:
				// Supported!
				break;
			case opRelative:
			case opVariable:
				// Is the offset a OffsetRef? If not, the operation is supported already.
				if (!src.offsetRef().source())
					break;
				// Fall thru
			default:
				// Add a separate move operation to load the source: we don't support loading
				// arbitrary things. Note: We don't need to update 'used', it is fine if we use the
				// same register for both src and dest!
				Reg r = unusedReg(used->at(line), src.size());
				loadRegister(to, r, src);
				instr = instr->alterSrc(r);
				break;
			}

			Operand dst = instr->dest();
			if (dst.type() != opRegister) {
				Reg t = unusedReg(used->at(line), dst.size());
				*to << instr->alterDest(t);
				*to << mov(dst, t);
			} else {
				*to << instr;
			}
		}

		void RemoveInvalid::fcastTfm(Listing *to, Instr *instr, Nat line) {
			// All operands need to be in fp registers.
			Reg src = loadFpRegister(to, instr->src(), line);

			Operand dest = instr->dest();
			if (dest.type() == opRegister && isVectorReg(dest.reg())) {
				*to << fcast(dest, src);
			} else {
				Reg destReg = unusedVectorReg(used->at(line), dest.size());
				*to << fcast(destReg, src);
				*to << mov(dest, destReg);
			}
		}

		void RemoveInvalid::fcastiTfm(Listing *to, Instr *instr, Nat line) {
			Reg src = loadFpRegister(to, instr->src(), line);

			Operand dest = instr->dest();
			if (dest.type() == opRegister && isIntReg(dest.reg())) {
				*to << instr->alterSrc(src);
			} else {
				Reg destReg = unusedReg(used->at(line), dest.size());
				*to << instr->alter(destReg, src);
				*to << mov(dest, destReg);
			}
		}

		void RemoveInvalid::fcastuTfm(Listing *to, Instr *instr, Nat line) {
			fcastiTfm(to, instr, line);
		}

		void RemoveInvalid::icastfTfm(Listing *to, Instr *instr, Nat line) {
			Operand src = instr->src();
			Reg srcReg = noReg;
			if (src.type() == opRegister && isIntReg(src.reg())) {
				srcReg = src.reg();
			} else {
				srcReg = unusedReg(used->at(line), src.size());
				used->at(line)->put(srcReg);
				loadRegister(to, srcReg, src);
			}

			Operand dest = instr->dest();
			if (dest.type() == opRegister && isVectorReg(dest.reg())) {
				*to << instr->alterSrc(srcReg);
			} else {
				Reg destReg = unusedVectorReg(used->at(line), dest.size());
				*to << instr->alter(destReg, srcReg);
				*to << mov(dest, destReg);
			}
		}

		void RemoveInvalid::ucastfTfm(Listing *to, Instr *instr, Nat line) {
			icastfTfm(to, instr, line);
		}

		void RemoveInvalid::dataInstr12Tfm(Listing *to, Instr *instr, Nat line) {
			// If "dest" is not a register, we need to surround this instruction with a load *and* a
			// store. If "src" is not a register, we need to add a load before. If "src" is too
			// large, we need to make it into a load.
			instr = limitImmSrc(to, instr, line, 12, false);
			removeMemoryRefs(to, instr, line);
		}

		void RemoveInvalid::bitmaskInstrTfm(Listing *to, Instr *instr, Nat line) {
			// If "dest" is not a register, we need to surround this instruction with a load *and* a
			// store. If "src" is not a register, we need to add a load before. If "src" is too
			// large, we need to make it into a load.

			Operand src = instr->src();
			if (src.type() == opConstant) {
				bool large = src.size().size64() > 4;
				Word value = src.constant();

				if (value == 0) {
					// Supported through special case.
				} else if (allOnes(value, large)) {
					// Supported through special case.
				} else if (encodeBitmask(value, large) == 0) {
					// Not supported, spill to memory.
					instr = instr->alterSrc(largeConstant(src));
				}
			}

			removeMemoryRefs(to, instr, line);
		}

		void RemoveInvalid::shiftInstrTfm(Listing *to, Instr *instr, Nat line) {
			Operand src = instr->src();
			if (src.type() == opConstant) {
				Word value = src.constant();
				if (instr->dest().size().size64() > 4) {
					if (value > 64)
						instr = instr->alterSrc(byteConst(64));
				} else {
					if (value > 32)
						instr = instr->alterSrc(byteConst(32));
				}
			}

			removeMemoryRefs(to, instr, line);
		}

		void RemoveInvalid::dataInstr4RegTfm(Listing *to, Instr *instr, Nat line) {
			Operand src = instr->src();
			if (src.type() != opRegister) {
				Reg t = unusedReg(used->at(line), src.size());
				used->at(line)->put(t);
				loadRegister(to, t, src);
				src = t;
			}

			Operand dest = instr->dest();
			if (dest.type() != opRegister) {
				Reg t = unusedReg(used->at(line), dest.size());
				loadRegister(to, t, dest);
				*to << instr->alter(t, src);
				*to << mov(dest, t);
			} else {
				*to << instr->alterSrc(src);
			}
		}

		Reg RemoveInvalid::loadFpRegister(Listing *to, const Operand &op, Nat line) {
			// Operands need to be in vector registers!
			if (op.type() == opRegister)
				if (isVectorReg(op.reg()))
					return op.reg();

			// Just load it into a free vector register.
			Reg r = unusedVectorReg(used->at(line), op.size());
			used->at(line)->put(r);
			*to << mov(r, op);
			return r;
		}

		void RemoveInvalid::fpInstrTfm(Listing *to, Instr *instr, Nat line) {
			Operand dest = instr->dest();
			DestMode mode = destMode(instr->op());

			Reg srcReg = loadFpRegister(to, instr->src(), line);

			Reg dstReg;
			if (mode & destRead) {
				dstReg = loadFpRegister(to, dest, line);
			} else {
				if (dest.type() == opRegister && isVectorReg(dest.reg())) {
					dstReg = dest.reg();
				} else {
					dstReg = unusedVectorReg(used->at(line), dest.size());
					// We don't need to update the register in the used set either, usage will not overlap.
					// Don't need to load!
				}
			}

			*to << instr->alter(dstReg, srcReg);

			if (destMode(instr->op()) & destWrite) {
				if (dest.type() != opRegister || dest.reg() != dstReg)
					*to << mov(dest, dstReg);
			}
		}

		void RemoveInvalid::idivTfm(Listing *to, Instr *instr, Nat line) {
			Operand src = instr->src();
			if (src.type() != opRegister) {
				Reg t = unusedReg(used->at(line), src.size());
				used->at(line)->put(t);
				loadRegister(to, t, src);
				src = t;
			}

			*to << cmp(src, xConst(src.size(), 0));
			*to << jmp(divZeroLabel(to), ifEqual); // TODO: Could be marked as "robust" to aid branch predictor

			Operand dest = instr->dest();
			if (dest.type() != opRegister) {
				Reg t = unusedReg(used->at(line), dest.size());
				loadRegister(to, t, dest);
				*to << instr->alter(t, src);
				*to << mov(dest, t);
			} else {
				*to << instr->alterSrc(src);
			}
		}

		void RemoveInvalid::udivTfm(Listing *to, Instr *instr, Nat line) {
			idivTfm(to, instr, line);
		}

		void RemoveInvalid::imodTfm(Listing *to, Instr *instr, Nat line) {
			umodTfm(to, instr, line);
		}

		void RemoveInvalid::umodTfm(Listing *to, Instr *instr, Nat line) {
			// GCC generates the following code for mod:
			// div <t>, <a>, <b>
			// mul <t>, <t>, <b>
			// sub <out>, <a>, <t>

			// Load src if needed.
			Operand src = instr->src();
			if (src.type() != opRegister) {
				Reg t = unusedReg(used->at(line), src.size());
				used->at(line)->put(t);
				loadRegister(to, t, src);
				src = t;
			}

			// Load dest if needed.
			Operand dest = instr->dest();
			if (dest.type() != opRegister) {
				Reg t = unusedReg(used->at(line), dest.size());
				used->at(line)->put(t);
				loadRegister(to, t, dest);
				dest = t;
			}

			*to << cmp(src, xConst(src.size(), 0));
			*to << jmp(divZeroLabel(to), ifEqual); // TODO: Could be marked as "robust" to aid branch predictor

			// The modulo code. Since we can't use 3-op codes here, we generate:
			// mov <t>, <a>
			// div <t>, <b>
			// mul <t>, <b>
			// sub <a>, <t>

			Reg t = unusedReg(used->at(line), dest.size());
			*to << mov(t, dest);
			if (instr->op() == op::imod)
				*to << idiv(t, src);
			else
				*to << udiv(t, src);
			*to << mul(t, src);
			*to << sub(dest, t);

			// Store dest if needed.
			if (dest != instr->dest())
				*to << mov(instr->dest(), dest);

		}

	}
}