1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419
|
/*
* Copyright (c) 2021-2023 Todd C. Miller <Todd.Miller@sudo.ws>
*
* Permission to use, copy, modify, and distribute this software for any
* purpose with or without fee is hereby granted, provided that the above
* copyright notice and this permission notice appear in all copies.
*
* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
* ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
#include <config.h>
#include <sys/socket.h>
#include <stdarg.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <fcntl.h>
#include <pwd.h>
#include <unistd.h>
#if defined(HAVE_STDINT_H)
# include <stdint.h>
#elif defined(HAVE_INTTYPES_H)
# include <inttypes.h>
#endif
#include <netinet/in.h>
#include <arpa/inet.h>
#ifdef NEED_RESOLV_H
# include <arpa/nameser.h>
# include <resolv.h>
#endif /* NEED_RESOLV_H */
#include <netdb.h>
#include <sudoers.h>
#include <interfaces.h>
static int fuzz_conversation(int num_msgs, const struct sudo_conv_message msgs[], struct sudo_conv_reply replies[], struct sudo_conv_callback *callback);
static int fuzz_printf(int msg_type, const char * restrict fmt, ...);
int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size);
/* For set_cmnd_path() */
static const char *orig_cmnd;
/* Required to link with parser. */
sudo_conv_t sudo_conv = fuzz_conversation;
sudo_printf_t sudo_printf = fuzz_printf;
FILE *
open_sudoers(const char *file, char **outfile, bool doedit, bool *keepopen)
{
/*
* If we allow the fuzzer to choose include paths it will
* include random files in the file system.
* This leads to bug reports that cannot be reproduced.
*/
return NULL;
}
static int
fuzz_printf(int msg_type, const char * restrict fmt, ...)
{
return 0;
}
static int
fuzz_conversation(int num_msgs, const struct sudo_conv_message msgs[],
struct sudo_conv_reply replies[], struct sudo_conv_callback *callback)
{
int n;
for (n = 0; n < num_msgs; n++) {
const struct sudo_conv_message *msg = &msgs[n];
switch (msg->msg_type & 0xff) {
case SUDO_CONV_PROMPT_ECHO_ON:
case SUDO_CONV_PROMPT_MASK:
case SUDO_CONV_PROMPT_ECHO_OFF:
/* input not supported */
return -1;
case SUDO_CONV_ERROR_MSG:
case SUDO_CONV_INFO_MSG:
/* no output for fuzzers */
break;
default:
return -1;
}
}
return 0;
}
bool
init_envtables(void)
{
return true;
}
int
set_cmnd_path(struct sudoers_context *ctx, const char *runchroot)
{
/* Reallocate ctx->user.cmnd to catch bugs in command_matches(). */
char *new_cmnd = strdup(orig_cmnd);
if (new_cmnd == NULL)
return NOT_FOUND_ERROR;
free(ctx->user.cmnd);
ctx->user.cmnd = new_cmnd;
return FOUND;
}
/* STUB */
bool
mail_parse_errors(const struct sudoers_context *ctx)
{
return true;
}
/* STUB */
bool
log_warningx(const struct sudoers_context *ctx, unsigned int flags,
const char * restrict fmt, ...)
{
return true;
}
static int
sudo_fuzz_query(struct sudoers_context *ctx, const struct sudo_nss *nss,
struct passwd *pw)
{
return 0;
}
static int
cb_unused(struct sudoers_parse_tree *parse_tree, struct alias *a, void *v)
{
return 0;
}
bool
cb_log_input(struct sudoers_context *ctx, const char *file,
int line, int column, const union sudo_defs_val *sd_un, int op)
{
return 0;
}
bool
cb_log_output(struct sudoers_context *ctx, const char *file,
int line, int column, const union sudo_defs_val *sd_un, int op)
{
return 0;
}
static FILE *
open_data(const uint8_t *data, size_t size)
{
#ifdef HAVE_FMEMOPEN
/* Operate in-memory. */
return fmemopen((void *)data, size, "r");
#else
char tempfile[] = "/tmp/sudoers.XXXXXX";
size_t nwritten;
int fd;
/* Use (unlinked) temporary file. */
fd = mkstemp(tempfile);
if (fd == -1)
return NULL;
unlink(tempfile);
nwritten = write(fd, data, size);
if (nwritten != size) {
close(fd);
return NULL;
}
lseek(fd, 0, SEEK_SET);
return fdopen(fd, "r");
#endif
}
static struct user_data {
const char *user;
const char *runuser;
const char *rungroup;
} user_data[] = {
{ "root", NULL, NULL },
{ "millert", "operator", NULL },
{ "millert", NULL, "wheel" },
{ "operator", NULL, NULL },
{ NULL }
};
int
LLVMFuzzerTestOneInput(const uint8_t *data, size_t size)
{
struct sudoers_context ctx = { { NULL } };
struct user_data *ud;
struct sudo_nss sudo_nss_fuzz;
struct sudo_nss_list snl = TAILQ_HEAD_INITIALIZER(snl);
struct sudoers_parse_tree parse_tree;
struct interface_list *interfaces;
struct passwd *pw;
struct group *gr;
const char *gids[10];
time_t now;
FILE *fp;
/* Don't waste time fuzzing tiny inputs. */
if (size < 5)
return 0;
fp = open_data(data, size);
if (fp == NULL)
return 0;
initprogname("fuzz_sudoers");
sudoers_debug_register(getprogname(), NULL);
if (getenv("SUDO_FUZZ_VERBOSE") == NULL)
sudo_warn_set_conversation(fuzz_conversation);
/* Sudoers locale setup. */
sudoers_initlocale(setlocale(LC_ALL, ""), "C");
sudo_warn_set_locale_func(sudoers_warn_setlocale);
bindtextdomain("sudoers", LOCALEDIR);
textdomain("sudoers");
/* Use the sudoers locale for everything. */
sudoers_setlocale(SUDOERS_LOCALE_SUDOERS, NULL);
/* Prime the group cache */
gr = sudo_mkgrent("wheel", 0, "millert", "root", (char *)NULL);
if (gr == NULL)
goto done;
sudo_gr_delref(gr);
gr = sudo_mkgrent("operator", 5, "operator", "root", "millert", (char *)NULL);
if (gr == NULL)
goto done;
sudo_gr_delref(gr);
gr = sudo_mkgrent("staff", 20, "root", "millert", (char *)NULL);
if (gr == NULL)
goto done;
sudo_gr_delref(gr);
gr = sudo_mkgrent("sudo", 100, "root", "millert", (char *)NULL);
if (gr == NULL)
goto done;
sudo_gr_delref(gr);
/* Prime the passwd cache */
pw = sudo_mkpwent("root", 0, 0, "/", "/bin/sh");
if (pw == NULL)
goto done;
gids[0] = "0";
gids[1] = "20";
gids[2] = "5";
gids[3] = NULL;
if (sudo_set_gidlist(pw, -1, NULL, (char **)gids, ENTRY_TYPE_FRONTEND) == -1)
goto done;
sudo_pw_delref(pw);
pw = sudo_mkpwent("operator", 2, 5, "/operator", "/sbin/nologin");
if (pw == NULL)
goto done;
gids[0] = "5";
gids[1] = NULL;
if (sudo_set_gidlist(pw, -1, NULL, (char **)gids, ENTRY_TYPE_FRONTEND) == -1)
goto done;
sudo_pw_delref(pw);
pw = sudo_mkpwent("millert", 8036, 20, "/home/millert", "/bin/tcsh");
if (pw == NULL)
goto done;
gids[0] = "0";
gids[1] = "20";
gids[2] = "5";
gids[3] = "100";
gids[4] = NULL;
if (sudo_set_gidlist(pw, -1, NULL, (char **)gids, ENTRY_TYPE_FRONTEND) == -1)
goto done;
sudo_pw_delref(pw);
/* The minimum needed to perform matching. */
ctx.user.host = ctx.user.shost = strdup("localhost");
ctx.runas.host = ctx.runas.shost = strdup("localhost");
orig_cmnd = (char *)"/usr/bin/id";
ctx.user.cmnd = strdup(orig_cmnd);
ctx.user.cmnd_args = strdup("-u");
if (ctx.user.host == NULL || ctx.runas.host == NULL ||
ctx.user.cmnd == NULL || ctx.user.cmnd_args == NULL)
goto done;
ctx.user.cmnd_base = sudo_basename(ctx.user.cmnd);
time(&now);
/* Add a fake network interfaces. */
interfaces = get_interfaces();
if (SLIST_EMPTY(interfaces)) {
static struct interface interface;
interface.family = AF_INET;
inet_pton(AF_INET, "128.138.243.151", &interface.addr.ip4);
inet_pton(AF_INET, "255.255.255.0", &interface.netmask.ip4);
SLIST_INSERT_HEAD(interfaces, &interface, entries);
}
/* Only one sudoers source, the sudoers file itself. */
init_parse_tree(&parse_tree, NULL, NULL, &ctx, NULL);
memset(&sudo_nss_fuzz, 0, sizeof(sudo_nss_fuzz));
sudo_nss_fuzz.parse_tree = &parse_tree;
sudo_nss_fuzz.query = sudo_fuzz_query;
TAILQ_INSERT_TAIL(&snl, &sudo_nss_fuzz, entries);
/* Initialize defaults and parse sudoers. */
init_defaults();
init_parser(&ctx, "sudoers");
sudoersrestart(fp);
sudoersparse();
reparent_parse_tree(&parse_tree);
if (!parse_error) {
/* Match user/host/command against parsed policy. */
for (ud = user_data; ud->user != NULL; ud++) {
int cmnd_status;
/* Invoking user. */
free(ctx.user.name);
ctx.user.name = strdup(ud->user);
if (ctx.user.name == NULL)
goto done;
if (ctx.user.pw != NULL)
sudo_pw_delref(ctx.user.pw);
ctx.user.pw = sudo_getpwnam(ctx.user.name);
if (ctx.user.pw == NULL) {
sudo_warnx_nodebug("unknown user %s", ctx.user.name);
continue;
}
/* Run user. */
if (ctx.runas.pw != NULL)
sudo_pw_delref(ctx.runas.pw);
if (ud->runuser != NULL) {
ctx.runas.user = (char *)ud->runuser;
SET(ctx.settings.flags, RUNAS_USER_SPECIFIED);
ctx.runas.pw = sudo_getpwnam(ctx.runas.user);
} else {
ctx.runas.user = NULL;
CLR(ctx.settings.flags, RUNAS_USER_SPECIFIED);
ctx.runas.pw = sudo_getpwnam("root");
}
if (ctx.runas.pw == NULL) {
sudo_warnx_nodebug("unknown run user %s", ctx.runas.user);
continue;
}
/* Run group. */
if (ctx.runas.gr != NULL)
sudo_gr_delref(ctx.runas.gr);
if (ud->rungroup != NULL) {
ctx.runas.group = (char *)ud->rungroup;
SET(ctx.settings.flags, RUNAS_GROUP_SPECIFIED);
ctx.runas.gr = sudo_getgrnam(ctx.runas.group);
if (ctx.runas.gr == NULL) {
sudo_warnx_nodebug("unknown run group %s",
ctx.runas.group);
continue;
}
} else {
ctx.runas.group = NULL;
CLR(ctx.settings.flags, RUNAS_GROUP_SPECIFIED);
ctx.runas.gr = NULL;
}
update_defaults(&ctx, &parse_tree, NULL, SETDEF_ALL, false);
sudoers_lookup(&snl, &ctx, now, NULL, NULL, &cmnd_status,
false);
/* Match again as a pseudo-command (list, validate, etc). */
sudoers_lookup(&snl, &ctx, now, NULL, NULL, &cmnd_status,
true);
/* Display privileges. */
display_privs(&ctx, &snl, ctx.user.pw, false);
display_privs(&ctx, &snl, ctx.user.pw, true);
}
/* Expand tildes in runcwd and runchroot. */
if (ctx.runas.pw != NULL) {
if (def_runcwd != NULL && strcmp(def_runcwd, "*") != 0) {
expand_tilde(&def_runcwd, ctx.runas.pw->pw_name);
}
if (def_runchroot != NULL && strcmp(def_runchroot, "*") != 0) {
expand_tilde(&def_runchroot, ctx.runas.pw->pw_name);
}
}
/* Check Defaults and aliases. */
check_defaults(&parse_tree, false);
check_aliases(&parse_tree, true, false, cb_unused);
}
done:
/* Cleanup. */
fclose(fp);
free_parse_tree(&parse_tree);
reset_parser();
sudoers_ctx_free(&ctx);
sudo_freepwcache();
sudo_freegrcache();
sudoers_setlocale(SUDOERS_LOCALE_USER, NULL);
sudoers_debug_deregister();
fflush(stdout);
return 0;
}
|