1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449
|
//===-- ExternalCommand.cpp -----------------------------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2015 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See http://swift.org/LICENSE.txt for license information
// See http://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
#include "llbuild/BuildSystem/ExternalCommand.h"
#include "llbuild/Basic/Hashing.h"
#include "llbuild/Basic/ExecutionQueue.h"
#include "llbuild/Basic/FileSystem.h"
#include "llbuild/BuildSystem/BuildFile.h"
#include "llbuild/BuildSystem/BuildKey.h"
#include "llbuild/BuildSystem/BuildNode.h"
#include "llbuild/BuildSystem/BuildValue.h"
#include "llbuild/Basic/FileInfo.h"
#include "llbuild/Basic/LLVM.h"
#include "llvm/ADT/Hashing.h"
#include "llvm/ADT/Twine.h"
#include "llvm/Support/FileSystem.h"
#include "llvm/Support/Path.h"
#include "llvm/Support/raw_ostream.h"
using namespace llbuild;
using namespace llbuild::basic;
using namespace llbuild::buildsystem;
CommandSignature ExternalCommand::getSignature() const {
CommandSignature code(getName());
for (const auto* input: inputs) {
code = code.combine(input->getName());
}
for (const auto* output: outputs) {
code = code.combine(output->getName());
}
return code
.combine(allowMissingInputs)
.combine(allowModifiedOutputs)
.combine(alwaysOutOfDate);
}
void ExternalCommand::configureDescription(const ConfigureContext&,
StringRef value) {
description = value;
}
void ExternalCommand::
configureInputs(const ConfigureContext&,
const std::vector<Node*>& value) {
inputs.reserve(value.size());
for (auto* node: value) {
inputs.emplace_back(static_cast<BuildNode*>(node));
}
}
void ExternalCommand::
configureOutputs(const ConfigureContext&, const std::vector<Node*>& value) {
outputs.reserve(value.size());
for (auto* node: value) {
outputs.emplace_back(static_cast<BuildNode*>(node));
}
}
bool ExternalCommand::
configureAttribute(const ConfigureContext& ctx, StringRef name,
StringRef value) {
if (name == "allow-missing-inputs") {
if (value != "true" && value != "false") {
ctx.error("invalid value: '" + value + "' for attribute '" +
name + "'");
return false;
}
allowMissingInputs = value == "true";
return true;
} else if (name == "allow-modified-outputs") {
if (value != "true" && value != "false") {
ctx.error("invalid value: '" + value + "' for attribute '" +
name + "'");
return false;
}
allowModifiedOutputs = value == "true";
return true;
} else if (name == "always-out-of-date") {
if (value != "true" && value != "false") {
ctx.error("invalid value: '" + value + "' for attribute '" +
name + "'");
return false;
}
alwaysOutOfDate = value == "true";
return true;
} else if (name == "repair-via-ownership-analysis") {
if (value == "true") {
repairViaOwnershipAnalysis = true;
return true;
} else if (value == "false") {
repairViaOwnershipAnalysis = false;
return true;
} else {
ctx.error("invalid value for attribute: '" + name + "'");
return false;
}
} else {
ctx.error("unexpected attribute: '" + name + "'");
return false;
}
}
bool ExternalCommand::
configureAttribute(const ConfigureContext& ctx, StringRef name,
ArrayRef<StringRef> values) {
ctx.error("unexpected attribute: '" + name + "'");
return false;
}
bool ExternalCommand::configureAttribute(
const ConfigureContext& ctx, StringRef name,
ArrayRef<std::pair<StringRef, StringRef>> values) {
ctx.error("unexpected attribute: '" + name + "'");
return false;
}
BuildValue ExternalCommand::
getResultForOutput(Node* node, const BuildValue& value) {
// If the value was a failed or cancelled command, propagate the failure.
if (value.isFailedCommand() || value.isPropagatedFailureCommand() ||
value.isCancelledCommand())
return BuildValue::makeFailedInput();
if (value.isSkippedCommand())
return BuildValue::makeSkippedCommand();
// Otherwise, we should have a successful command -- return the actual
// result for the output.
assert(value.isSuccessfulCommand());
// If the node is virtual, the output is always a virtual input value.
//
// FIXME: Eliminate this, and make the build value array contain an array of
// build values.
auto buildNode = static_cast<BuildNode*>(node);
if (buildNode->isVirtual() && !buildNode->isCommandTimestamp()) {
return BuildValue::makeVirtualInput();
}
// Find the index of the output node.
//
// FIXME: This is O(N). We don't expect N to be large in practice, but it
// could be.
auto it = std::find(outputs.begin(), outputs.end(), node);
assert(it != outputs.end());
auto idx = it - outputs.begin();
assert(idx < static_cast<ssize_t>(value.getNumOutputs()));
auto& info = value.getNthOutputInfo(idx);
if (info.isMissing())
return BuildValue::makeMissingOutput();
return BuildValue::makeExistingInput(info);
}
bool ExternalCommand::isResultValid(BuildSystem& system,
const BuildValue& value) {
// Treat the command as always out-of-date, if requested.
if (alwaysOutOfDate)
return false;
// If the prior value wasn't for a successful command, recompute.
if (!value.isSuccessfulCommand())
return false;
// Check the timestamps on each of the outputs.
for (unsigned i = 0, e = outputs.size(); i != e; ++i) {
auto* node = outputs[i];
// Ignore virtual outputs.
if (node->isVirtual())
continue;
// Rebuild if the output information has changed.
//
// We intentionally allow missing outputs here, as long as they haven't
// changed. This is under the assumption that the commands themselves are
// behaving correctly when they exit successfully, and that downstream
// commands would diagnose required missing inputs.
//
// FIXME: CONSISTENCY: One consistency issue in this model currently is that
// if the output was missing, then appears, nothing will remove it; that
// results in an inconsistent build. What would be nice if we supported
// per-edge annotations on whether an output was optional -- in that case we
// could enforce and error on the missing output if not annotated, and we
// could enable behavior to remove such output files if annotated prior to
// running the command.
auto info = node->getFileInfo(system.getFileSystem());
// If this output is mutated by the build, we can't rely on equivalence,
// only existence.
if (node->isMutated()) {
if (value.getNthOutputInfo(i).isMissing() != info.isMissing())
return false;
continue;
}
if (value.getNthOutputInfo(i) != info)
return false;
}
// Otherwise, the result is ok.
return true;
}
void ExternalCommand::start(BuildSystem& system,
core::TaskInterface ti) {
// Initialize the build state.
skipValue = llvm::None;
missingInputNodes.clear();
hasMissingDynamicInputs = false;
// Request all of the inputs.
unsigned id = 0;
for (auto it = inputs.begin(), ie = inputs.end(); it != ie; ++it, ++id) {
ti.request(BuildKey::makeNode(*it).toData(), id);
}
// Delegate to the subclass in case it needs more custom inputs.
startExternalCommand(system, ti);
}
void ExternalCommand::providePriorValue(BuildSystem& system,
core::TaskInterface,
const BuildValue& value) {
if (value.isSuccessfulCommand()) {
hasPriorResult = true;
}
}
void ExternalCommand::provideValue(BuildSystem& system,
core::TaskInterface ti,
uintptr_t inputID,
const BuildValue& value) {
// Inform subclasses about the value
provideValueExternalCommand(system, ti, inputID, value);
if (value.isSuccessfulCommand() || value.isFailedCommand() || value.isPropagatedFailureCommand() || value.isCancelledCommand()) {
// If the value is a successful command, it must probably be a value that was requested for a custom task, so
// skip the input processing
return;
}
// All direct inputs should be individual node values.
assert(!value.hasMultipleOutputs());
assert(value.isExistingInput() || value.isMissingInput() ||
value.isMissingOutput() || value.isFailedInput() ||
value.isVirtualInput() || value.isSkippedCommand() ||
value.isDirectoryTreeSignature() ||
value.isDirectoryTreeStructureSignature() ||
value.isStaleFileRemoval());
// If the input should cause this command to skip, how should it skip?
auto getSkipValueForInput = [&]() -> llvm::Optional<BuildValue> {
// If the value is an signature, existing, or virtual input, we are always
// good.
if (value.isDirectoryTreeSignature() ||
value.isDirectoryTreeStructureSignature() ||
value.isExistingInput() ||
value.isVirtualInput() || value.isStaleFileRemoval())
return llvm::None;
// We explicitly allow running the command against a missing output, under
// the expectation that responsibility for reporting this situation falls to
// the command.
//
// FIXME: Eventually, it might be nice to harden the format so that we know
// when an output was actually required versus optional.
if (value.isMissingOutput())
return llvm::None;
// If the value is a missing input, but those are allowed, it is ok.
if (value.isMissingInput()) {
if (allowMissingInputs)
return llvm::None;
else
return BuildValue::makePropagatedFailureCommand();
}
// Propagate failure.
if (value.isFailedInput())
return BuildValue::makePropagatedFailureCommand();
// A skipped dependency doesn't cause this command to skip.
if (value.isSkippedCommand())
return llvm::None;
llvm_unreachable("unexpected input");
};
// Check if we need to skip the command because of this input.
auto skipValueForInput = getSkipValueForInput();
if (skipValueForInput.hasValue()) {
skipValue = std::move(skipValueForInput);
if (value.isMissingInput()) {
if (inputs.size() > inputID) {
missingInputNodes.insert(inputs[inputID]);
} else {
// FIXME: This should better track which dynamic input was missing. Right now, the higher level build system needs to reconstruct that information.
hasMissingDynamicInputs = true;
}
}
} else {
// If there is a missing input file (from a successful command), we always
// need to run the command.
if (value.isMissingOutput())
canUpdateIfNewer = false;
}
}
bool ExternalCommand::canUpdateIfNewerWithResult(const BuildValue& result) {
// Unless `allowModifiedOutputs` is specified, we always need to update if
// ran.
if (!allowModifiedOutputs)
return false;
// If it was specified, then we can update if all of our outputs simply exist.
for (unsigned i = 0, e = result.getNumOutputs(); i != e; ++i) {
const FileInfo& outputInfo = result.getNthOutputInfo(i);
// If the output is missing, we need to rebuild.
if (outputInfo.isMissing())
return false;
}
return true;
}
BuildValue
ExternalCommand::computeCommandResult(BuildSystem& system, core::TaskInterface ti) {
// Capture the file information for each of the output nodes.
//
// FIXME: We need to delegate to the node here.
SmallVector<FileInfo, 8> outputInfos;
for (auto* node: outputs) {
if (node->isCommandTimestamp()) {
// FIXME: We currently have to shoehorn the timestamp into a fake file
// info, but need to refactor the command result to just store the node
// subvalues instead.
FileInfo info{};
info.size = ti.currentEpoch();
outputInfos.push_back(info);
} else if (node->isVirtual()) {
outputInfos.push_back(FileInfo{});
} else {
outputInfos.push_back(node->getFileInfo(
system.getFileSystem()));
}
}
// FIXME: If the outputs are empty, it might mean that this instance is for a custom task, which does not
// currently have any hooks for specifying what the outputs are. It might make sense to create a new BuildValue
// for a successful command with custom data, so that we can avoid the file system for commands that don't require
// the filesystem. For now, hackily insert the timestamp just to differentiate between 2 build values that ran at
// different times.
if (outputs.size() == 0) {
FileInfo info{};
info.size = ti.currentEpoch();
outputInfos.push_back(info);
}
return BuildValue::makeSuccessfulCommand(outputInfos);
}
void ExternalCommand::execute(BuildSystem& system,
core::TaskInterface ti,
QueueJobContext* context,
ResultFn resultFn) {
// If this command should be skipped, do nothing.
if (skipValue.hasValue()) {
// If this command had a failed input, treat it as having failed.
if (!missingInputNodes.empty() || hasMissingDynamicInputs) {
system.getDelegate().commandCannotBuildOutputDueToMissingInputs(this,
outputs.empty() ? nullptr : outputs[0], missingInputNodes);
// Report the command failure.
system.getDelegate().hadCommandFailure();
}
resultFn(std::move(skipValue.getValue()));
return;
}
assert(missingInputNodes.empty());
assert(!hasMissingDynamicInputs);
// If it is legal to simply update the command, then see if we can do so.
if (canUpdateIfNewer && hasPriorResult) {
BuildValue result = computeCommandResult(system, ti);
if (canUpdateIfNewerWithResult(result)) {
resultFn(std::move(result));
return;
}
}
// Create the directories for the directories containing file outputs.
//
// FIXME: Implement a shared cache for this, to reduce the number of
// syscalls required to make this happen.
for (auto* node: outputs) {
if (!node->isVirtual()) {
// Attempt to create the directory; we ignore errors here under the
// assumption the command will diagnose the situation if necessary.
//
// FIXME: Need to use the filesystem interfaces.
auto parent = llvm::sys::path::parent_path(node->getName());
if (node->getName().endswith("/")) {
parent = llvm::sys::path::parent_path(parent);
}
if (!parent.empty()) {
(void) system.getFileSystem().createDirectories(parent);
}
}
}
// Invoke the external command.
system.getDelegate().commandStarted(this);
executeExternalCommand(system, ti, context, {[this, &system, ti, resultFn](ProcessResult result) mutable {
system.getDelegate().commandFinished(this, result.status);
// Process the result.
switch (result.status) {
case ProcessStatus::Failed:
resultFn(BuildValue::makeFailedCommand());
return;
case ProcessStatus::Cancelled:
resultFn(BuildValue::makeCancelledCommand());
return;
case ProcessStatus::Succeeded:
resultFn(computeCommandResult(system, ti));
return;
case ProcessStatus::Skipped:
case ProcessStatus::Unknown:
// It is illegal to get skipped result at this point.
break;
}
llvm::report_fatal_error("unknown result");
}});
}
|