1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
|
// RUN: %check_clang_tidy %s bugprone-assignment-in-if-condition %t
void f(int arg) {
int f = 3;
if ((f = arg) || (f == (arg + 1)))
// CHECK-MESSAGES: :[[@LINE-1]]:10: warning: an assignment within an 'if' condition is bug-prone [bugprone-assignment-in-if-condition]
{
f = 5;
}
}
void f1(int arg) {
int f = 3;
if ((f == arg) || (f = (arg + 1)))
// CHECK-MESSAGES: :[[@LINE-1]]:24: warning: an assignment within an 'if' condition is bug-prone [bugprone-assignment-in-if-condition]
{
f = 5;
}
}
void f2(int arg) {
int f = 3;
if (f = arg)
// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: an assignment within an 'if' condition is bug-prone [bugprone-assignment-in-if-condition]
{
f = 5;
}
}
volatile int v = 32;
void f3(int arg) {
int f = 3;
if ((f == arg) || ((arg + 6 < f) && (f = v)))
// CHECK-MESSAGES: :[[@LINE-1]]:42: warning: an assignment within an 'if' condition is bug-prone [bugprone-assignment-in-if-condition]
{
f = 5;
}
}
void f4(int arg) {
int f = 3;
if ((f == arg) || ((arg + 6 < f) && ((f = v) || (f < 8))))
// CHECK-MESSAGES: :[[@LINE-1]]:43: warning: an assignment within an 'if' condition is bug-prone [bugprone-assignment-in-if-condition]
{
f = 5;
} else if ((arg + 8 < f) && ((f = v) || (f < 8)))
// CHECK-MESSAGES: :[[@LINE-1]]:35: warning: an assignment within an 'if' condition is bug-prone [bugprone-assignment-in-if-condition]
{
f = 6;
}
}
class BrokenOperator {
public:
int d = 0;
int operator=(const int &val) {
d = val + 1;
return d;
}
};
void f5(int arg) {
BrokenOperator bo;
int f = 3;
bo = f;
if (bo.d == 3) {
f = 6;
}
if (bo = 3)
// CHECK-MESSAGES: :[[@LINE-1]]:10: warning: an assignment within an 'if' condition is bug-prone [bugprone-assignment-in-if-condition]
{
f = 7;
}
if ((arg == 3) || (bo = 6))
// CHECK-MESSAGES: :[[@LINE-1]]:25: warning: an assignment within an 'if' condition is bug-prone [bugprone-assignment-in-if-condition]
{
f = 8;
}
v = f;
}
// Tests that shouldn't trigger warnings.
void awesome_f2(int arg) {
int f = 3;
if ((f == arg) || (f == (arg + 1))) {
f = 5;
}
}
void awesome_f3(int arg) {
int f = 3;
if (f == arg) {
f = 5;
}
}
void awesome_f4(int arg) {
int f = 3;
if ((f == arg) || ((arg + 6 < f) && ((f == v) || (f < 8)))) {
f = 5;
}
}
template <typename Func> bool exec(Func F) { return F(); }
void lambda_if() {
int X;
if ([&X] {
X = 5;
return true;
}()) {
}
if (exec([&] {
X = 5;
return true;
})) {
}
}
|
