1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
|
// RUN: %check_clang_tidy %s bugprone-unhandled-self-assignment %t -- \
// RUN: -config="{CheckOptions: \
// RUN: [{key: bugprone-unhandled-self-assignment.WarnOnlyIfThisHasSuspiciousField, \
// RUN: value: false}]}"
// Classes with pointer field are still caught.
class PtrField {
public:
PtrField &operator=(const PtrField &object) {
// CHECK-MESSAGES: [[@LINE-1]]:13: warning: operator=() does not handle self-assignment properly [bugprone-unhandled-self-assignment]
return *this;
}
private:
int *p;
};
// With the option, check catches classes with trivial fields.
class TrivialFields {
public:
TrivialFields &operator=(const TrivialFields &object) {
// CHECK-MESSAGES: [[@LINE-1]]:18: warning: operator=() does not handle self-assignment properly [bugprone-unhandled-self-assignment]
return *this;
}
private:
int m;
float f;
double d;
bool b;
};
// The check warns also when there is no field at all.
// In this case, user-defined copy assignment operator is useless anyway.
class ClassWithoutFields {
public:
ClassWithoutFields &operator=(const ClassWithoutFields &object) {
// CHECK-MESSAGES: [[@LINE-1]]:23: warning: operator=() does not handle self-assignment properly [bugprone-unhandled-self-assignment]
return *this;
}
};
|
